Thanks Darrel and Michael for your suggestion and will evaluate which suits
best for our use case.
-
Deepak
On Thu, Mar 9, 2017 at 3:42 AM, Darrel Schneider
wrote:
> Mike is correct that the first time you ask a VMCachedDeserializable for
> the deserialized value
[
https://issues.apache.org/jira/browse/GEODE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Diane Hardman updated GEODE-2553:
-
Summary: After deleting and recreating my Lucene index and region, my
Lucene query hung. (was:
[
https://issues.apache.org/jira/browse/GEODE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Diane Hardman updated GEODE-2553:
-
Summary: After deleting and recreating my Lucene index and region, my
Lucene query should be
I just committed the changes for GEODE-2594. With this change in place,
Apache Geode no longer uses or requires the tools.jar or Attach API by
default, and the gfsh scripts no longer add the tools.jar to the classpath.
This means anyone who is maintaining Docker images or anything similar can
[
https://issues.apache.org/jira/browse/GEODE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Smith reassigned GEODE-2595:
Assignee: Dan Smith
> Change LuceneService.createIndex to use a factory pattern
>
[
https://issues.apache.org/jira/browse/GEODE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Smith resolved GEODE-2595.
--
Resolution: Fixed
Fix Version/s: 1.2.0
> Change LuceneService.createIndex to use a factory
[
https://issues.apache.org/jira/browse/GEODE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904247#comment-15904247
]
ASF subversion and git services commented on GEODE-2595:
Commit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57483/#review168575
---
Fix it, then Ship it!
[
https://issues.apache.org/jira/browse/GEODE-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904187#comment-15904187
]
Kirk Lund commented on GEODE-2594:
--
I have added the "docs" component because this change requires
> On March 10, 2017, 12:51 a.m., Kirk Lund wrote:
> > I really don't think these changes (removal of one call stack for the
> > overridden methods) are going to improve performance. For code clarity, I'd
> > really prefer to not make this change. My recommendation is to discard
> > these
[
https://issues.apache.org/jira/browse/GEODE-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2594:
-
Component/s: docs
> Remove optional usage of Attach API
> ---
>
>
[
https://issues.apache.org/jira/browse/GEODE-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2594:
-
Labels: StartCommand StatusCommand StopCommand gfsh (was: gfsh)
> Remove optional usage of Attach API
>
[
https://issues.apache.org/jira/browse/GEODE-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904177#comment-15904177
]
ASF subversion and git services commented on GEODE-2594:
Commit
> On March 8, 2017, 9:16 p.m., Jinmei Liao wrote:
> > Any test changes? We probably can create a integrated/dunit test that would
> > start a server with those ssl properties (including passwords) turned on,
> > and have debug level truned on, and security truned on as well, and have
> > gfsh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57466/#review168567
---
I really don't think these changes (removal of one call stack for
[
https://issues.apache.org/jira/browse/GEODE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904147#comment-15904147
]
ASF subversion and git services commented on GEODE-2553:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904146#comment-15904146
]
ASF subversion and git services commented on GEODE-2539:
Commit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57483/
---
Review request for geode, Barry Oglesby, Lynn Hughes-Godfrey, nabarun nag, Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57437/
---
(Updated March 10, 2017, 12:17 a.m.)
Review request for geode, Jinmei Liao,
> On March 9, 2017, 6:27 p.m., Kirk Lund wrote:
> > Here's the change I recommend for improving performance. The problem is
> > this line...
> >
> > private static SecurityService defaultInstance = new
> > IntegratedSecurityService();
> >
> > It always installs a IntegratedSecurityService.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57437/
---
(Updated March 10, 2017, 12:08 a.m.)
Review request for geode, Jinmei Liao,
> On March 9, 2017, 6:27 p.m., Kirk Lund wrote:
> > Here's the change I recommend for improving performance. The problem is
> > this line...
> >
> > private static SecurityService defaultInstance = new
> > IntegratedSecurityService();
> >
> > It always installs a IntegratedSecurityService.
[
https://issues.apache.org/jira/browse/GEODE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Huynh reassigned GEODE-2643:
--
Assignee: Jason Huynh
> Combine chunk and file region into a single region
>
Jason Huynh created GEODE-2643:
--
Summary: Combine chunk and file region into a single region
Key: GEODE-2643
URL: https://issues.apache.org/jira/browse/GEODE-2643
Project: Geode
Issue Type: Bug
---
Spring Data GemFire > Nightly-ApacheGeode > #495 was successful.
---
Scheduled
1682 tests in total.
https://build.spring.io/browse/SGF-NAG-495/
--
This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57482/
---
Review request for geode.
Repository: geode
Description
---
Client ping
[
https://issues.apache.org/jira/browse/GEODE-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra reassigned GEODE-2642:
--
Assignee: Hitesh Khamesra
> Sometime client doesn't ping server in ping-interval
>
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903962#comment-15903962
]
Kevin Duling commented on GEODE-2539:
-
Jetty 9.4's API has changed significantly around Session
Hi Roger:
Sorry to hear about this. There is system property on client side to clean
pdx-registry when it disconnects from server. You can find details here
https://discuss.pivotal.io/hc/en-us/articles/221351508-Getting-Stale-PDXType-error-on-client-after-clean-start-up-of-servers.
I think we
[
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903939#comment-15903939
]
ASF GitHub Bot commented on GEODE-2636:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903938#comment-15903938
]
ASF subversion and git services commented on GEODE-2636:
Commit
Does anyone know why we introduced the property
ON_DISCONNECT_CLEAR_PDXTYPEIDS for the client and then make it FALSE as
a default?
Surely we'd actually want to reset the pdx registry when a client
disconnects from the servers GEODE-1037
On 3/9/17 12:55, Roger Vandusen wrote:
Hey
Hitesh Khamesra created GEODE-2642:
--
Summary: Sometime client doesn't ping server in ping-interval
Key: GEODE-2642
URL: https://issues.apache.org/jira/browse/GEODE-2642
Project: Geode
Issue
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903916#comment-15903916
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903918#comment-15903918
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903917#comment-15903917
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903914#comment-15903914
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903915#comment-15903915
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903911#comment-15903911
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903913#comment-15903913
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903919#comment-15903919
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
[
https://issues.apache.org/jira/browse/GEODE-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903912#comment-15903912
]
ASF GitHub Bot commented on GEODE-2592:
---
Github user karensmolermiller commented on a diff in the
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105278104
--- Diff: geode-docs/tools_modules/gfsh/command-pages/list.html.md.erb ---
@@ -398,6 +402,49 @@ gfsh> list indexes
No Indexes Found
```
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105277380
--- Diff: geode-docs/tools_modules/gfsh/command-pages/describe.html.md.erb
---
@@ -233,6 +237,48 @@ PDX Serialization Meta-Data Stored : No
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105277043
--- Diff: geode-docs/tools_modules/gfsh/command-pages/create.html.md.erb ---
@@ -675,6 +679,47 @@ Occurred on following members
1.
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105276904
--- Diff: geode-docs/tools_modules/gfsh/command-pages/create.html.md.erb ---
@@ -675,6 +679,47 @@ Occurred on following members
1.
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105276623
--- Diff: geode-docs/tools_modules/gfsh/command-pages/create.html.md.erb ---
@@ -675,6 +679,47 @@ Occurred on following members
1.
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105278956
--- Diff: geode-docs/tools_modules/gfsh/command-pages/search.html.md.erb ---
@@ -0,0 +1,49 @@
+---
+title: search lucene
+---
+
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105279939
--- Diff:
geode-docs/tools_modules/gfsh/quick_ref_commands_by_area.html.md.erb ---
@@ -277,6 +277,20 @@ limitations under the License.
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105277324
--- Diff: geode-docs/tools_modules/gfsh/command-pages/describe.html.md.erb
---
@@ -233,6 +237,48 @@ PDX Serialization Meta-Data Stored : No
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode/pull/419#discussion_r105277184
--- Diff: geode-docs/tools_modules/gfsh/command-pages/describe.html.md.erb
---
@@ -233,6 +237,48 @@ PDX Serialization Meta-Data Stored : No
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/50#discussion_r105272239
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,6 +26,9 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH
[
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903867#comment-15903867
]
ASF GitHub Bot commented on GEODE-2636:
---
Github user metatype commented on a diff in the pull
> On March 9, 2017, 6:27 p.m., Kirk Lund wrote:
> > Here's the change I recommend for improving performance. The problem is
> > this line...
> >
> > private static SecurityService defaultInstance = new
> > IntegratedSecurityService();
> >
> > It always installs a IntegratedSecurityService.
Original message
From: echobravopapa
Date: 3/9/17 12:59 PM (GMT-07:00)
To: dev@geode.apache.org
Subject: [GitHub] geode-native pull request #49: GEODE-2513 Unbrand docs
section on Preserving...
Github user echobravopapa commented on a diff in
[
https://issues.apache.org/jira/browse/GEODE-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903837#comment-15903837
]
ASF subversion and git services commented on GEODE-2614:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903840#comment-15903840
]
ASF subversion and git services commented on GEODE-2553:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903836#comment-15903836
]
ASF subversion and git services commented on GEODE-2614:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903839#comment-15903839
]
ASF subversion and git services commented on GEODE-2539:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903842#comment-15903842
]
ASF subversion and git services commented on GEODE-2612:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903835#comment-15903835
]
ASF subversion and git services commented on GEODE-2539:
Commit
[
https://issues.apache.org/jira/browse/GEODE-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903843#comment-15903843
]
ASF subversion and git services commented on GEODE-1969:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903838#comment-15903838
]
ASF subversion and git services commented on GEODE-2616:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903841#comment-15903841
]
ASF subversion and git services commented on GEODE-2617:
Commit
[
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903827#comment-15903827
]
ASF GitHub Bot commented on GEODE-2636:
---
Github user PivotalSarge commented on a diff in the pull
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/50#discussion_r105266335
--- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
@@ -165,15 +165,15 @@ int main(int argc, char** argv) {
LOGINFO("Registered Person
[
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903825#comment-15903825
]
ASF GitHub Bot commented on GEODE-2636:
---
Github user echobravopapa commented on a diff in the pull
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/50#discussion_r105265184
--- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
@@ -165,15 +165,15 @@ int main(int argc, char** argv) {
LOGINFO("Registered Person
[
https://issues.apache.org/jira/browse/GEODE-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Darrel Schneider reassigned GEODE-1969:
---
Assignee: Darrel Schneider (was: Amey Barve)
> oplog closed while writing to oplog
[
https://issues.apache.org/jira/browse/GEODE-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903802#comment-15903802
]
ASF GitHub Bot commented on GEODE-2636:
---
GitHub user PivotalSarge opened a pull request:
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/50
GEODE-2636: Switch to CMake variable for library name.
- Parameterize the name of the library for which the quickstarts look.
- Fix warnings that obfuscate when the quickstarts can not
[
https://issues.apache.org/jira/browse/GEODE-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903798#comment-15903798
]
ASF GitHub Bot commented on GEODE-1969:
---
Github user dschneider-pivotal commented on the issue:
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/320
After looking over this fix we decided that it is too simple to have a
reasonable unit test.
I will pull it in
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903756#comment-15903756
]
ASF GitHub Bot commented on GEODE-2513:
---
Github user echobravopapa commented on a diff in the pull
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/49#discussion_r105257135
--- Diff:
docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb ---
@@ -19,19 +19,19 @@ See the License for the specific
> On March 9, 2017, 6:27 p.m., Kirk Lund wrote:
> > Here's the change I recommend for improving performance. The problem is
> > this line...
> >
> > private static SecurityService defaultInstance = new
> > IntegratedSecurityService();
> >
> > It always installs a IntegratedSecurityService.
> On March 9, 2017, 6:27 p.m., Kirk Lund wrote:
> > Here's the change I recommend for improving performance. The problem is
> > this line...
> >
> > private static SecurityService defaultInstance = new
> > IntegratedSecurityService();
> >
> > It always installs a IntegratedSecurityService.
Jinmei Liao created GEODE-2641:
--
Summary: export logs help strings has [--group=value(nullvalue)*]
[--member=value(nullvalue)*]
Key: GEODE-2641
URL: https://issues.apache.org/jira/browse/GEODE-2641
> On March 9, 2017, 6:27 p.m., Kirk Lund wrote:
> > Here's the change I recommend for improving performance. The problem is
> > this line...
> >
> > private static SecurityService defaultInstance = new
> > IntegratedSecurityService();
> >
> > It always installs a IntegratedSecurityService.
[
https://issues.apache.org/jira/browse/GEODE-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao updated GEODE-2379:
---
Description:
the new command help:
NAME
export logs
IS AVAILABLE
false
SYNOPSIS
Export
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57437/
---
(Updated March 9, 2017, 6:29 p.m.)
Review request for geode, Jinmei Liao,
[
https://issues.apache.org/jira/browse/GEODE-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao updated GEODE-2379:
---
Summary: Document new behavior of export logs (was: Document new gfsh
command to export cluster
[
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903539#comment-15903539
]
ASF GitHub Bot commented on GEODE-2513:
---
Github user joeymcallister commented on a diff in the pull
Github user joeymcallister commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/49#discussion_r105233328
--- Diff:
docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb ---
@@ -19,19 +19,19 @@ See the License for the specific
[
https://issues.apache.org/jira/browse/GEODE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaojian zhou updated GEODE-2617:
-
Fix Version/s: 1.2.0
> LuceneResultStruct should be Serializable
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57437/#review168482
---
Ship it!
Ship It!
- Jinmei Liao
On March 9, 2017, 12:02
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57431/#review168481
---
Ship it!
Ship It!
- Kirk Lund
On March 8, 2017, 8:58 p.m.,
[
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903522#comment-15903522
]
ASF GitHub Bot commented on GEODE-2513:
---
Github user karensmolermiller commented on a diff in the
Github user karensmolermiller commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/49#discussion_r105231666
--- Diff:
docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb ---
@@ -19,19 +19,19 @@ See the License for the specific
[
https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903514#comment-15903514
]
Karen Smoler Miller commented on GEODE-2513:
Instead of changing just this one instance of the
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105008854
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/ExecutionHandlerContext.java
---
@@ -135,8 +135,14 @@ private void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105060019
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SRandMemberExecutor.java
---
@@ -42,9 +42,8 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105010837
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -289,7 +331,9 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105059140
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SPopExecutor.java
---
@@ -36,24 +37,26 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105046939
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SMembersExecutor.java
---
@@ -39,16 +39,18 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105061296
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SetOpExecutor.java
---
@@ -47,23 +44,23 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105009858
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -95,18 +98,38 @@ public
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104552749
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashExecutor.java
---
@@ -75,14 +96,76 @@
}
/**
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105053042
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SMoveExecutor.java
---
@@ -45,30 +48,44 @@ public void
1 - 100 of 130 matches
Mail list logo