[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131290606 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java --- @@ -302,14 +302,14 @@ boolean checkForExpiration()

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131290383 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java --- @@ -302,14 +302,14 @@ boolean checkForExpiration()

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131290142 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java --- @@ -196,6 +196,13 @@ long

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131290034 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java --- @@ -87,7 +87,8 @@ private Thread thread;

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131287954 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java --- @@ -302,14 +302,14 @@ boolean checkForExpiration() {

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131287871 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockToken.java --- @@ -87,7 +87,8 @@ private Thread thread;

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131287366 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockRequestProcessor.java --- @@ -196,6 +196,13 @@ long

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182181 --- 1. The help message for the property should state what it does

[GitHub] geode issue #683: GEODE-3314 - additional refactoring for developer QoL.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/683 @kohlmu-pivotal @hiteshk25 @bschuchardt @pivotal-amurmann @WireBaron --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

GitHub user galen-pivotal opened a pull request: https://github.com/apache/geode/pull/683 GEODE-3314 - additional refactoring for developer QoL. * Write characterization tests for DLockService. * Remove debugging code. * Remove dead code. * Remove comments. * Extract

Re: Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61420/#review182179 --- Ship it! Ship It! - Brian Rowe On Aug. 3, 2017, 10:07 p.m.,

Re: Review Request 61411: GEODE-3286 Failing to cleanup connections from ConnectionTable receiver table (corrected "stopped" check in previous fix)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61411/#review182149 --- Fix it, then Ship it! Nitpicks below, but change looks good.

Re: behavior of "connect" command when --use-ssl

Good question. +1 to... I also think specifying settings should be "explicit" rather than picking up arbitrary files in known locations (e.g. working dir, home dir, classpath, etc). This would be decidedly bad if an auth file were picked up that opened Geode up to the world, for instance. On

[GitHub] geode issue #682: GEODE-3393: One-way SSL authentication fails with FileNotF...

Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/682 @hiteshk25 @bschuchardt @pivotal-amurmann @WireBaron --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] geode pull request #682: GEODE-3393: One-way SSL authentication fails with F...

GitHub user kohlmu-pivotal opened a pull request: https://github.com/apache/geode/pull/682 GEODE-3393: One-way SSL authentication fails with FileNotFoundException for $USER_HOME/.keystore Thank you for submitting a contribution to Apache Geode. In order to streamline the

Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61420/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182172 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 3, 2017, 9:15

Re: behavior of "connect" command when --use-ssl

Well, then `connect` will be inconsistent with other commands (e.g. `start locator`) at best. Geode is going to pick up the gfSecurity.properties file in your HOME directory whether you want it to or not, and especially regardless of the options given to either `start locator` or `start server`

Re: behavior of "connect" command when --use-ssl

I don't have any problem of having all the "security" info in another properties file, but the fact that it's still trying to load a property file even if the command did not say so explicitly. I might have such a file sitting in my home dir for some occasions, but I may not want to use it in this

Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund,

Re: [DISCUSS] Feature branch cleanup

On Thu, Aug 3, 2017 at 1:41 PM, Jinmei Liao wrote: > I am not sure why I have so many branches there. I don't remember I created > them. But this is what I get when I tried to delete one of them: > > *$* git fetch origin > > *$* git push origin --delete feature/GEODE-2632-6

Re: [DISCUSS] Feature branch cleanup

I am not sure why I have so many branches there. I don't remember I created them. But this is what I get when I tried to delete one of them: *$* git fetch origin *$* git push origin --delete feature/GEODE-2632-6 error: unable to delete 'feature/GEODE-2632-6': remote ref does not exist error:

Review Request 61411: GEODE-3286 Failing to cleanup connections from ConnectionTable receiver table (corrected "stopped" check in previous fix)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61411/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182131 --- Ship it! Ship It! - Kirk Lund On Aug. 3, 2017, 5:12 p.m.,

Re: Review Request 61185: GEODE-3231: use tempWorkingFolder to avoid test log file contamination between tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61185/#review182128 --- Ship it! Ship It! - Emily Yeh On July 27, 2017, 4:57 p.m.,

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review182126 --- Ship it! Looks good! +1

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/ --- (Updated Aug. 3, 2017, 5:12 p.m.) Review request for geode, Emily Yeh, Jared

Review Request 61409: GEODE-3328: simplify GfshParserRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: Review Request 61281: GEODE-3379 Geode transaction may commit on a secondary bucket after bucket rebalance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61281/#review182124 --- Fix it, then Ship it! Ship It!

Re: behavior of "connect" command when --use-ssl

Historically, gfSecurity.properties is a companion to gemfire.properties in which sensitive key/value pairs can be kept in. The log banner does not (or did not) log any values in gfSecurity.properties. Users would also typically protect gfSecurity.properties with tighter permissions than

[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

Github user darrenfoong commented on the issue: https://github.com/apache/geode/pull/668 I've added code to unset/clear the temporarily-set system properties for testing. Thank you Kenneth for your feedback. --- If your project is set up for it, you can reply to this email

Re: [DISCUSS] Feature branch cleanup

+1 I did this awhile back. Once you’ve finished work on a feature branch please remove it. https://stackoverflow.com/questions/2003505/how-do-i-delete-a-git-branch-both-locally-and-remotely Anthony > On Aug 2, 2017, at 9:54 PM, Nabarun Nag wrote: > > Branch Name > Ticket >

[GitHub] geode issue #668: GEODE-3306: Remove whitespace StringBuffers/nodes created ...

Github user darrenfoong commented on the issue: https://github.com/apache/geode/pull/668 I just realised I'll need to unset the property to prevent any side effects in the other tests; working on it now. --- If your project is set up for it, you can reply to this email and have your

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131182576 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/AbstractPulseConnectivityTest.java --- @@ -15,26 +15,31 @@ package

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131182711 --- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/internal/PulseAppListenerTest.java --- @@ -0,0 +1,91 @@ +/* + * Licensed to the

[GitHub] geode pull request #677: GEODE-3038: A server process shuts down quietly whe...

Github user anton-mironenko commented on a diff in the pull request: https://github.com/apache/geode/pull/677#discussion_r131154689 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -1208,6 +1208,9 @@ private void initialize() {

[GitHub] geode issue #677: GEODE-3038: A server process shuts down quietly when path ...

Github user anton-mironenko commented on the issue: https://github.com/apache/geode/pull/677 @dschneider-pivotal Thank you for your feedback. I've replaced CacheXmlException with RuntimeException. Sorry for two duplicate commits instead of the only one. --- If your project is set

Re: [DISCUSS] Feature branch cleanup

+1 to using your own fork for feature work On Wed, Aug 2, 2017 at 10:58 PM, Jacob Barrett wrote: > Along those same lines it would be really nice if people would use their > own forks for feature branches, then we wouldn't have this mess at all. > > Sent from my iPhone > >

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131071385 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java --- @@ -270,6 +271,7 @@ private void startHttpService(boolean

[GitHub] geode pull request #664: Fix for GEODE-3292

Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131071365 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the

RE: Stored procedures on Apache Geode.

Hi John, Thank you very much for all this details provided , was very helpful!!! Thanks Marios From: John Blum [via Apache Geode (Incubating) Developers Forum] [ml+s70738n24960...@n6.nabble.com] Sent: Thursday, August 03, 2017 12:56 AM To: Marios