[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

2017-08-14 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/702#discussion_r133113689 --- Diff: geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java --- @@ -96,46 +99,55 @@ public int getMaxThreads() {

Build failed in Jenkins: Geode-nightly #923

2017-08-14 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-3328: fix a test failure on windows. [klund] Revert "GEODE-3328: fix a test failure on windows." [klund] GEODE-3436: revert recent refactoring of GFSH commands

Re: Gitbox enables the full GitHub workflow

2017-08-14 Thread Jacob Barrett
Awesome! Thanks! On Mon, Aug 14, 2017 at 4:27 PM Mark Bretl wrote: > Ticket created, https://issues.apache.org/jira/browse/INFRA-14876 > > Lets see where it goes... > > --Mark > > On Mon, Aug 14, 2017 at 2:13 PM, Jacob Barrett > wrote: > > > Mark, if

[GitHub] geode pull request #698: Mark ProtoBuf interface as experimental

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/698 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Gitbox enables the full GitHub workflow

2017-08-14 Thread Mark Bretl
Ticket created, https://issues.apache.org/jira/browse/INFRA-14876 Lets see where it goes... --Mark On Mon, Aug 14, 2017 at 2:13 PM, Jacob Barrett wrote: > Mark, if you want the experience for the next repo you should do it. > Thanks! > > -Jake > > > Sent from my iPhone >

[GitHub] geode-native pull request #116: GEODE-3439: Split ThinClientRegionInterestTe...

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode-native pull request #116: GEODE-3439: Split ThinClientRegionInterestTe...

2017-08-14 Thread pivotal-jbarrett
GitHub user pivotal-jbarrett opened a pull request: https://github.com/apache/geode-native/pull/116 GEODE-3439: Split ThinClientRegionInterestTestsN into mulitple tests … …to avoid random failures. You can merge this pull request into a Git repository by running: $ git

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #647 was SUCCESSFUL (with 2027 tests)

2017-08-14 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #647 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-647/ -- This

Review Request 61627: GEODE-3437: Fix list and describe region tests

2017-08-14 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

[GitHub] geode pull request #682: GEODE-3393: One-way SSL authentication fails with F...

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Gitbox enables the full GitHub workflow

2017-08-14 Thread Jacob Barrett
Mark, if you want the experience for the next repo you should do it. Thanks! -Jake Sent from my iPhone > On Aug 14, 2017, at 1:17 PM, Ernest Burghardt wrote: > > Mark, Go ahead and file it and geode-native will be the canaries... > > Thanks, > Ernie > >> On Mon, Aug

Re: Gitbox enables the full GitHub workflow

2017-08-14 Thread Ernest Burghardt
Mark, Go ahead and file it and geode-native will be the canaries... Thanks, Ernie On Mon, Aug 14, 2017 at 2:16 PM, Mark Bretl wrote: > Since we have people wanting this and need a small experiment group to > blaze the trail for us, I think the geode-native would be a good

Re: Gitbox enables the full GitHub workflow

2017-08-14 Thread Mark Bretl
Since we have people wanting this and need a small experiment group to blaze the trail for us, I think the geode-native would be a good choice since it has active PRs and commits. Looks like the process to migrate from Git@ASF to GitHub is to create an INFRA ticket with type 'Gitbox Request'.

Re: Gitbox enables the full GitHub workflow

2017-08-14 Thread Jacob Barrett
Well, I am not seeing any -1 votes for this switch. Let's make the change. Any takers for following up with Inra to make this go? On Mon, Aug 7, 2017 at 6:49 PM Jacob Barrett wrote: > +1 for Gitbox > > This will greatly simplify the workflow committers go through with pull

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133013984 --- Diff: geode-old-versions/build.gradle --- @@ -65,6 +100,71 @@ task createGeodeClasspathsFile { new

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133013329 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java --- @@ -34,6 +34,7 @@ import

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133012849 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTest.java --- @@ -0,0 +1,254 @@ +/* + *

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133012057 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java --- @@ -150,6 +166,66 @@ public TomcatInstall(TomcatVersion

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133011336 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java --- @@ -131,15 +142,20 @@ public TomcatInstall(TomcatVersion

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread DivineEnder
Github user DivineEnder commented on a diff in the pull request: https://github.com/apache/geode/pull/712#discussion_r133010884 --- Diff: geode-assembly/src/test/java/org/apache/geode/session/tests/ServerContainer.java --- @@ -134,6 +134,7 @@ public

[GitHub] geode pull request #712: GEODE-3434: Allow the modules to be interoperable w...

2017-08-14 Thread jhuynh1
GitHub user jhuynh1 opened a pull request: https://github.com/apache/geode/pull/712 GEODE-3434: Allow the modules to be interoperable with current and ol… …der versions of tomcat 7 Modified DeltaSessions to use reflection to handle attributes fields incase an earlier

[GitHub] geode pull request #711: GEODE-3436: revert all commands refactorings

2017-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/711 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...

2017-08-14 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/700#discussion_r133001811 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java --- @@ -79,9 +81,10 @@

[GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...

2017-08-14 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/700#discussion_r133000153 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java --- @@ -59,13 +59,14 @@

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-14 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132878512 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -72,9 +99,15 @@ public static

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

2017-08-14 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132878378 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -63,6 +65,31 @@ private static