Re: [DISCUSS] Time to cut Geode 1.10.0?

What was missing from the RFC process for the cluster management service? I saw a [Discuss] thread for it, as well as a proposal at https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service On Tue, Jul 23, 2019 at 10:02 AM Udo Kohlmeyer wrote: > I don't believe we should be

Re: Is the documentation wrong here?

Yes, I believe the docs there are out of date and need to be updated. This change in the naming of deployed jars was introduced in Geode 1.2 by https://github.com/apache/geode/pull/429. On Tue, Jun 4, 2019 at 7:27 AM liyuj <18624049...@163.com> wrote: > Hi, > > >

Re: Backwards compatibility issue with JSONFormatter

It looks like the japi-compliance-checker tool to which Anthony linked is available as a gradle plugin: https://github.com/melix/japicmp-gradle-plugin On Tue, May 14, 2019 at 5:07 PM Ryan McMahon wrote: > Fixed in > >

Re: Gradle build broken?

You might also try ./gradlew build --refresh-dependencies if this happens again. On Wed, Jan 23, 2019 at 9:38 AM Kirk Lund wrote: > I saw the same problem a few weeks ago. I ended up deleting the directories > in my .m2 repository and rebuilding. That seemed to fix it. > > The cause seems to

Re: [VOTE] Time-based release schedule for minor releases

To my mind, one of the core reasons for SemVer is to communicate the level of estimated risk to users when taking an update. It seems to me that the amount of code change included in a quarterly release will always introduce more risk than a single narrowly-targeted fix for a CVE (like those that

Re: Has anyone else been getting gradle "Unable to start the daemon process."

You might be running into this: https://stackoverflow.com/a/52510288 On Mon, Oct 1, 2018 at 2:03 PM Patrick Rhomberg wrote: > Hello all. > > I've been getting some strange failures lately, with the output given > below. I have noticed that creating a `gradle wrapper` fixes these > issues.

Re: [VOTE] Apache Geode 1.5.0.RC2

Out of curiosity, what was Pulkit's suggestion? I don't see it in this thread. On Thu, Apr 5, 2018, 8:32 AM Alexander Murmann wrote: > I am very much in favor of Pulkit's suggestion. We've previously discussed > using something like >

Re: [DISCUSS]: Tests requiring external services

Just FYI, the reason that :acceptanceTest is currently only a target of precheckin is https://issues.apache.org/jira/browse/GEODE-3296 For the full details, see this thread on the Gradle Forums: https://discuss.gradle.org/t/test-task-with-forkevery-1-and-includecategories-performs-poorly/23401

Re: [Discussion] Improving Spotless to be Even More Beautiful

+1 to all of the above On Mon, Mar 19, 2018 at 2:51 PM, Patrick Rhomberg wrote: > Hello all! > > I'm making another pass at patching up some of our smellier broken > windows, to mix metaphors. To that end, there are a few things I'd like to > add to spotless to more

Re: Debugging dunit in intellij now fails?

That looks like you have already have a process running on the port that the debugger is trying to connect on. I'd try to netstat -an and kill any process bound to that port. On Tue, Mar 6, 2018 at 1:06 PM, Kirk Lund wrote: > Anyone else see this when attempting to use

Re: [VOTE] Apache Geode release - 1.3.0 RC4

+1 Built from source and performed basic operations against a small cluster. > On Oct 26, 2017, at 11:54 AM, Swapnil Bawaskar wrote: > > This is the fourth release candidate for Apache Geode, version 1.3.0. > Thanks to all the community members for their contributions to

Re: [Discuss] CliStrings

> On Oct 20, 2017, at 1:59 PM, Dan Smith wrote: > > +1 for removing it. > > I do think it would be nice if we add localization in the future. But > I don't really like the idea of leaving stuff in our code just in case > we decide to implement a feature in the future - we

[Discuss] CliStrings

I wanted to kick off a discussion about the usage of CliStrings. For those unfamiliar, it’s a java class that contains about ~3000 lines of String constants and has a javadoc explaining that it is an attempt at i18n localization. Does anyone know if this localization is actually implemented

Re: [Discuss] Geode gradle plugin

ooked at https://plugins.gradle.org/docs/submit > <https://plugins.gradle.org/docs/submit> > <https://plugins.gradle.org/docs/submit > <https://plugins.gradle.org/docs/submit>> ? > > Anthony > > >> On Oct 11, 2017, at 7:56 PM, Jared Stewart <jste

[Discuss] Geode gradle plugin

Hi all, I've been working on a Gradle plugin to make it easier to write integration tests for applications that use Apache Geode, and would like to discuss where it should reside. To give some background, we have a JUnit Rule called GfshRule that lets you write tests that execute gfsh

Re: [DISCUSS] CI improvements

+1 I think this will be a huge improvement to the reliability of our test infrastructure. - Jared > On Oct 6, 2017, at 9:26 AM, Kirk Lund wrote: > > +1 no thoughts other than make it so! > > On Fri, Oct 6, 2017 at 7:08 AM, Anthony Baker wrote: > >> Hi

Re: Rebase and squash before merging PRs

the menu when you are >> ready to merge. Remember to use "Rebase and merge". >> >> >> ​ >> >> Not sure if this is useful to everyone, but when I push a subsequent commit >> to my feature branch, I always use "force push", so that

Rebase and squash before merging PRs

I’ve been seeing a lot more merge commits on develop since we moved to Gitbox. Just wanted to give everyone a friendly reminder to please rebase before merging to keep our git history tidy and readable. Thanks, Jared

Re: ExportConfigCommandDUnitTest

t passes when I run it in IntelliJ. The cause was: > > Caused by: java.net.BindException: Address already in use > > So, I'm assuming the test tried to use a port that was in use. Is the test > using a random port or a default port? > > On Wed, Oct 4, 2017 at 5:14 PM, Jared

Re: How gitbox works

Https://github.com/apache is where I had to accept the invite and get the third box green. I didn't seem to get an email invite either. - Jared On Sep 18, 2017 12:51 PM, "Kirk Lund" wrote: If I navigate to https://github.com/apache, I see the following at the top with a

Re: Request: Build flag to skip download of previous Geode versions

I think this might do it: ./gradlew build -x :geode-old-versions:compileJava -x :geode-old-versions:verifyGeodetest120 -x :geode-old-versions:downloadZipFiletest120 -x :geode-old-versions:downloadAndUnzipFiletest120 > On Sep 18, 2017, at 9:46 AM, Kirk Lund wrote: > > I

Re: [DISCUSS] authorizing function execution

. > > > > On Wed, Sep 13, 2017 at 11:22 AM, Jared Stewart <jstew...@pivotal.io> wrote: > >> After some more investigation into the implementation details, here is our >> updated proposal to add to the Function interface: >> >> default

Re: [DISCUSS] authorizing function execution

After some more investigation into the implementation details, here is our updated proposal to add to the Function interface: default Collection getRequiredPermissions(Optional onRegion) { return Collections.singletonList(ResourcePermissions.DATA_WRITE); } This method can be overridden by

Re: Flaky failures in Geode Nightly Build

I would prefer not to mark ExportLogsStatsOverHttpDUnitTest as flaky. This is the first time we’ve seen it fail, and it looks like it failed due to insufficient cleanup from a previous test. We’re working on finding the culprit test and adding the missing cleanup. (Or you can mark it flaky

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

> On Sept. 11, 2017, 4:54 p.m., Jared Stewart wrote: > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/GfshStartLocatorLogTest.java > > Line 36 (original), 33 (patched) > > <https://reviews.apache.org/r/62163/diff/1/?file=1817628#file1817

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/#review185108 --- Ship it! Ship It! - Jared Stewart On Sept. 9, 2017, 6:21

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

/internal/cli/commands/GfshStartLocatorLogTest.java Line 36 (original), 33 (patched) <https://reviews.apache.org/r/62163/#comment261303> I think this probably ought to be `AcceptanceTest`. - Jared Stewart On Sept. 9, 2017, 6:21 a.m., Jinmei Liao

Re: Review Request 62189: GEODE-2817: consolidate authorize(*) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62189/#review185024 --- Ship it! Ship It! - Jared Stewart On Sept. 8, 2017, 4:28

Re: Review Request 62132: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62132/#review185020 --- Ship it! Ship It! - Jared Stewart On Sept. 8, 2017, 7:58

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

> On Sept. 8, 2017, 4:37 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Lines 232 (patched) > > <https://reviews.apache.org/r/62179/diff/1-2/?file=1818168#file1818168line243> > > > &g

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

g/r/62179/#comment261209> Do you think there is any chance someone will start both a server and a client in the same VM? (To deal with that I think we would just remove the `else{` and always try to disconnect the DS, even if `member` was not `null`) - Jared Stewart On Sept. 8, 20

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

rVM.getVM().invoke((SerializableRunnableIF) MemberStarterRule::disconnectDSIfAny); }; Arrays.stream(members).filter(Objects::nonNull).forEach(stopMemberAndDisconnectDS); ``` - Jared Stewart On Sept. 7, 2017, 11:12 p.m., Jinmei L

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

ur intent is to trigger authorization. - Jared Stewart On Sept. 7, 2017, 3:33 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Review Request 62178: GEODE-3449: Fix flakiness in ConnectCommandWithSSLTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62178/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 62132: GEODE-3277: Fix error path constructors of Launcher inner State classess

/LocatorLauncher.java Line 1099 (original), 1092 (patched) <https://reviews.apache.org/r/62132/#comment261049> Do you think there is any value in logging the full stacktrace of the exception? It looks like that never gets logged anywhere. - Jared Stewart On Sept. 6, 2017, 8:10 p.m., Ken Howe

Re: Missing Gitbox activation email

>>>>>> On Wed, Sep 6, 2017 at 4:21 PM Dan Smith <dsm...@pivotal.io> wrote: >>>>>> >>>>>> If you are stuck on 3rd step (MFA Status) make you have added your >>>>> github >>>>>> username on id.apache.org *and* that

Re: Missing Gitbox activation email

) make you have added your >>>>> github >>>>>> username on id.apache.org *and* that you have accepted the invitation >>>>> to >>>>>> join the apache group on github. >>>>>> >>>>>> You should see an

Re: Missing Gitbox activation email

I’m stuck on the same step. I tried clearing out my GitHub username at id.apache.org and then re-adding it in the hopes of re-triggering the email, but it still hasn’t arrived. - Jared > On Sep 6, 2017, at 4:04 PM, Udo Kohlmeyer wrote: > > Hey there,

Re: Review Request 62022: GEODE-3549: fix the constantly failing flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62022/#review184320 --- Ship it! Ship It! - Jared Stewart On Aug. 31, 2017, 9:22

Review Request 62021: GEODE-3547: Simplify behavior for non-writable deploy directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62021/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 62002: GEODE-3539: Add tests for List Members and Describe Member

ying > > only call this after gfsh displays the result already. The whole gfsh > > result displayer is a mess for now. > > Jared Stewart wrote: > I only intended to use this method from tests and I think in that case > there should always be a result.

Re: Review Request 62002: GEODE-3539: Add tests for List Members and Describe Member

d e-mail. To reply, visit: https://reviews.apache.org/r/62002/#review184275 ------- On Aug. 30, 2017, 10:13 p.m., Jared Stewart wrote: > > --- > This is an a

Review Request 62002: GEODE-3539: Add tests for List Members and Describe Member

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62002/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund

Review Request 62001: GEODE-3525: Dockerize AcceptanceTests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62001/ --- Review request for geode, Anthony Baker, Jens Deppe, Jinmei Liao, Jared Stewart

Re: Review Request 61995: wip

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61995/#review184174 --- Ship it! Ship It! - Jared Stewart On Aug. 30, 2017, 5:38

Re: Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest

, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes --- Geode-junit needs Awaitility Repository: geode Description --- GEODE-2859: Fix race condition in ShowDeadlockDUnitTest Diffs (updated) - geode-core/src/test/java/org/apache/geode/management/internal/cli

Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

ache.org/r/61972/#review184081 --- On Aug. 29, 2017, 4:53 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Review Request 61974: GEODE-2859: Fix race condition in ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61974/ --- Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61972/ --- (Updated Aug. 29, 2017, 4:53 p.m.) Review request for geode, Emily Yeh, Jared

Review Request 61972: GEODE-3445: Convert connect acceptance test to DUnit test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61972/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 61860: GEODE-3510: GfshRule displays output from StdError

running Thanks, Jared Stewart

Re: Review Request 61860: GEODE-3510: GfshRule displays output from StdError

cally generated e-mail. To reply, visit: https://reviews.apache.org/r/61860/#review183798 ------- On Aug. 23, 2017, 8:18 p.m., Jared Stewart wrote: > > --- > This is an a

Review Request 61860: GEODE-3510: GfshRule displays output from StdError

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61860/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: Nightly build failures caused by attempted use of default ports

I think we just need to have AcceptanceTest (and possibly IntegrationTest) run inside Docker like DistributedTest already does. - Jared. > On Aug 23, 2017, at 11:32 AM, Anilkumar Gingade wrote: > >>> 1) use Docker for AcceptanceTest and IntegrationTest targets? > To be

Re: Gitbox enables the full GitHub workflow

+1 for moving the other repos to Gitbox On Aug 22, 2017 10:43 AM, "Anthony Baker" wrote: > On Aug 7, 2017, at 6:09 PM, Roman Shaposhnik wrote: > > Hi! > > it has just come to my attention that Gitbox at ASF > has been enabling full GitHub workflow

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

> On Aug. 17, 2017, 5:35 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > > Lines 2017 (patched) > > <https://reviews.apache.org/r/61701/diff/1/?file=1798850#file1798850line2020> > > > > I th

Re: Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

/commands/ConnectCommand.java 274f61c Diff: https://reviews.apache.org/r/61802/diff/2/ Changes: https://reviews.apache.org/r/61802/diff/1-2/ Testing --- Precheckin running Thanks, Jared Stewart

Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61802/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 61758: GEODE-3471: Identify NPE in MBeanProxyFactory

we'll be able to decide how to properly deal with a null value. - Jared --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61758/#review183354 ------- On Aug. 18, 2017, 9:55 p.m., Jared Stewart wrote: > > ---

Re: [Discuss] Compatibility with Apache Xerces

It sounds like these changes ought to be ok. If there is no objection, I will go ahead and pull them in this afternoon. Thanks, Jared > On Aug 21, 2017, at 9:09 AM, Jacob Barrett wrote: > > Looking into the legacy repo I can see that the fix for the StringBuffer > issue

Review Request 61757: GEODE-2859: Fix ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61757/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: [DISCUSS] authorizing function execution

We already have a similar annotation that we use internally to secure GFSH commands: @ResourceOperation(resource = Resource.DATA, operation = Operation.MANAGE) public Result createRegion( One option might be to move this annotation into a public package and to enforce it if present on

Re: Review Request 61694: GEODE-3235: Deploy jar registers functions which extend FunctionAdapter

/61694/diff/1-2/ Testing --- precheckin running Thanks, Jared Stewart

Re: Changes to Jenkins geode-nightly build job

Thanks Jens, this will be a huge improvement! > On Aug 17, 2017, at 10:35 AM, Jens Deppe wrote: > > Hi, > > I'm making changes to the geode-nightly build such that it will use docker > containers for distributedTests. This means that these tests can also be >

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

ecycle/GfshStatusCommandsIntegrationTest.java Lines 85 (patched) <https://reviews.apache.org/r/61701/#comment259162> Looks like you intended to uncomment this line. - Jared Stewart On Aug. 16, 2017, 9:21 p.m., Ken Howe wrote: > > --- > Thi

Review Request 61694: GEODE-3235: Deploy jar registers functions which extend FunctionAdapter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61694/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 61627: GEODE-3437: Fix list and describe region tests

Thanks, Jared Stewart

Review Request 61627: GEODE-3437: Fix list and describe region tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61627/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: [DISCUSS] New annotation to identify Functions whose class hierarchy spans multiple jar files

onable to set limitations to keep the initial scope > small, but be sure those are well documented since users will be coming > from many different frameworks having many different expectations. > > Food for thought/hope this helps. > > Regards, > -John > > > [1] > http

Re: Review Request 61599: GEODE-3328: fix a test failure on windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61599/#review182759 --- Ship it! Ship It! - Jared Stewart On Aug. 11, 2017, 10:42

Re: Review Request 61563: GEODE-3383: Refactor deploy tests

/management/internal/cli/commands/CommandOverHttpDUnitTest.java 7753aafbd7dc5ea4288e27f088400163f6739347 Diff: https://reviews.apache.org/r/61563/diff/1/ Testing (updated) --- Precheckin passed Thanks, Jared Stewart

Review Request 61563: GEODE-3383: Refactor deploy tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61563/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/#review182442 --- Ship it! Ship It! - Jared Stewart On Aug. 8, 2017, 9:10 p.m

Review Request 61507: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61507/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

/ClientCQAuthDUnitTest.java Lines 54 (patched) <https://reviews.apache.org/r/61480/#comment258340> Oops, I was a little trigger happy with my "Ship it!".. Should there be one more test here to make sure that things work as expected when a user has both permissions? - Jared Stewart On Au

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/#review182433 --- Ship it! Ship It! - Jared Stewart On Aug. 7, 2017, 8:13 p.m

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- Precheckin running Thanks, Jared Stewart

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

> On Aug. 7, 2017, 8:21 p.m., Jared Stewart wrote: > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java > > Lines 140 (patched) > > <https://reviews.apache.org/r/61480/diff/1/?file=1791025#file1791025line141> > >

Re: Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61487/#review182405 --- Ship it! Ship It! - Jared Stewart On Aug. 8, 2017, 4:38 p.m

Re: Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

ne is expected to obtain the lock on `CacheFactory`. - Jared Stewart On Aug. 8, 2017, 12:19 a.m., Kirk Lund wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 61472: GEODE-3097: fix an accidental bug introduced when working on ssl over http

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61472/#review182315 --- Ship it! Ship It! - Jared Stewart On Aug. 7, 2017, 5:18 p.m

Re: Review Request 61417: GEODE-3328: adding ssl-truststore-type to the config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61417/#review182230 --- Ship it! Ship It! - Jared Stewart On Aug. 3, 2017, 9:15 p.m

Re: Review Request 61426: GEODE-3277: Fix error path constructors of inner State classes of the Launchers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61426/#review182229 --- Ship it! Ship It! - Jared Stewart On Aug. 4, 2017, 2:55 p.m

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

. - Jared Stewart On Aug. 3, 2017, 5:12 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: behavior of "connect" command when --use-ssl

+1 to excluding the home dir at the very least. I think that behavior is surprising, and it also makes it harder to maintain multiple separate, isolated versions of Geode on the same machine. (One can easily introduce an unintended properties file into their configuration simply by copying it

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

sit: https://reviews.apache.org/r/61166/#review181999 --- On Aug. 2, 2017, 5:54 p.m., Jared Stewart wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

/ImplementsFunction.java PRE-CREATION Diff: https://reviews.apache.org/r/61166/diff/7/ Changes: https://reviews.apache.org/r/61166/diff/6-7/ Testing --- Precheckin running Thanks, Jared Stewart

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

/deployment/compiler/ImplementsFunction.java PRE-CREATION Diff: https://reviews.apache.org/r/61166/diff/6/ Changes: https://reviews.apache.org/r/61166/diff/5-6/ Testing --- Precheckin running Thanks, Jared Stewart

Re: Review Request 61231: GEODE-3328: simply extract connect command from ShellCommand

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61231/#review181866 --- Ship it! Ship It! - Jared Stewart On July 28, 2017, 8:41

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

://reviews.apache.org/r/61166/diff/4-5/ Testing --- Precheckin running Thanks, Jared Stewart

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

declaration. Is it intended? I omitted a package declaration for simplicity since it didn't seem necessary to specify one. I can add one in if you think the lack of a package is confusing. - Jared --- This is an automa

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

/r/61166/diff/4/ Changes: https://reviews.apache.org/r/61166/diff/3-4/ Testing --- Precheckin running Thanks, Jared Stewart

Review Request 61224: GEODE-3318: Fix UniversalMembershipListenerAdapterDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61224/ --- Review request for geode, Emily Yeh, Galen O'Sullivan, Jared Stewart, Ken Howe

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

/ Changes: https://reviews.apache.org/r/61166/diff/2-3/ Testing --- Precheckin running Thanks, Jared Stewart

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

/diff/2/ Changes: https://reviews.apache.org/r/61166/diff/1-2/ Testing --- Precheckin running Thanks, Jared Stewart

Review Request 61196: GEODE-3326: Fix intermittent ConcurrentDeployDUnitTest failure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61196/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 61185: GEODE-3231: use tempWorkingFolder to avoid test log file contamination between tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61185/#review181613 --- Ship it! Ship It! - Jared Stewart On July 27, 2017, 4:57

Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund

Re: Review Request 61119: GEODE-3097: GFSH works over HTTP with SSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61119/#review181398 --- Ship it! Ship It! - Jared Stewart On July 25, 2017, 10:11

Review Request 61114: GEODE-3296: Speed up Acceptance Tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61114/ --- Review request for geode, Anthony Baker, Emily Yeh, Jens Deppe, Jared Stewart

  1   2   3   4   5   >