Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

che.org/r/5/#comment246508> delete line geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java Lines 76 (patched) <https://reviews.apache.org/r/5/#comment246509> delete line - Ken Howe On May 1, 2017, 7:

Re: Review Request 58849: GEODE-2840: add a DUnit test to test concurrent deploy

larity to the code. Exceptions would be where the name might conflict with a keyword, which is not the case here. - Ken Howe On April 28, 2017, 6:02 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 58848: GEODE-2632: prevent ClassCastException from ConnectionCountProbe to Identifiable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58848/#review173384 --- Ship it! Ship It! - Ken Howe On April 28, 2017, 7:40 p.m

Re: Review Request 58742: GEODE-2632: minor fixes from code review

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58742/#review173224 --- Ship it! Ship It! - Ken Howe On April 26, 2017, 5:17 p.m

Re: Review Request 58751: GEODE-2632: make GemFireCacheImpl.getRegion(String) non-final

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58751/#review173213 --- Ship it! Ship It! - Ken Howe On April 26, 2017, 8:54 p.m

Re: Review Request 58595: GEODE-2681: refactoring to prevent synchronization hang on getAnyInstance

798 (which is a dupilcate of GEODE-2681.) Precheckin has been started. Thanks, Ken Howe

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

/LocatorServerStartupRule.java Line 67 (original), 63 (patched) <https://reviews.apache.org/r/58518/#comment245592> Javadoc comment is no longer needed - Ken Howe On April 19, 2017, 11:22 p.m., Jared Stewart

Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172364 --- Ship it! Ship It! - Ken Howe On April 18, 2017, 9:58 p.m

Re: Review Request 58460: GEODE-2632: refactoring part 1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58460/#review172121 --- Ship it! Ship It! - Ken Howe On April 17, 2017, 7:09 p.m

Re: Review Request 58460: GEODE-2632: refactoring part 1

st/java/org/apache/geode/internal/cache/control/MemoryMonitorJUnitTest.java Lines 297-301 (original), 297-301 (patched) <https://reviews.apache.org/r/58460/#comment245101> Spotless seems to have made a mess of this and the following comment. - Ken Howe On April 14, 2017, 9:

Re: Review Request 58435: GEODE-2647: remove unnecessary client puts from ClientHealthStatsDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58435/#review171956 --- Ship it! Ship It! - Ken Howe On April 13, 2017, 10:15 p.m

Re: Review Request 58388: GEODE-2730: refactor rules

ithAutoStart() ? - Ken Howe On April 12, 2017, 11:32 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 58388: GEODE-2730: refactor rules

> On April 12, 2017, 9:10 p.m., Ken Howe wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java > > Lines 110 (patched) > > <https://reviews.apache.org/r/58388/diff/2/?file=1690839#file1690839line110> > > > > I

Re: Review Request 58388: GEODE-2730: refactor rules

ts a boolean to start (or not) later in the before() method. My interpretation is that it's an "auto start" flag for each test. - Ken Howe On April 12, 2017, 3:08 p.m., Jinmei Liao wrote: > > --- > This is an automatic

Re: Review Request 58388: GEODE-2730: refactor rules

to have been somewhat haphazard up to now. This commnent applies to all our rules, not just this one. - Ken Howe On April 12, 2017, 3:08 p.m., Jinmei Liao wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 58325: GEODE-2737: Change Pulse UI tests to use random port for JMX connections

ing Thanks, Ken Howe

Re: Review Request 58325: GEODE-2737: Change Pulse UI tests to use random port for JMX connections

/diff/2-3/ Testing (updated) --- ==> Precheckin was clean other than spotlessCheck. Re-runing the precheckin after reformatting to correct the failure All Pulse UI tests run locally pass. Precheckin is running Thanks, Ken Howe

Re: Review Request 58325: GEODE-2737: Change Pulse UI tests to use random port for JMX connections

y pass. Precheckin is running Thanks, Ken Howe

Review Request 58325: GEODE-2737: Change Pulse UI tests to use random port for JMX connections

://reviews.apache.org/r/58325/diff/1/ Testing --- All Pulse UI tests run locally pass. Precheckin is running Thanks, Ken Howe

Re: Review Request 58319: GEODE-2765: change gfsh help to use log4j levels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58319/#review171491 --- Ship it! Ship It! - Ken Howe On April 10, 2017, 9:06 p.m

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

206) at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:216) at org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146) Re-running precheckin after merging current develop to my branch. Thanks, Ken Howe

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

216) at org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146) Re-running precheckin after merging current develop to my branch. Thanks, Ken Howe

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

216) at org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146) Thanks, Ken Howe

Re: Review Request 58050: GEODE-2725: export logs --dir now honored when not connected via HTTP[S].

> > (Updated March 30, 2017, 6:17 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, > Kirk Lund, and Swapnil Bawaskar. > > > Repository: geode > > > Description > --- > > exp

Re: Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

216) at org.apache.geode.management.internal.cli.functions.SizeExportLogsFunctionCacheTest.withFunctionError_shouldThrow(SizeExportLogsFunctionCacheTest.java:146) Thanks, Ken Howe

Re: Review Request 58050: GEODE-2725: export logs --dir now honored when not connected via HTTP[S].

ated e-mail. To reply, visit: > https://reviews.apache.org/r/58050/ > --- > > (Updated March 30, 2017, 6:17 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, > Kirk Lund, and Swapnil Bawaskar. > > > Repository: geode >

Review Request 58080: GEODE-2420: Add classes to estimated the size of exported logs

--- Precheckin is running Thanks, Ken Howe

Re: Review Request 58010: GEODE-2716: export logs default behavior changed from filtering at log level INFO to ALL.

the change noted above.) - Ken Howe On March 28, 2017, 10:34 p.m., Patrick Rhomberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169795 --- - Ken Howe On March 17, 2017, 6:48 p.m., Jinmei Liao wrote

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169799 --- - Ken Howe On March 17, 2017, 6:48 p.m., Jinmei Liao wrote

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57729/#review169524 --- Ship it! Ship It! - Ken Howe On March 17, 2017, 6:48 p.m

Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion

apping is: LogWriter.FINE and FINER --> Level.DEBUG LogWriter.FINEST --> Level.TRACE The new mapping has LogWriter.FINE --> Level.DEBUG LogWriter.FIBNER abnd FINEST --> Level.TRACE - Ken Howe On March 17, 2017, 6:48 p.m.,

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review169054 --- Ship it! Ship It! - Ken Howe On March 15, 2017, 8:02 p.m

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

move the deleted files dir from the dir.listFiles() rather than arbitarily returning length - 1. Something like List listOfFiles = Arrays.asList(dir.listFiles()); listOfFiles.remove(dirOfDeletedFiles.getName()); return listOfFiles.size(); - Ken Howe On March 13, 2017,

Re: Review Request 57522: check for string "null" in server/locator status message

Ran spotlessApply Re-started precheckin Thanks, Ken Howe

Re: Review Request 57431: GEODE-2633: When turning on fine logging, GEODE logs the keystore password in clear text

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57431/#review168833 --- Ship it! Ship It! - Ken Howe On March 13, 2017, 6:05 p.m

Review Request 57522: check for string "nul" in server/locator status message

en started Thanks, Ken Howe

Re: Review Request 57390: GEODE-2539: Upgrading Jetty causes RestSecurityItegrationTest to fail

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57390/#review168474 --- Ship it! Ship It! - Ken Howe On March 7, 2017, 7:09 p.m

Re: Review Request 57439: GEODE-2576: delete the zip file on locator after it's being streamed to client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57439/#review168468 --- Ship it! Ship It! - Ken Howe On March 9, 2017, 12:44 a.m

Re: Review Request 57311: GEODE-2593: add port range to AvailablePortHelper to fix testUDPPortRange

ent240005> Is the upper_bound a useable port? If so then the outer loop test should be '<='. Also in the test condition, the upper_bound should be reduced by the count to enusre that i + j doesn't exceed the upper_bound. - Ken Howe On March 4, 2017, 1:57 a.m.,

Re: Review Request 57243: GEODE-2416: Collect together artifacts from individual servers into a single zip file

to the latest (version 3) without examining the intermediate changes. As these changes appear that they won't break nightly builds (your precheckin passed), it would be great to get this merged so that further refinements to the export logs command behavior can be dealt with individually. - Ken Howe

Re: Review Request 57249: GEODE-2488: Remove lsof from netstat command tests

Diff: https://reviews.apache.org/r/57249/diff/2/ Changes: https://reviews.apache.org/r/57249/diff/1-2/ Testing --- Tested locally on JVMs with small heap to verify there are no OOMEs Precheckin has been started. Thanks, Ken Howe

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

atched) <https://reviews.apache.org/r/57242/#comment239611> Why use locatorPort from 0 to -1? The test in startServer(Properties properties, int locatorPort, boolean pdxPersistent) is for >0 - Ken Howe On March 2, 2017, 3:30 p.m., Ji

Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure

://reviews.apache.org/r/57221/diff/1-2/ Testing --- Ran spotlessApply Precheckin is in progress Thanks, Ken Howe

Review Request 57221: GEODE-2541: Fixed ClassCastException failure

/ Testing --- Ran spotlessApply Precheckin is in progress Thanks, Ken Howe

Re: Review Request 57175: GEODE-4160: upgrade mortbay-jetty-servlet-api dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57175/#review167511 --- Ship it! Ship It! - Ken Howe On March 1, 2017, 1:39 a.m

Re: Build failed in Jenkins: Geode-nightly #762

I’m working on the NetstatDUnitTest failure. GEODE-2541 Ken > On Feb 28, 2017, at 8:35 AM, Apache Jenkins Server > wrote: > > 2: Task failed with an exception. > --- > * What went wrong: > Execution failed for task ':geode-core:flakyTest'. >> There were

Re: Review Request 57050: GEODE-2461: remove unnecessary explicit dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57050/#review166763 --- Ship it! Ship It! - Ken Howe On Feb. 24, 2017, 9:37 p.m

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56801/#review166005 --- Ship it! Ship It! - Ken Howe On Feb. 17, 2017, 11:56 p.m

Re: Review Request 56801: GEODE-2457: Replace org.apache.geode.internal.FileUtil with org.apache.commons.io.FileUtils

e code. - Ken Howe On Feb. 17, 2017, 10:21 p.m., Kevin Duling wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56637/#review165559 --- Ship it! Ship It! - Ken Howe On Feb. 14, 2017, 7 p.m

Re: Review Request 56668: GEODE-2474: mark NetstatDUnitTest as flaky

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56668/#review165545 --- Ship it! Ship It! - Ken Howe On Feb. 14, 2017, 5:01 p.m

Re: Review Request 56637: refactor ServerStarterRule and LocatorStarterRule so that they can be created without a Properties first.

/ServerStarterRule.java (lines 89 - 94) <https://reviews.apache.org/r/56637/#comment237407> Looks like a null properties argument will cause an NPE - Ken Howe On Feb. 14, 2017, 4:19 p.m., Jinmei Liao

Re: Review Request 56506: GEODE-2398: Retry oplog channel.write on silent failures

- Ken ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56506/#review164991 --- On Feb. 11, 2017, midnight, Ken Howe wrote: > >

Re: Review Request 56506: GEODE-2398: Retry oplog channel.write on silent failures

d e-mail. To reply, visit: https://reviews.apache.org/r/56506/#review165186 ------- On Feb. 11, 2017, midnight, Ken Howe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/565

Re: Review Request 56506: GEODE-2398: Retry oplog channel.write on silent failures

/cache/Oplog.java 0b98364 geode-core/src/test/java/org/apache/geode/internal/cache/OplogFlushTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56506/diff/ Testing --- Started precheckin Thanks, Ken Howe

Re: Review Request 56522: GEODE-2198: do not import cluster config if any region exists to prevent different servers having conflicing region definitions at one point of time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56522/#review165136 --- Ship it! Ship It! - Ken Howe On Feb. 10, 2017, 12:57 a.m

Re: Review Request 56516: GEODE-2456: change JUnit4CacheTestCase tearDown to use deleteQuietly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56516/#review165128 --- Ship it! Ship It! - Ken Howe On Feb. 9, 2017, 8:06 p.m

Review Request 56506: GEODE-2398: Retry oplog channel.write on silent failures

/internal/cache/OplogFlushTest.java PRE-CREATION Diff: https://reviews.apache.org/r/56506/diff/ Testing --- Started precheckin Thanks, Ken Howe

<    1   2