Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136638437
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportDataFunction.java
---
@@ -40,9 +40,13 @@ public void execute
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136639140
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ImportDataIntegrationTest.java
---
@@ -0,0 +1,158
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136638047
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java
---
@@ -41,44 +44,34 @@ public Result
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136638633
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportDataIntegrationTest.java
---
@@ -0,0 +1,127
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136637196
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
---
@@ -1351,6 +1351,12 @@
"File to
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136638194
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java
---
@@ -87,4 +80,45 @@ public Result
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/753
I would like to get a better understanding of the new feature first. So
before the "export data" is export data of a specific region on a specific
member to a file. All three options are
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/745#discussion_r135635795
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommand.java
---
@@ -794,7 +84,7 @@ public Result
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/664
I will pull this in the moment I got a green pipeline
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131182576
--- Diff:
geode-assembly/src/test/java/org/apache/geode/tools/pulse/AbstractPulseConnectivityTest.java
---
@@ -15,26 +15,31 @@
package
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131182711
--- Diff:
geode-pulse/src/test/java/org/apache/geode/tools/pulse/internal/PulseAppListenerTest.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131050219
--- Diff:
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131049554
--- Diff:
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131049401
--- Diff:
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131050061
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
---
@@ -270,6 +271,7 @@ private void startHttpService
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131049994
--- Diff:
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java
---
@@ -38,6 +38,12 @@ protected void before() throws
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/660#discussion_r129910320
--- Diff:
geode-docs/managing/security/implementing_authorization.html.md.erb ---
@@ -56,13 +56,23 @@ which classifies whether the operation
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/660#discussion_r129908926
--- Diff:
geode-docs/managing/security/implementing_authorization.html.md.erb ---
@@ -56,13 +56,23 @@ which classifies whether the operation
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129673457
--- Diff: geode-core/src/main/java/org/apache/geode/internal/ExitCode.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129647221
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java
---
@@ -0,0 +1,396
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/652#discussion_r129646761
--- Diff: geode-core/src/main/java/org/apache/geode/internal/ExitCode.java
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/598#discussion_r128354651
--- Diff:
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/OptionAliasesIntegrationTest.java
---
@@ -0,0 +1,259
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/590
pulling this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao closed the pull request at:
https://github.com/apache/geode/pull/557
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jinmeiliao closed the pull request at:
https://github.com/apache/geode/pull/604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/608#discussion_r124434616
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java
---
@@ -48,13 +49,13 @@
public class
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/geode/pull/604
GEODE-2919: fix lucene security tests
this is to fix the failing lucent tests. Created a PR to see how travis
thinks about it.
You can merge this pull request into a Git repository by running
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/589#discussion_r123845237
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
---
@@ -37,20 +38,25 @@
private String
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/589#discussion_r123818259
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
---
@@ -37,20 +38,25 @@
private String
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/589#discussion_r123544960
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
---
@@ -37,20 +38,25 @@
private String
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/589#discussion_r123544587
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
---
@@ -37,20 +38,25 @@
private String
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/589#discussion_r123332996
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java
---
@@ -37,20 +38,25 @@
private String
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/548#discussion_r120134823
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
@@ -412,7 +411,7 @@ public Result
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/geode/pull/557
add GfshParserRule to facilitate command unit test
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/530
will pull this in after testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/546#discussion_r119159305
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
---
@@ -726,13 +733,13 @@
public static final
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/500#discussion_r117080378
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
---
@@ -406,124 +400,140 @@ public Result
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/500#discussion_r117081706
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
---
@@ -145,6 +153,7 @@ public void startServer(boolean
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/452
resort back to review board.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jinmeiliao closed the pull request at:
https://github.com/apache/geode/pull/452
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/452
review board is having some trouble updating my old reviews. I am using the
pull request. It should addressed all the points that Ken wrote in the old
review. But, please review more. Thanks
GitHub user jinmeiliao opened a pull request:
https://github.com/apache/geode/pull/452
GEODE-2730: refactor rules
* consolidate the two sets of server/locator starter rules
* do not allow member start up at test initialization time.
* validate properties in @Before
* use
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/445
I'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/438
I'll pull this in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/439
I'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/432
Is the comment on here https://reviews.apache.org/r/57822/ addressed in
this PR?
Is precheckin successful?
---
If your project is set up for it, you can reply to this email and have your
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/429
It would be a good idea to do a walkthrough of these changes for us to
understand the major change points.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/335#discussion_r95898738
--- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
@@ -32,7 +32,7 @@
mvc-dispatcher
-/pulse/*
--- End diff
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/335#discussion_r95892864
--- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
@@ -32,7 +32,7 @@
mvc-dispatcher
-/pulse/*
--- End diff
Github user jinmeiliao commented on the issue:
https://github.com/apache/geode/pull/328
I'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/327#discussion_r95418869
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/RegionAlterFunction.java
---
@@ -237,7 +237,7 @@ public void execute
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/327#discussion_r95420817
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
---
@@ -833,6 +833,120
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/327#discussion_r95420944
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java
---
@@ -833,6 +833,120
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/308#discussion_r93131489
--- Diff: geode-core/src/test/java/org/apache/geode/util/test/TestUtil.java
---
@@ -46,11 +47,15 @@ public static String getResourcePath(Class clazz
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r93097202
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r92888056
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/317#discussion_r92666840
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
---
@@ -85,21 +91,16 @@ public void connect(String
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/317#discussion_r92544631
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
---
@@ -44,32 +46,32
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/317#discussion_r92544756
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locator.java ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/317#discussion_r92544538
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ClusterConfig.java
---
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/317#discussion_r92544596
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ConfigGroup.java ---
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/317#discussion_r92545081
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
---
@@ -0,0 +1,144
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/316#discussion_r92544045
--- Diff:
geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
---
@@ -257,15 +257,65 @@ private void readUsers(final
63 matches
Mail list logo
