Github user kirklund closed the pull request at:
https://github.com/apache/geode/pull/699
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132600143
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java
---
@@ -96,33 +117,55 @@ void close() {
* @throws
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599897
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java
---
@@ -96,33 +117,55 @@ void close() {
* @throws
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599768
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/FileProcessController.java
---
@@ -112,56 +119,43 @@ private void stop(final File
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132599627
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/AttachProcessUtils.java
---
@@ -14,21 +14,28 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132598899
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -104,6 +109,8 @@
helpMap.put("bind-address",
---
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132598795
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -795,25 +785,25 @@ protected String toString(final Date
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132592102
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,182 @@
+/*
+
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132571788
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/config/ClusterConfigurationNotAvailableException.java
---
@@ -0,0 +1,29 @@
+/*
+
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132569537
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1781,8 +1782,8 @@ protected void validate() {
*
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132568184
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1352,11 +1328,13 @@ protected void parseCommand(final
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132585045
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/FileProcessController.java
---
@@ -112,56 +119,43 @@ private void stop(final File
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132570355
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -104,6 +109,8 @@
helpMap.put("bind-address",
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132562988
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -795,25 +785,25 @@ protected String toString(final Date
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132572256
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/AttachProcessUtils.java
---
@@ -14,21 +14,28 @@
*/
package
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132585334
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java
---
@@ -96,33 +117,55 @@ void close() {
*
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542184
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542091
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542146
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542169
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542242
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1075,8 +1082,7 @@ private LocatorState
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542157
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542106
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542063
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542016
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,179 @@
+/*
+ *
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132542008
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderWindowsTest.java
---
@@ -0,0 +1,97 @@
+/*
+ *
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132541957
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1848,8 +1884,7 @@ public LocatorLauncher build() {
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132541795
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java
---
@@ -228,9 +230,9 @@ private void disconnect() {
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132541592
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -502,7 +507,7 @@ protected static Integer identifyPid() {
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132535229
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -157,7 +162,7 @@ protected static Properties
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132533643
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
---
@@ -31,7 +31,7 @@
import
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132532669
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,234 @@
+/*
+ *
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132532612
--- Diff:
geode-core/src/main/java/org/apache/geode/config/internal/ClusterConfigurationNotAvailableException.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132532641
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java
---
@@ -0,0 +1,243 @@
+/*
+ *
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132483129
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LocatorLauncherLocalIntegrationTest.java
---
@@ -14,745 +14,270 @@
*/
package
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132515331
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java ---
@@ -810,9 +819,6 @@ public void setStatus(final String
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132520010
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/StartupStatus.java
---
@@ -14,29 +14,37 @@
*/
package
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132501696
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/mbean/Process.java
---
@@ -16,7 +16,6 @@
/**
* Extracted from
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132497014
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/NonBlockingProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,182 @@
+/*
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132325049
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1075,8 +1082,7 @@ private LocatorState
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132326281
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132324608
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132324550
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132323674
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132322055
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321751
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321738
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321803
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132321846
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java
---
@@ -0,0 +1,270 @@
+/*
+ * Licensed
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132303567
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderWindowsTest.java
---
@@ -0,0 +1,97 @@
+/*
+ *
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132314371
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132314473
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132315473
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132304059
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderIntegrationTest.java
---
@@ -0,0 +1,179 @@
+/*
+ *
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132314337
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java
---
@@ -0,0 +1,505 @@
+/*
+ * Licensed to the
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132307061
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -157,7 +162,7 @@ protected static Properties
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132312668
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1848,8 +1884,7 @@ public LocatorLauncher build() {
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132312583
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -502,7 +507,7 @@ protected static Integer identifyPid() {
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132311304
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java
---
@@ -228,9 +230,9 @@ private void disconnect() {
Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132306579
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
---
@@ -31,7 +31,7 @@
import
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132312206
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java
---
@@ -0,0 +1,243 @@
+/*
+ *
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132308711
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java
---
@@ -47,26 +50,21 @@
@Before
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132308040
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132307026
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132299177
--- Diff:
geode-core/src/main/java/org/apache/geode/config/internal/ClusterConfigurationNotAvailableException.java
---
@@ -0,0 +1,29 @@
+/*
+ *
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132301005
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132285291
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java
---
@@ -14,253 +14,370 @@
*/
package
Github user pdxrunner commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132281558
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java
---
@@ -47,26 +50,21 @@
@Before
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/699
GEODE-3413: overhaul launcher and process classes and tests
This is primarily an overall of all ServerLauncher and LocatorLauncher
tests and org.apache.geode.internal.process tests. The main
69 matches
Mail list logo