Re: Very red CI -> Hold merges, please

2019-02-08 Thread Kirk Lund
If you put quotes around "WANRollingUpgradeNewSenderProcessOldEvent" in Jira, then the search finds no hits. Without the quotes it results in two tickets now including the one you worked on. Jira must be searching for partial string matches without quotes -- so some sequence of words in the name

Re: Very red CI -> Hold merges, please

2019-02-08 Thread Bruce Schuchardt
Testing on the fix for GEODE-6363 passed on overnight runs.  I could push a change to mask the problem and do more testing today if that's what folks want or I could push the fix. On 2/7/19 4:20 PM, Alexander Murmann wrote: Bruce, would it make sense to for now revert the suspect change to

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Xiaojian Zhou
WANRollingUpgradeNewSenderProcessOldEvent is not related with GEODE-3967. I wonder why search guided us to GEODE-3967. Regards Gester On Thu, Feb 7, 2019 at 8:34 PM Owen Nichols wrote: > Pipeline is back to green now. Thank you to everyone who stepped up to > get things back on track. > > If

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Owen Nichols
Pipeline is back to green now. Thank you to everyone who stepped up to get things back on track. If you had PR checks fail this week, please re-trigger them (by making an empty commit). > On Feb 7, 2019, at 4:20 PM, Alexander Murmann wrote: > > Bruce, would it make sense to for now revert

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Alexander Murmann
Bruce, would it make sense to for now revert the suspect change to the test? At that point we should be back to full green and we all can without a doubt go back to our usual flow of merging to develop. Thoughts? On Thu, Feb 7, 2019 at 2:37 PM Kirk Lund wrote: > Hmm, and that was another false

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Kirk Lund
Hmm, and that was another false search hit in Jira! Searching for WANRollingUpgradeNewSenderProcessOldEvent in Jira brings up GEODE-3967 which apparently does NOT involve that test. So, maybe we found another flaky test. Jira search seems to not work very well. On Thu, Feb 7, 2019 at 2:24 PM

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Kirk Lund
The UpgradeTest failures on your latest commit for this PR are WANRollingUpgradeNewSenderProcessOldEvent which seems to be a reoccurrence of [GEODE-3967](https://issues.apache.org/jira/browse/GEODE-3967). I recommend having Gester take a look at that these failures. He marked

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Bruce Schuchardt
I'm looking into the locator test failures.  I recently changed those tests to make them not depend on the old JUnit4DistributedTestCase and they lost some settings along the way.  There's also a real problem with Geode that this test is exposing because of that change, so I'd like to NOT fix

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Alexander Murmann
Awesome! Things look a lot better now. It seems like the only consistent issue now is in DistributedTestOpenJDK11 where the LocatorDUnitTest `testMultipleLocatorsRestartingAtSameTimeWithMissingServers` has been failing since 2 days or so. Is anyone looking at that? On Thu, Feb 7, 2019 at 12:37 PM

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Jens Deppe
No worries. I think I have a better fix now. At least the builds are moving again. On Thu, Feb 7, 2019 at 12:11 PM Kirk Lund wrote: > Sorry, go ahead and revert the commit and reopen the PR. > > On Thu, Feb 7, 2019 at 11:36 AM Jens Deppe wrote: > > > I was still working on a fix... > > > > On

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Kirk Lund
Sorry, go ahead and revert the commit and reopen the PR. On Thu, Feb 7, 2019 at 11:36 AM Jens Deppe wrote: > I was still working on a fix... > > On Thu, Feb 7, 2019 at 11:31 AM Kirk Lund wrote: > > > I merged it in. > > > > On Thu, Feb 7, 2019 at 11:28 AM Kirk Lund wrote: > > > > > I think we

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Jens Deppe
I was still working on a fix... On Thu, Feb 7, 2019 at 11:31 AM Kirk Lund wrote: > I merged it in. > > On Thu, Feb 7, 2019 at 11:28 AM Kirk Lund wrote: > > > I think we should go ahead and merge in > > https://github.com/apache/geode/pull/3172 since it resolves the > > GfshConsoleModeUnitTest

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Kirk Lund
I merged it in. On Thu, Feb 7, 2019 at 11:28 AM Kirk Lund wrote: > I think we should go ahead and merge in > https://github.com/apache/geode/pull/3172 since it resolves the > GfshConsoleModeUnitTest UnitTest failures. > > On Thu, Feb 7, 2019 at 9:57 AM Nabarun Nag wrote: > >> FYI, I have just

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Kirk Lund
I think we should go ahead and merge in https://github.com/apache/geode/pull/3172 since it resolves the GfshConsoleModeUnitTest UnitTest failures. On Thu, Feb 7, 2019 at 9:57 AM Nabarun Nag wrote: > FYI, I have just merged a ci timeout fix to increase the timeout for > geode-benchmarks to 4h.

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Nabarun Nag
FYI, I have just merged a ci timeout fix to increase the timeout for geode-benchmarks to 4h. This does not influence any geode modules. Regards Naba On Thu, Feb 7, 2019 at 9:32 AM Alexander Murmann wrote: > Hi folks, > > Our CI is very red since ~24 hours > < >