Build failed in Jenkins: Geode-release #60

2017-06-09 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-2420: add file-size-limit param to the ExportLogsController -- [...truncated 98.57 KB...] :geode-benchmarks:check :geode-benchmarks:build

[GitHub] geode-native pull request #102: GEODE-2741: Adding a warning for 64bit Windo...

2017-06-09 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/102#discussion_r121248442 --- Diff: src/CMakeLists.txt --- @@ -17,6 +17,15 @@ project(nativeclient) list(APPEND CMAKE_MODULE_PATH

[GitHub] geode pull request #565: GEODE-3021: Any call after the first to setPdxStrin...

2017-06-09 Thread jhuynh1
Github user jhuynh1 closed the pull request at: https://github.com/apache/geode/pull/565 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Review Request 59961: GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME

2017-06-09 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: SecurityService versus Cluster Config

2017-06-09 Thread Swapnil Bawaskar
I think we should revisit connecting to the distributed system with properties. In addition to what Kirk mentioned below, I think one of the big limitation of this is the inability to change properties on a running cluster. If there is a property that a user needs to change, they will have to

[GitHub] geode pull request #572: GEODE-3042: Quick doc of new string-based partition...

2017-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #580 was SUCCESSFUL (with 1868 tests)

2017-06-09 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #580 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-580/ -- This

[GitHub] geode issue #572: GEODE-3042: Quick doc of new string-based partition resolv...

2017-06-09 Thread karensmolermiller
Github user karensmolermiller commented on the issue: https://github.com/apache/geode/pull/572 Thanks Dave and Eric. I've created https://issues.apache.org/jira/browse/GEODE-3063 to address further documentation for this new feature. I'm going to merge this in. --- If your

Re: SecurityService versus Cluster Config

2017-06-09 Thread Kirk Lund
The usage of CacheFactory#setSecurityManager (and setPostProcessor) is working as expected, both before and after my changes! The problem is that Cluster Config is requested during Cache initialization which means that any gemfire.properties stored in Cluster Config will not be used by

[GitHub] geode pull request #572: GEODE-3042: Quick doc of new string-based partition...

2017-06-09 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/572 GEODE-3042: Quick doc of new string-based partition resolver @dschneider-pivotal @davebarnes97 @pivotal-eshu @joeymcallister and all of the Geode community: Please review this PR with

[GitHub] geode-native pull request #102: GEODE-2741: Adding a warning for 64bit Windo...

2017-06-09 Thread mhansonp
GitHub user mhansonp opened a pull request: https://github.com/apache/geode-native/pull/102 GEODE-2741: Adding a warning for 64bit Windows Tools sets - Need to include -Thost=x64 in the configuration step You can merge this pull request into a Git repository by running: $ git

[GitHub] geode pull request #562: GEODE-3025: GET operation before Lucene query

2017-06-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/562 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: SecurityService versus Cluster Config

2017-06-09 Thread John Blum
I am not sure I follow everything that is happening here quite yet as I have not had time to go over this in more detail and digest it. But, I certainly hope that the security-manager property in Geode is not impacted by this in anyway since *Spring Data Geode* builds on this and, well, this

[GitHub] geode issue #562: GEODE-3025: GET operation before Lucene query

2017-06-09 Thread nabarunnag
Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/562 @ladyVader @upthewaterspout @boglesby @gesterzhou -- Adding more potential reviewers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

Re: SecurityService versus Cluster Config

2017-06-09 Thread Kirk Lund
Yeah I think we need #2 in the long run. Right now nearly all of the gemfire.properties are ignored if you use Cluster Config. The few gemfire.properties that are mutable by RuntimeDistributionConfigImpl will work when used in Cluster Config -- I believe all other gemfire.properties would be

Re: SecurityService versus Cluster Config

2017-06-09 Thread Kirk Lund
I've reverted my change on release/1.2.0. I'm currently planning to work on #1 on develop in the short term. On Fri, Jun 9, 2017 at 12:45 PM, Kirk Lund wrote: > The new changes for SecurityService don't work with Cluster Config. We > only had one test that would've failed but

Re: SecurityService versus Cluster Config

2017-06-09 Thread Udo Kohlmeyer
+1 for #2. It does seem more correct On 6/9/17 12:45, Kirk Lund wrote: The new changes for SecurityService don't work with Cluster Config. We only had one test that would've failed but it was annotated with @Ignore. The problem is this: The security-manager is a gemfire property and is now

[GitHub] geode pull request #551: GEODE-2971: consistency in shell exit codes for sta...

2017-06-09 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/551 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #551: GEODE-2971: consistency in shell exit codes for status com...

2017-06-09 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/551 After significant testing redesign, this PR will be closed. The ticket will be resolved after additional `@Rule` resources are added that more accurately represent real `gfsh` usage. --- If

[GitHub] geode pull request #557: add GfshParserRule to facilitate command unit test

2017-06-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/557#discussion_r121198226 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java --- @@ -0,0 +1,51 @@ +/* +

[GitHub] geode pull request #560: Geode 2818: Adding aliases to any command options t...

2017-06-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/560#discussion_r121197448 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java --- @@ -736,7 +736,7 @@ public Result exportData(

Re: git commit message guidelines

2017-06-09 Thread Mark Bretl
Hey Kirk, Found it on the wiki, https://cwiki.apache.org/confluence/display/GEODE/Commit+Message+Format --Mark On Fri, Jun 9, 2017 at 11:10 AM, Kirk Lund wrote: > Do we have our git commit message guidelines saved or posted somewhere? I'm > looking at a PR with a VERY long

[GitHub] geode pull request #565: GEODE-3021: Any call after the first to setPdxStrin...

2017-06-09 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/565#discussion_r121196596 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java --- @@ -2002,7 +2002,8 @@ void

[GitHub] geode pull request #565: GEODE-3021: Any call after the first to setPdxStrin...

2017-06-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/565#discussion_r121195985 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java --- @@ -2002,7 +2002,8 @@ void

git commit message guidelines

2017-06-09 Thread Kirk Lund
Do we have our git commit message guidelines saved or posted somewhere? I'm looking at a PR with a VERY long 1st line.

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

2017-06-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/571#discussion_r121188665 --- Diff: geode-core/src/main/java/org/apache/geode/internal/logging/LogWriterFactory.java --- @@ -87,19 +87,19 @@ public static InternalLogWriter

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

2017-06-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/571#discussion_r121188448 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java --- @@ -478,9 +478,8 @@ private InternalLocator(int port,

Re: Review Request 59946: GEODE-3054: escaping the escape character in the command string before passing it to the SimpleParser

2017-06-09 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59946/#review177495 --- Ship it! Ship It! - Jared Stewart On June 9, 2017, 2:57

Re: Review Request 59946: GEODE-3054: escaping the escape character in the command string before passing it to the SimpleParser

2017-06-09 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59946/#review177494 --- Ship it! Ship It! - Kirk Lund On June 9, 2017, 2:57 p.m.,

Jenkins build is back to normal : Geode-nightly #861

2017-06-09 Thread Apache Jenkins Server
See

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-09 Thread Udo Kohlmeyer
> On June 9, 2017, 1:06 a.m., Galen O'Sullivan wrote: > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java > > Lines 82 (patched) > > > > > > I'm missing the time

Review Request 59946: GEODE-3054: escaping the escape character in the command string before passing it to the SimpleParser

2017-06-09 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59946/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

2017-06-09 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59852/#review177483 --- Ship it! Ship It! - Ken Howe On June 8, 2017, 9:22 p.m.,

RE: Need information about FunctionStatistics

2017-06-09 Thread Dinesh Akhand
Hi Team, Problem Solved , Function Stats works fine if function is associated with JVM . else it will display 0 . Thanks, Dinesh Akhand From: Dinesh Akhand Sent: Friday, June 9, 2017 4:34 PM To: dev@geode.apache.org; 'bogle...@pivotal.io' Subject: RE: Need information

Build failed in Jenkins: Geode-release-flaky #10

2017-06-09 Thread Apache Jenkins Server
See -- [...truncated 88.84 KB...] Download https://repo1.maven.org/maven2/org/springframework/ldap/spring-ldap-core/2.3.1.RELEASE/spring-ldap-core-2.3.1.RELEASE.jar Download

RE: Need information about FunctionStatistics

2017-06-09 Thread Dinesh Akhand
Hi Barry, Yes , I can see the function statics in VSD but looks like All the stats are 0 . not even for single function stats are correct . FunctionExecution, 2265, FunctionServiceStatistics: "2017/06/07 12:11:09.201 IDT" samples=502 functionExecutionsCompleted operations/sec:

Build failed in Jenkins: Geode-release #59

2017-06-09 Thread Apache Jenkins Server
See Changes: [jstewart] GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest [dbarnes] GEODE-3029: Tomcat Install Documentation has incorrect required JARs -- [...truncated