Re: Geode Module Configuration

2017-08-09 Thread Jacob Barrett
Yes there is an extension point on cache. Just follow the lucene as example but put your XML elements inside cache element. Sent from my iPhone > On Aug 9, 2017, at 4:38 PM, Dan Smith wrote: > > There is no global configuration for lucene right now. > > Adding extensions

[GitHub] geode pull request #706: GEODE-3304: when colocated child bucket is destroye...

2017-08-09 Thread gesterzhou
GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/706 GEODE-3304: when colocated child bucket is destroyed, it should not i… @upthewaterspout @boglesby …mpact its parent bucket's creation. Thank you for submitting a

[GitHub] geode pull request #705: GEODE-3111 GatewayReceiver - DEFAULT_MANUAL_START v...

2017-08-09 Thread davebarnes97
GitHub user davebarnes97 opened a pull request: https://github.com/apache/geode/pull/705 GEODE-3111 GatewayReceiver - DEFAULT_MANUAL_START value is ambiguous Updated user guide and javadocs to agree with actual default setting (=false). You can merge this pull request into a Git

Re: Geode Module Configuration

2017-08-09 Thread Dan Smith
There is no global configuration for lucene right now. Adding extensions to the cache.xml *looks* like it should be possible. InternalCache implements Extensible which means that theoretically you should be able to call InternalCache.getExtensionPoint.addExtension(yourXmlParser). That whole

Re: Geode Module Configuration

2017-08-09 Thread Kirk Lund
Not yet. I'd like to introduce org.apache.geode.config package and start ripping out all of the configuration from DistributedSystem and Cache and move them to something (a Configuration class?) that lives in org.apache.geode.config. Would this live in a geode-config module...? I don't think

Geode Module Configuration

2017-08-09 Thread Brian Rowe
Hi all, We are interested in adding some configuration parameters for the new (pre-alpha) client-server protocol that lives in geode-protobuf. We're curious if there is a good way to keep configuration out of geode-core while still allowing users to set it conveniently. It looks like for

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132325049 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -1075,8 +1082,7 @@ private LocatorState

[GitHub] geode pull request #704: GEODE-3300: Complete and expose parallel export fea...

2017-08-09 Thread nreich
GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/704 GEODE-3300: Complete and expose parallel export feature for use This change exposes parallel export of snapshots. It provides a filename mapper for parallel exports that gives each snapshot file a

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #642 was SUCCESSFUL (with 2027 tests)

2017-08-09 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #642 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-642/ -- This

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132326281 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132324608 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132324550 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132323674 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #703: GEODE-3328 Properties to set Key/Trust Store Type f...

2017-08-09 Thread davebarnes97
GitHub user davebarnes97 opened a pull request: https://github.com/apache/geode/pull/703 GEODE-3328 Properties to set Key/Trust Store Type for SSL configurati… …on - add to docs Added documentation for ssl-keystore-type and ssl-truststore-type to the user manual in two

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132322055 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java --- @@ -14,253 +14,370 @@ */ package

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132321751 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132321738 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132321803 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132321846 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/ServerLauncherRemoteIntegrationTestCase.java --- @@ -0,0 +1,270 @@ +/* + * Licensed

[GitHub] geode issue #702: GEODE-3416: Reduce synchronization blockages in SocketClos...

2017-08-09 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/702 @bschuchardt @dschneider-pivotal is on the review of this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132303567 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderWindowsTest.java --- @@ -0,0 +1,97 @@ +/* + *

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132314371 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to the

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132314473 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to the

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132315473 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to the

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132304059 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/BlockingProcessStreamReaderIntegrationTest.java --- @@ -0,0 +1,179 @@ +/* + *

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132314337 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/LauncherIntegrationTestCase.java --- @@ -0,0 +1,505 @@ +/* + * Licensed to the

Re: [DRAFT] Geode Board Report August 2017

2017-08-09 Thread William Markito Oliveira
LGTM On Wed, Aug 9, 2017 at 4:29 PM, Joey McAllister wrote: > Looks good. Thanks, Dan! > > On Wed, Aug 9, 2017 at 2:23 PM Anthony Baker wrote: > > > LGTM > > > > > On Aug 9, 2017, at 2:01 PM, Mark Bretl wrote: > > > > > > Looks

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132307061 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -157,7 +162,7 @@ protected static Properties

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132312668 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java --- @@ -1848,8 +1884,7 @@ public LocatorLauncher build() {

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132312583 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -502,7 +507,7 @@ protected static Integer identifyPid() {

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132311304 --- Diff: geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java --- @@ -228,9 +230,9 @@ private void disconnect() {

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132306579 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java --- @@ -31,7 +31,7 @@ import

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132312206 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/FileProcessControllerIntegrationTest.java --- @@ -0,0 +1,243 @@ +/* + *

Re: [DRAFT] Geode Board Report August 2017

2017-08-09 Thread Joey McAllister
Looks good. Thanks, Dan! On Wed, Aug 9, 2017 at 2:23 PM Anthony Baker wrote: > LGTM > > > On Aug 9, 2017, at 2:01 PM, Mark Bretl wrote: > > > > Looks good to me. Thanks Dan for taking the time to create the draft. > > > > If there are no issues, then I

Re: [DRAFT] Geode Board Report August 2017

2017-08-09 Thread Anthony Baker
LGTM > On Aug 9, 2017, at 2:01 PM, Mark Bretl wrote: > > Looks good to me. Thanks Dan for taking the time to create the draft. > > If there are no issues, then I will post this EOD PST. > > --Mark > > On Mon, Aug 7, 2017 at 2:04 PM, Dan Smith wrote: >

[GitHub] geode issue #702: GEODE-3416: Reduce synchronization blockages in SocketClos...

2017-08-09 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/702 @bschuchardt @galen-pivotal @hiteshk25 @pivotal-amurmann @dschneider-pivotal @WireBaron @kirklund --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

2017-08-09 Thread kohlmu-pivotal
GitHub user kohlmu-pivotal opened a pull request: https://github.com/apache/geode/pull/702 GEODE-3416: Reduce synchronization blockages in SocketCloser. Remove synchronization blocks around HashMap. Replace that implementation with simpler ThreadPool that is not unbounded and

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132308711 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java --- @@ -47,26 +50,21 @@ @Before

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132308040 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java --- @@ -14,253 +14,370 @@ */ package

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132307026 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java --- @@ -14,253 +14,370 @@ */ package

Re: Review Request 61472: GEODE-3097: fix an accidental bug introduced when working on ssl over http

2017-08-09 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61472/#review182530 --- Ship it! Ship It! - Emily Yeh On Aug. 7, 2017, 5:18 p.m.,

Re: Review Request 61409: GEODE-3328: simplify GfshParserRule

2017-08-09 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61409/#review182529 --- Ship it! Ship It! - Emily Yeh On Aug. 3, 2017, 5:12 p.m.,

Re: [DRAFT] Geode Board Report August 2017

2017-08-09 Thread Mark Bretl
Looks good to me. Thanks Dan for taking the time to create the draft. If there are no issues, then I will post this EOD PST. --Mark On Mon, Aug 7, 2017 at 2:04 PM, Dan Smith wrote: > Hi folks, > > Please review the below draft for our report to the board for this past >

Re: Gitbox enables the full GitHub workflow

2017-08-09 Thread Nabarun Nag
+1 will this allow us to choose reviewers while creating PRs on github now? Regards Nabarun On Wed, Aug 9, 2017 at 1:19 PM Udo Kohlmeyer wrote: > +1 > > > On 8/9/17 12:56, Anthony Baker wrote: > > +1 > > > >> On Aug 8, 2017, at 12:46 PM, Mark Bretl

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132299177 --- Diff: geode-core/src/main/java/org/apache/geode/config/internal/ClusterConfigurationNotAvailableException.java --- @@ -0,0 +1,29 @@ +/* + *

[GitHub] geode pull request #701: GEODE-3337: Refactoring LauncherLifecycleCommandsDU...

2017-08-09 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/701 GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3337) `LauncherLifecycleCommandsDUnitTest` was a huge

Review Request 61540: GEODE-3403: Modify rolling upgrade test configuration for 1.2.x release

2017-08-09 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61540/ --- Review request for geode, Alexander Murmann, Galen O'Sullivan, Udo Kohlmeyer,

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132301005 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the

Re: Gitbox enables the full GitHub workflow

2017-08-09 Thread Udo Kohlmeyer
+1 On 8/9/17 12:56, Anthony Baker wrote: +1 On Aug 8, 2017, at 12:46 PM, Mark Bretl wrote: +1 for Gitbox I have been watching threads on INFRA list and been waiting to see when a good time would be to introduce the idea to the community. The Gitbox project has been

Re: Gitbox enables the full GitHub workflow

2017-08-09 Thread Anthony Baker
+1 > On Aug 8, 2017, at 12:46 PM, Mark Bretl wrote: > > +1 for Gitbox > > I have been watching threads on INFRA list and been waiting to see when a > good time would be to introduce the idea to the community. The Gitbox > project has been going since the end of 2016 and

Re: Ability to push to dockerhub

2017-08-09 Thread Anthony Baker
done > On Aug 9, 2017, at 12:40 PM, Jens Deppe wrote: > > Hi, > > I'd like the ability to push to the 'apachegeode' dockerhub repository in > order to publish various docker images used for building Geode. My > dockerhub account is 'jensdeppe'. > > Thanks > --Jens

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132285291 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherTest.java --- @@ -14,253 +14,370 @@ */ package

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread pdxrunner
Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/699#discussion_r132281558 --- Diff: geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTest.java --- @@ -47,26 +50,21 @@ @Before

Re: Review Request 61506: GEODE-3328: refactor ConnectCommand

2017-08-09 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61506/ --- (Updated Aug. 9, 2017, 7:02 p.m.) Review request for geode, Emily Yeh, Jared

[GitHub] geode pull request #700: GEODE-3386 - Make KeyedErrorResponse & ErrorRespons...

2017-08-09 Thread pivotal-amurmann
GitHub user pivotal-amurmann opened a pull request: https://github.com/apache/geode/pull/700 GEODE-3386 - Make KeyedErrorResponse & ErrorResponse siblings Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask

[GitHub] geode pull request #699: GEODE-3413: overhaul launcher and process classes a...

2017-08-09 Thread kirklund
GitHub user kirklund opened a pull request: https://github.com/apache/geode/pull/699 GEODE-3413: overhaul launcher and process classes and tests This is primarily an overall of all ServerLauncher and LocatorLauncher tests and org.apache.geode.internal.process tests. The main

Re: Geode Nightly Build with Docker

2017-08-09 Thread Dan Smith
I don't think this is a port conflict issue. I think this is a matter of what our code does when we are running on an ubuntu machine with the default configuration. Ubuntu puts an entry in /etc/hosts mapping 127.0.1.1 to the local hostname. We saw this yesterday and Bruce was going to create a

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Review Request 61426: GEODE-3277: Fix error path constructors of inner State classes of the Launchers

2017-08-09 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61426/#review182501 ---

Re: Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

2017-08-09 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61487/#review182500 ---

[GitHub] geode pull request #697: GEODE-3407: fix deadlock between JMX and reconnect

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/697 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: continuous query internal mechanism

2017-08-09 Thread Roi Apelker
Dhanyavad -Original Message- From: Anilkumar Gingade [mailto:aging...@pivotal.io] Sent: Tuesday, August 08, 2017 9:55 PM To: dev@geode.apache.org Subject: Re: continuous query internal mechanism Registered events, i meant, are events generated for interest registration

[GitHub] geode issue #664: Fix for GEODE-3292

2017-08-09 Thread jujoramos
Github user jujoramos commented on the issue: https://github.com/apache/geode/pull/664 @jinmeiliao: thanks for reviewing this :-). One more quick question and I'll leave you alone: do I need to change the status of [GEODE-3292](https://issues.apache.org/jira/browse/GEODE-3292) to