[GitHub] geode pull request #648: GEODE-3206 : Corrected order of lucene search resul...

[deepakddixit]

GitHub user deepakddixit opened a pull request:

https://github.com/apache/geode/pull/648

GEODE-3206 : Corrected order of lucene search results based on score.

* Lucene results with higher score value are more relevant than lower once.
  Used descending comparator for lucene search result based on score,
  so most relevant results will be listed first.

* Added test case to verify the changed order.

* Modified expected result from test case, as the order of result is
  changed to match relevancy of result searched.

* Optimized imports with new style file.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/deepakddixit/incubator-geode bugfix/GEODE-3206

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/648.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #648


commit 4e0e921793f535fee9827b6c77ba63194bcc0f66
Author: Deepak Dixit 
Date:   2017-07-18T14:07:36Z

GEODE-3206 : Corrected order of lucene search results based on score.

* Lucene results with higher score value are more relevant than lower once.
  Using descending comparator for lucene search result based on score,
  so most relevant results will be listed first.

* Added test case to verify the changed order.

* Modified expected result from test case, as the order of result is
  changed to match relevancy of result searched.

* Optimized imports with new style file.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is back to normal : Geode-nightly-flaky #70

[Apache Jenkins Server]

See 

Build failed in Jenkins: Geode-nightly #901

[Apache Jenkins Server]

See 


Changes:

[emilyyeh1997] GEODE-2601: Made banner and configs log only once and added a 
test to

[khowe] GEODE-2920: added security tests for create diskstore and create

[khowe] GEODE-2189 Docs: Update Swagger UI links Added link to OpenAPI

[khowe] GEODE-3207 Swagger library updates: update user guide

[khowe] GEODE-3166: use the 3 param getCredential interface.

[khowe] GEODE-2860: Refactor use of EventTracker

[dbarnes] (no ticket) User Guide: Remove nonfunctional archive drop-down from 
page

[ukohlmeyer] GEODE-3141: GetRegion Operation implemented Added

[ukohlmeyer] GEODE-3141: Amended due to review feedback. BasicTypes.Region.type

[ukohlmeyer] GEODE-3141: spotless reformatting

[ukohlmeyer] GEODE-3141: Remove misleading comment. This now closes #630

[upthewaterspout] GEODE-3232: Get a snapshot of maps when serializing 
FilterProfile

--
[...truncated 336.55 KB...]
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:spotlessJavaCheck
:geode-junit:spotlessCheck
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-protobuf:assemble
:geode-protobuf:extractIncludeTestProto
:geode-protobuf:extractTestProto UP-TO-DATE
:geode-protobuf:generateTestProto UP-TO-DATE
:geode-protobuf:compileTestJavaNote: Some input files use unchecked or unsafe 
operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-protobuf:processTestResources
:geode-protobuf:testClasses
:geode-protobuf:checkMissedTests
:geode-protobuf:spotlessJavaCheck
:geode-protobuf:spotlessCheck
:geode-protobuf:test
:geode-protobuf:check
:geode-protobuf:build
:geode-protobuf:distributedTest
:geode-protobuf:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/645


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #647: GEODE-3271: Refactor WanCommands

[YehEmily]

GitHub user YehEmily opened a pull request:

https://github.com/apache/geode/pull/647

GEODE-3271: Refactor WanCommands

[See the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3271)

`WanCommands.java` was a large class that contained multiple commands. Each 
command has been refactored into a separate class, and the methods shared by 
these commands have been refactored into a new and appropriately named class of 
their own. Tests associated with `WanCommands` have been renamed and split up 
into tests with names that relate to the newly separated commands.

- [x] There is a JIRA ticket associated with this PR that is referenced in 
the commit message

- [x] This PR has been rebased against the latest commit within the target 
branch

- [x] The initial contribution is a single, squashed commit

- [x] `gradlew build` runs cleanly

- [x] Unit tests have been updated to verify changes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/YehEmily/geode GEODE-3271

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #647


commit 6dd031d13473d500181342ba35f203caf1b8edbc
Author: YehEmily 
Date:   2017-07-19T20:16:03Z

GEODE-3271: Separating WanCommands into multiple command classes

commit f9a7242f3a4250ad157cfba5a20ff5e9b8b4a688
Author: YehEmily 
Date:   2017-07-19T20:16:03Z

GEODE-3271: Separating WanCommands into multiple command classes

commit 0728ccebb4538b7934bf73d7c9ab4aca832ede6d
Author: YehEmily 
Date:   2017-07-19T22:22:02Z

Merge branch 'GEODE-3271' of github.com:YehEmily/geode into GEODE-3271

commit 4c9873e46150264c2fb92b64926c603130460c47
Author: YehEmily 
Date:   2017-07-19T22:41:22Z

Adding tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #621 was SUCCESSFUL (with 1979 tests). Change made by John Blum.

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #621 was successful.
---
Scheduled with changes by John Blum.
1981 tests in total.

https://build.spring.io/browse/SGF-NAG-621/




--
Code Changes
--
John Blum (c10c9ddfe3d889418a16ffafcd2c159ebd8ba2eb):

>DATAGEODE-20 - Upgrade to Apache Geode 1.2.0.

John Blum (e016c6fc4bf02890ddca3b5f42651ab201db330b):

>DATAGEODE-13 - Test @EnablePool annotation properties configuration.

John Blum (346b458580377989776d4698b79dff31923de51e):

>DATAGEODE-13 - Add additional tests for all Annotation config application 
>properties.



--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode issue #404: Geode 2469

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/404
  
At this point this PR is a bit out of date. To merge, all of the .class, 
.pdf, .fig, etc. files would need to be removed, the merge fix done and 
whatever other cleanup is necessary. It also looks like there may be a 
concurrency bug, so that should be tested and fixed if necessary. And whatever 
other fixes are necessary. It's not a trivial amount of work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #646: GEODE-3213: Refactor ProtoBuf handler flow

[pivotal-amurmann]

Github user pivotal-amurmann commented on the issue:

https://github.com/apache/geode/pull/646
  
@kohlmu-pivotal @WireBaron @hiteshk25 @galen-pivotal @bschuchardt 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/645#discussion_r128376504
  
--- Diff: 
geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARQAddOperationJUnitTest.java
 ---
@@ -287,12 +289,11 @@ public void testNoExpiryOnThreadIdentifier() {
   eventsMap.get(threadId));
 
   // wait for some more time to allow expiry on data
--- End diff --

Should probably remove this comment about waiting for some time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

[ladyVader]

GitHub user ladyVader opened a pull request:

https://github.com/apache/geode/pull/645

GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts

* Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to 
checking expiration

@upthewaterspout @nabarunnag

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3113

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/645.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #645


commit f286244a864e3eb61bbb586b678d39e0227bd574
Author: Lynn Hughes-Godfrey 
Date:   2017-07-18T20:48:24Z

GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts

* Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to 
checking expiration




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60985/#review180980
---


Ship it!




Ship It!

- Jinmei Liao


On July 19, 2017, 9:06 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60985/
> ---
> 
> (Updated July 19, 2017, 9:06 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3217: Reimplement gfsh query as a single-step command
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
>  3f4397b3d025ee5453a6df338eed41589ff339c0 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryInterceptor.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
>  fe88fc98d397fa748f8f54b900b1511eb114c0b6 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
>  41cc171dbabee2cf51a9e28d051b8365a3c44699 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
>  8ab7c9342ebd5370deba45a35dbf68201f2b7333 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DataCommandsController.java
>  fb6318449e027c94ba4fd2fa87c84f8181ce61a4 
>   
> geode-core/src/test/java/org/apache/geode/management/DataCommandMBeanTest.java
>  e5d6ce8d5bfb35eb503c66c9650fde2a33a51315 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/result/ResultBuilderTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60985/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin passed (except for some flaky failures that appear to be unrelated)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60985/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3217: Reimplement gfsh query as a single-step command


Diffs
-

  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
 3f4397b3d025ee5453a6df338eed41589ff339c0 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryInterceptor.java
 PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 fe88fc98d397fa748f8f54b900b1511eb114c0b6 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
 41cc171dbabee2cf51a9e28d051b8365a3c44699 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
 8ab7c9342ebd5370deba45a35dbf68201f2b7333 
  
geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DataCommandsController.java
 fb6318449e027c94ba4fd2fa87c84f8181ce61a4 
  
geode-core/src/test/java/org/apache/geode/management/DataCommandMBeanTest.java 
e5d6ce8d5bfb35eb503c66c9650fde2a33a51315 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/result/ResultBuilderTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60985/diff/1/


Testing
---

Precheckin passed (except for some flaky failures that appear to be unrelated)


Thanks,

Jared Stewart

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60974/#review180975
---


Ship it!




Ship It!

- Jared Stewart


On July 19, 2017, 7:37 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60974/
> ---
> 
> (Updated July 19, 2017, 7:37 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * do not log to file by default, only when withLogInFile is called
> * do not create a workingDir and sets the user.dir by default, only when 
> withWorkingDir is called
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  045e13edc798f2bd3460dc17bbfeec28ac5022e4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  0b012c9569236e2d368d88b14bf506ac9bd5d8be 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
>  a78b26fb560c17c96b794ecedc09e10c87766ef0 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  33439e6063150b87938f21f13e647d3b0ecc4896 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
>  d98641849eed458b4c830e1fa198f4d986b0c4ce 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
>  510a4e7fef1aff5a1aa8f00f569cd6422b7816ab 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
>  a8b498ddbecb9d8733ed4f98c1c80cb18da5c37e 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
>  066f8828f64b7caa9c9748683f9214868105fed8 
>   
> geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
>  e90bc0a69222998322e02fcfad1b6bad3c97f4d1 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  b977b50e28b8d518fd3d9da6c03b55f8b7cbff34 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  62ae2e223f019c78000ff7492510c24aba9c930c 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
>  7dada04cc63aaa2668e103524bd63d3c58310257 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
>  688af782b8a7e6d12aca38694f9df05ac8a1bef7 
> 
> 
> Diff: https://reviews.apache.org/r/60974/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

[YehEmily]

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/598#discussion_r128363171
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/OptionAliasesIntegrationTest.java
 ---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
--- End diff --

I think you're right - this test does seem to do just the same things 
OptionAliasParserTest does. I'll get rid of this test and update the PR - 
thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

[YehEmily]

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/598#discussion_r128362946
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
 ---
@@ -26,6 +26,8 @@
 import java.util.function.Predicate;
 import java.util.stream.Collectors;
 
+import javax.mail.Folder;
--- End diff --

Nope! I'll delete it and update the PR - thanks again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

[YehEmily]

Github user YehEmily commented on a diff in the pull request:

https://github.com/apache/geode/pull/598#discussion_r128362904
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
 ---
@@ -14,6 +14,8 @@
  */
 package org.apache.geode.management.internal.cli.commands;
 
+import java.util.concurrent.TimeUnit;
--- End diff --

Nope! I'll delete it and update the PR - thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

[kirklund]

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/598#discussion_r128354422
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java
 ---
@@ -26,6 +26,8 @@
 import java.util.function.Predicate;
 import java.util.stream.Collectors;
 
+import javax.mail.Folder;
--- End diff --

Is this import used? It looks like just the import was added so it's 
probably unused. Delete it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

[jinmeiliao]

Github user jinmeiliao commented on a diff in the pull request:

https://github.com/apache/geode/pull/598#discussion_r128354651
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/OptionAliasesIntegrationTest.java
 ---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for 
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
+ * or implied. See the License for the specific language governing 
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
--- End diff --

these tests simply checks the exit code for each command, and not checking 
if the server really belongs to these groups. I am wondering do we really need 
such a long running tests to test the command options. I would think that 
OptionAliasParserTest would be sufficient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

[kirklund]

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/598#discussion_r128354400
  
--- Diff: 
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
 ---
@@ -14,6 +14,8 @@
  */
 package org.apache.geode.management.internal.cli.commands;
 
+import java.util.concurrent.TimeUnit;
--- End diff --

Is this import used? It looks like just the import was added so it's 
probably unused. Delete it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60974/
---

(Updated July 19, 2017, 7:37 p.m.)


Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

* do not log to file by default, only when withLogInFile is called
* do not create a workingDir and sets the user.dir by default, only when 
withWorkingDir is called


Diffs (updated)
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
 045e13edc798f2bd3460dc17bbfeec28ac5022e4 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
 0b012c9569236e2d368d88b14bf506ac9bd5d8be 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
 a78b26fb560c17c96b794ecedc09e10c87766ef0 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
 33439e6063150b87938f21f13e647d3b0ecc4896 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
 d98641849eed458b4c830e1fa198f4d986b0c4ce 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
 510a4e7fef1aff5a1aa8f00f569cd6422b7816ab 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
 a8b498ddbecb9d8733ed4f98c1c80cb18da5c37e 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
 066f8828f64b7caa9c9748683f9214868105fed8 
  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 e90bc0a69222998322e02fcfad1b6bad3c97f4d1 
  
geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
 b977b50e28b8d518fd3d9da6c03b55f8b7cbff34 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 62ae2e223f019c78000ff7492510c24aba9c930c 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
 5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
 7dada04cc63aaa2668e103524bd63d3c58310257 
  
geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
 688af782b8a7e6d12aca38694f9df05ac8a1bef7 


Diff: https://reviews.apache.org/r/60974/diff/2/

Changes: https://reviews.apache.org/r/60974/diff/1-2/


Testing
---


Thanks,

Jinmei Liao

Re: Review Request 60977: GEODE-3251: make JMX test rules more robust

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60977/#review180959
---


Ship it!




Ship It!

- Ken Howe


On July 19, 2017, 5:14 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60977/
> ---
> 
> (Updated July 19, 2017, 5:14 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3251
> https://issues.apache.org/jira/browse/GEODE-3251
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3251: make JMX test rules more robust
> 
> Add "Failed to retrieve RMIServer stub" to rule await
> to help ensure that JMX RMI is ready before running
> the test.
> 
> Also removed Soft assertions from DiskStoreMXBeanSecurityJUnitTest.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
>  4d101e7862dd45bbf4faaec84cb4f808cfd26cf3 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  872553efed290890708caaf98dc206b4735005d0 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MBeanServerConnectionRule.java
>  3addc4e2ff07d36a340ed548e4c9a2d7f6094390 
> 
> 
> Diff: https://reviews.apache.org/r/60977/diff/1/
> 
> 
> Testing
> ---
> 
> DiskStoreMXBeanSecurityJUnitTest
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

[davebarnes97]

Github user davebarnes97 commented on a diff in the pull request:

https://github.com/apache/geode/pull/644#discussion_r128331252
  
--- Diff: geode-docs/tools_modules/gfsh/configuring_gfsh.html.md.erb ---
@@ -24,13 +24,13 @@ The `gfsh.bat` and `gfsh` bash script automatically 
append the required Apache G
 
 ## JAR Libraries in CLASSPATH
 
-When you start up `gfsh`, it will automatically load required JAR files 
that have been packaged in the `gfsh-dependencies.jar` file. You do not need to 
modify your CLASSPATH to run gfsh. When starting servers and locators in gfsh, 
the start server and start locator commands will load `server-dependencies.jar` 
and `locator-dependencies.jar` files into the process CLASSPATH for you.
+When you start up `gfsh`, it will automatically load required JAR files 
that have been packaged in the `gfsh-dependencies.jar` file. You do not need to 
modify your CLASSPATH to run `gfsh`.
 
-These dependency JAR files are packaged in your Apache Geode installation 
in the `$GEMFIRE/lib` (or on Windows, the `%GEODE_HOME%\lib`) directory.
+The JAR files are packaged within your installation directory in the `lib` 
directory.
 
 ## Machine Hostname
 
-On some operating systems, you may need to ensure that the hostname of 
your machine is configured in your system hosts file. For example, on Mac OSX 
you may need to map your machine's hostname to your IP address in the 
`/etc/hosts` file in order for `gfsh` and Pulse to operate correctly.
+On some operating systems, you may need to ensure that the host name of 
your machine is configured in your system hosts file. For example, on Mac OSX 
you may need to map your machine's host name to your IP address in the 
`/etc/hosts` file in order for `gfsh` and Pulse to operate correctly.
--- End diff --

LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #590: GEODE-3090: Fixing gfsh help message (and a lot of other t...

[jinmeiliao]

Github user jinmeiliao commented on the issue:

https://github.com/apache/geode/pull/590
  
pulling this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

[joeymcallister]

Github user joeymcallister commented on a diff in the pull request:

https://github.com/apache/geode/pull/644#discussion_r128320777
  
--- Diff: geode-docs/tools_modules/gfsh/configuring_gfsh.html.md.erb ---
@@ -24,13 +24,13 @@ The `gfsh.bat` and `gfsh` bash script automatically 
append the required Apache G
 
 ## JAR Libraries in CLASSPATH
 
-When you start up `gfsh`, it will automatically load required JAR files 
that have been packaged in the `gfsh-dependencies.jar` file. You do not need to 
modify your CLASSPATH to run gfsh. When starting servers and locators in gfsh, 
the start server and start locator commands will load `server-dependencies.jar` 
and `locator-dependencies.jar` files into the process CLASSPATH for you.
+When you start up `gfsh`, it will automatically load required JAR files 
that have been packaged in the `gfsh-dependencies.jar` file. You do not need to 
modify your CLASSPATH to run `gfsh`.
 
-These dependency JAR files are packaged in your Apache Geode installation 
in the `$GEMFIRE/lib` (or on Windows, the `%GEODE_HOME%\lib`) directory.
+The JAR files are packaged within your installation directory in the `lib` 
directory.
 
 ## Machine Hostname
 
-On some operating systems, you may need to ensure that the hostname of 
your machine is configured in your system hosts file. For example, on Mac OSX 
you may need to map your machine's hostname to your IP address in the 
`/etc/hosts` file in order for `gfsh` and Pulse to operate correctly.
+On some operating systems, you may need to ensure that the host name of 
your machine is configured in your system hosts file. For example, on Mac OSX 
you may need to map your machine's host name to your IP address in the 
`/etc/hosts` file in order for `gfsh` and Pulse to operate correctly.
--- End diff --

Isn't "hostname" correct here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #557: add GfshParserRule to facilitate command unit test

[jinmeiliao]

Github user jinmeiliao closed the pull request at:

https://github.com/apache/geode/pull/557


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #604: GEODE-2919: fix lucene security tests

[jinmeiliao]

Github user jinmeiliao closed the pull request at:

https://github.com/apache/geode/pull/604


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/644

GEODE-3208 Revise docs with outdated JAR references

@joeymcallister @davebarnes97 @kirklund Please review.

Note: While making modifications to satisfy GEODE-3208, I took the liberty 
of injecting newlines and changing file names to remove the need for horizontal 
scroll bars in the resulting html, modified IP addresses (to use a 
"documentation IP address"), and removed a duplicated portion of an example.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3208

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #644


commit b7f757017d1c0ac7d6622afab2350d6844d889bc
Author: Karen Miller 
Date:   2017-07-19T17:28:17Z

GEODE-3208 Revise docs with outdated JAR references




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode-examples pull request #11: GEODE-3233 Prefix distribution files with a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode-examples/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #592: GEODE-2707: Removing TXLockToken

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/592


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 60977: GEODE-3251: make JMX test rules more robust

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60977/#review180950
---


Ship it!




Ship It!

- Jared Stewart


On July 19, 2017, 5:14 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60977/
> ---
> 
> (Updated July 19, 2017, 5:14 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3251
> https://issues.apache.org/jira/browse/GEODE-3251
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3251: make JMX test rules more robust
> 
> Add "Failed to retrieve RMIServer stub" to rule await
> to help ensure that JMX RMI is ready before running
> the test.
> 
> Also removed Soft assertions from DiskStoreMXBeanSecurityJUnitTest.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
>  4d101e7862dd45bbf4faaec84cb4f808cfd26cf3 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  872553efed290890708caaf98dc206b4735005d0 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MBeanServerConnectionRule.java
>  3addc4e2ff07d36a340ed548e4c9a2d7f6094390 
> 
> 
> Diff: https://reviews.apache.org/r/60977/diff/1/
> 
> 
> Testing
> ---
> 
> DiskStoreMXBeanSecurityJUnitTest
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Re: RMIServer stub failures

[Kirk Lund]

It's a bit of a hack but I submitted https://reviews.apache.org/r/60977/

Something in the JMX RMI startup seems to be asynchronous, so our JMX junit
rules "await" this startup before letting the test start. I added a check
for "Failed to retrieve RMIServer stub" to this await step.

If anyone has further ideas, please send them my way...

On Wed, Jul 19, 2017 at 10:01 AM, Kirk Lund  wrote:

> Any ideas what to do with RMIServer stub failures in tests? This seems to
> be something going wrong in the JDK code that's outside of our control.
> Moving these JMX tests to FlakyTest category will have no effect. We'll
> simply have all JMX tests in FlakyTest instead of IntegrationTest. I can't
> see a way to "fix" it unless the community wants to use RetryRule on these
> tests. We would have to apply it to every single JMX test.
>
> :geode-core:integrationTest
>
> org.apache.geode.management.internal.security.
> DiskStoreMXBeanSecurityJUnitTest > testNoAccess FAILED
> java.io.IOException: Failed to retrieve RMIServer stub: 
> javax.naming.ServiceUnavailableException
> [Root exception is java.rmi.ConnectException: Connection refused to host:
> 10.254.0.238; nested exception is:
> java.net.ConnectException: Connection refused (Connection refused)]
>
> Caused by:
> javax.naming.ServiceUnavailableException [Root exception is
> java.rmi.ConnectException: Connection refused to host: 10.254.0.238; nested
> exception is:
> java.net.ConnectException: Connection refused (Connection
> refused)]
>
> Caused by:
> java.rmi.ConnectException: Connection refused to host:
> 10.254.0.238; nested exception is:
> java.net.ConnectException: Connection refused (Connection
> refused)
>
> Caused by:
> java.net.ConnectException: Connection refused (Connection
> refused)
>
> 3598 tests completed, 1 failed, 163 skipped
> :geode-core:integrationTest FAILED
>

Re: Review Request 60977: GEODE-3251: make JMX test rules more robust

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60977/#review180949
---


Ship it!




Ship It!

- Jinmei Liao


On July 19, 2017, 5:14 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60977/
> ---
> 
> (Updated July 19, 2017, 5:14 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, 
> and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-3251
> https://issues.apache.org/jira/browse/GEODE-3251
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-3251: make JMX test rules more robust
> 
> Add "Failed to retrieve RMIServer stub" to rule await
> to help ensure that JMX RMI is ready before running
> the test.
> 
> Also removed Soft assertions from DiskStoreMXBeanSecurityJUnitTest.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
>  4d101e7862dd45bbf4faaec84cb4f808cfd26cf3 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  872553efed290890708caaf98dc206b4735005d0 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MBeanServerConnectionRule.java
>  3addc4e2ff07d36a340ed548e4c9a2d7f6094390 
> 
> 
> Diff: https://reviews.apache.org/r/60977/diff/1/
> 
> 
> Testing
> ---
> 
> DiskStoreMXBeanSecurityJUnitTest
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>

Review Request 60977: GEODE-3251: make JMX test rules more robust

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60977/
---

Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, and 
Patrick Rhomberg.


Bugs: GEODE-3251
https://issues.apache.org/jira/browse/GEODE-3251


Repository: geode


Description
---

GEODE-3251: make JMX test rules more robust

Add "Failed to retrieve RMIServer stub" to rule await
to help ensure that JMX RMI is ready before running
the test.

Also removed Soft assertions from DiskStoreMXBeanSecurityJUnitTest.


Diffs
-

  
geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
 4d101e7862dd45bbf4faaec84cb4f808cfd26cf3 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 872553efed290890708caaf98dc206b4735005d0 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/MBeanServerConnectionRule.java
 3addc4e2ff07d36a340ed548e4c9a2d7f6094390 


Diff: https://reviews.apache.org/r/60977/diff/1/


Testing
---

DiskStoreMXBeanSecurityJUnitTest
precheckin in progress


Thanks,

Kirk Lund

RMIServer stub failures

[Kirk Lund]

Any ideas what to do with RMIServer stub failures in tests? This seems to
be something going wrong in the JDK code that's outside of our control.
Moving these JMX tests to FlakyTest category will have no effect. We'll
simply have all JMX tests in FlakyTest instead of IntegrationTest. I can't
see a way to "fix" it unless the community wants to use RetryRule on these
tests. We would have to apply it to every single JMX test.

:geode-core:integrationTest

org.apache.geode.management.internal.security.DiskStoreMXBeanSecurityJUnitTest
> testNoAccess FAILED
java.io.IOException: Failed to retrieve RMIServer stub:
javax.naming.ServiceUnavailableException [Root exception is
java.rmi.ConnectException: Connection refused to host: 10.254.0.238; nested
exception is:
java.net.ConnectException: Connection refused (Connection refused)]

Caused by:
javax.naming.ServiceUnavailableException [Root exception is
java.rmi.ConnectException: Connection refused to host: 10.254.0.238; nested
exception is:
java.net.ConnectException: Connection refused (Connection refused)]

Caused by:
java.rmi.ConnectException: Connection refused to host:
10.254.0.238; nested exception is:
java.net.ConnectException: Connection refused (Connection
refused)

Caused by:
java.net.ConnectException: Connection refused (Connection
refused)

3598 tests completed, 1 failed, 163 skipped
:geode-core:integrationTest FAILED

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

[Jinmei Liao]

> On July 19, 2017, 4:49 p.m., Jared Stewart wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
> > Line 92 (original), 96 (patched)
> > 
> >
> > I think that having two differently-named public methods (rather than 
> > one method with a boolean flag) might express the intent of the tests 
> > calling this method more clearly.
> > 
> > Basically I'm thinking something like: 
> > ```
> > public MemberVM startLocatorVMWithLogInFile(int index, 
> > Properties properties) { 
> > startLocatorVM(index, properties, true);
> > }
> > 
> >  private MemberVM startLocatorVM(int index, Properties 
> > properties, boolean withLogInFile)
> > ``` 
> > 
> > The three-arg variant could still be around under the hood as a private 
> > method, but the tests would read like:
> > ```
> > startLocatorVMWithLogInFile(0, props) 
> > ``` 
> > 
> > rather than
> > ```
> > startLocatorVM(0,props,true)
> > ```

good idea, I will do that. I hate adding more flag in the parameter list.


- Jinmei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60974/#review180943
---


On July 19, 2017, 4:06 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60974/
> ---
> 
> (Updated July 19, 2017, 4:06 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * do not log to file by default, only when withLogInFile is called
> * do not create a workingDir and sets the user.dir by default, only when 
> withWorkingDir is called
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  045e13edc798f2bd3460dc17bbfeec28ac5022e4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  0b012c9569236e2d368d88b14bf506ac9bd5d8be 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
>  a78b26fb560c17c96b794ecedc09e10c87766ef0 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  33439e6063150b87938f21f13e647d3b0ecc4896 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
>  d98641849eed458b4c830e1fa198f4d986b0c4ce 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
>  510a4e7fef1aff5a1aa8f00f569cd6422b7816ab 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
>  a8b498ddbecb9d8733ed4f98c1c80cb18da5c37e 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
>  066f8828f64b7caa9c9748683f9214868105fed8 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java
>  e3fe173e7d00686df5bf3b9e3212f3dca4c161c7 
>   
> geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
>  e90bc0a69222998322e02fcfad1b6bad3c97f4d1 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  b977b50e28b8d518fd3d9da6c03b55f8b7cbff34 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  62ae2e223f019c78000ff7492510c24aba9c930c 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
>  7dada04cc63aaa2668e103524bd63d3c58310257 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
>  688af782b8a7e6d12aca38694f9df05ac8a1bef7 
> 
> 
> Diff: https://reviews.apache.org/r/60974/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60974/#review180943
---




geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
Line 92 (original), 96 (patched)


I think that having two differently-named public methods (rather than one 
method with a boolean flag) might express the intent of the tests calling this 
method more clearly.

Basically I'm thinking something like: 
```
public MemberVM startLocatorVMWithLogInFile(int index, Properties 
properties) { 
startLocatorVM(index, properties, true);
}

 private MemberVM startLocatorVM(int index, Properties properties, 
boolean withLogInFile)
``` 

The three-arg variant could still be around under the hood as a private 
method, but the tests would read like:
```
startLocatorVMWithLogInFile(0, props) 
``` 

rather than
```
startLocatorVM(0,props,true)
```


- Jared Stewart


On July 19, 2017, 4:06 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60974/
> ---
> 
> (Updated July 19, 2017, 4:06 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * do not log to file by default, only when withLogInFile is called
> * do not create a workingDir and sets the user.dir by default, only when 
> withWorkingDir is called
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  045e13edc798f2bd3460dc17bbfeec28ac5022e4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  0b012c9569236e2d368d88b14bf506ac9bd5d8be 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
>  a78b26fb560c17c96b794ecedc09e10c87766ef0 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  33439e6063150b87938f21f13e647d3b0ecc4896 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
>  d98641849eed458b4c830e1fa198f4d986b0c4ce 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
>  510a4e7fef1aff5a1aa8f00f569cd6422b7816ab 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
>  a8b498ddbecb9d8733ed4f98c1c80cb18da5c37e 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
>  066f8828f64b7caa9c9748683f9214868105fed8 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java
>  e3fe173e7d00686df5bf3b9e3212f3dca4c161c7 
>   
> geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
>  e90bc0a69222998322e02fcfad1b6bad3c97f4d1 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  b977b50e28b8d518fd3d9da6c03b55f8b7cbff34 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  62ae2e223f019c78000ff7492510c24aba9c930c 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
>  7dada04cc63aaa2668e103524bd63d3c58310257 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
>  688af782b8a7e6d12aca38694f9df05ac8a1bef7 
> 
> 
> Diff: https://reviews.apache.org/r/60974/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60924: GEODE-2920: added security tests for create diskstore and create persistent region.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60924/#review180938
---


Ship it!




+1

- Kirk Lund


On July 17, 2017, 9:39 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60924/
> ---
> 
> (Updated July 17, 2017, 9:39 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2920: handle non-existent role in ExampleSecurityManager
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java
>  c1d7ebfa017ccc627e7d4da6db951d3f61e2461b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
>  c2be173f8844bcf25361edc9e5d428f62aa8761f 
>   
> geode-core/src/test/java/org/apache/geode/security/ExampleSecurityManagerTest.java
>  9093a7bc70835ae50c72a80739a3f8ab4789cacd 
>   
> geode-core/src/test/resources/org/apache/geode/security/templates/security.json
>  c1ee9fc22bad58642d814c5930eb2d02810dad0e 
> 
> 
> Diff: https://reviews.apache.org/r/60924/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60974/#review180937
---


Ship it!




+1

- Kirk Lund


On July 19, 2017, 4:06 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60974/
> ---
> 
> (Updated July 19, 2017, 4:06 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
> Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> * do not log to file by default, only when withLogInFile is called
> * do not create a workingDir and sets the user.dir by default, only when 
> withWorkingDir is called
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
>  045e13edc798f2bd3460dc17bbfeec28ac5022e4 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
>  0b012c9569236e2d368d88b14bf506ac9bd5d8be 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
>  a78b26fb560c17c96b794ecedc09e10c87766ef0 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
>  33439e6063150b87938f21f13e647d3b0ecc4896 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
>  d98641849eed458b4c830e1fa198f4d986b0c4ce 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
>  510a4e7fef1aff5a1aa8f00f569cd6422b7816ab 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
>  a8b498ddbecb9d8733ed4f98c1c80cb18da5c37e 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
>  066f8828f64b7caa9c9748683f9214868105fed8 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java
>  e3fe173e7d00686df5bf3b9e3212f3dca4c161c7 
>   
> geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
>  e90bc0a69222998322e02fcfad1b6bad3c97f4d1 
>   
> geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
>  b977b50e28b8d518fd3d9da6c03b55f8b7cbff34 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  62ae2e223f019c78000ff7492510c24aba9c930c 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
>  5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
>  7dada04cc63aaa2668e103524bd63d3c58310257 
>   
> geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
>  688af782b8a7e6d12aca38694f9df05ac8a1bef7 
> 
> 
> Diff: https://reviews.apache.org/r/60974/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60974/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

* do not log to file by default, only when withLogInFile is called
* do not create a workingDir and sets the user.dir by default, only when 
withWorkingDir is called


Diffs
-

  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
 045e13edc798f2bd3460dc17bbfeec28ac5022e4 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsIntegrationTest.java
 0b012c9569236e2d368d88b14bf506ac9bd5d8be 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsOnServerManagerDUnit.java
 a78b26fb560c17c96b794ecedc09e10c87766ef0 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsStatsDUnitTest.java
 33439e6063150b87938f21f13e647d3b0ecc4896 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
 d98641849eed458b4c830e1fa198f4d986b0c4ce 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionTest.java
 510a4e7fef1aff5a1aa8f00f569cd6422b7816ab 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogExporterIntegrationTest.java
 a8b498ddbecb9d8733ed4f98c1c80cb18da5c37e 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
 066f8828f64b7caa9c9748683f9214868105fed8 
  
geode-core/src/test/java/org/apache/geode/management/internal/security/MultiUserDUnitTest.java
 e3fe173e7d00686df5bf3b9e3212f3dca4c161c7 
  
geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
 e90bc0a69222998322e02fcfad1b6bad3c97f4d1 
  
geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java
 b977b50e28b8d518fd3d9da6c03b55f8b7cbff34 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 62ae2e223f019c78000ff7492510c24aba9c930c 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java
 5b4f2c14545847d9a3fcfc501fdd9ff1e19771ba 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/test/MemberStarterRuleTest.java
 7dada04cc63aaa2668e103524bd63d3c58310257 
  
geode-web/src/test/java/org/apache/geode/management/internal/security/LogNoPasswordTest.java
 688af782b8a7e6d12aca38694f9df05ac8a1bef7 


Diff: https://reviews.apache.org/r/60974/diff/1/


Testing
---


Thanks,

Jinmei Liao

Re: Stored procedures on Apache Geode.

[John Blum]

Hi Marios-

Regarding...

*> Do you think this indeed will have a huge impact on the performance?*

There are many factors that affect performance.  A few things to consider
might be...

1. How well you planned and organized the data (e.g. partitioning strategy,
possible collocation).
2. How large are the data entries.
3. What type of queries you may be performing (which might be an important
factor in collocation, with the ability to run queries local to the node).
4. What data management policies are in effect (e.g. eviction, expiration).
5. What the logic in your SPs are doing and how effectively they can be
parallelized.
6. etc.

*> Is there any best practises for doing this or any demo you could provide
demonstrating this process?(SP to geode/gemfire functions)*

I know of customers who have migrated or are migrating from a RDBMS to an
IMDG like Geode/GemFire, but I do not know the results of their work.  I am
in R and not regularly exposed to that type of information.  Others on
this list might have better information for you.

Regards,
John


On Tue, Jul 18, 2017 at 10:59 PM, marios390 <
marios.sofocle...@creditsafe.com> wrote:

> Hi John,
>
> As mentioned the other day, we are interested in lift all the stored
> procedures up into the
> cluster.Do you think this indeed will have a huge impact on the
> performance? Is there any best practises for doing this or any demo you
> could provide demonstrating this process?(SP to geode/gemfire functions)
> I would really appreciate it if you could provide any material related to
> this.
>
> Thanks
> Marios
> 
> From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> ml+s70738n24351...@n6.nabble.com]
> Sent: Friday, July 14, 2017 6:35 PM
> To: Marios Sofocleous/IT/CREDITSAFE
> Subject: Re: Stored procedures on Apache Geode.
>
> Hi Marios-
>
> I may not be the best person to answer this.  There is a Pivotal GemFire /
> Greenplum Connector available for download here...
>
> https://network.pivotal.io/products/pivotal-gemfire/#/
> releases/5376/file_groups/495 smbkFovlp6IgDkajN0nKt4CrX58E5K46E5Gas7UCAFodHRwOi8vc2Nhbm1ha
> WwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9MS1UbzJSR211OUx2TE
> NHdk1HTXFNMXliTUZtU0xZV293d2dsYWNUMHJBJnU9aHR0cHMlM2ElMmYlMm
> ZuZXR3b3JrJTJlcGl2b3RhbCUyZWlvJTJmcHJvZHVjdHMlMmZwaXZvdGFsLW
> dlbWZpcmUlMmYlMjMlMmZyZWxlYXNlcyUyZjUzNzYlMmZmaWxlJTVmZ3JvdXBzJTJmNDk1>
>
> More information on the Connector can be found here...
>
> http://ggc.docs.pivotal.io/ggc/relnotes/release_notes30.html
>  7o1EZnK4vhJL646E5Gas7UCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9MS1UbzJSR211OUx2TENHdk1HTXFNMXliTUZtU0xZV293d3dq
> T0pPbHJnJnU9aHR0cCUzYSUyZiUyZmdnYyUyZWRvY3MlMmVwaXZvdGFsJTJl
> aW8lMmZnZ2MlMmZyZWxub3RlcyUyZnJlbGVhc2UlNWZub3RlczMwJTJlaHRtbA..>
>
> As you may know, Apache Geode is the open source core of Pivotal GemFire (
> https://pivotal.io/pivotal-gemfire avpjDplcz8GhyxNakFqKyxR0D7vFnF2EyHNgs3HhSye46E5Gas7UCAFodHRw
> Oi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9MS1UbzJSR211OUx2TE
> NHdk1HTXFNMXliTUZtU0xZV293d3R4Yk1DZ3JnJnU9aHR0cHMlM2ElMmYlMm
> ZwaXZvdGFsJTJlaW8lMmZwaXZvdGFsLWdlbWZpcmU.>).  Theoretically, it probably
> would/should work to connect Geode with Greenplum, though I have not done
> this and I am not sure it is a combination Pivotal nor the Apache Geode
> community supports.
>
> There is example of using this Connector with Geode here...
>
> https://github.com/mgoddard-pivotal/FraudDetection-wwko mhVyYn6hNXwW9OLdPgBcsVH6ty0EvvNRtbL2w9DhzRm46E5Gas7UCAFodHRw
> Oi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_Yz03NDIyJmQ9MS1UbzJSR211OUx2TE
> NHdk1HTXFNMXliTUZtU0xZV293dzBxUHBDa19nJnU9aHR0cHMlM2ElMmYlMm
> ZnaXRodWIlMmVjb20lMmZtZ29kZGFyZC1waXZvdGFsJTJmRnJhdWREZXRlY3
> Rpb24td3drbw..>
>
> Which was the basis for this presentation/article...
>
> https://content.pivotal.io/blog/big-data-meets-fast-data-
> to-fight-fraud-and-more FcCwMktO46E5Gas7UCAFodHRwOi8vc2Nhbm1haWwudHJ1c3R3YXZlLmNvbS8_
> Yz03NDIyJmQ9MS1UbzJSR211OUx2TENHdk1HTXFNMXliTUZtU0xZV293MXNt
> T2NEem9nJnU9aHR0cHMlM2ElMmYlMmZjb250ZW50JTJlcGl2b3RhbCUyZWlv
> JTJmYmxvZyUyZmJpZy1kYXRhLW1lZXRzLWZhc3QtZGF0YS10by1maWdodC1m
> cmF1ZC1hbmQtbW9yZQ..>
>
> -j
>
>
>
> On Thu, Jul 13, 2017 at 11:33 PM, marios390 <
> [hidden email]> wrote:
>
> > Hi John,
> >
> > Just a quick one,
> > Geode could be integrated with green plum and if not what alternatives
> for
> > this.
> >
> > Thanks
> > Ms
> > 
> > From: John Blum [via Apache Geode (Incubating) Developers Forum] [
> > [hidden email]]
> > Sent: Thursday, July 13, 2017 11:33 PM
> > To: Marios Sofocleous/IT/CREDITSAFE
> > Subject: Re: Stored procedures on Apache Geode.
> >
> > Hi Marios-
> >
> > It seems you and your team could be / mostly are likely dealing with a
> > high-volume of sensitive information, but without knowing a 

RE: Geode-Native Windows build

[Daniel Farcovich]

Hi Jacob,
I can confirm that build passed on VS2017 using generator "Visual Studio 15 
2017 Win64".

Thanks,
Daniel

-Original Message-
From: Jacob Barrett [mailto:jbarr...@pivotal.io] 
Sent: Thursday, July 13, 2017 4:20 PM
To: dev@geode.apache.org
Subject: Re: Geode-Native Windows build

Yup! It should match the the minimum requirements mentioned at the very least. 
It should also compile fine under 2017 though I don't believe anyone has yet.

Sent from my iPhone

> On Jul 13, 2017, at 6:08 AM, Daniel Farcovich  
> wrote:
> 
> From BUILDING.md:
> 
> Windows Generator
> 
> The recommended generator on Windows is Visual Studio 12 2013 Win64:
> 
> $ cmake -G "Visual Studio 12 2013 Win64" ../src
> 
> 
> Should we change that?
> 
> Daniel
> 
> -Original Message-
> From: Jacob Barrett [mailto:jbarr...@pivotal.io]
> Sent: Thursday, July 13, 2017 3:06 PM
> To: dev@geode.apache.org
> Subject: Re: Geode-Native Windows build
> 
> VS 2013 is not fully C++11 compliant. The minimum compiler on windows is VS 
> 2015.
> 
> Sent from my iPhone
> 
>> On Jul 13, 2017, at 4:32 AM, Daniel Farcovich  
>> wrote:
>> 
>> As I mentioned in the first email I receive compilation errors, for example:
>> 31>C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\include\geode/utils.hpp(57):
>>  error C2144: syntax error : 'bool' should be preceded by ';' 
>> (C:\Users\Fdaniel\Source\Repos\geode-native2\src\cppcache\src\FunctionServiceImpl.
>> 
>> The root cause of this error is in the use of "constexpr" in utils.hpp and 
>> build in VS2013.
>> There are features of c++11 which are not implemented in various VS versions.
>> Here is a table with the unsupported features, where constexpr is one of 
>> them:
>> https://msdn.microsoft.com/en-us/library/hh567368.aspx#featurelist
>> 
>> I assume the rest of the errors are of the same reason.
>> 
>> Although boost has already macros to workaround constexpr (BOOST_CONSTEXPR), 
>> my suggestion is to add a macro to geode_base.hpp for removing constexpr 
>> when it's not supported:
>> #ifdef _WIN32
>> #if _MSC_VER > 1800 //VS2015 and higher #define GF_CONSTEXPR 
>> constexpr #else #define GF_CONSTEXPR #endif #else #define 
>> GF_CONSTEXPR constexpr #endif
>> 
>> Daniel
>> 
>> -Original Message-
>> From: Daniel Farcovich
>> Sent: Thursday, July 13, 2017 10:07 AM
>> To: 'dev@geode.apache.org' 
>> Subject: RE: Geode-Native Windows build
>> 
>> Hi Jake and Ernest,
>> 
>> I tried to build from c:\build
>> Here is the config command and output:
>> 
>> c:\build>cmake  -DCMAKE_INSTALL_PREFIX=C:\build\out -G "Visual Studio
>> 12 2013 Win64" -Thost=x64
>> C:\Users\Fdaniel\Source\Repos\geode-native2\src
>> -- The C compiler identification is MSVC 18.0.21005.1
>> -- The CXX compiler identification is MSVC 18.0.21005.1
>> -- Check for working C compiler: C:/Program Files (x86)/Microsoft 
>> Visual Studio 12.0/VC/bin/amd64/cl.exe
>> -- Check for working C compiler: C:/Program Files (x86)/Microsoft 
>> Visual Studio 12.0/VC/bin/amd64/cl.exe -- works
>> -- Detecting C compiler ABI info
>> -- Detecting C compiler ABI info - done
>> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft 
>> Visual Studio 12.0/VC/bin/amd64/cl.exe
>> -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft 
>> Visual Studio 12.0/VC/bin/amd64/cl.exe -- works
>> -- Detecting CXX compiler ABI info
>> -- Detecting CXX compiler ABI info - done
>> -- Detecting CXX compile features
>> -- Detecting CXX compile features - done
>> -- Performing Test CFLAGS_M64_ALLOWED
>> -- Performing Test CFLAGS_M64_ALLOWED - Failed
>> -- Performing Test CXXFLAGS_M64_ALLOWED
>> -- Performing Test CXXFLAGS_M64_ALLOWED - Failed
>> -- Performing Test CFLAGS_mt_ALLOWED
>> -- Performing Test CFLAGS_mt_ALLOWED - Failed
>> -- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found 
>> suitable version "1.8.0.74", minimum required is "1.8.0.60") found
>> components:  Development
>> -- Found Geode: 
>> C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apac
>> h e-geode\bin\gfsh.bat (found suitable version "1.1.1", minimum 
>> required is "1.0")
>> -- Found Doxygen: C:/Program Files/doxygen/bin/doxygen.exe (found 
>> suitable version "1.8.13", minimum required is "1.6")
>> -- Found Git: C:/Program Files/Git/cmd/git.exe (found suitable 
>> version "2.10.2.windows.1", minimum required is "1.7")
>> -- Looking for include files sys/param.h, sys/mount.h
>> -- Looking for include files sys/param.h, sys/mount.h - not found
>> -- Looking for SIGSTKFLT
>> -- Looking for SIGSTKFLT - not found
>> -- Looking for SIGPWR
>> -- Looking for SIGPWR - not found
>> -- Found Geode: 
>> C:\Users\Fdaniel\Source\Repos\geode\geode-assembly\build\install\apac
>> h e-geode\bin\gfsh.bat (found version "1.1.1")
>> -- Found Java: C:/Program Files/Java/jdk1.8.0_74/bin/java.exe (found 
>> version "1.8.0.74")
>> -- Found Doxygen: C:/Program