Re: [DISCUSS] Criteria for PMC, committers

One concern I have about not bundling committer and PMC membership is that there is not much incentive to nominate someone to become a PMC member. When someone is an active contributor but not a committer it's visible in the fact that they have to ask others to merge their PRs, which also provides

Re: what is the best way to update a geode pull request

+1 for doing whatever facilitates reviewing and is best for the PR (which may vary by PR or even reviewers) -1 to disallowing or even strongly discouraging force pushing in a PR (go ahead and merge or rebase as each person prefers but don't force that preference on others) I prefer to separate cle

Re: [DISCUSS] require reviews before merging a PR

I'm -1 for requiring N reviews before merging a commit. Overall, I support Lazy Consensus. If I post a PR that fixes the flakiness in a test, the precheckin jobs prove it, and it sits there for 2 weeks without reviews, then I favor merging it in at that point without any reviews. I'm not going to

Re: [DISCUSS] Disable merge for failing pull requests

I’m still not interested until there is a solution for all community members to retrigger failed jobs. Also not excited about not having a way to override if there is a known issue that prevents a job from going green. My last PR needed multiple reruns because of a known flakey test with an acti

Re: [DISCUSS] Disable merge for failing pull requests

I’d like to follow up on this discussion from late last year. Six months ago, Kirk wrote: > After we get it more consistently GREEN, I would be willing to change my vote > to +1. While we’re still not perfect, I have noticed that PR checks go green much more consistently now than they did six

Re: [DISCUSS] Criteria for PMC, committers

I think in any point of view we are looking at Committer or PMC membership, it does come down to merit. Does the person have the merit, which can also be trust, to be a Committer and/or PMC member? The difference between Committer and PMC member is not simply being 'gatekeepers' of the codebase, P

Re: Static Analysis Tools such as SonarQube or others?

I used SonarQube on a project it helped the team where to focus on next. The reports that it generates are extremely useful to help see how the code progresses over time across the many dimensions. On Tue, Jun 4, 2019 at 12:46 PM Mark Bretl wrote: > I have used SonarQube for many years, includ

Re: [PROPOSAL] Add hostname-for-clients to ConfigurationProperties

Thanks for the feedback. Both Dan and Juan pointed out how the hostname-for-clients are configured for each individual components currently: server/locator/gateway receivers are from gfsh commands options and jmx are from gemfire properties. Let me revise my original proposal to: Let's add a globa

Re: [PROPOSAL] Add hostname-for-clients to ConfigurationProperties

Hello Jinmei, Applying this change will prevent users from using different NICs for different types of traffic, meaning that the same server won't be able to listen for JMX connections on *NIC1* and regular client-server connections on *NIC2*, right?. If my assumption is correct then we'd be remov

Re: [PROPOSAL] Add hostname-for-clients to ConfigurationProperties

A user can configure the hostname-for-clients for locators and gateway receivers - they are part of the respective gfsh commands. Are you suggesting deprecating those settings as well, or just having a global property that is the default value if it is not overridden for a specific locator, cache-s

Re: Static Analysis Tools such as SonarQube or others?

I have used SonarQube for many years, including integrating for the Geode codebase in the past and using it now my current day job, and like it a lot. The ASF hosts a server at https://builds.apache.org/analysis/, however, the version is quite old and does not have features such as Quality Gating o

[PROPOSAL] Add hostname-for-clients to ConfigurationProperties

We have "jmx-manager-hostname-for-clients" in the geode properties, we think it would be a good idea to deprecate that and use "hostname-for-clients" for the entire server. Currently we already need this property when launching a locator and start a gateway-receiver, and we have no way to pre-confi

Re: Static Analysis Tools such as SonarQube or others?

We're currently running PMD as part of the gradle build. PMD is just running a couple of rules specifically to look for mutable statics. We've also enabled integration with lgtm to get a report - https://lgtm.com/projects/g/apache/geode/. I think added m

Re: Is the documentation wrong here?

@liyuj Congratulations on finding a Geode doc bug. To get the problem on the official "to do" list, you are hereby encouraged to open a JIRA ticket in the Geode project, citing the 'docs' component. Your original email with Jared's response would serve well as the bug description. If you'd like to

Re: Is the documentation wrong here?

Yes, I believe the docs there are out of date and need to be updated. This change in the naming of deployed jars was introduced in Geode 1.2 by https://github.com/apache/geode/pull/429. On Tue, Jun 4, 2019 at 7:27 AM liyuj <18624049...@163.com> wrote: > Hi, > > > https://geode.apache.org/docs/gu

Is the documentation wrong here?

Hi, https://geode.apache.org/docs/guide/19/configuring/cluster_config/deploying_application_jars.html This document has such a paragraph: Versioning of JAR Files When you deploy JAR files to a cluster or member group, the JAR file is modified to indicate version information in its name. E

Static Analysis Tools such as SonarQube or others?

Hi all, Has anyone had experience using static analysis tools such as SonarQube? Were there helpful? And favourites that worked well? Thanks