Review Request 56244: GEODE-2410 : afterPrimary and afterSecondary event listeners pass through the same critical section code

2017-02-02 Thread nabarun nag
--- * Lucene precheck successfull * Hydra failures are imminent - work ongoing on EOF + rebalance exceptions Thanks, nabarun nag

Re: Review Request 56244: GEODE-2410 : afterPrimary and afterSecondary event listeners pass through the same critical section code

2017-02-02 Thread nabarun nag
://reviews.apache.org/r/56244/diff/ Testing (updated) --- * Lucene precheck successfull * work ongoing on EOF + rebalance exceptions Thanks, nabarun nag

Re: Review Request 56244: GEODE-2410 : afterPrimary and afterSecondary event listeners pass through the same critical section code

2017-02-02 Thread nabarun nag
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56244/#review164038 ----------- On Feb. 2, 2017, 10:32 p.m., nabarun nag wrote: > > --

Re: Review Request 56244: GEODE-2410 : afterPrimary and afterSecondary event listeners pass through the same critical section code

2017-02-02 Thread nabarun nag
/IndexRepositorySpy.java d3b1f2f Diff: https://reviews.apache.org/r/56244/diff/ Testing --- * Lucene precheck successfull * Hydra failures are imminent - work ongoing on EOF + rebalance exceptions Thanks, nabarun nag

Re: Review Request 56355: GEODE-2314: EOF file segment exceptions due to empty file

2017-02-06 Thread nabarun nag
[planning to put a function to decrement the stats in case of exception] - nabarun nag On Feb. 6, 2017, 11:47 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 56355: GEODE-2314: EOF file segment exceptions due to empty file

2017-02-06 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56355/#review164442 --- Ship it! Ship It! - nabarun nag On Feb. 7, 2017, 12:49 a.m

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-27 Thread nabarun nag
e have a lot of buckets and we write a test to keep moving buckets or changing the primary/secondary status very fast. - nabarun nag On Jan. 27, 2017, 7:05 a.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 55956: GEODE-2367: Lucene indexes do not handle ha scenarios

2017-01-27 Thread nabarun nag
/internal/LucenePrimaryBucketListener.java (line 57) <https://reviews.apache.org/r/55956/#comment234725> We should now change the name of the file from to LucenePrimaryBucketListener to just LuceneBucketListener as this now also handles the event of becoming secondary - nabarun nag On J

Re: Review Request 56088: GEODE-2367: ResultCollector was not being cleared on bucket not found exception

2017-01-30 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56088/#review163536 --- Ship it! Ship It! - nabarun nag On Jan. 30, 2017, 5:44 p.m

Re: Review Request 56034: GEODE-2372: Displaying the stacktrace while printing the exception message in handleException

2017-01-27 Thread nabarun nag
) - geode-core/src/main/java/org/apache/geode/cache/client/internal/OpExecutorImpl.java 54f8e39 Diff: https://reviews.apache.org/r/56034/diff/ Testing --- Thanks, nabarun nag

Review Request 56034: GEODE-2372: Displaying the stacktrace while printing the exception message in handleException

2017-01-27 Thread nabarun nag
/cache/client/internal/OpExecutorImpl.java 54f8e39 Diff: https://reviews.apache.org/r/56034/diff/ Testing --- Thanks, nabarun nag

Re: Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

2017-02-23 Thread nabarun nag
che.org/r/57001/diff/ Testing --- spotlessApply geode-lucene:prechecin Thanks, nabarun nag

Review Request 57001: Added Dunit tests for to test out Lucene pagination in persistent PR

2017-02-23 Thread nabarun nag
Thanks, nabarun nag

Re: Review Request 56933: Attempt to refactor the Lucene DUnit tests

2017-02-22 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56933/#review166392 --- Ship it! Ship It! - nabarun nag On Feb. 22, 2017, 5:09 p.m

Re: Review Request 56933: Attempt to refactor the Lucene DUnit tests

2017-02-22 Thread nabarun nag
/LuceneDUnitTest.java (line 70) <https://reviews.apache.org/r/56933/#comment238318> If ACCESSOR_PARTITION and PARTITION_PROXY have the same effect we can remove one of them as they both zero local max memory. - nabarun nag On Feb. 22, 2017, 5:09 p.m., Jason Huynh

Re: Review Request 56936: Change LuceneFunction exception thrown type and rename to LuceneQueryFunction

2017-02-22 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56936/#review166441 --- Ship it! Ship It! - nabarun nag On Feb. 22, 2017, 11:06 p.m

Re: Review Request 56557: GEODE-2459 When node fails while renaming, new primary node resumes and may delete chunks

2017-02-10 Thread nabarun nag
e-name. Then immediately after sometime, it is hitting this deleteFile call when it is not recovering from a crash during a rename. - is it suppose to delete the chunks then? will the file.possiblyRename still remain true. - nabarun nag On Feb. 10, 2017, 7:42 p.m., Jason Huynh

Re: Review Request 56557: GEODE-2459 When node fails while renaming, new primary node resumes and may delete chunks

2017-02-10 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56557/#review165167 --- Ship it! Ship It! - nabarun nag On Feb. 10, 2017, 7:42 p.m

Re: Review Request 56769: Fix some races in to IndexRepository creation

2017-02-16 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56769/#review165883 --- Ship it! Ship It! - nabarun nag On Feb. 16, 2017, 9:17 p.m

Re: Review Request 56719: GEODE-2491: Reduce logging of handled exceptions in LuceneEventListener and LuceneBucketListeners

2017-02-15 Thread nabarun nag
/internal/LuceneBucketListener.java (line 58) <https://reviews.apache.org/r/56719/#comment237623> Hi Jason, I am not sure but should we have an identical catch block for afterPrimary too?? - nabarun nag On Feb. 15, 2017, 8:54 p.m., Jason Huynh

Re: Review Request 56719: GEODE-2491: Reduce logging of handled exceptions in LuceneEventListener and LuceneBucketListeners

2017-02-15 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56719/#review165766 --- Ship it! Ship It! - nabarun nag On Feb. 15, 2017, 8:54 p.m

Re: Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-17 Thread nabarun nag
stener was invoked, resulting in a bucket not found exception. To avoid exceptions during rebalancing we are giving the system another chance to create the Index repo. - nabarun nag On Jan. 17, 2017, 10:09 p.m., nabarun nag

Re: Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-17 Thread nabarun nag
y buckets are moved around. Thanks, nabarun nag

Re: Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-17 Thread nabarun nag
restarting it and checking the stats are correct. 3. Running gfsh command to create two servers and shutting / restarting them alternatively and checking if the stats remain correct after the primary buckets are moved around. Thanks, nabarun nag

Review Request 57229: getCache method implemented for LuceneServiceImpl

2017-03-01 Thread nabarun nag
/57229/diff/1/ Testing --- SpotlessApply geode-lucene:precheckin Thanks, nabarun nag

Re: Review Request 57057: GEODE-2538: Don't invoke a cache loader when fetching values for a lucene query

2017-02-27 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57057/#review166949 --- Ship it! Ship It! - nabarun nag On Feb. 25, 2017, 1:05 a.m

Re: Review Request 57057: GEODE-2538: Don't invoke a cache loader when fetching values for a lucene query

2017-02-27 Thread nabarun nag
/internal/results/LuceneGetPageFunctionTest.java (line 39) <https://reviews.apache.org/r/57057/#comment239042> Should the class name end with JUnitTest - nabarun nag On Feb. 25, 2017, 1:05 a.m., Dan Smith

Re: Review Request 53917: GEODE-2123 Replace static members in ParallelgatewaySenderQueues with instance variables

2016-11-18 Thread nabarun nag
--- Thanks, nabarun nag

Re: Review Request 54713: GEODE-105: Adding a test for creating an index with null map values

2016-12-13 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54713/#review159039 --- Ship it! Ship It! - nabarun nag On Dec. 13, 2016, 6:41 p.m

Review Request 55440: GEODE-1733: Index repository is now created when the chunk bucket becomes primary.

2017-01-11 Thread nabarun nag
restarting it and checking the stats are correct. 3. Running gfsh command to create two servers and shutting / restarting them alternatively and checking if the stats remain correct after the primary buckets are moved around. Thanks, nabarun nag

Re: New Committer And PMC Member: Ernest Burghardt

2017-03-24 Thread Nabarun Nag
Congrats and welcome !!! :) On Fri, Mar 24, 2017 at 3:41 PM Bruce Schuchardt wrote: > Welcome to the group Ernie! > > Le 3/24/2017 à 3:03 PM, Anthony Baker a écrit : > > The Apache Geode Project Management Committee has invited Ernest > > Burghardt to be committer on the

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-21 Thread nabarun nag
d of prototype solution. We wanted to make sure if we are in the right path before changing the RAW index module - nabarun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/585

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-19 Thread nabarun nag
/LuceneEventListenerJUnitTest.java 79de29a09 geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java 8e4c179a5 Diff: https://reviews.apache.org/r/58550/diff/1/ Testing --- Thanks, nabarun nag

[DISCUSS] Feature branch cleanup

2017-08-02 Thread Nabarun Nag
Hi I was wondering if we should clean up the feature branches related to closed or resolved GEODE tickets in the origin repository. Below are the listed tickets and associated branch. Regards Nabarun Nag Branch Name Ticket Status Committers [merged to develop] origin/feature/GEODE-11 GEODE

Re: [VOTE] Apache Geode release - v1.2.0 RC2

2017-07-13 Thread Nabarun Nag
build -Dskip.test= true" on the source files. Regards Nabarun Nag > On Jul 12, 2017, at 7:58 AM, Anthony Baker <aba...@pivotal.io> wrote: > > This is the second release candidate for Apache Geode, version 1.2.0. > Thanks to all the community members for their contributions to t

Apache Nightly build machine disk space usage

2017-07-03 Thread Nabarun Nag
Hello all, Build 54 has a failed test where the machine has reached 92% disk usage *Failed Test:* testStartServerAndExecuteCommands –

Re: 2 unit tests fail in geode-core

2017-08-01 Thread Nabarun Nag
Hi Anton, I was able to reproduce the issue if I shut down my wifi and remove my ethernet cable from my Mac [no network connections active / on]. Once wifi is switched on or ethernet is connected to the machine the tests pass. Regards Nabarun Nag > On Aug 1, 2017, at 7:48 AM, Anton Mirone

Re: Gitbox enables the full GitHub workflow

2017-08-09 Thread Nabarun Nag
+1 will this allow us to choose reviewers while creating PRs on github now? Regards Nabarun On Wed, Aug 9, 2017 at 1:19 PM Udo Kohlmeyer wrote: > +1 > > > On 8/9/17 12:56, Anthony Baker wrote: > > +1 > > > >> On Aug 8, 2017, at 12:46 PM, Mark Bretl

Request to blacklist H2 on Apache Nightly Builds

2017-08-07 Thread Nabarun Nag
Hi We need to blacklist H2 machine from running the Apache Nightly builds for Apache Geode project. Please can someone with the necessary permission do it. Regards Nabarun Nag

Re: Gitbox enables the full GitHub workflow

2017-08-22 Thread Nabarun Nag
+1 On Tue, Aug 22, 2017 at 11:15 AM Kirk Lund wrote: > +1 to move all our repos to gitbox > > On Tue, Aug 22, 2017 at 11:08 AM, Jacob Barrett > wrote: > > > +1 > > > > Sent from my iPhone > > > > > On Aug 22, 2017, at 10:49 AM, Jared Stewart

Re: GMSMembershipManagerJUnitTest failing consistently in precheckin

2017-05-09 Thread Nabarun Nag
We suspect that it is because of usage of static InternalDistributedSystem getAnyInstance() which gets it a LonerDistributionManager created by some other test. We have created a JIRA ticket [GEODE-2896] for it and have a fix for it. Regards Naba On Tue, May 9, 2017 at 9:00 AM Jinmei Liao

Re: [VOTE] Using Pull Requests over Review Board

2017-06-12 Thread Nabarun Nag
+1 On using PR. I feel using github PR is more convenient because of the following reasons a. Commit messages are automatically made into the header and description in PR, whereas in reviewboard, you upload the patch and do all the writing - manually. It feels redundant. b. After changing the

Re: [DISCUSS] Using Pull Requests over Review Board

2017-06-08 Thread Nabarun Nag
+1 on using PR. We can use the @tags and the github notification page[Participating tag] to check the PRs that need our attention. Also, IMHO feature branches from which the PRs are created should be in our personal fork rather than the main geode git repo. Because when we push a branch called

Re: [DISCUSS] Addition of isValid API to Index interface

2017-09-20 Thread Nabarun Nag
The PR #768 has been created for this issue and also GEODE-3520 has been changed to reflect this requirement. Regards Nabarun On Thu, Sep 14, 2017 at 5:29 PM Nabarun Nag <n...@apache.org> wrote: > Thanks you guys for the review. I will revert the GEODE-3520 ticket to > reflect tha

Re: [DISCUSS] Addition of isValid API to Index interface

2017-09-20 Thread Nabarun Nag
the index instead, and log a warning message to that > effect? This will free up the memory used by the index and will proactively > let the admin/user know what happened. > > On Wed, Sep 20, 2017 at 9:59 AM Nabarun Nag <n...@apache.org> wrote: > > > The PR #768 has been create

Re: [DISCUSS] Addition of isValid API to Index interface

2017-09-14 Thread Nabarun Nag
Thanks you guys for the review. I will revert the GEODE-3520 ticket to reflect that invalidate should happen for both synchronous and asynchronous index maintenance. Also, I will resend the PR which reflects the changes mentioned in the ticket Regards Nabarun Nag On Thu, Sep 14, 2017 at 5:55

Re: [DISCUSS] Addition of isValid API to Index interface

2017-09-08 Thread Nabarun Nag
Engineer, GemFire Product Manager > Mobile: +1-631-835-4771 <(631)%20835-4771> > > On Fri, Sep 8, 2017 at 12:34 PM, Dan Smith <dsm...@pivotal.io> wrote: > > > +1 > > > > -Dan > > > > On Thu, Sep 7, 2017 at 9:14 PM, Nabarun Nag <n...@apa

Re: Missing Gitbox activation email

2017-09-07 Thread Nabarun Nag
.org/setup/. You should also change the URL of > your > >>> origin from Apache to GitHub. You will also notice we have full control > >>> over pull requests, including assignments and labeling. Good times > ahead. > >>> > >>>> On Wed, Sep 6,

Re: Missing Gitbox activation email

2017-09-06 Thread Nabarun Nag
*I think the email takes some time to arrive."An organisational invite will be sent to you via email shortly thereafter (within 30 minutes)."* On Wed, Sep 6, 2017 at 4:21 PM Dan Smith wrote: > If you are stuck on 3rd step (MFA Status) make you have added your github >

[DISCUSS] Addition of isValid API to Index interface

2017-09-07 Thread Nabarun Nag
use an exception while loading the entry into the index. Regards Nabarun Nag

Re: [DISCUSS] Clean build takes 10minutes to complete now

2017-09-12 Thread Nabarun Nag
As we are working on fixing this issue, some extra parameters may help the build to get bit quicker on your machine. using -xjavadoc -xdoc Eg: ./gradlew clean build -Dskip.tests=true -xjavadoc -xdocs BUILD SUCCESSFUL Total time: 2 mins 2.729 secs Also, I think as Jason mentioned that the slow

Re: DSFIDNotFoundException: Unknown DataSerializableFixedID: -158

2017-10-18 Thread Nabarun Nag
GEODE-3841 was opened to address this issue. Also complete logs of tests that ran before and after the failed test were also added in the comment section of the JIRA On Wed, Oct 18, 2017 at 10:10 AM Kirk Lund wrote: > Here's a log snippet with the failure -- looks like there's

Re: [DISCUSS] Maximum duration that a class may contain a @Flaky

2017-11-03 Thread Nabarun Nag
I think majority of the flaky test tags were put in one shot in one commit. So the timer will expire on all tests in one shot. Also we have stopped marking things flaky, if something fails in CI, we immediately try to fix it. If there is a flakiness element in the test, the test is immediately

Re: Default branch for geode should be 'develop'

2017-12-11 Thread Nabarun Nag
+1 On Mon, Dec 11, 2017 at 3:10 PM Bruce Schuchardt wrote: > +1 > > > On 12/11/17 1:40 PM, Jens Deppe wrote: > > Currently, github has the default branch for apache/geode set to > 'master'. > > (which is why you need to point the relevant branch to 'develop' for > every

Re: [Proposal]: behavior change when region doesn't exist in cluster configuration

2018-04-27 Thread Nabarun Nag
With the new implementation, will it allow two different regions with the same exact name to exist in the cluster ? I meant like server A had a cache.xml with region “test” with different properties as to the cache.xml in server B for region “test”. And the locator had an empty cluster config.

Re: Quarterly report - DRAFT for your review

2018-05-08 Thread Nabarun Nag
LGTM Regards Naba On Tue, May 8, 2018 at 10:44 AM Joey McAllister wrote: > Looks good to me, too. Thanks, Dave! > > On Tue, May 8, 2018 at 10:41 AM Mark Bretl wrote: > > > Looks good! Thanks Dave! > > > > --Mark > > > > On Tue, May 8, 2018 at 10:13

[DISCUSS] Request to setup test pipelines for Apache Geode 1.7.0 release

2018-05-21 Thread Nabarun Nag
Hi Geode Community, As we have created a release branch for Apache Geode 1.7.0 , we request CI test pipeline to be established for the branch - "release/1.7.0" in order to prepare for the release. Regards Nabarun Nag

Re: [DISCUSS] Request to setup test pipelines for Apache Geode 1.7.0 release

2018-05-22 Thread Nabarun Nag
Sorry about that. release/1.7.0 branch has been created for Apache geode-examples repo Regards Nabarun Nag On Tue, May 22, 2018 at 11:26 AM Anthony Baker <aba...@pivotal.io> wrote: > Sure thing Naba. We still need a release branch for geode-examples though. > > Anthony > >

Fixed version as 1.8

2018-05-24 Thread Nabarun Nag
Hi Geode Community, If you are committing any fix to the Apache Geode develop branch only, please mark the the fixed version as 1.8 in the respective JIRA ticket Regards Nabarun Nag

Re: Next release 1.7.0

2018-05-18 Thread Nabarun Nag
Hi Barbara, I volunteer to be the release manager for Apache Geode 1.7.0. Regards Naba [image: giphy.gif] On Fri, May 18, 2018 at 9:02 AM Barbara Pruijn wrote: > Hi all, > > Nice work on getting the 1.6.0 release out the door! Next up is 1.7.0. > We’ve finished around 200

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-05-23 Thread Nabarun Nag
s of commits for GEODE-5071 and > > >> GEODE-5242 really > > >> belong in Geode 1.7. They just missed making it in before the release > > >> branch was cut. I'm going to > > >> cherry pick them into the 1.7 release branch. If anyone disagrees > wit

[DISCUSS] Apache Geode 1.7.0 release branch created

2018-05-21 Thread Nabarun Nag
Hello Geode dev community, We have created a release branch for Apache Geode 1.7.0 - "release/1.7.0" Please do review and raise any issue with the release branch. If no concerns are raised we will start with voting for release candidate within a week. Regards Nabarun Nag

Re: [PROPOSAL] Add mod and arithmetic functionality to OQL

2018-02-06 Thread Nabarun Nag
+1 [Apache ID] On Tue, Feb 6, 2018 at 3:40 PM Nabarun Nag <n...@pivotal.io> wrote: > +1 > On Tue, Feb 6, 2018 at 12:12 PM Kirk Lund <kl...@apache.org> wrote: > >> +1 for adding these ops to OQL >> >> On Tue, Feb 6, 2018 at 11:45 AM, Anilkumar Gingade <

Re: [PROPOSAL] Add mod and arithmetic functionality to OQL

2018-02-06 Thread Nabarun Nag
+1 On Tue, Feb 6, 2018 at 12:12 PM Kirk Lund wrote: > +1 for adding these ops to OQL > > On Tue, Feb 6, 2018 at 11:45 AM, Anilkumar Gingade > wrote: > > > +1 like the idea... > > > > On Tue, Feb 6, 2018 at 10:22 AM, Jason Huynh wrote: >

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-21 Thread Nabarun Nag
Yeah , I can continue with the release manager tasks. My understanding from Dan's email is that every JIRA that was closed as 1.8 needs to be changed to 1.7 after we rebase develop over release/1.7 branch. Regards Nabarun Nag On Tue, Aug 21, 2018 at 11:57 AM Dan Smith wrote: > +1 to updat

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-21 Thread Nabarun Nag
I will wait for a day to give all developers sometime to commit any new fixes into develop that is needed in 1.7.0. Please do let me know if there is any concern. Regards Nabarun Nag On Tue, Aug 21, 2018 at 12:42 PM Nabarun Nag wrote: > Yeah , I can continue with the release manager tasks.

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-24 Thread Nabarun Nag
I will be rebasing the release branch with develop, to bring in all the improvements/ enhancements that went in in the past few months. I am waiting on the tickets mentioned in this thread to be closed to start on a fresh release branch. Regards Nabarun Nag On Fri, Aug 24, 2018 at 12:20 PM

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Nabarun Nag
I completely agree. Once the branch is created, it will undergo all compatibility and upgrade tests. The commit that you have mentioned will be reverted in 1.7.0, as well as any related commits Regards Nabarun Nag On Mon, Aug 27, 2018 at 1:34 PM Bruce Schuchardt wrote: > I don't think i

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Nabarun Nag
I am about to change the fixed version in GEODE JIRAs to 1.7.0 for those tickets which are marked closed or resolved with 1.8.0 as the fix version. Please do let me know if there are any concerns. The new release branch has not been created yet. Regards Nabarun Nag On Mon, Aug 27, 2018 at 10:17

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Nabarun Nag
270 GEODE-5269 GEODE-5267 GEODE-5265 GEODE-5255 GEODE-5249 GEODE-5237 GEODE-5223 GEODE-5220 GEODE-5186 GEODE-5157 GEODE-4965 GEODE-4791 GEODE-4726 GEODE-4614 GEODE-4593 GEODE-4336 GEODE-3530 GEODE-3505 GEODE-1866 GEODE-1357 On Mon, Aug 27, 2018 at 12:11 PM Nabarun Nag wrote: > @Bruce those c

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-27 Thread Nabarun Nag
@Bruce those changes were done when 1.7.0 release process was in-progress, and a release branch was already created. But we stopped that process mid way. This happened in May 2018. We are planning to rebase the 1.7.0 brach with the current develop pretty soon. Regards Nabarun On Mon, Aug 27, 2018

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-28 Thread Nabarun Nag
Hi Juan, GEODE-5618 as PR#2360 has been merged in to develop. The new branch has not yet been created hence this fix will be in 1.7.0 Regards Nabarun Nag On Tue, Aug 28, 2018 at 12:33 AM Juan José Ramos wrote: > Hello team, > > Can we also include GEODE-5618 in the next release?.

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-31 Thread Nabarun Nag
d delete windows jobs from the > branch > > before we create the pipeline for 1.7. > > > > Apologies for holding up the release. > > > > Sai. > > > > On Fri, Aug 31, 2018, 10:23 AM Nabarun Nag wrote: > > > > > I am waiting on the documentation

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-31 Thread Nabarun Nag
mmen] GEODE-5254 - [Dale Emery] GEODE-4794 - [Sai] GEODE-5594 - [Sai] Regards Nabarun Nag On Fri, Aug 31, 2018 at 3:18 PM Nabarun Nag wrote: > > Please continue using 1.7.0 as a fix version in JIRA till the email comes > in that the 1.7.0 release branch has be cut. > > Changin

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-31 Thread Nabarun Nag
Regards Nabarun Nag On Fri, Aug 31, 2018 at 2:20 PM Nabarun Nag wrote: > A new feature of get/set cluster config was added as new feature to gfsh. > This needs to be added to the documentation. > Once this is done, the branch will be ready. > > Regards > Nabarun > > > On F

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-31 Thread Nabarun Nag
Announcement : The branch for 1.7.0 has been cut. Please from this point onwards use 1.8.0 as the fixed version for your JIRAs Regards Nabarun Nag On Fri, Aug 31, 2018 at 3:34 PM Nabarun Nag wrote: > Requesting status update on the following JIRA tickets. These tickets have > c

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-09-04 Thread Nabarun Nag
Houghton] GEODE-5280 - [xiaojian zhou & Biju Kunjummen] These tickets have commits into develop but they are still open with fix version as 1.8.0 Regards Nabarun Nag On Fri, Aug 31, 2018 at 3:38 PM Dale Emery wrote: > I have resolved GEODE-5254 > > Dale > > > On Aug 31, 201

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-09-04 Thread Nabarun Nag
Boorlagadda > wrote: > > > So the issue is that it takes longer to start than previous releases? > > Also, is this wait time only when using Gfsh to create gateway-receiver? > > > > On Tue, Sep 4, 2018 at 4:03 PM Nabarun Nag wrote: > > > > > C

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-09-04 Thread Nabarun Nag
--member=server1 5. create gateway-receiver --member=server2 `This gets stuck for 2 minutes` Is the 2 minute wait time acceptable? Should we document it? When we revert GEODE-5591, this issue does not happen. Regards Nabarun Nag On Tue, Sep 4, 2018 at 10:50 AM Nabarun Nag wrote: > Status Upd

Re: 2 minute gateway startup time due to GEODE-5591

2018-09-05 Thread Nabarun Nag
GEODE-5591 has been reverted in develop ref: 901da27f227a8ce2b7d6b681619782a1accd9330 Regards Nabarun Nag On Wed, Sep 5, 2018 at 10:14 AM Ryan McMahon wrote: > +1 for reverting in both places. > > I see that there is already an isGatewayReceiver flag in the AcceptorImpl > constr

Re: 2 minute gateway startup time due to GEODE-5591

2018-09-05 Thread Nabarun Nag
*correction: cherry picked to release/1.7.0 On Wed, Sep 5, 2018 at 10:54 AM Nabarun Nag wrote: > @Udo I have mentioned in an earlier mail that it will be reverted in > develop and then cherry picked to develop. release/1.7.0 branch has not > being published yet, as it is undergoing pr

Re: 2 minute gateway startup time due to GEODE-5591

2018-09-05 Thread Nabarun Nag
@Udo I have mentioned in an earlier mail that it will be reverted in develop and then cherry picked to develop. release/1.7.0 branch has not being published yet, as it is undergoing preliminary tests before release candidate is published. Regards Nabarun Nag On Wed, Sep 5, 2018 at 10:46 AM Udo

Re: Concerning Apache Geode 1.7.0

2018-09-05 Thread Nabarun Nag
as the branch is ready. Regards Nabarun Nag On Wed, Sep 5, 2018 at 2:10 PM John Blum wrote: > I see that the branch for Apache Geode 1.7.0 (release/1.7.0 [1]) has been > created in preparation for the upcoming the 1.7 release. > > I am trying to get an early sense/feel for the required ch

Re: Concerning Apache Geode 1.7.0

2018-09-05 Thread Nabarun Nag
. Regards Nabarun Nag On Wed, Sep 5, 2018 at 2:41 PM John Blum wrote: > I'd also say that, in general, those branches need to be cleaned up. There > are a crap load of branches in there! Are all those branches actively > developed and currently being built by a nightly CI? I'd argue th

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-09-05 Thread Nabarun Nag
[UPDATE] Cherry-picking 156333bfc397c96963e7af598897066989ff0d4e GEODE-5695 to release branch On Tue, Sep 4, 2018 at 4:45 PM Nabarun Nag wrote: > >>>>So the issue is that it takes longer to start than previous releases? > Yes > > >>>>Also, is this wait

Re: Concerning Apache Geode 1.7.0

2018-09-05 Thread Nabarun Nag
in place the snapshots would be published on clean builds. > > -Jake > > > > On Sep 5, 2018, at 3:04 PM, Nabarun Nag wrote: > > > > @John, everything you mentioned in mail is how things happen in Apache > > Geode where we cut a release branch and develop moves to

Re: Concerning Apache Geode 1.7.0

2018-09-05 Thread Nabarun Nag
For the nightly build snapshot hosting, it will have to go through [DISCUSS] -> [VOTE] , then implemented. Currently, it is out of scope for the 1.7.0 release process. Regards Nabarun Nag On Wed, Sep 5, 2018 at 3:10 PM John Blum wrote: > I just need nightly build snapshots (with art

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-07 Thread Nabarun Nag
CORRECTION: if '*no*' concerns are raised, we will start with the voting for the release candidate soon. Regrads Nabarun Nag On Fri, Sep 7, 2018 at 9:08 AM Nabarun Nag wrote: > Hello Geode Dev Community, > > We have created a new release branch for Apache Geode 1.7.0 - > &q

[DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-07 Thread Nabarun Nag
the voting for the release candidate soon. Regards Nabarun Nag

Re: [DISCUSS] and the NEW Apache Geode 1.7.0 release branch has been created

2018-09-10 Thread Nabarun Nag
Hello Anthony, I plan to do that while creating the release candidate. If there are no concerns raised on the release branch, I will start with the process soon. Regards Nabarun Nag On Mon, Sep 10, 2018 at 8:51 AM Anthony Baker wrote: > Looks good Naba! Only thing I see right

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-29 Thread Nabarun Nag
Thank you Sai, We are also waiting on documentation to be updated to reflect the changes made by these resolved JIRAs. Once that is completed, I believe that we will be ready for the new branch. Regards Nabarun Nag On Wed, Aug 29, 2018 at 11:45 AM Sai Boorlagadda wrote: > I have merged GE

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-29 Thread Nabarun Nag
Please continue marking fixed versions as 1.7.0 till the release branch is ready. The following tickets' fixed versions have been changed to 1.7.0 from 1.8.0 GEODE-5579 GEODE-5646 GEODE-5648 Regards Nabarun Nag On Wed, Aug 29, 2018 at 2:20 PM Nabarun Nag wrote: > Thank you Sai, > We ar

Re: 1.6.0 release

2018-04-19 Thread Nabarun Nag
Hi Mike, GEODE-3926 only two commits made into the release On Thu, Apr 19, 2018 at 10:49 AM Xiaojian Zhou wrote: > I have cherry-picked GEODE-5056 into 9.5 and 1.6.0 > > On Thu, Apr 19, 2018 at 9:09 AM, Bruce Schuchardt > wrote: > > > Thanks Mike -

Re: 1.6.0 release

2018-04-19 Thread Nabarun Nag
2d5f54a1e2 - 83c667b12c510f7a10aca57179b9e61f29cfddbb I think lack of these commits in the release/1.6.0 is causing failures in the rolling upgrade tests. I am currently testing the branch with these fixes. Will update soon. Regards Nabarun Nag On Thu, Apr 19, 2018 at 12:15 PM Naba

Re: 1.6.0 release

2018-04-19 Thread Nabarun Nag
The GEODE-3926 commit has now been reverted on release 1.6.0 Lucene precheckin ran with no errors hence pushed to origin/release/1.6.0 branch. Will update one we get complete test run on the branch. Regards Nabarun On Thu, Apr 19, 2018 at 12:19 PM Nabarun Nag <n...@apache.org> wrote: >

Re: [DISCUSS] gradle checks for test categories.

2018-03-21 Thread Nabarun Nag
Deppe <jde...@pivotal.io> wrote: > The build already fails if a test is added without @Category. Do you mean > it should fail if the test also does not have one of these newer > categories? > > --Jens > > On Wed, Mar 21, 2018 at 9:51 AM, Nabarun Nag <n...@apache.org&g

[DISCUSS] gradle checks for test categories.

2018-03-21 Thread Nabarun Nag
Hi, As we have now categorized our tests to categories like LuceneTests, WanTests, OQLQueriesTests, should we modify our gradle script to fail the build if a new test class was added without a test category. This will prevent test classes to be added without a fine level test category by mistake.

Re: Release process for Apache Geode wiki

2018-10-11 Thread Nabarun Nag
; > On Wed, Oct 10, 2018 at 7:01 PM Nabarun Nag wrote: > > > Hi, > > > > I have created a new wiki page on how to release Apache Geode. > > Please do a review and let me know if there are any suggestions or > > modifications required. > > > >

Re: [DISCUSS] LGTM on pull requests

2018-11-09 Thread Nabarun Nag
As per running periodically , LGTM runs it every Monday. As for who would fix it, LGTM mentions which commit caused the failure and who was the author of it. So i think its the author's responsibility to fix it. Personally, LGTM list a table that shows how many alerts we caused by which author

Requesting access to concourse.

2018-11-15 Thread Nabarun Nag
Hi, Please grant me access to the concourse infrastructure to run/setup pipelines. Regards Nabarun Nag

  1   2   3   >