GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/385
[GEODE-2408] Refactor CacheableDate to use C++ std::chrono
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/375
Merged, please close
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/387
The convention in this pull request is not consistent with the Google C++
Style Guide.
https://google.github.io/styleguide/cppguide.html#The__define_Guard
---
If your project
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98807830
--- Diff: dist/LICENSE ---
@@ -0,0 +1,390 @@
+ Apache License
+ Version 2.0, January
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98809847
--- Diff: dist/LICENSE ---
@@ -0,0 +1,390 @@
+ Apache License
+ Version 2.0, January
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/379
GEODE-2317: FindGeode searches GEODE_HOME environment variable.
@upthewaterspout Does this meet your request for using GEODE_HOME?
You can merge this pull request into a Git repository
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98808052
--- Diff: dist/NOTICE ---
@@ -0,0 +1,8 @@
+Apache Geode Native Client
+Copyright 2017 The Apache Software Foundation.
+
+This product
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98808024
--- Diff: dist/LICENSE ---
@@ -0,0 +1,390 @@
+ Apache License
+ Version 2.0, January
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/378
@echobravopapa merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98807604
--- Diff: dist/LICENSE ---
@@ -0,0 +1,390 @@
+ Apache License
+ Version 2.0, January
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98807616
--- Diff: src/CMakeLists.txt ---
@@ -71,7 +71,7 @@ set(CPACK_PACKAGE_FILE_NAME
${CPACK_PACKAGE_NAME}-${PRODUCT_VERSION}-${CPACK_SYS
set
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98808234
--- Diff: NOTICE ---
@@ -3,3 +3,6 @@ Copyright 2017 The Apache Software Foundation.
This product includes software developed
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/377
@metatype We do not ship the source or binary for SQLite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98810293
--- Diff: NOTICE ---
@@ -3,3 +3,6 @@ Copyright 2017 The Apache Software Foundation.
This product includes software developed
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/376
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/373
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/377
GEODE-1435: Adds binary distribution licensing.
* Adds binary licensing to binary package.
* Corrects error in source LICENSE file.
@metatype can you please review this?
You
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
@metatype looks good if you want to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/199
Yes, you can correct it but please make sure its agains the latest branch.
It may be easier to close and open a new one.
---
If your project is set up for it, you can reply to this email
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/365
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/367
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/372
Merged, please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/371
[GEODE-2308] Change library names to for Apache Geode branding.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/370
Merged, please close pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/367
We should include links to CTest documents.
To run singles or subsets of tests you need to use ctest directly.
ctest -R
---
If your project is set up for it, you
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/350
Feature/geode 2316
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode feature/GEODE-2316
Alternatively you can
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/355
Looks good, will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/357
rejecting as duplicate of #356
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101825168
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
#pragma once
-#ifndef
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101824812
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
add_subdirectory(cryptoimpl)
add_subdirectory(dhimpl
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/12#discussion_r101671763
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
# expect script
.*changepasswd$
+.*winrm.cloud-init$
# doxygen
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101662122
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1113,12 +1117,11 @@ class TcrMessageHelper {
return NULL_OBJECT;
} else
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101659601
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
#pragma once
-#ifndef
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101659693
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -20,7 +20,7 @@
* limitations under the License
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/12#discussion_r101658884
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
# expect script
.*changepasswd$
+.*winrm.cloud-init$
# doxygen
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101659366
--- Diff: src/CMakeLists.txt ---
@@ -224,7 +222,7 @@ add_subdirectory(cppcache)
add_subdirectory(cryptoimpl)
add_subdirectory(dhimpl
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/27
@dgkimura I think the GitHub UI would work better if the Geode repo was
actually hosted in GitHub but since this is a mirror it causes some strange
behaviors with pull requests
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/30
Does this change create the xml files in each of the individual integration
test's runtime directory of the root of the all the tests?
---
If your project is set up for it, you can
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102813470
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/27
A rebase would have been preferable to a merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005494
--- Diff: src/tests/cpp/security/XmlAuthzCredentialGenerator.hpp ---
@@ -27,7 +27,7 @@
#include
#include
--- End diff
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103004766
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005369
--- Diff: src/tests/cpp/security/PkcsAuthInit.cpp ---
@@ -19,7 +19,7 @@
#include
#include
#include
-#include "st
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103009272
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103004805
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
--
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005160
--- Diff: src/tests/cpp/fwklib/TaskClient.cpp ---
@@ -20,12 +20,12 @@
#include "fwklib/FwkLog.hpp"
#include "fwk
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005713
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.hpp ---
@@ -27,10 +27,10 @@
#include
#include
-#include
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/38
GEODE-2549: Delete unused files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode-native
feature/GEODE
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103031314
--- Diff: src/tests/cpp/fwklib/Timer.hpp ---
@@ -28,18 +28,18 @@
#ifdef _WIN32
-#include
-#include
-#include
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/33
@PivotalSarge CMakeList.txt.in is there to build Antlr with CMake rather
than the very complicated and broken build process it ships with.
---
If your project is set up for it, you
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/36
GEODE-2494: Replace SpinLock with spinlock_mutex.
Replaces our non-standard SpinLock with spinlock_mutex that implements the
C++11 standard BasicLockable. Where applicable the spin
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/37
GEODE-2531: Replace HostAsm::atomic with std::atomic.
Focus on commit c3411fd since the others are from pull #36.
Replaces the HostAsm::atomic* functions and ACE::Atomic
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103054617
--- Diff: src/cppcache/src/CacheableBuiltins.cpp ---
@@ -19,7 +19,7 @@
#include
extern "C" {
-#include
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103054588
--- Diff: src/cppcache/integration-test/BuiltinCacheableWrappers.hpp ---
@@ -23,7 +23,7 @@
#include "CacheableWrapper.hpp"
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/17
Please close this pull request and resubmit when you have cleaned up all
the places that use hashcode.
---
If your project is set up for it, you can reply to this email and have your
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743673
--- Diff: src/cppcache/src/CqServiceVsdStats.hpp ---
@@ -108,7 +108,7 @@ class CPPCACHE_EXPORT CqServiceVsdStats : public
CqServiceStatistics
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102739522
--- Diff: src/cppcache/include/geode/geode_base.hpp ---
@@ -69,32 +69,9 @@
#define GF_TEMPLATE_EXPORT
#endif
-#if defined
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r10278
--- Diff: src/cppcache/src/RegionStats.hpp ---
@@ -129,7 +129,7 @@ class CPPCACHE_EXPORT RegionStats {
class RegionStatType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102746696
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.cpp ---
@@ -535,21 +535,21 @@ uint32
HostStatHelperWin::getInt32Value
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742228
--- Diff: src/cppcache/include/geode/statistics/StatisticsFactory.hpp ---
@@ -96,7 +96,7 @@ class CPPCACHE_EXPORT StatisticsFactory
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102745344
--- Diff: src/cppcache/src/statistics/HostStatHelperSolaris.cpp ---
@@ -86,23 +86,23 @@ void
HostStatHelperSolaris::refreshProcess
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742460
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -245,7 +245,7 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743540
--- Diff: src/cppcache/src/CacheImpl.cpp ---
@@ -185,8 +185,8 @@ bool CacheImpl::getAndResetNetworkHopFlag() {
return networkhop
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102744883
--- Diff: src/cppcache/src/statistics/GeodeStatisticsFactory.hpp ---
@@ -98,50 +98,50 @@ class GeodeStatisticsFactory : public
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102738544
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102739037
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102739212
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/28#discussion_r102749040
--- Diff: src/cppcache/src/ClientMetadata.cpp ---
@@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char*
partitionName
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/25#discussion_r102736948
--- Diff: src/xsds/gfcpp-cache-9.0.xsd ---
@@ -33,7 +33,7 @@ limitations under the License.
version="9.0">
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102789698
--- Diff: src/clicache/src/CacheableDate.cpp ---
@@ -90,7 +90,7 @@ namespace Apache
TimeSpan epochSpan = m_dateTime - EpochTime
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/19#discussion_r102271148
--- Diff: src/cppcache/integration-test/CMakeLists.txt ---
@@ -21,7 +21,7 @@ target_link_libraries(${TEST_UTILS_LIB}
PRIVATE
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/24
@PivotalSarge yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102517638
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
$<TARGET_PROPERTY:_apa
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/9
[GEODE-2408] Refactor CacheableDate with C++11 standards.
Moved from old repo to new repo. Can I get a thumbs up please?
You can merge this pull request into a Git repository
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100912867
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/385
Moved to https://github.com/apache/geode-native/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100942381
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/6#discussion_r100957079
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void
CacheHelper::createDuplicateXMLFile(std::string
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/6#discussion_r100956921
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void
CacheHelper::createDuplicateXMLFile(std::string
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/6#discussion_r100956809
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1382,6 +1377,31 @@ void
CacheHelper::createDuplicateXMLFile(std::string
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/7#discussion_r100958376
--- Diff: src/dependencies/xerces-c/CMakeLists.txt ---
@@ -32,10 +32,10 @@ if (WIN32)
set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/7#discussion_r100958307
--- Diff: src/dependencies/xerces-c/CMakeLists.txt ---
@@ -32,10 +32,10 @@ if (WIN32)
set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/11
GEODE-2486: Initialize OpenSSL for DEFAULT cipher support.
- Init SSLv23_client mode to support negotiation of all SSL/TLS
versions.
- Cleanup C++ style issues.
- Update
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100877742
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100878314
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100878727
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/15#discussion_r101610701
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1114,10 +1116,10 @@ class TcrMessageHelper {
} else if (!isObj
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
Looking at this a little more... I don't think that gfppcache directly
depends on -lz. If it is just a transitive dependency from libxml2 then we
should move the -lz to target library
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/341
I would suggest a little more detail on the building in windows since the
command provided will use NMake and suck for the person building. Include
statement about -G generator options
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/341
Let's also move the BUILDING.md down to the root directory so it is easier
to find.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/342
GEODE-2309: Replace Pivotal Copyright and add Apache License notice.
Can I please get quick review of the copyright and license changes.
You can merge this pull request into a Git
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/341
@upthewaterspout, Its an easy change. We went for consistency with the
CMake community on the explicit variable setting. It is however consistent to
have the module "find" t
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
I've been down this ordering road before. Pretty sure this change will
break on Windows and possibly Solaris. If the known to work platforms in the
BUILDING doc, which have you tested
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352845
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
* limitations under the License.
*/
#include "LRULis
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353400
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -19,18 +19,22 @@
#include "TrackedMapEntry.hpp"
#include "Reg
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353360
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -96,33 +102,38 @@ void LRUList<TEntry,
TCreateEntry>::getLRUEntry(LRUListEntryPtr&a
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103354398
--- Diff: src/cppcache/include/geode/CacheStatistics.hpp ---
@@ -102,8 +102,8 @@ class CPPCACHE_EXPORT CacheStatistics : public
SharedBase
1 - 100 of 180 matches
Mail list logo
