[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r135573704 --- Diff: geode-core/src/main/java/org/apache/geode/security/StreamAuthenticator.java --- @@ -46,6 +44,14 @@ void receiveMessage(InputStream inputStream, OutputStream outputStream, boolean isAuthenticated(); /** + * Return an authorization object which can be used to determine which permissions this stream has + * according to the provided securityManager. + * + * Calling this before authentication has succeeded may result in a null return object. --- End diff -- `Optional` doesn't really fix the problem, just introduces more GC pressure :-) Wouldn't it be better to throw `IllegalStateException` when the precondition is not met? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #719: GEODE-3447 Implement client authorization for the new prot...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/719 I'm not suggesting changing the protobuf message. That seems ok to me. Since the `StreamAuthenticator` is part of protobuf messaging I think it should remain in the `geode-protobuf` module. Putting it in a public API package for RBAC seems like we're leaking abstractions into other parts of the codebase. Am I missing something? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #733: Keeping old versions around even during a clean
Github user metatype commented on the issue: https://github.com/apache/geode/pull/733 Um, should we add a `reallyClean` task to scrub this dir? What about users of `-PbuildRoot`? I'm inclined towards keeping temporary build files in `build`. But IMO... +0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #404: Geode 2469
Github user metatype commented on the issue: https://github.com/apache/geode/pull/404 What would it take to get this PR merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples pull request #11: GEODE-3233 Prefix distribution files with a...
GitHub user metatype opened a pull request: https://github.com/apache/geode-examples/pull/11 GEODE-3233 Prefix distribution files with apache- You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/geode-examples develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-examples/pull/11.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11 commit bcf98bc1cc94f0d72a7c3e4192691e3ea01a25e8 Author: Anthony Baker <aba...@apache.org> Date: 2017-07-18T00:38:59Z GEODE-3233 Prefix distribution files with apache- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples pull request #9: GEODE-3199: Make signing with a gpg key opti...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/9#discussion_r127090456
--- Diff: gradle/release.gradle ---
@@ -41,17 +41,19 @@ gradle.taskGraph.whenReady( { graph ->
})
gradle.taskGraph.whenReady { taskGraph ->
- if (!version.endsWith('SNAPSHOT')) {
-if(!project.hasProperty('signing.keyId') ||
!project.hasProperty('signing.secretKeyRingFile')) {
- println "You must configure your signing.keyId and
signing.secretKeyRingFile"
- println "in ~/.gradle/gradle.properties in order to sign jars\n"
- println "See
https://cwiki.apache.org/confluence/display/GEODE/Release+Steps;
- throw new GradleException("Signing key/keyring is missing")
-}
+ if (project.hasProperty('askpass')) {
--- End diff --
Should this be called `signReleaseArtifacts` since it guards signing (which
may cause the password dialog to appear depending on your environment)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-examples/pull/8#discussion_r127074360 --- Diff: queries/scripts/new_startAll.sh --- @@ -0,0 +1,48 @@ +#!/bin/bash --- End diff -- How is this file used? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/8#discussion_r127074639
--- Diff:
queries/src/main/java/org/apache/geode/examples/queries/Example.java ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.queries;
+
+import java.util.function.Consumer;
+import java.util.Iterator;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.query.Query;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.SelectResults;
+
+
+public class Example implements Consumer<Region<Integer, EmployeeData>> {
+ public static void main(String[] args) {
+// connect to the locator using default port 10334
+ClientCache cache = new
ClientCacheFactory().addPoolLocator("127.0.0.1", 10334)
+.set("log-level", "WARN").create();
+
+// create a local region that matches the server region
+Region<Integer, EmployeeData> region =
+cache.<Integer,
EmployeeData>createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY)
+.create("example-region");
+
+Example e = new Example();
+e.accept(region);
+e.doQueries(cache, region);
--- End diff --
I think `doQueries` should be called from `accept` to make it easier to
unit test the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/8#discussion_r127073923
--- Diff:
queries/src/main/java/org/apache/geode/examples/queries/EmployeeData.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.queries;
+
+import java.io.Serializable;
+
+public class EmployeeData implements Serializable {
+ private static final long serialVersionUID = 1L;
+
+ // private EmployeeKey nameAndNumber;
+ private String firstName;
+ private String lastName;
+ private int emplNumber;
+ private String email;
+ private int salary;
+ private int hoursPerWeek;
+
+ // public EmployeeData(EmployeeKey nameAndNumber, int salary, int
hoursPerWeek) {
--- End diff --
Delete this dead code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/8#discussion_r127073986
--- Diff:
queries/src/main/java/org/apache/geode/examples/queries/EmployeeData.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.queries;
+
+import java.io.Serializable;
+
+public class EmployeeData implements Serializable {
+ private static final long serialVersionUID = 1L;
+
+ // private EmployeeKey nameAndNumber;
+ private String firstName;
+ private String lastName;
+ private int emplNumber;
+ private String email;
+ private int salary;
+ private int hoursPerWeek;
+
+ // public EmployeeData(EmployeeKey nameAndNumber, int salary, int
hoursPerWeek) {
+ // this.nameAndNumber = nameAndNumber;
+ // this.salary = salary;
+ // this.hoursPerWeek = hoursPerWeek;
+ // }
+
+ public EmployeeData(String firstName, String lastName, int emplNumber,
String email, int salary,
+ int hoursPerWeek) {
+this.firstName = firstName;
+this.lastName = lastName;
+this.emplNumber = emplNumber;
+this.email = email;
+this.salary = salary;
+this.hoursPerWeek = hoursPerWeek;
+ }
+
+ public String getFirstName() {
+return firstName;
+ }
+
+ public String getLastName() {
+return lastName;
+ }
+
+ public int getEmplNumber() {
+return emplNumber;
+ }
+
+ public String getEmail() {
+return email;
+ }
+
+ public int getSalary() {
+return salary;
+ }
+
+ public int getHoursPerWeek() {
+return hoursPerWeek;
+ }
+
+ @Override
+ // public String toString() {
--- End diff --
// delete me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-examples/pull/8#discussion_r127073565
--- Diff:
queries/src/main/java/org/apache/geode/examples/queries/Example.java ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.examples.queries;
+
+import java.util.function.Consumer;
+import java.util.Iterator;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.query.Query;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.SelectResults;
+
+
+public class Example implements Consumer<Region<Integer, EmployeeData>> {
+ public static void main(String[] args) {
+// connect to the locator using default port 10334
+ClientCache cache = new
ClientCacheFactory().addPoolLocator("127.0.0.1", 10334)
+.set("log-level", "WARN").create();
+
+// create a local region that matches the server region
+Region<Integer, EmployeeData> region =
+cache.<Integer,
EmployeeData>createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY)
+.create("example-region");
+
+Example e = new Example();
+e.accept(region);
+e.doQueries(cache, region);
+cache.close();
+ }
+
+ @Override
+ public void accept(Region<Integer, EmployeeData> region) {
+// put entries in the region
+String[] firstNames =
+
"Alex,Bertie,Kris,Dale,Frankie,Jamie,Morgan,Pat,Ricky,Taylor,Casey,Jessie,Ryan,Skyler"
+.split(",");
+String[] lastNames =
+
"Able,Bell,Call,Driver,Forth,Jive,Minnow,Puts,Reliable,Tack,Catch,Jam,Redo,Skip".split(",");
+int salaries[] = new int[] {6, 8, 75000, 9, 10};
+int hours[] = new int[] {40, 40, 40, 40, 30, 20};
+int emplNumber = 1;
+for (int index = 0; index < firstNames.length; index++) {
+ emplNumber = emplNumber + index;
+ Integer key = emplNumber;
+ String email = firstNames[index] + "." + lastNames[index] +
"@example.com";
+ int salary = salaries[index % 5];
+ int hoursPerWeek = hours[index % 6];
+ EmployeeData value = new EmployeeData(firstNames[index],
lastNames[index], emplNumber, email,
+ salary, hoursPerWeek);
+ region.put(key, value);
+}
+
+// count the values in the region
+int inserted = region.keySetOnServer().size();
+System.out.println(String.format("Counted %d keys in region %s",
inserted, region.getName()));
+
+// fetch and print all values in the region (without using a query)
+region.keySetOnServer().forEach(key ->
System.out.println(region.get(key)));
+
+ }
+
+ // Query using the API
+ private void doQueries(ClientCache cache, Region<Integer, EmployeeData>
region) {
+String regionName = region.getName();
+QueryService queryService = cache.getQueryService();
+
+// query for every entry in the region, and print query results
+String queryString1 = "SELECT DISTINCT * FROM /" + regionName;
+System.out.println(String.format("\nQuery: %s", queryString1));
+Query query = queryService.newQuery(queryString1);
+SelectResults results = null;
+try {
+ results = (SelectResults) query.execute();
+} catch (Exception e) {
+ e.printStackTrace();
--- End diff --
I think you should use a single `catch` block. It simplifies the code and
you probably want to abort if there's an error instead of trying to continue.
---
If your project is set up for it,
[GitHub] geode-examples pull request #8: GEODE-3195 Add querying example to the geode...
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-examples/pull/8#discussion_r127073236 --- Diff: replicated/scripts/start.gfsh --- @@ -19,7 +19,9 @@ start locator --name=locator --bind-address=127.0.0.1 start server --name=server1 --locators=127.0.0.1[10334] --server-port=0 start server --name=server2 --locators=127.0.0.1[10334] --server-port=0 +#connect --- End diff -- Is this needed? I think it should be removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #7: GEODE-3196: Fixing the format of the .md5 and .sha2...
Github user metatype commented on the issue: https://github.com/apache/geode-examples/pull/7 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #508: GEODE-2908: Adding the new tag as per swagger notification...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/508 @jaredjstewart any thoughts on this change? If it's good I'd like to merge it since we need it for 1.2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #558: GEODE-194: Remove spark connector
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/558 GEODE-194: Remove spark connector Remove the spark connector code until it can be updated for the current spark release. We should also integrate the build lifecycle and consider how to extract this into a separate reo. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [X] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode remove-spark Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/558.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #558 commit d95993b944d706baeb0c5e6c13a7d00754159123 Author: Anthony Baker <aba...@apache.org> Date: 2017-05-06T00:00:02Z GEODE-194: Remove spark connector Remove the spark connector code until it can be updated for the current spark release. We should also integrate the build lifecycle and consider how to extract this into a separate reo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #538: GEODE-2975: Change the location of the lucene xsd
Github user metatype commented on the issue: https://github.com/apache/geode/pull/538 Does this also affect the xsd location on http://geode.apache.org? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store
Github user metatype commented on the issue: https://github.com/apache/geode/pull/525 Why is `notExecutedMembers` null? Is that the issue that should be addressed instead of changing the message? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #509: GEODE-265: Removing deprecated API from Execution interfac...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/509 @jhuynh1 I just noticed the one recent deprecation. Given this is a public API change you should probably double-check me :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #474: GEODE-2788: Add official Socket timeout parameter w...
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/474#discussion_r115865619 --- Diff: geode-core/src/main/resources/META-INF/schemas/geode.apache.org/schema/cache/cache-1.0.xsd --- @@ -1191,6 +1191,7 @@ As of 6.5 disk-dirs is deprecated on region-attributes. Use disk-store-name inst + --- End diff -- BTW, if we change the XSD it needs to get posted on geode.apache.org via the asf-site branch of geode-site. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #501: GEODE-2897 Add PR template for github
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/501 GEODE-2897 Add PR template for github You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/501.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #501 commit 8308a384dcdcceb7ce91ceedc29c711bc75d24ce Author: Anthony Baker <aba...@apache.org> Date: 2017-05-09T06:00:05Z GEODE-2897 Add PR template for github --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-site issue #2: GEODE-2554 Add htaccess file for docs redirect
Github user metatype commented on the issue: https://github.com/apache/geode-site/pull/2 Whoops, you're right. Ok, let's just do the latest -> 11 rule. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-site issue #2: GEODE-2554 Add htaccess file for docs redirect
Github user metatype commented on the issue: https://github.com/apache/geode-site/pull/2 Not sure why travis is unhappy. Perhaps we need to override the `install` directive to prevent it from trying to run `gradlew assemble`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #4: Updating and simplifying examples
Github user metatype commented on the issue: https://github.com/apache/geode-examples/pull/4 Added a cache loader example to test drive the approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #4: Updating and simplifying examples
Github user metatype commented on the issue: https://github.com/apache/geode-examples/pull/4 The latest update incorporates the feedback on testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #4: Updating and simplifying examples
Github user metatype commented on the issue: https://github.com/apache/geode-examples/pull/4 @upthewaterspout Thanks for giving this a test drive! Lombok requires an IDE plugin. I like it because it removes a lot of boilerplate code but it's probably to "magical" for an example. I'll revert those changes. Do you have any ideas on how to make the example code more testable while retaining clarity? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples pull request #4: Updating and simplifying examples
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-examples/pull/4#discussion_r113305384 --- Diff: README.md --- @@ -17,29 +17,59 @@ limitations under the License. [https://geode.apache.org/img/apache_geode_logo.png; align="center"/>](http://geode.apache.org) -[](https://travis-ci.org/apache/geode-examples) [](https://www.apache.org/licenses/LICENSE-2.0) +[](https://travis-ci.org/apache/geode-examples) [](https://www.apache.org/licenses/LICENSE-2.0) # Apache Geode examples -This is the home of Apache Geode examples that are bundled with the project. Contributions[2] and corrections are welcome. Please talk to us about your suggestions at [dev@geode.apache.org](mailto:dev@geode.apache.org) or submit a [pull request](https://github.com/apache/geode/pull/new/develop). +This is the home of Apache Geode examples that are bundled with the project. +Contributions[2] and corrections are welcome. Please talk to us +about your suggestions at [dev@geode.apache.org](mailto:dev@geode.apache.org) +or submit a [pull request](https://github.com/apache/geode/pull/new/develop). -## Example requirements +## Adding a new example -All examples: +Follow this approach to add a new example: -* Need to be testable. Use unit tests, integration tests or whatever is applicable. Tests will run through the project's CI. --- End diff -- Here's my thesis: `gradle runAll` is the integration test. The model for building an example is prescriptive. I want to be able to run the example and any tests from my IDE. I want to show users how to use `gfsh` to start servers. Wherever we can I want to distill an example into a single pane of code. We should write unit tests as needed while being careful that those tests don't get in the way of learning. IMO the two examples we have today don't need additional unit tests. Do you agree? Feedback welcome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #4: Updating and simplifying examples
Github user metatype commented on the issue: https://github.com/apache/geode-examples/pull/4 Adding for comment: @upthewaterspout, @joeymcallister, @davebarnes97, @karensmolermiller, @markito --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples pull request #4: Updating and simplifying examples
GitHub user metatype opened a pull request: https://github.com/apache/geode-examples/pull/4 Updating and simplifying examples These are some ideas I have to simplify our examples. Please let me know what you think. You can build and run everything from the root by invoking `./gradlew runAll`. Each example consists of the following: - A `README.md` that walks the user through the tutorial - An `Example.java` application as well as supporting classes and tests as needed - A gfsh start script: `scripts/start.gfsh` - A gfsh stop script: `scripts/stop.gfsh` The changes in this PR support the above model. The build script has tasks to start a cluster, run the example, and stop the cluster using the downloaded Geode install. However, the README's reference specific gfsh commands to familiarize the user with interacting with Geode. I avoided using bash scripts to simplify the environment. This means using the default locator port of 10334. I also removed a number of unit tests that added complexity IMO. I think the examples should be easy to extend. If `gradle runAll` succeeds that should be a sufficient check to ensure that the example is still functioning. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/geode-examples develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-examples/pull/4.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4 commit f811a1cd664d8a888bd447068d00ad98597d1bd1 Author: Anthony Baker <aba...@apache.org> Date: 2017-04-24T19:24:47Z Add eclipse generator, improve formatting commit 3da70b823815b02434519a1df4cf0c6a2b53a961 Author: Anthony Baker <aba...@apache.org> Date: 2017-04-25T06:21:10Z update examples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench
Github user metatype commented on the issue: https://github.com/apache/geode/pull/450 @upthewaterspout thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #443: [GEODE-1887] #comment Fix for Client PROXY region should d...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/443 ^^^ Changing _we_ to _I_ in above comment, because we all come to the project as individual contributors :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #455: GEODE-2770 - Move the shutdown of the rest interface to th...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/455 LGTM @jinmeiliao --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #53: Feature/geode 2609
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/53#discussion_r107014175
--- Diff: src/docs/win_index.html ---
@@ -19,21 +19,21 @@
- Pivotal GemFire Native Client Documentation
+ Apache Geode Native Client Documentation
<!--
.style2 {font-size: medium}
-->
-
-Pivotal GemFire Native
Client Documentation
+Apache Geode Native Client Documentation
Access documentation at http://docs-gemfire-native-develop.cfapps.io; target="_blank">Pivotal
GemFire Native Client Documentation.
--- End diff --
@pivotal-jbarrett until we have the docs hosted on geode.apache.org, unless
you have a better suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #404: Geode 2469
Github user metatype commented on the issue: https://github.com/apache/geode/pull/404 @galen-pivotal dlock approach seems too heavy-weight for updating a key. Every hash is single-threaded through this lock. I think the granularity we want is concurrent updates over different hashes, but thread-safe updates of a particular hash. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #53: Feature/geode 2609
GitHub user metatype opened a pull request: https://github.com/apache/geode-native/pull/53 Feature/geode 2609 You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/geode-native feature/GEODE-2609 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 commit a8ef66214d7765e521b465d8e9cd554e602a99a7 Author: Anthony Baker <aba...@apache.org> Date: 2017-03-14T04:24:54Z GEODE-2609 Remove Pivotal references from API docs commit a7c0b0caadaa51cc25b6d9d1ce0c5a70038818ba Author: Anthony Baker <aba...@apache.org> Date: 2017-03-14T04:26:40Z GEODE-2609 Include graphviz in docker build image The dot program is needed for building the docs and is installed from the graphviz package. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #50: GEODE-2636: Switch to CMake variable for libr...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/50#discussion_r105272239
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,6 +26,9 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH=${NATIVECLIENT_DIR}/lib)
endif()
+set(PRODUCT_LIB_NAME "apache-geode" CACHE STRING "Binary name")
--- End diff --
Ah, makes sense. I was wondering how that got set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #421: GEODE-2595: Change LuceneService.createIndex to use a fact...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/421 API changes look good to me. There's a compile error in a test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/397 @kirklund any thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #409: GEODE-880 Remove unused classes
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/409 GEODE-880 Remove unused classes @kirklund I think this should close out GEODE-880. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode feature/GEODE-880 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/409.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #409 commit d00bfc4971d6e8e344dbe83debfdf8929a1b5bda Author: Anthony Baker <aba...@apache.org> Date: 2017-02-28T06:04:46Z GEODE-880 Remove unused classes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #39: Add rat checks to travis-ci build
GitHub user metatype opened a pull request: https://github.com/apache/geode-native/pull/39 Add rat checks to travis-ci build You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/geode-native develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 4ff971de19aa9a33743eb729f17fefad93c5bc01 Author: Anthony Baker <aba...@apache.org> Date: 2017-02-27T05:01:59Z Add rat checks to travis-ci build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #408: GEODE-2551 Fix code issues found by AppChecker
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/408 GEODE-2551 Fix code issues found by AppChecker You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode feature/GEODE-2551 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/408.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #408 commit 92c9ad1e2df8d11b970e08be7b868294300434a4 Author: Anthony Baker <aba...@apache.org> Date: 2017-02-26T21:20:34Z GEODE-2551 Fix code issues found by AppChecker --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #407: GEODE-2550 Improve README and BUILDING
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/407 GEODE-2550 Improve README and BUILDING - Word wrap everything so its easier to read from terminal - Simplify and remove duplicate instructions in BUILDING - Improve wording in README - Improve the 'Geode in 5 minutes example You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/407.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #407 commit 0b11ec63ab691507ed9e4cc01d7753befdd51cce Author: Anthony Baker <aba...@apache.org> Date: 2017-02-25T16:09:48Z GEODE-2550 Improve README and BUILDING --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #388: GEODE-2428: Adding support of Serialization/deserializatio...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/388 This looks good to me, @bschuchardt what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #397: Add junit to try parsing of simple XML file w pool ...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/397 The test failure doesn't seem to be related to your changes, though you need to run `gradlew spotlessApply` to format your PR correctly. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #397: Add junit to try parsing of simple XML file w pool ...
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/397#discussion_r103062304 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java --- @@ -15,19 +15,25 @@ package org.apache.geode.internal.cache.xmlcache; import static org.junit.Assert.*; +import static org.mockito.Mockito.*; +import static org.apache.geode.distributed.ConfigurationProperties.*; import java.lang.reflect.Field; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; import java.util.HashMap; import java.util.Locale; +import java.util.Properties; import org.junit.Test; import org.junit.experimental.categories.Category; import org.xml.sax.Attributes; import org.xml.sax.SAXException; import org.apache.geode.test.junit.categories.UnitTest; +import org.apache.geode.distributed.internal.membership.gms.mgr.*; +import org.apache.geode.distributed.DistributedSystem; +import org.apache.geode.distributed.internal.*; --- End diff -- I'd prefer to see explicit import statements rather than wildcard imports. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #406: GEODE-2526: Enhance log statement to include ResourceTypeN...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/406 Please update the PR after running `gradlew spotlessApply`. Thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #404: Geode 2469
Github user metatype commented on the issue: https://github.com/apache/geode/pull/404 Thanks for the contribution. Could you fix the test failure in `RegionProviderTest`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103040225 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [](https://travis-ci.org/apache/geode-site) [](https://www.apache.org/licenses/LICENSE-2.0) # Apache Geode Site + +This directory contains the source files for the project [website](https://geode.apache.org). Website content is written in [Markdown](https://help.github.com/articles/markdown-basics) and the site files are generated from that source by a tool called [Pandoc](http://johnmacfarlane.net/pandoc). + +Source files for the website are in `website/content`. Generated files for the website are in `build/content`. + +**NOTE:** To make changes to the [Apache Geode User Guide](http://geode.apache.org/docs/), which is published to the website: + +- Review [CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md) for information about contributing to the documentation source files. +- Follow the [README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for information about building a local version of the guide and adding it to the website. + +The website is updated by a "sync" tool that monitors the __asf-site__ branch +of our Git repo, so after making changes you must place your updated source +and generated files on the __asf-site__ branch and push. +The content will be published to the +[Geode website](http://geode.apache.org) after a 5-20 minute delay. + +## Prerequisites --- End diff -- You might be able to run under cygwin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103039403 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [](https://travis-ci.org/apache/geode-site) [](https://www.apache.org/licenses/LICENSE-2.0) # Apache Geode Site + +This directory contains the source files for the project [website](https://geode.apache.org). Website content is written in [Markdown](https://help.github.com/articles/markdown-basics) and the site files are generated from that source by a tool called [Pandoc](http://johnmacfarlane.net/pandoc). + +Source files for the website are in `website/content`. Generated files for the website are in `build/content`. + +**NOTE:** To make changes to the [Apache Geode User Guide](http://geode.apache.org/docs/), which is published to the website: + +- Review [CONTRIBUTING](https://github.com/apache/geode/blob/develop/geode-docs/CONTRIBUTE.md) for information about contributing to the documentation source files. +- Follow the [README](https://github.com/apache/geode/blob/develop/geode-book/README.md) for information about building a local version of the guide and adding it to the website. + +The website is updated by a "sync" tool that monitors the __asf-site__ branch +of our Git repo, so after making changes you must place your updated source +and generated files on the __asf-site__ branch and push. +The content will be published to the +[Geode website](http://geode.apache.org) after a 5-20 minute delay. + +## Prerequisites + +To generate the site locally, you need to install java and docker. + +## How to change/update the website + +### 1. Find and edit the source files you need to change + +Source files for the website are in ``website/content``. When changing the content of the site, find the Markdown files that you +need to edit and make your change. If you need to change the layout or styling of the site, then you will probably need to change +an HTML, JS or CSS file. + +### 2. Locally generate the site and test your changes + +To generate the site content, run the `nanoc` compiler: + +$ ./gradlew compile + +To view the generated site, run: + +$ ./gradlew view + +and point your browser at `http://localhost:3000`. To make further changes, stop the build, edit files, recompile, and view again. + +### 3. Publish your changes to the site + +Once you are happy with your changes, commit them to the __master__ branch. +The changes also need to be propagated to the __asf-site__ branch. Run the +gradle command + +$ ./gradlew publish + +to checkout the __asf-site__ branch and copy the website files. You will +need to manually commit and push your changes on the __asf-site__ branch. + +The site should update in 5-10 minutes. If it does not, --- End diff -- Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode-site/pull/1#discussion_r103039387
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
*/
plugins {
- id "org.nosphere.apache.rat" version "0.3.0"
+ id 'org.nosphere.apache.rat' version '0.3.0'
+ id 'org.ajoberstar.grgit' version '1.6.0'
}
-apply plugin: "org.nosphere.apache.rat"
+apply plugin: 'org.ajoberstar.grgit'
+
+task clean << {
+ delete buildDir
+}
+
+def dockerCmd = "docker run -v '${projectDir}':/geode-site -p 3000:3000 -w
/geode-site/website apachegeode/geode-site-build "
+
+task compile(type:Exec, dependsOn: rat) {
+ inputs.dir "${projectDir}/website"
+ outputs.dir "${buildDir}/content"
+ executable 'bash'
+ args "-c", dockerCmd + "nanoc compile"
+}
+
+task view(type:Exec, dependsOn: compile) {
+ executable 'bash'
+ args "-c", dockerCmd + "nanoc view"
+}
+
+task publish(dependsOn: compile) {
--- End diff --
I thought about that, but I'm hesitant to go all the way (git
add/commit/push) since that would require a clean workspace and we'd have to
figure out `git rm` cases. At least this can be used as a starting point and
is less confusing than the prior `tar` instructions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view
GitHub user metatype opened a pull request: https://github.com/apache/geode-site/pull/1 GEODE-2507 Add gradle tasks for compile and view Add gradle tasks to make it really simple to compile and view the website. The gradle task relies on a docker container, apachegeode/geode-site-build that has the build chain preinstalled. There's also a preliminary cut at improvements for publishing the site content. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/geode-site master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-site/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6
Github user metatype closed the pull request at: https://github.com/apache/geode/pull/403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6
Github user metatype commented on the issue: https://github.com/apache/geode/pull/403 In this case geode-pulse uses commons-beanutils v1.9.3 while geode-core is pulling in commons-beanutils v1.8.3 via shiro-core. The version is different between `lib/*` and `geode-pulse-*.war`. The override resolution strategy gives us another way to control transitive dependencies. In some (rare) instances, we may want to ship a different version than specified in the pom file. Let me know if you think this is getting overly complicated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #405: Delete website
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/405 Delete website You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode delete-website Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/405.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #405 commit e8de9a47e7fae148f76f0396fb8f050d0ef2abcb Author: Anthony Baker <aba...@apache.org> Date: 2017-02-21T15:39:38Z GEODE-2507 Update LICENSE, rat for removing geode-site Remove LICENSE references to files used in geode-site. Update rat exclusions for same. No changes needed to NOTICE. commit a2353e96eb334ee38fede5605433d81de06742ec Author: Anthony Baker <aba...@apache.org> Date: 2017-02-21T15:42:56Z GEODE-2507 Remove geode-site files The geode-site files have been moved to a new repo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #403: GEODE-2506 Update Spring from 4.3.2 to 4.3.6
Github user metatype commented on the issue: https://github.com/apache/geode/pull/403 @upthewaterspout @scmbuildguy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #401: Remove generated html files
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/401 Remove generated html files Delete generated html files from geode-site/website/content/docs/guide since these files can be rebuilt from geode-docs/ and the generated content is only used in the asf-site branch. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/401.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #401 commit 43fcadee6cfd57ee4191ae200d5c6ce20ab123b1 Author: Anthony Baker <aba...@apache.org> Date: 2017-02-17T16:56:48Z Remove generated html files Delete generated html files from geode-site/website/content/docs/guide since these files can be rebuilt from geode-docs/ and the generated content is only used in the asf-site branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-native pull request #16: GEODE-2501 Update docker build container
GitHub user metatype opened a pull request: https://github.com/apache/geode-native/pull/16 GEODE-2501 Update docker build container Update the docker build container to use Geode v1.1.0. Push the container to the Geode dockerhub repository apachegeode/geode-native-build:latest Update the travis-ci config to pull the docker container to speed up the build. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/geode-native develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode-native/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 036b0f91f73ca31d02a5c1760e89fa24f165f6e9 Author: Anthony Baker <aba...@apache.org> Date: 2017-02-17T14:37:42Z GEODE-2501 Update docker build container Update the docker build container to use Geode v1.1.0. Push the container to the Geode dockerhub repository apachegeode/geode-native-build:latest Update the travis-ci config to pull the docker container to speed up the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #398: Split the redis adapter into its own package
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101391406
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
---
@@ -1330,21 +1360,12 @@ private void startMemcachedServer() {
}
private void startRedisServer() {
-int port = system.getConfig().getRedisPort();
-if (port != 0) {
- String bindAddress = system.getConfig().getRedisBindAddress();
- assert bindAddress != null;
- if
(bindAddress.equals(DistributionConfig.DEFAULT_REDIS_BIND_ADDRESS)) {
-getLoggerI18n().info(
-
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_PORT_0,
-new Object[] {port});
- } else {
-getLoggerI18n().info(
-
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_BIND_ADDRESS_0_PORT_1,
-new Object[] {bindAddress, port});
- }
- this.redisServer = new GeodeRedisServer(bindAddress, port);
- this.redisServer.start();
+GeodeRedisService geodeRedisService =
getService(GeodeRedisService.class);
--- End diff --
Good news! There *is* a way to start services and do gfsh extensions.
Take a look at the lucene module. The only bits that are in `geode-core` are
for serialization and string messages--which we don't have a good solution for
as of yet (contributions welcome!).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #398: Split the redis adapter into its own package
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101375546
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
---
@@ -1330,21 +1360,12 @@ private void startMemcachedServer() {
}
private void startRedisServer() {
-int port = system.getConfig().getRedisPort();
-if (port != 0) {
- String bindAddress = system.getConfig().getRedisBindAddress();
- assert bindAddress != null;
- if
(bindAddress.equals(DistributionConfig.DEFAULT_REDIS_BIND_ADDRESS)) {
-getLoggerI18n().info(
-
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_PORT_0,
-new Object[] {port});
- } else {
-getLoggerI18n().info(
-
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_BIND_ADDRESS_0_PORT_1,
-new Object[] {bindAddress, port});
- }
- this.redisServer = new GeodeRedisServer(bindAddress, port);
- this.redisServer.start();
+GeodeRedisService geodeRedisService =
getService(GeodeRedisService.class);
--- End diff --
Is there a reason why we can't extract *all* redis code into `geode-redis`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #398: Split the redis adapter into its own package
Github user metatype commented on the issue: https://github.com/apache/geode/pull/398 Also, I believe redis is started by providing an option to `start server`. How do you plan to extract that from `geode-core`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.
Github user metatype commented on the issue: https://github.com/apache/geode/pull/391 LGTM. There are still references to Pivotal, GemStone, and copyright stuff that should be cleaned up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file
Github user metatype closed the pull request at: https://github.com/apache/geode/pull/394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #387: GEODE-2411: Remove references to Gemfire from include guar...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/387 Built and ran unit tests. I'll merge this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #389: GEODE-1434: Add ASF headers
Github user metatype closed the pull request at: https://github.com/apache/geode/pull/389 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/394#discussion_r99871967 --- Diff: .travis.yml --- @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +language: cpp +sudo: required + +before_install: + - sudo apt-get -qq update + - sudo apt-get -y build-essential + - sudo apt-get install -y cmake + - sudo apt-get install -y doxygen + - sudo apt-get install -y git + - sudo apt-get install -y openjdk-8-jdk + - sudo apt-get install -y wget + - sudo apt-get install -y zlib1g-dev + +install: mkdir build && cd build && cmake ../src && cmake --build . -- -j 8 --- End diff -- Do the unit tests require a GEODE install? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #394: GEODE-2437 Add travis-ci file
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/394 GEODE-2437 Add travis-ci file Configure travis-ci to build cppcache on linux and run unit tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode feature/GEODE-2437 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/394.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #389: GEODE-1434: Add ASF headers
Github user metatype commented on the issue: https://github.com/apache/geode/pull/389 `rake` is a ruby thing. We need a .travis.yml file to build and run unit tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #326: Feature/geode 2103 : Adding --http-service-port and --http...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/326 @jinmeiliao any thoughts on this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #389: GEODE-1434: Add ASF headers
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/389 GEODE-1434: Add ASF headers - Add missing ASF headers - Add .ratignore to define excluded files There are 3 remaining files to clean up: - examples/clicache/ProductBrowser/lib/productClient.jar (this is binary and should be removed) - packer/solaris/files/etc/resolv.conf (this is a site-specific file and should be cleaned up) - packer/windows/winrm.cloud-init (either exclude or add comment) The files excluded from src headers are listed in `.ratignore`. You can run the rat tool using `java -jar ~/tools/apache-rat-0.12/apache-rat-0.12.jar --dir . --exclude-file .ratignore`. I've built and run unit tests on osx. Still to do: run the integration tests and confirm nothing is broken on other platforms. I removed `src/pdxautoserializer/.depend` as it was empty. Please confirm that this is correct. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode next-gen-native-client-software-grant Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/389.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #389 commit 1776293fbb8548fc3e223daff8a7c6d7d3febf79 Author: Anthony Baker <aba...@apache.org> Date: 2017-02-03T23:43:27Z GEODE-1434: Add ASF headers - Add missing ASF headers - Add .ratignore to define excluded files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #329: [GEODE-1887] #comment Fix for Issue #1887
Github user metatype commented on the issue: https://github.com/apache/geode/pull/329 Please fix conflict, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #326: Feature/geode 2103 : Adding --http-service-port and --http...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/326 IIRC, there's an integration test that should be updated with the new options. Take a look at `geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #315: GEODE-1995: Removed ReliableMessageQueue, ReliableMessageQ...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/315 @dschneider-pivotal what's next for this PR? Is it good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #377: GEODE-1435: Adds binary distribution licensing.
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/377#discussion_r98812545 --- Diff: dist/LICENSE --- @@ -0,0 +1,390 @@ + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work
[GitHub] geode pull request #377: GEODE-1435: Adds binary distribution licensing.
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode/pull/377#discussion_r98810309
--- Diff: src/CMakeLists.txt ---
@@ -71,7 +71,7 @@ set(CPACK_PACKAGE_FILE_NAME
${CPACK_PACKAGE_NAME}-${PRODUCT_VERSION}-${CPACK_SYS
set(CPACK_INCLUDE_TOPLEVEL_DIRECTORY 0)
set(CPACK_PACKAGING_INSTALL_PREFIX "/${CPACK_PACKAGE_NAME}")
#set(CPACK_PACKAGE_DESCRIPTION_FILE "${CMAKE_CURRENT_SOURCE_DIR}/README")
-#set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_CURRENT_SOURCE_DIR}/LICENSE")
+set(CPACK_RESOURCE_FILE_LICENSE
"${CMAKE_CURRENT_SOURCE_DIR}/../dist/LICENSE")
--- End diff --
Got it. Once I get a build I'll double-check that both LICENSE and NOTICE
are present.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #377: GEODE-1435: Adds binary distribution licensing.
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/377#discussion_r98809463 --- Diff: dist/LICENSE --- @@ -0,0 +1,390 @@ + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work
[GitHub] geode pull request #377: GEODE-1435: Adds binary distribution licensing.
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/377#discussion_r98808538 --- Diff: NOTICE --- @@ -3,3 +3,6 @@ Copyright 2017 The Apache Software Foundation. This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + +This product includes software from the --- End diff -- Ok good, we only need to declare the ANTLR bundling in the binary distribution then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #377: GEODE-1435: Adds binary distribution licensing.
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/377#discussion_r98800020 --- Diff: dist/LICENSE --- @@ -0,0 +1,390 @@ + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work
[GitHub] geode pull request #377: GEODE-1435: Adds binary distribution licensing.
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/377#discussion_r98806425 --- Diff: dist/LICENSE --- @@ -0,0 +1,390 @@ + Apache License + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work
[GitHub] geode pull request #377: GEODE-1435: Adds binary distribution licensing.
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/377#discussion_r98800742 --- Diff: NOTICE --- @@ -3,3 +3,6 @@ Copyright 2017 The Apache Software Foundation. This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + +This product includes software from the --- End diff -- Is ANTLR bundled in the source distribution? If so, it should be declared in the associated `LICENSE`. If not, this should be removed. Also, see comments on `NOTICE` for binary distribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #353: GEODE-2269 update to allow region entries non null ...
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/353#discussion_r97697959 --- Diff: .gitignore --- @@ -12,6 +12,12 @@ build/ .idea/ build-eclipse/ /tags +bin +runtime --- End diff -- Thanks for the contribution! Did you mean to include the `.gitignore` changes in this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #342: GEODE-2309: Replace Pivotal Copyright and add Apache Licen...
Github user metatype commented on the issue: https://github.com/apache/geode/pull/342 LGTM, these changes typically take multiple iterations to get right. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu
Github user metatype commented on the issue: https://github.com/apache/geode/pull/344 Any further discussion? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #343: GEODE-1435 Update LICENCE and NOTICE
GitHub user metatype opened a pull request: https://github.com/apache/geode/pull/343 GEODE-1435 Update LICENCE and NOTICE This should cover the bundled source components. You can merge this pull request into a Git repository by running: $ git pull https://github.com/metatype/incubator-geode next-gen-native-client-software-grant Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #343 commit 7b926d214ecf3ef943d8a0e939829fe2542d081f Author: Anthony Baker <aba...@apache.org> Date: 2017-01-18T05:14:45Z GEODE-1435 Update LICENSE and NOTICE --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode-examples issue #2: Build updates for examples
Github user metatype commented on the issue: https://github.com/apache/geode-examples/pull/2 We have an ASF-developed `gradlew` script that does not require the `gradle-wrapper.jar` file to be present, unlike the version from the gradle distribution. We don't have an equivalent `gradlew.bat` script. It's really not *that* complicated, but more than I want to do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #341: GEODE-2306: Update native client BUILDING.md to ref...
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/341#discussion_r96437308 --- Diff: src/BUILDING.md --- @@ -17,7 +22,7 @@ * C++11 compiler *(see platform specific requirements)* ### Optional Tools -* [Doxygen 8.11](http://www.stack.nl/~dimitri/doxygen/download.html) *(If building source documentation)* +* [Doxygen 8.11](http://www.stack.nl/~dimitri/doxygen/download.html) *(for building source documentation)* --- End diff -- I found that doxygen was required in order to run `cmake ../src`. If it wasn't installed cmake died. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #330: [GEODE-2227] AutoSerializableJUnitTest.testMultiple...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode/pull/330#discussion_r94783782
--- Diff:
geode-core/src/test/java/org/apache/geode/pdx/AutoSerializableJUnitTest.java ---
@@ -1291,7 +1289,8 @@ public void testMultipleClassLoaders() throws
Exception {
List urls = new ArrayList();
String classPathStr = System.getProperty("java.class.path");
if (classPathStr != null) {
- String[] cpList = classPathStr.split(":");
+ String[] cpList =
--- End diff --
You can avoid the ternary operator by using
`System.getProperty("path.separator")`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #325: merge new version
Github user metatype commented on the issue: https://github.com/apache/geode/pull/325 Thanks for the contribution. However, I'm currently -1 until you clarify the purpose of the change and follow some of the recommendations included in our project contribution guidelines such as: - You need to file a JIRA for any change to the code base. This helps drive discussion / consensus and makes it easy to do release notes. - Separate code reformatting changes from actual logic changes. This makes it easier to review. - Don't include \@author tags - Use `git rebase -i` to squash commits like 'this is a test'. We only want to see useful commits in our git history - We use spotless to manage the source code formatting. If you want to change the format, please start a discussion on the dev@geode list. See the wiki pages for more details: https://cwiki.apache.org/confluence/display/GEODE/How+to+Contribute Thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] geode pull request #321: [GEODE-1577] Unhelpful generic types on Execution.e...
Github user metatype commented on a diff in the pull request: https://github.com/apache/geode/pull/321#discussion_r93149349 --- Diff: geode-core/src/main/java/org/apache/geode/cache/execute/Execution.java --- @@ -89,7 +89,7 @@ * * @since GemFire 6.0 */ - public ResultCollector execute(String functionId) throws FunctionException; + public <T, S> ResultCollector<T, S> execute(String functionId) throws FunctionException; --- End diff -- Since this is a public API, you should describe the params in javadoc when it's not obvious what T and S refer to. You can use the `@param` tag as seen in [1]. [1] https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/cache/snapshot/RegionSnapshotService.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #295: [GEODE-1984] #comment Fix Issue Make GatewaySend...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/295 Sorry, I meant to write "I delete the remote branch for you". :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #295: [GEODE-1984] #comment Fix Issue Make GatewaySend...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/295 `git push origin --delete feature/GEODE-1984`. You should also confirm that you've deleted the branch from your _local_ repo (`git branch -D feature/GEODE-1984`). Are you still having problems with write access? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #275: [GEODE-1871] - Updating and cleaning up Dockerfi...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/275 Is this ready to be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025623
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatisticsMonitor.java
---
@@ -114,14 +100,14 @@ protected void monitor(long millisTimeStamp,
List resourceInst
private final void monitorStatisticIds(long millisTimeStamp,
List resourceInstances) {
-List statisticIdsToMonitor = statisticIds;
+ConcurrentHashSet statisticIdsToMonitor = statisticIds;
if (!statisticIdsToMonitor.isEmpty()) {
// TODO:
}
}
protected final void notifyListeners(StatisticsNotification
notification) {
-List listenersToNotify = this.listeners;
+ConcurrentHashSet listenersToNotify =
this.listeners;
--- End diff --
I don't think this copy is needed since `listeners` is never updated after
initialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/299#discussion_r90025760
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
---
@@ -110,7 +100,7 @@ public void sampled(long nanosTimeStamp,
List resourceInstance
}
private void monitor(final long sampleTimeMillis, final
List resourceInstance) {
-List currentMonitors =
StatMonitorHandler.this.monitors;
+ConcurrentHashSet currentMonitors =
StatMonitorHandler.this.monitors;
--- End diff --
I don't think this copy is needed since `monitors` is never updated after
initialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #299: [ GEODE-2141 ] #comment Fix Issue #2141
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/299#discussion_r90025277 --- Diff: geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java --- @@ -38,7 +37,8 @@ private final boolean enableMonitorThread; /** The registered monitors */ - private volatile List monitors = Collections.emptyList(); + private volatile ConcurrentHashSet monitors = --- End diff -- Instead of `volatile` I think this should be final. I don't see a write to this var after initialization. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #295: [GEODE-1984] #comment Fix Issue Make GatewaySend...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/295 @davinash I think you merged `master` into your feature branch. I suggest closing this PR and starting a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/291 @davinash I think you merged `master` into your feature branch. I suggest closing this PR and starting a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r89132685
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/BugGeode_1653DUnitTest.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.*;
+import org.apache.geode.cache.client.internal.LocatorTestBase;
+import org.apache.geode.cache.execute.Execution;
+import org.apache.geode.cache.execute.Function;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePort;
+import org.apache.geode.internal.cache.functions.TestFunction;
+import org.apache.geode.test.dunit.Assert;
+import org.apache.geode.test.dunit.Host;
+import org.apache.geode.test.dunit.NetworkUtils;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Created by amey on 22/11/16.
+ */
+@Category(DistributedTest.class)
+public class BugGeode_1653DUnitTest extends LocatorTestBase {
+
+ public BugGeode_1653DUnitTest() {
+super();
+ }
+
+ @Override
+ public final void postSetUp() throws Exception {
+disconnectAllFromDS();
+ }
+
+ @Override
+ protected final void postTearDownLocatorTestBase() throws Exception {
+disconnectAllFromDS();
+ }
+
+ @Test
+ public void testBugGeode_1653() {
+
+// Test case for Executing a fire-and-forget function on all servers
as opposed to only
+// executing on the ones the
+// client is currently connected to.
+
+Host host = Host.getHost(0);
+VM locator = host.getVM(0);
+VM server1 = host.getVM(1);
+VM server2 = host.getVM(2);
+VM client = host.getVM(3);
+
+final int locatorPort =
AvailablePort.getRandomAvailablePort(AvailablePort.SOCKET);
+final String locatorHost = NetworkUtils.getServerHostName(host);
+
+// Step 1. Start a locator and one cache server.
+locator.invoke("Start Locator", () -> startLocator(locatorHost,
locatorPort, ""));
+
+String locString = getLocatorString(host, locatorPort);
+
+// Step 2. Start a server and create a replicated region "R1".
+server1.invoke("Start BridgeServer",
+() -> startBridgeServer(new String[] {"R1"}, locString, new
String[] {"R1"}));
+
+// Step 3. Create a client cache with pool mentioning locator.
+client.invoke("create client cache and pool mentioning locator", () ->
{
+ ClientCacheFactory ccf = new ClientCacheFactory();
+ ccf.addPoolLocator(locatorHost, locatorPort);
+ ClientCache cache = ccf.create();
+ Pool pool1 = PoolManager.createFactory().addLocator(locatorHost,
locatorPort)
+ .setServerGroup("R1").create("R1");
+
+ Region region1 =
cache.createClientRegionFactory(ClientRegionShortcut.PROXY).setPoolName("R1")
+ .create("R1");
+
+ // Step 4. Execute the function to put DistributedMemberID into
above created replicated
+ // region.
+ Function function = new TestFunction(false,
TestFunction.TEST_FUNCTION_1653);
+ FunctionService.registerFunction(function);
+
+ String regionName = "R1";
+ Execution dataSet = FunctionService.onServers(pool1);
+ dataSet.withArgs(regionName).execute(function);
+ Thread.sleep(1000);
--- End diff --
Using explicit thread sleep calls in tests is not recommended as this will
cause the test to sporadically fail. Here's an example of changing a sleep to
a condition:
https://git-wip-us.apache.o
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781178
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -1493,6 +1495,7 @@ public Result startServer(
help = CliStrings.START_SERVER__PASSWORD__HELP) String
passwordToUse)
// NOTICE: keep the parameters in alphabetical order based on their
CliStrings.START_SERVER_* text
{
+System.out.println("GEODE_HOME = " + GEODE_HOME);
--- End diff --
Please remove print statement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #291: [GEODE-1122] Fixed Dependency on environm...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/291#discussion_r88781054
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/AgentUtil.java ---
@@ -52,7 +52,7 @@ public AgentUtil(String gemfireVersion) {
*geode-web-api
*/
public String findWarLocation(String warFilePrefix) {
-String gemfireHome = getGemFireHome();
+String gemfireHome = getGeodeHome();
--- End diff --
Can you update the above javadocs with GEODE_HOME instead of GEMFIRE?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
