Re: [DISCUSS] CODEOWNERS mechanism feedback

2021-03-25 Thread Nabarun Nag
We will get these approved as soon as possible. Regards, Nabarun From: Mario Ivanac Sent: Thursday, March 25, 2021 4:17 AM To: dev@geode.apache.org Subject: Odg: [DISCUSS] CODEOWNERS mechanism feedback Hi all, just to remind on this topic. Could we expand

Odg: [DISCUSS] CODEOWNERS mechanism feedback

2021-03-25 Thread Mario Ivanac
Šalje: Anthony Baker Poslano: 17. ožujka 2021. 18:08 Prima: dev@geode.apache.org Predmet: Re: [DISCUSS] CODEOWNERS mechanism feedback I think for an active, healthy project community we need to balance two things that are somewhat oppositional: make it easy

Re: [DISCUSS] CODEOWNERS mechanism feedback

2021-03-17 Thread Anthony Baker
I think for an active, healthy project community we need to balance two things that are somewhat oppositional: make it easy to contribute and ensure the project meets the needs of our users for stability and robust behaviors in the face of failures. > On Mar 17, 2021, at 9:45 AM, Jacob

Re: [DISCUSS] CODEOWNERS mechanism feedback

2021-03-17 Thread Jacob Barrett
> On Mar 17, 2021, at 9:38 AM, Nabarun Nag wrote: > > "the review process is taking longer now. " > I agree that the review process is taking a bit longer, but that is the price > I believe needs to be paid to improve the probability of good quality code is > being merged to Geode. More

Re: [DISCUSS] CODEOWNERS mechanism feedback

2021-03-17 Thread Anthony Baker
Hi Alberto! I haven’t looked at PR review throughput metrics. I know that is certainly an interesting measure to keep an eye on w.r.t to the CODEOWNERS / CODEWATCHERS processes. I think another equally interesting metric is the “quality” of PR reviews. This is difficult to measure but you

Re: [DISCUSS] CODEOWNERS mechanism feedback

2021-03-17 Thread Nabarun Nag
Apache Geode. Regards Nabarun From: Alberto Gomez Sent: Wednesday, March 17, 2021 8:46 AM To: dev@geode.apache.org Subject: [DISCUSS] CODEOWNERS mechanism feedback Hi, It's been more than two months since the CODEOWNERS file has been in place to automatically add reviewers to pul

[DISCUSS] CODEOWNERS mechanism feedback

2021-03-17 Thread Alberto Gomez
Hi, It's been more than two months since the CODEOWNERS file has been in place to automatically add reviewers to pull requests. While we have seen the great benefit of having the experts in the matter being automatically assigned as reviewers to each pull request, I have the feeling that the