[GitHub] geode pull request #565: GEODE-3021: Any call after the first to setPdxStrin...

[jhuynh1]

Github user jhuynh1 closed the pull request at:

https://github.com/apache/geode/pull/565


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #565: GEODE-3021: Any call after the first to setPdxStrin...

[jhuynh1]

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/565#discussion_r121196596
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
 ---
@@ -2002,7 +2002,8 @@ void populateListForEquiJoin(List list, Object 
outerEntries, Object innerEntries
*/
   synchronized void setPdxStringFlag(Object key) {
 // For Null and Undefined keys do not set the isIndexedPdxKeysFlagSet 
flag
-if (key == null || key == IndexManager.NULL || key == 
QueryService.UNDEFINED) {
+if (isIndexedPdxKeysFlagSet || key == null || key == IndexManager.NULL
--- End diff --

They are slightly different.  The isIndexedPdxKeys is represents whether 
the index is storing pdx as keys. The isIndexedPdxKeysFlagSet, is a boolean 
that is used as a short circuit to only call the method once.  I guess it was a 
performance "enhancement" to not call the method over and over for every value 
and just call it only for the first call.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #565: GEODE-3021: Any call after the first to setPdxStrin...

[kirklund]

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/565#discussion_r121195985
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
 ---
@@ -2002,7 +2002,8 @@ void populateListForEquiJoin(List list, Object 
outerEntries, Object innerEntries
*/
   synchronized void setPdxStringFlag(Object key) {
 // For Null and Undefined keys do not set the isIndexedPdxKeysFlagSet 
flag
-if (key == null || key == IndexManager.NULL || key == 
QueryService.UNDEFINED) {
+if (isIndexedPdxKeysFlagSet || key == null || key == IndexManager.NULL
--- End diff --

Looks like you have two flags for the same thing... isIndexedPdxKeys and 
isIndexedPdxKeysFlagSet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #565: GEODE-3021: Any call after the first to setPdxStrin...

[jhuynh1]

GitHub user jhuynh1 opened a pull request:

https://github.com/apache/geode/pull/565

GEODE-3021: Any call after the first to setPdxStringFlag should no-op

  * The flag isIndexedPdxKeysFlagSet is now checked before setting pdx 
string flag

@nabarunnag @ladyVader 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3021

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #565


commit c2943a4acb9c9325662a4cbee14823e0a1c05061
Author: Jason Huynh 
Date:   2017-06-01T20:52:41Z

GEODE-3021: Any call after the first to setPdxStringFlag should no-op

  * The flag isIndexedPdxKeysFlagSet is now checked before setting pdx 
string flag




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---