Build failed in Jenkins: Geode-nightly #302

2015-12-04 Thread Apache Jenkins Server
See Changes: [hiteshk25] With disable tcp(udp) now we don't throttle serial executor queue [hiteshk25] Added GMSJoinLeave tests [huynhja] Adding additional unit tests for GMSHealthMonitor and GMSJoinLeave Moved [dschneider] GEODE-626:

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #148 was SUCCESSFUL (with 1227 tests)

2015-12-04 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #148 was successful. --- Scheduled 1231 tests in total. https://build.spring.io/browse/SGF-NAG-148/ -- This

Re: removing the license from jgroups configuration files

2015-12-04 Thread Roman Shaposhnik
On Fri, Dec 4, 2015 at 10:59 AM, Dan Smith wrote: > If it really comes to it, we could optimize the xml files as part of the > build process. So the checked in code would have the comments, formatting, > etc. but the version in the jar would be stripped. I think this is the bare minimum that coul

Re: removing the license from jgroups configuration files

2015-12-04 Thread Roman Shaposhnik
On Fri, Dec 4, 2015 at 9:35 AM, Bruce Schuchardt wrote: > Well, we don't have it in the log4j2.xml configuration file so I don't see > why we need it in the JGroups configuration file. I'm afraid that while log4j2.xml configuration file clearly fits the description of 'lack of creativity' the JG

Re: Review Request 40997: GMS - new unit tests for JGroupsMessenger

2015-12-04 Thread Bruce Schuchardt
> On Dec. 5, 2015, 12:35 a.m., anilkumar gingade wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/JoinResponseMessage.java, > > line 117 > > > > > > Does this h

Re: removing the license from jgroups configuration files

2015-12-04 Thread Edin Zulich
+1 for the sake of keeping it simple... …or, alternatively (if we cannot keep it simple), Dan’s solution for stripping out the extraneous text. Edin > On Dec 4, 2015, at 12:12 PM, Bruce Schuchardt wrote: > > +1 > > Le 12/4/2015 10:44 AM, Anilkumar Gingade a écrit : >> Agree with Jacob... >>

Review Request 41005: GEODE-626: add unit test coverage for MemoryChunk methods

2015-12-04 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41005/ --- Review request for geode, Eric Shu and Scott Jewell. Bugs: GEODE-626 https:

Re: Review Request 40997: GMS - new unit tests for JGroupsMessenger

2015-12-04 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40997/#review109061 --- gemfire-core/src/main/java/com/gemstone/gemfire/distributed/intern

Review Request 40997: GMS - new unit tests for JGroupsMessenger

2015-12-04 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40997/ --- Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, Jianx

[GitHub] incubator-geode pull request: Verified preceding content merges, f...

2015-12-04 Thread davebarnes97
GitHub user davebarnes97 opened a pull request: https://github.com/apache/incubator-geode/pull/47 Verified preceding content merges, fixed a couple of typos. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davebarnes97/incubator-

Re: removing the license from jgroups configuration files

2015-12-04 Thread Bruce Schuchardt
+1 Le 12/4/2015 10:44 AM, Anilkumar Gingade a écrit : Agree with Jacob... -Anil. On Fri, Dec 4, 2015 at 10:14 AM, Jacob Barrett wrote: WHAT FILES IN AN APACHE RELEASE DO NOT REQUIRE A LICENSE HEADER? A file without any degree of creativity in either its literal elements or its structure i

Re: Review Request 40932: GEODE-622: improve OffHeapStorage unit test coverage

2015-12-04 Thread Scott Jewell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40932/#review109020 --- Ship it! Ship It! - Scott Jewell On Dec. 3, 2015, 10:57 p.m., D

Re: Review Request 40886: Adding additional unit tests for GMSHealthMonitor and GMSJoinLeave

2015-12-04 Thread Jason Huynh
> On Dec. 4, 2015, 12:47 a.m., Bruce Schuchardt wrote: > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java, > > line 462 > > > > > > add socket.c

Re: removing the license from jgroups configuration files

2015-12-04 Thread Dan Smith
If it really comes to it, we could optimize the xml files as part of the build process. So the checked in code would have the comments, formatting, etc. but the version in the jar would be stripped. -Dan On Fri, Dec 4, 2015 at 10:44 AM, Anilkumar Gingade wrote: > Agree with Jacob... > > -Anil.

Re: removing the license from jgroups configuration files

2015-12-04 Thread Anilkumar Gingade
Agree with Jacob... -Anil. On Fri, Dec 4, 2015 at 10:14 AM, Jacob Barrett wrote: > WHAT FILES IN AN APACHE RELEASE DO NOT REQUIRE A LICENSE HEADER? > > A file without any degree of creativity in either its literal elements or > its structure is not protected by copyright law; therefore, such a

Review Request 40977: GEODE-563: Moving gfsh tests from closed

2015-12-04 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40977/ --- Review request for geode. Repository: geode Description --- GEODE-563: M

[GitHub] incubator-geode pull request: GEODE-341: Refactor Java packages to...

2015-12-04 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the pull request: https://github.com/apache/incubator-geode/pull/46#issuecomment-162040088 The only changes that should be in this pull request for GEODE-341 are the changes specific to this issue. Only the package names should be changed in t

[jira] [Commented] (GEODE-341) Refactor Java packages to reflect Apache organization

2015-12-04 Thread Juan José Ramos
Thanks Jens and Vincent, I must read carefully about the license stuff, I thought it was just another project and so I included the files directly. Regarding geode dependency, I knew it was for testing purposes but currently there are not tests using those classes so I decided to remove the depend

Re: removing the license from jgroups configuration files

2015-12-04 Thread Jacob Barrett
WHAT FILES IN AN APACHE RELEASE DO NOT REQUIRE A LICENSE HEADER? A file without any degree of creativity in either its literal elements or its structure is not protected by copyright law; therefore, such a file does not require a license header. If in doubt about the extent of the file's creati

[GitHub] incubator-geode pull request: GEODE-341: Refactor Java packages to...

2015-12-04 Thread vfordpivotal
Github user vfordpivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/46#issuecomment-162039056 A number of the pom.xml dependencies removed will need to be re-added as they will be needed for testing (creating stats files...) which at present is missi

Re: removing the license from jgroups configuration files

2015-12-04 Thread Anthony Baker
Here’s the policy: http://www.apache.org/legal/src-headers.html Anthony > On Dec 4, 2015, at 10:03 AM, Jacob Barrett wrote: > > Do we really need to be adding licensing and copyright notices to config > files? > > > > > — > > Jacob Barrett > Manager > GemFire Advanced Customer Engineerin

[GitHub] incubator-geode pull request: GEODE-341: Refactor Java packages to...

2015-12-04 Thread jdeppe-pivotal
Github user jdeppe-pivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/46#issuecomment-162037193 A couple of things: - The MultiAxisChartFX class is GPL code and cannot have an Apache 2.0 license attached to it. This is the reason this code wa

Re: removing the license from jgroups configuration files

2015-12-04 Thread Jacob Barrett
Do we really need to be adding licensing and copyright notices to config files? — Jacob Barrett  Manager  GemFire Advanced Customer Engineering (ACE)  Pivotal jbarr...@pivotal.io  503-533-3763 For immediate support please contact Pivotal Support at  http://support.pivotal.io/ On Fri, Dec 4,

Re: removing the license from jgroups configuration files

2015-12-04 Thread Anthony Baker
It’s going to be added there too :-) GEODE-18 is still WIP. Anthony > On Dec 4, 2015, at 9:35 AM, Bruce Schuchardt wrote: > > Well, we don't have it in the log4j2.xml configuration file so I don't see > why we need it in the JGroups configuration file. > > Le 12/3/2015 6:34 PM, Roman Shapos

Regarding integrated security - GEODE-17

2015-12-04 Thread Jens Deppe
Greetings. A while back work was done to implement the Integrated Security spec as described here [1]. This work is currently sitting in branch feature/GEODE-17. It includes changes for JMX security, REST security and, by ext

Re: Regarding integrated security - GEODE-17

2015-12-04 Thread John Blum
+1 for Spring Security On Fri, Dec 4, 2015 at 9:36 AM, William Markito wrote: > Huge +1 for using Shiro / Spring Security and moving to a standard security > model. > > On Fri, Dec 4, 2015 at 9:33 AM, Jens Deppe wrote: > > > Greetings. > > > > A while back work was done to implement the Integra

Re: Regarding integrated security - GEODE-17

2015-12-04 Thread William Markito
Huge +1 for using Shiro / Spring Security and moving to a standard security model. On Fri, Dec 4, 2015 at 9:33 AM, Jens Deppe wrote: > Greetings. > > A while back work was done to implement the Integrated Security spec as > described here >

Re: removing the license from jgroups configuration files

2015-12-04 Thread Bruce Schuchardt
Well, we don't have it in the log4j2.xml configuration file so I don't see why we need it in the JGroups configuration file. Le 12/3/2015 6:34 PM, Roman Shaposhnik a écrit : Is this really that big of a deal? I presume this affects startup only. Thanks, Roman.

[GitHub] incubator-geode pull request: GEODE-341: Refactor Java packages to...

2015-12-04 Thread jujoramos
GitHub user jujoramos opened a pull request: https://github.com/apache/incubator-geode/pull/46 GEODE-341: Refactor Java packages to reflect Apache organization. - Root project is now "geode-jvsd". - Root package is now "org.apache.geode.jvsd". - Classes from Multi

[GitHub] incubator-geode pull request: GEODE-341: Refactor Java packages to...

2015-12-04 Thread jujoramos
Github user jujoramos closed the pull request at: https://github.com/apache/incubator-geode/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] incubator-geode pull request: GEODE-341: Refactor Java packages to...

2015-12-04 Thread jujoramos
GitHub user jujoramos opened a pull request: https://github.com/apache/incubator-geode/pull/45 GEODE-341: Refactor Java packages to reflect Apache organization. - Root project is now "geode-jvsd". - Root package is now "org.apache.geode.jvsd". - Classes from MultiAxisChartFX