Re: Next steps with flickering tests

2016-04-25 Thread Anthony Baker
Thanks Kirk! ~/code/incubator-geode (develop)$ grep -ro "FlakyTest.class" . | grep -v Binary | wc -l | xargs echo "Flake factor:" Flake factor: 136 Anthony > On Apr 25, 2016, at 9:45 PM, William Markito wrote: > > +1 > > Are we also planning to automate the additional

Re: Next steps with flickering tests

2016-04-25 Thread William Markito
+1 Are we also planning to automate the additional build task somehow ? I'd also suggest creating a wiki page with some stats (like how many FlakyTests we currently have) and the idea behind this effort so we can keep track and see how it's evolving over time. On Mon, Apr 25, 2016 at 6:54 PM,

Re: Next steps with flickering tests

2016-04-25 Thread Kirk Lund
That would probably work for any test that doesn't require @FixMethodOrder, but I think we only have half a dozen of those and I believe those are IntegrationTests (no DistributedTests). -Kirk On Mon, Apr 25, 2016 at 7:19 PM, Udo Kohlmeyer wrote: > +1 on forkEvery1. > >

Next steps with flickering tests

2016-04-25 Thread Kirk Lund
After completing GEODE-1233, all currently known flickering tests are now annotated with our FlakyTest JUnit Category. In an effort to divide our build up into multiple build pipelines that are sequential and dependable, we could consider excluding FlakyTests from the primary integrationTest and

Review Request 46668: putAll and removeAll getEventForPosition no longer marked as retained

2016-04-25 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46668/ --- Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.

Re: Review Request 46662: remove TODO OFFHEAP comments

2016-04-25 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46662/#review130522 --- Fix it, then Ship it!

Re: @since tags in our javadocs - old gemfire vs. geode versions

2016-04-25 Thread Darrel Schneider
+1 for having on explicit GemFire and Geode On Mon, Apr 25, 2016 at 4:43 PM, Kenneth Howe wrote: > +1 to “gemFire x.y.z” > > Adding the GemFire makes it obvious where the feature came from, no > inference > required as would happen if we left just a version number for old

Re: @since tags in our javadocs - old gemfire vs. geode versions

2016-04-25 Thread Kenneth Howe
+1 to “gemFire x.y.z” Adding the GemFire makes it obvious where the feature came from, no inference required as would happen if we left just a version number for old @since annotations. Ken > On Apr 25, 2016, at 4:39 PM, Kirk Lund wrote: > > +1 for @since Geode 1.0.0 > >

Re: @since tags in our javadocs - old gemfire vs. geode versions

2016-04-25 Thread Kirk Lund
+1 for @since Geode 1.0.0 If we keep the pre-existing @since tags, then I'd prefer to add "GemFire" to them for better clarity. Thus, @since 4.0.0 would be changed to @since GemFire 4.0.0. Just my preference. -Kirk On Mon, Apr 25, 2016 at 4:32 PM, Sai Boorlagadda

Re: Build failed in Jenkins: Geode-nightly #445

2016-04-25 Thread Kirk Lund
Is there any way to get a thread dump for a hung test from the ASF Jenkins? The only waits that this test performs are polling a condition with a timeout. If it hung, then I'm concerned there might have been a deadlock of some sort. -Kirk On Fri, Apr 22, 2016 at 10:54 AM, Dan Smith

Re: @since tags in our javadocs - old gemfire vs. geode versions

2016-04-25 Thread Sai Boorlagadda
+1 for Geode 1.0.0 And we can leave current @since tags as-is with out "GemFire" to denote predate Geode. So if you see "Geode x.y.z" => added in Geode or "x.y.z" => Predate to Geode (i.e.,) GemFire. On Fri, Apr 22, 2016 at 3:37 PM, John Blum

Re: Review Request 46590: GEODE-1237 remove the check for network-partition-detection uniformity

2016-04-25 Thread Jianxia Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46590/#review130514 --- Ship it! Ship It! - Jianxia Chen On April 22, 2016, 10:29

Re: Review Request 46660: GEODE-1278: Catch and translate CacheCLosedException

2016-04-25 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46660/#review130508 ---

Review Request 46660: GEODE-1278: Catch and translate CacheCLosedException

2016-04-25 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46660/ --- Review request for geode. Repository: geode Description --- Catch the

Re: Review Request 46655: GEODE-1288: Correct entry expiration detection logic error

2016-04-25 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46655/#review130505 --- Fix it, then Ship it! After addressing this issue and doing

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #290 has FAILED

2016-04-25 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #290 failed. --- Scheduled No failed tests found, a possible compilation error.

Review Request 46636: GEODE-1293: Updating module scripts and structure

2016-04-25 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46636/ --- Review request for geode, anilkumar gingade, Jason Huynh, nabarun nag, and Dan

Re: Review Request 46590: GEODE-1237 remove the check for network-partition-detection uniformity

2016-04-25 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46590/#review130494 --- Ship it! Ship It! - Udo Kohlmeyer On April 22, 2016, 10:29

Review Request 46655: GEODE-1288: Correct entry expiration detection logic error

2016-04-25 Thread Scott Jewell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46655/ --- Review request for geode. Repository: geode Description --- GEODE-1288:

Re: Review Request 46625: when there're multiple cache servers on the same jvm, keep the first proxy for the each client

2016-04-25 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46625/#review130480 ---

Re: Review Request 46590: GEODE-1237 remove the check for network-partition-detection uniformity

2016-04-25 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46590/#review130459 --- Ship it! Ship It! - Hitesh Khamesra On April 22, 2016,

Build failed in Jenkins: Geode-nightly #449

2016-04-25 Thread Apache Jenkins Server
See -- [...truncated 537 lines...] :geode-joptsimple:assemble :geode-joptsimple:compileTestJava UP-TO-DATE :geode-joptsimple:processTestResources UP-TO-DATE :geode-joptsimple:testClasses UP-TO-DATE

Review Request 46625: when there're multiple cache servers on the same jvm, keep the first proxy for the each client

2016-04-25 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46625/ --- Review request for geode and anilkumar gingade. Bugs: GEODE-1183