Re: Review Request 46706: GEODE-1259: Upgrade gradle version to 2.12

2016-04-26 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46706/#review130715 --- Ship it! Ship It! - Mark Bretl On April 26, 2016, 4:12

Re: Review Request 46636: GEODE-1293: Updating module scripts and structure

2016-04-26 Thread Dick Cavender
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46636/#review130699 --- In earlier versions the rpm used these scripts. We need to make

Re: Review Request 46636: GEODE-1293: Updating module scripts and structure

2016-04-26 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46636/#review130695 --- Ship it! I'm not quite sure what this modify_war script is all

Re: @since tags in our javadocs - old gemfire vs. geode versions

2016-04-26 Thread Dan Smith
I think they may be helpful in the public API - to be able to tell if you are using a feature that has been around for a while, or to realize what version you need to upgrade to in order to get a feature. -Dan On Tue, Apr 26, 2016 at 4:12 PM, Udo Kohlmeyer wrote: > Just

Review Request 46706: GEODE-1259: Upgrade gradle version to 2.12

2016-04-26 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46706/ --- Review request for geode, Anthony Baker, anilkumar gingade, Barry Oglesby, Mark

Re: Review Request 46706: GEODE-1259: Upgrade gradle version to 2.12

2016-04-26 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46706/#review130687 --- Ship it! Ship It! - Dan Smith On April 26, 2016, 11:12

Re: @since tags in our javadocs - old gemfire vs. geode versions

2016-04-26 Thread Udo Kohlmeyer
Just for my own curiosity... why do we need the @since tag? What benefit does it provide the product/code? --Udo On 27/04/2016 7:43 am, Dan Smith wrote: It sounds like more people are in favor of Geode 1.0.0 and GemFire x.y.z, so I created bug GEODE-1316 to implement this change. -Dan On

[GitHub] incubator-geode pull request: GEODE-1262: Removed VM5-VM7 in Async...

2016-04-26 Thread upthewaterspout
Github user upthewaterspout commented on the pull request: https://github.com/apache/incubator-geode/pull/137#issuecomment-214898386 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #291 has FAILED

2016-04-26 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #291 failed. --- Scheduled No failed tests found, a possible compilation error.

Re: Next steps with flickering tests

2016-04-26 Thread Kirk Lund
I'm in favor of running the FlakyTests together at the end of precheckin using forkEvery 1 on them too. What about running two nightly builds? One that runs all the non-flaky UnitTests, IntegrationTests and DistributedTests. Plus another nightly build that runs only FlakyTests? We can run Jenkins

Re: Review Request 46660: GEODE-1278: Catch and translate CacheCLosedException

2016-04-26 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46660/#review130665 --- Ship it! Ship It! - Darrel Schneider On April 26, 2016,

Re: Next steps with flickering tests

2016-04-26 Thread Dan Smith
+1 for separating these out and running them with forkEvery 1. I think they should probably still run as part of precheckin and the nightly builds though. We don't want this to turn into essentially disabling and ignoring these tests. -Dan On Tue, Apr 26, 2016 at 10:28 AM, Kirk Lund

Re: Review Request 46668: putAll and removeAll getEventForPosition no longer marked as retained

2016-04-26 Thread Scott Jewell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46668/#review130651 --- Ship it! Ship It! - Scott Jewell On April 26, 2016, 12:46

Re: [Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #288 has FAILED

2016-04-26 Thread John Blum
Thanks Dan. Yeah, I think I will roll the version to 1.0.0-incubating.M2 for the time being. I cannot set the version to 1.0.0-incubating.M3 until *SDG with Apache Geode support* for 1.0.0-incubating.M2 has been released since I could inadvertently pick up changes meant for M3 in the SDG M2

Re: Next steps with flickering tests

2016-04-26 Thread Kirk Lund
There are quite a few test classes that have multiple test methods which are annotated with the FlakyTest category. More thoughts: In general, I think that if any given test fails intermittently then it is a FlakyTest. A good test should either pass or fail consistently. After annotating a test

Re: [Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #288 has FAILED

2016-04-26 Thread Dan Smith
I'm not sure why those snapshots went away. Maybe something automatically deleted the snapshot repo when M2 was released? But then yeah, I don't understand why those old snapshots are still there. In any case, it doesn't make sense to build off of M2 snapshots at this point because M2 is no

Re: Review Request 46660: GEODE-1278: Catch and translate CacheCLosedException

2016-04-26 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46660/ --- (Updated April 26, 2016, 5:11 p.m.) Review request for geode, Darrel

Re: Review Request 46668: putAll and removeAll getEventForPosition no longer marked as retained

2016-04-26 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46668/#review130646 --- Ship it! Ship It! - Ken Howe On April 26, 2016, 12:46 a.m.,

Re: Next steps with flickering tests

2016-04-26 Thread Jianxia Chen
+1 On Mon, Apr 25, 2016 at 6:54 PM, Kirk Lund wrote: > After completing GEODE-1233, all currently known flickering tests are now > annotated with our FlakyTest JUnit Category. > > In an effort to divide our build up into multiple build pipelines that are > sequential and

Review Request 46705: Integrated Security for JMX and commands

2016-04-26 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46705/ --- Review request for geode. Repository: geode Description --- integration

Build failed in Jenkins: Geode-nightly #450

2016-04-26 Thread Apache Jenkins Server
See Changes: [bschuchardt] GEODE-1237 remove the check for network-partition-detection uniformity [dbarnes] GEODE-54: Missing Javadocs -- [...truncated 481 lines...] :geode-web:war