Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Dave Barnes
I'm a fan of PDFs, too, for their searchability among other things. There's no process in place, yet, for generating a good-looking PDF from the Markdown sources. Something to put on the to-do list. Right now, HTML format is the best presentation. On Monday, October 17, 2016, William Markito

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread William Markito
IHMO, it would be really nice to ship a PDF version of the docs. About the examples, if we could package and ship sources only for that module, that would be cool as well. On Mon, Oct 17, 2016 at 5:21 PM, Dan Smith wrote: > Along these lines, should we distributing the

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Dan Smith
Along these lines, should we distributing the docs with the binary release? Or maybe just providing a link to them? The README.md shipped with 1.0.RC2 points to http://geode.docs.pivotal.io/ . What about geode-examples? Should that be part of the binary release? -Dan On Mon, Oct 17, 2016 at

Re: Review Request 52963: GEODE-388: Deprecating DynamicRegionFactory

2016-10-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52963/#review152995 --- Ship it! Ship It! - Jinmei Liao On Oct. 18, 2016, 12:06

Review Request 52963: GEODE-388: Deprecating DynamicRegionFactory

2016-10-17 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52963/ --- Review request for geode and Darrel Schneider. Repository: geode Description

Re: Review Request 52891: GEODE-538: Add check for persistent data recovery

2016-10-17 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52891/ --- (Updated Oct. 17, 2016, 11:15 p.m.) Review request for geode, anilkumar

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Karen Miller
@Anil: Without the fix that GEODE-1883 should bring, client caches only have 1 way of setting the security properties: do it via the callback. Once the fix is in, client caches should again have 2 ways of setting the security properties: 1. do it via the callback, or 2. place in a

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Anilkumar Gingade
+1 for release... On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade wrote: > Hi Karen, > > The fix still keeps the doc stating: > "a client will need to set its credential, composed of the two properties > `security-username` and `security-password`." > > What i see is,

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Anilkumar Gingade
Hi Karen, The fix still keeps the doc stating: "a client will need to set its credential, composed of the two properties `security-username` and `security-password`." What i see is, additional doc about setting the auth properties using callbacks Am i missing anything? -Anil. On Mon,

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Joey McAllister
@Roman: Nothing that I can think of, apart from giving the community time to offer feedback here (which, it looks like, is all positive). William Markito and I were able to build and test a local version of the website with the docs included. Based on the +1s here, I'd like to go ahead and push

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Mark Bretl
+1 On Mon, Oct 17, 2016 at 2:04 PM, Kirk Lund wrote: > +1 > > > On Mon, Oct 17, 2016 at 12:49 PM, Roman Shaposhnik > wrote: > > > On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker > wrote: > > > Since the geode docs have now been merged

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Kirk Lund
+1 On Mon, Oct 17, 2016 at 12:49 PM, Roman Shaposhnik wrote: > On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker wrote: > > Since the geode docs have now been merged to the develop branch, let’s > start > > hosting them on http://geode.apache.org.

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Niall Pemberton
+1 :) Niall On Mon, Oct 17, 2016 at 6:57 PM, Anthony Baker wrote: > Since the geode docs have now been merged to the develop branch, let’s > start hosting them on http://geode.apache.org. Thoughts? > > Anthony > > > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar

Re: Review Request 52949: GEODE-2009: apply FlakyTest category to testCreateAlterDestroyUpdatesSharedConfig

2016-10-17 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52949/#review152942 --- Ship it! Ship It! - Kevin Duling On Oct. 17, 2016, 12:18

Re: Review Request 52937: GEODE-2007: fix unchecked warnings

2016-10-17 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52937/#review152946 --- Ship it! Huzzah for reducing warnings! - Kevin Duling On

Re: Review Request 52956: GEODE-2011: add FlakyTest category to testNonPersistentServerRestartAutoSerializer

2016-10-17 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52956/#review152945 --- Ship it! Ship It! - Kevin Duling On Oct. 17, 2016, 1:03

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Karen Miller
+0 With GEODE-1883 being moved to a subsequent release, the just-donated docs are not-quite current with respect to how a client cache may set its credentials for authentication. I put in a fix for this on the develop branch:

Review Request 52956: GEODE-2011: add FlakyTest category to testNonPersistentServerRestartAutoSerializer

2016-10-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52956/ --- Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.

Re: Review Request 52891: GEODE-538: Add check for persistent data recovery

2016-10-17 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52891/#review152936 ---

Review Request 52937: GEODE-2007: fix unchecked warnings

2016-10-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52937/ --- Review request for geode, Jinmei Liao and Kevin Duling. Bugs: GEODE-2007

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Roman Shaposhnik
On Mon, Oct 17, 2016 at 10:57 AM, Anthony Baker wrote: > Since the geode docs have now been merged to the develop branch, let’s start > hosting them on http://geode.apache.org. Thoughts? Huge +1! Anything stopping you from pushing the first update and start maintaining it

Re: Review Request 52936: GEODE-2006: add FlakyTest category to testSelectCommand

2016-10-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52936/#review152931 --- Ship it! Ship It! - Jinmei Liao On Oct. 17, 2016, 5:59

Re: Review Request 52949: GEODE-2009: apply FlakyTest category to testCreateAlterDestroyUpdatesSharedConfig

2016-10-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52949/#review152930 --- Ship it! Ship It! - Jinmei Liao On Oct. 17, 2016, 7:18

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Jinmei Liao
+1 On Mon, Oct 17, 2016 at 12:05 PM, Dan Smith wrote: > +1 - I was going to ask about this on the release thread. Let's put them up > on geode.apache.org! > > -Dan > > On Mon, Oct 17, 2016 at 11:33 AM, Swapnil Bawaskar > wrote: > > > +1, It would be

Review Request 52949: GEODE-2009: apply FlakyTest category to testCreateAlterDestroyUpdatesSharedConfig

2016-10-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52949/ --- Review request for geode, Jinmei Liao and Kevin Duling. Bugs: GEODE-2009

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Dan Smith
+1 - I was going to ask about this on the release thread. Let's put them up on geode.apache.org! -Dan On Mon, Oct 17, 2016 at 11:33 AM, Swapnil Bawaskar wrote: > +1, It would be great to have this by the time we put the vote out on > general@incubator > > On Mon, Oct 17,

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Dan Smith
+1 Checked * signatures * maven repo with simple sample app * command line test through gfsh * built the source Checked it with this thing: https://github.com/upthewaterspout/geode-release-check On Mon, Oct 17, 2016 at 11:55 AM, William Markito wrote: > +1 > >

[GitHub] incubator-geode pull request #262: GEODE-2004: Create/update/delete query th...

2016-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread William Markito
+1 Checked SHA, signatures, build/run, sample app and command line testing through gfsh. On Mon, Oct 17, 2016 at 10:33 AM, Kirk Lund wrote: > +1 I think we should target GEODE-2004 and GEODE-1883 for a point release > after 1.0.0 > > > On Mon, Oct 17, 2016 at 9:46 AM, Jinmei

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread William Markito
+1 On Mon, Oct 17, 2016 at 11:33 AM, Swapnil Bawaskar wrote: > +1, It would be great to have this by the time we put the vote out on > general@incubator > > On Mon, Oct 17, 2016 at 10:59 AM, Joey McAllister > wrote: > > > Only a very enthusiastic

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Swapnil Bawaskar
+1, It would be great to have this by the time we put the vote out on general@incubator On Mon, Oct 17, 2016 at 10:59 AM, Joey McAllister wrote: > Only a very enthusiastic +1. :) > > On Mon, Oct 17, 2016 at 10:57 AM Anthony Baker wrote: > > > Since

Re: Review Request 52936: GEODE-2006: add FlakyTest category to testSelectCommand

2016-10-17 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52936/#review152920 --- Ship it! Ship It! - Kevin Duling On Oct. 17, 2016, 10:59

[GitHub] incubator-geode pull request #262: GEODE-2004: Create/update/delete query th...

2016-10-17 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/262 GEODE-2004: Create/update/delete query through rest api should requir… …e DATA:READ instead of DATA:WRITE You can merge this pull request into a Git repository by running: $ git

Re: Review Request 52931: GEODE-1993: allow LocatorServerStartupRule to save server's ports as well.

2016-10-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52931/#review152916 --- Ship it!

Re: Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Joey McAllister
Only a very enthusiastic +1. :) On Mon, Oct 17, 2016 at 10:57 AM Anthony Baker wrote: > Since the geode docs have now been merged to the develop branch, let’s > start hosting them on http://geode.apache.org. Thoughts? > > Anthony > > > On Oct 15, 2016, at 5:51 PM, Swapnil

Review Request 52936: GEODE-2006: add FlakyTest category to testSelectCommand

2016-10-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52936/ --- Review request for geode, Jinmei Liao and Kevin Duling. Bugs: GEODE-2006

Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Anthony Baker
Since the geode docs have now been merged to the develop branch, let’s start hosting them on http://geode.apache.org. Thoughts? Anthony > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar wrote: > > > The documentation on how to install and use Apache Geode are hosted >

Re: Review Request 52935: GEODE-2005: fix javadoc warning

2016-10-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52935/#review152911 --- Ship it! Ship It! - Jinmei Liao On Oct. 17, 2016, 5:44

Review Request 52935: GEODE-2005: fix javadoc warning

2016-10-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52935/ --- Review request for geode, Jinmei Liao and Kevin Duling. Bugs: GEODE-2005

Re: Review Request 52933: GEODE-1874: setNextNeighbor method allocates a HashSet on every p2p message received

2016-10-17 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52933/#review152910 --- Ship it! Ship It! - Bruce Schuchardt On Oct. 17, 2016, 5:18

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Kirk Lund
+1 I think we should target GEODE-2004 and GEODE-1883 for a point release after 1.0.0 On Mon, Oct 17, 2016 at 9:46 AM, Jinmei Liao wrote: > +0 > > This candidate does not include the fix for GEODE-2004 and GEODE-1883. It's > not a must fix though. > > On Sun, Oct 16, 2016 at

Review Request 52933: GEODE-1874: setNextNeighbor method allocates a HashSet on every p2p message received

2016-10-17 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52933/ --- Review request for geode, Bruce Schuchardt and Hitesh Khamesra. Repository:

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Jinmei Liao
+0 This candidate does not include the fix for GEODE-2004 and GEODE-1883. It's not a must fix though. On Sun, Oct 16, 2016 at 6:58 PM, Anthony Baker wrote: > +1 > > * Verified sha’s > * Verified signatures > * Verified tag signature > * Build and run from src distro > *

Re: Review Request 52896: GEODE-706 Fixed race condition between expiry thread and put thread.

2016-10-17 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52896/#review152895 ---

Re: Review Request 52931: GEODE-1993: allow LocatorServerStartupRule to save server's ports as well.

2016-10-17 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52931/#review152888 --- Ship it! Ship It! - Kevin Duling On Oct. 17, 2016, 8:10

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

2016-10-17 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52889/#review152890 --- Ship it! Ship It! - Kevin Duling On Oct. 14, 2016, 11:41

Review Request 52931: GEODE-1993: allow LocatorServerStartupRule to save server's ports as well.

2016-10-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52931/ --- Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund.