Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45993/#review128808 ---

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45993/ --- (Updated April 13, 2016, 7:39 p.m.) Review request for geode, Bruce

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

> On April 11, 2016, 4:44 p.m., Mark Bretl wrote: > > I agree that we should not be including test jars in our product lib. > > > > Also, was precheckin or Travis CI run on this change? It looks like tests > > not in Geode source were run to verify this change. The gradle change shall be

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

> On April 11, 2016, 3:43 p.m., Bruce Schuchardt wrote: > > geode-assembly/build.gradle, line 116 > > > > > > Is this modifying the assembled product's lib directory? > > Anthony Baker wrote: > I agree, doesn't

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45993/#review128155 --- I agree that we should not be including test jars in our product

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

> On April 11, 2016, 3:43 p.m., Bruce Schuchardt wrote: > > geode-assembly/build.gradle, line 116 > > > > > > Is this modifying the assembled product's lib directory? I agree, doesn't seem right to modify the

Re: Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45993/#review128137 --- geode-assembly/build.gradle (line 116)

Review Request 45993: GEODE-1201: Adding compileRuntimeLibs to geode-assembly for tests Amending bind address configuration for http-service-bind-address

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45993/ --- Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen.