Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131714 --- Ship it! - Bruce Schuchardt On May 4, 2016, 5:12 p.m.,

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131528 --- I like this a lot better

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/ --- (Updated May 3, 2016, 4:46 p.m.) Review request for geode, Bruce Schuchardt,

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

> On May 2, 2016, 11:06 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 1595 > > > > > > I still don't

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131408 ---

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/ --- (Updated May 2, 2016, 10:34 p.m.) Review request for geode, Bruce Schuchardt,

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131374 --- I think you should remove the hashset creation and just fix the

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

> On May 2, 2016, 12:29 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 1742 > > > > > > I don't think we

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131367 --- Ship it! Ship It! - Udo Kohlmeyer On May 2, 2016, 4:36

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

> On May 2, 2016, 7:29 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java, > > line 1699 > > > > > > I don't understand

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

> On May 2, 2016, 5:01 p.m., Bruce Schuchardt wrote: > > I can only see one place where this collection is being accessed outside of > > synchronization: waitForResults() returns it instead of a copy of the > > collection. > > > > Can't we just make a copy of the collection under

Re: Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/#review131330 --- I can only see one place where this collection is being accessed

Review Request 46896: GEODE-1327 GMSJoinLeave: got java.util.ConcurrentModificationException while updating log message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46896/ --- Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.