Build failed in Jenkins: Geode-nightly #634

2016-10-26 Thread Apache Jenkins Server
See Changes: [sbawaskar] Adding my PGP key to KEYS [jiliao] GEODE-2014: Upgrade Swagger libraries [dbarnes] GEODE-2023: Add Lucene documentation [dbarnes] GEODE-2023: update paths to Lucene docs [dschneider] GEODE-2026: fix flaky test

Re: Review Request 53214: GEODE-2040 Add to docs Tomcat 8.0 and 8.5 for HTTP Session Mgmt module

2016-10-26 Thread William Markito
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53214/#review153983 --- Ship it! Ship It! - William Markito On Oct. 26, 2016, 11:44

Re: [DISCUSS] Graduation

2016-10-26 Thread Bruce Schuchardt
+1 Le 10/25/2016 à 5:25 PM, Roman Shaposhnik a écrit : Hi! with the 1.0.0-incubating release officially out (huge kudos to the team!) I think it is time we officially start our graduation discussion. Process-wise graduation consists of drafting a board resolution, getting it approved by the

Re: Review Request 53190: [GEODE-2037] Update documentation links

2016-10-26 Thread Joey McAllister
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53190/#review153886 --- Ship it! Ship It! - Joey McAllister On Oct. 26, 2016, 3:12

Re: GEODE-2036 and documentation practices and procedures

2016-10-26 Thread Dave Barnes
3. If there's no hard-and-fast rule for *always* associating a JIRA with every change, then I agree with Anthony and Dan for typos and small changes. On Wed, Oct 26, 2016 at 9:19 AM, Dan Smith wrote: > 1) +1 > 2) +1 > > 3) > > I don’t see much value in creating an uber-JIRA

Review Request 53190: [GEODE-2037] Update documentation links

2016-10-26 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53190/ --- Review request for geode, Jinmei Liao, Joey McAllister, and Karen Miller.

Re: GEODE-2036 and documentation practices and procedures

2016-10-26 Thread Dan Smith
1) +1 2) +1 3) > I don’t see much value in creating an uber-JIRA for tracking minor doc changes. Why not skip it entirely? I agree with Anthony on this one, there's not much value in having some catch all JIRA for unrelated changes. -Dan On Tue, Oct 25, 2016 at 7:08 PM, Anthony Baker

[GitHub] incubator-geode pull request #271: Feature/geode 2014

2016-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 53168: GEODE-2030: security support for SDG

2016-10-26 Thread Jinmei Liao
> On Oct. 26, 2016, 9:39 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceTest.java, > > line 21 > > > > > > This should be: > > > > import

Re: CI failures due to JMX client heartbeat thread

2016-10-26 Thread Dan Smith
Just looking at a couple of these bugs, these are fatal level errors. Do you know what is causing them or what affect this might have? [fatal 2016/09/29 12:12:03.891 PDT tid=0x18d] (tid=397 msgId=39) No longer connected to cc6-co6.gemstone.com[27162]. -Dan On Wed, Oct 26, 2016 at 4:50 PM,

CI failures due to JMX client heartbeat thread

2016-10-26 Thread Bruce Schuchardt
We have 23 CI failure tickets concerning suspect strings from "JMX client heartbeat" threads. I think we should add this to ExpectedStrings.java and close these tickets. The suspect strings are coming from javax.management.remote.rmi.RMIConnector and I don't think there's anything we can do

Re: Review Request 53168: GEODE-2030: security support for SDG

2016-10-26 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53168/#review153964 --- You can add a new commit to this review with rbt post

Re: Review Request 53214: GEODE-2040 Add to docs Tomcat 8.0 and 8.5 for HTTP Session Mgmt module

2016-10-26 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53214/#review153966 --- Ship it! Ship It! - Dan Smith On Oct. 26, 2016, 11:44 p.m.,

Review Request 53214: GEODE-2040 Add to docs Tomcat 8.0 and 8.5 for HTTP Session Mgmt module

2016-10-26 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53214/ --- Review request for geode, William Markito and Dan Smith. Repository: geode

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-26 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/#review153965 --- Ship it! Ship It! - Darrel Schneider On Oct. 26, 2016, 2:45

Re: GEODE-2036 and documentation practices and procedures

2016-10-26 Thread Anthony Baker
Great! I’m much more comfortable with describing the process as CTR. Anthony > On Oct 26, 2016, at 12:31 PM, Karen Miller wrote: > > I would also like to add that the C-T-R model for small doc changes such as > typo corrections > sounds like a good model to follow. So,

Re: [DISCUSS] Graduation

2016-10-26 Thread Swapnil Bawaskar
+1 On Tuesday, October 25, 2016, Udo Kohlmeyer wrote: > +1 > > > On 25/10/16 5:43 pm, Joey McAllister wrote: > >> +1 >> >> On Tue, Oct 25, 2016 at 5:42 PM Anthony Baker wrote: >> >> +1 >>> >>> On Oct 25, 2016, at 5:25 PM, Roman Shaposhnik

Review Request 53199: GEODE-2000 ClientMemberShipListener at client should see server-bind-address in event memberId

2016-10-26 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53199/ --- Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. Bugs: geode-2000

Re: Review Request 53190: [GEODE-2037] Update documentation links

2016-10-26 Thread Karen Miller
> On Oct. 26, 2016, 6:35 p.m., Karen Miller wrote: > > Ship It! I checked each changed link to verify that there were no bad links. Note that for the change in file geode-site/website/content/releases/index.html to be applied, the website will need to be updated after commit. - Karen

Re: Review Request 53190: [GEODE-2037] Update documentation links

2016-10-26 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53190/#review153896 --- Ship it! Ship It! - Mark Bretl On Oct. 26, 2016, 8:12 a.m.,

Re: Review Request 53190: [GEODE-2037] Update documentation links

2016-10-26 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53190/#review153903 --- Ship it! Ship It! - Jinmei Liao On Oct. 26, 2016, 3:12

Re: Review Request 53190: [GEODE-2037] Update documentation links

2016-10-26 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53190/#review153920 --- Ship it! Ship It! - Karen Miller On Oct. 26, 2016, 3:12

Re: [DISCUSS] Graduation

2016-10-26 Thread Kirk Lund
+1 On Wed, Oct 26, 2016 at 8:59 AM, Bruce Schuchardt wrote: > +1 > > > Le 10/25/2016 à 5:25 PM, Roman Shaposhnik a écrit : > >> Hi! >> >> with the 1.0.0-incubating release officially out (huge kudos >> to the team!) I think it is time we officially start our graduation

Review Request 53198: GEODE-17: Fix a logical bug that prevents customers to set both Peer and Client authenticator

2016-10-26 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53198/ --- Review request for geode, Kevin Duling and Kirk Lund. Repository: geode

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-26 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/#review153908 ---

Re: GEODE-2036 and documentation practices and procedures

2016-10-26 Thread Joey McAllister
3. +1 to Anthony and Dan's recommendation not to use a catch-all JIRA. I think the idea was an attempt to fit within existing guidelines. If there's no requirement to use a JIRA here, let's not do it. On Wed, Oct 26, 2016 at 9:26 AM Dave Barnes wrote: > 3. If there's no

Re: Review Request 53168: GEODE-2030: security support for SDG

2016-10-26 Thread John Blum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53168/#review153913 ---

Re: [DISCUSS] Graduation

2016-10-26 Thread Ashvin A
+1 On Tue, Oct 25, 2016 at 5:25 PM, Roman Shaposhnik wrote: > inactive > microsoft.com (Ashvin) > :-(

Re: GEODE-2036 and documentation practices and procedures

2016-10-26 Thread Karen Miller
I would also like to add that the C-T-R model for small doc changes such as typo corrections sounds like a good model to follow. So, +1 to that. On Wed, Oct 26, 2016 at 10:20 AM, Karen Miller wrote: > Good by me to not have a catch-all JIRA. I've made one commit under it,

Re: Review Request 53150: GEODE-2024 Deadlock creating a new distributed lock service Grantor while transactions are in progress

2016-10-26 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53150/#review153925 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 25, 2016, 4:13

Re: Review Request 53199: GEODE-2000 ClientMemberShipListener at client should see server-bind-address in event memberId

2016-10-26 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53199/#review153926 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 26, 2016, 6:30

Re: [DISCUSS] Graduation

2016-10-26 Thread Mark Bretl
+1 On Wed, Oct 26, 2016 at 12:04 PM, Ashvin A wrote: > +1 > > On Tue, Oct 25, 2016 at 5:25 PM, Roman Shaposhnik wrote: > > > inactive > > microsoft.com (Ashvin) > > > > :-( >

Re: [DISCUSS] Graduation

2016-10-26 Thread Nabarun Nag
+1 On Wed, Oct 26, 2016 at 12:07 PM Mark Bretl wrote: > +1 > > On Wed, Oct 26, 2016 at 12:04 PM, Ashvin A wrote: > > > +1 > > > > On Tue, Oct 25, 2016 at 5:25 PM, Roman Shaposhnik > wrote: > > > > > inactive > > >

Re: [DISCUSS] Graduation

2016-10-26 Thread Michael Stolz
+1 -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Oct 25, 2016 8:25 PM, "Roman Shaposhnik" wrote: > Hi! > > with the 1.0.0-incubating release officially out (huge kudos > to the team!) I think it is time we officially start our graduation >

Re: Review Request 53150: GEODE-2024 Deadlock creating a new distributed lock service Grantor while transactions are in progress

2016-10-26 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53150/#review153944 --- Ship it! Ship It! - Darrel Schneider On Oct. 25, 2016, 9:13

Re: Review Request 53198: GEODE-17: Fix a logical bug that prevents customers to set both Peer and Client authenticator

2016-10-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53198/#review153943 --- Ship it! Ship It! - Kirk Lund On Oct. 26, 2016, 5:42 p.m.,

Re: Review Request 53168: GEODE-2030: security support for SDG

2016-10-26 Thread Jinmei Liao
> On Oct. 26, 2016, 6:20 p.m., John Blum wrote: > > geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java, > > line 454 > > > > > > Note, this assertion will only apply if

Re: Review Request 53108: GEODE-2012: always write stat types to archive

2016-10-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/ --- (Updated Oct. 26, 2016, 9:45 p.m.) Review request for geode, Anthony Baker,

IntelliJ error: Plugin with id 'com.diffplug.gradle.spotless' not found

2016-10-26 Thread Kirk Lund
I refreshed on the Gradle tab in IntelliJ, but it's failing with: Gradle 'closed' project refresh failed Error: Plugin with id 'com.diffplug.gradle.spotless' not found. Anyone know how to fix IntelliJ after you update geode checkout? Thanks, Kirk

Re: IntelliJ error: Plugin with id 'com.diffplug.gradle.spotless' not found

2016-10-26 Thread Kirk Lund
Nevermind. I figured it out. -Kirk On Wed, Oct 26, 2016 at 3:38 PM, Kirk Lund wrote: > I refreshed on the Gradle tab in IntelliJ, but it's failing with: > > Gradle 'closed' project refresh failed > Error: Plugin with id 'com.diffplug.gradle.spotless' not found. > >

Re: Review Request 53150: GEODE-2024 Deadlock creating a new distributed lock service Grantor while transactions are in progress

2016-10-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53150/#review153940 --- Ship it! Ship It! - Kirk Lund On Oct. 25, 2016, 4:13 p.m.,

Re: Review Request 53168: GEODE-2030: security support for SDG

2016-10-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53168/#review153948 ---

Re: GEODE-2036 and documentation practices and procedures

2016-10-26 Thread Karen Miller
Good by me to not have a catch-all JIRA. I've made one commit under it, and I'll now close the JIRA. On Wed, Oct 26, 2016 at 9:36 AM, Joey McAllister wrote: > 3. +1 to Anthony and Dan's recommendation not to use a catch-all JIRA. > > I think the idea was an attempt to