Re: Review Request 44877: GEODE-27: Adding a test to verify the bundled jars have not changed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44877/#review123921 --- Can anything be done not to have static versions of jars in the

Re: Review Request 44936: Changed references of off-heap compaction to defragmentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44936/#review123943 ---

Re: Can we close GEODE-36 ? (Gfsh renaming)

+1, but only if its "Geode Fab-SHell" On Wed, Mar 16, 2016 at 8:54 AM, Michael Stolz wrote: > +1 > Or Geode Fabric SHell > > We used to call it a Data Fabric at one time :) > > -- > Mike Stolz > Principal Engineer, GemFire Product Manager > Mobile: 631-835-4771 > > On Wed,

Review Request 44990: GEODE-947 Client log message misleading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44990/ --- Review request for geode, Darrel Schneider, Hitesh Khamesra, Jianxia Chen, and

[GitHub] incubator-geode pull request: GEODE-247: Fix in executeQuery funct...

Github user nabarunnag commented on the pull request: https://github.com/apache/incubator-geode/pull/112#issuecomment-198073859 Will start a new pull request with the code modification suggested in the comments for this pull request. --- If your project is set up for it, you can

Re: Review Request 45048: GEODE-559: CI Failure: ClientInterestNotifyDUnitTest.testInterestNotify failed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45048/#review124287 ---

Build failed in Jenkins: Geode-nightly #413

See Changes: [bschuchardt] GEODE-947 Client log message misleading [hkhamesra] GEODE-1100 Neglect view when it send by member which is not in current [hkhamesra] GEODE-519 Make sure that membership port range is available. [hkhamesra]

Re: Review Request 44869: Fixed updateStateAndSendEvent to consider testBytesUsedForThresholdSet

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44869/ --- (Updated March 16, 2016, 8:10 p.m.) Review request for geode, Darrel

Re: Review Request 44877: GEODE-27: Adding a test to verify the bundled jars have not changed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44877/#review123905 --- Fix it, then Ship it! Ship It!

[GitHub] incubator-geode pull request: Geode-54: missing javadocs

Github user davebarnes97 closed the pull request at: https://github.com/apache/incubator-geode/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 44968: GEODE-27: Further build cleanup - removing some forced dependencies and moving findbugs annotations to geode-core

> On March 17, 2016, 6:58 p.m., Mark Bretl wrote: > > gradle/java.gradle, line 97 > > > > > > Is there ever a time where a sub-project is not dependent on geode-core > > and would use the findbugs-annotations? > >

Re: [DISCUSS] M2 issues - what's included and how we're tracking them

+1 On Fri, Mar 18, 2016 at 3:12 PM, Anthony Baker wrote: > +1 > > I would also consider: > > GEODE-818 > GEODE-835 > > Anthony > > > On Mar 18, 2016, at 3:00 PM, Dan Smith wrote: > > > > If we do that, I think we should remove a few more things from the

Re: Can we close GEODE-36 ? (Gfsh renaming)

Thank you all folks! I'll put that to bed then... On Wed, Mar 16, 2016 at 10:05 AM, Kenneth Howe wrote: > +1 > > > On Mar 16, 2016, at 9:57 AM, Dan Smith wrote: > > > > +1 to gfsh, and +1 to William's ascii art! > > > > -Dan > > > > > > > > > > > > On Wed,

Re: Review Request 44977: GEODE-949: refactor and repackage security test code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44977/#review124189 --- Ship it! Ship It! - Jens Deppe On March 17, 2016, 8:04

Re: Review Request 44929: GEODE-1067: The dispatcher now handles IllegalStateException by retrying batch without the released event

> On March 17, 2016, 5:06 p.m., Dan Smith wrote: > > What are the reasons why the serialized value is not available? Could this > > change cause us to drop events without realizing it due to bugs in getting > > the off heap value? The data PR is locally destroyed which in turn locally

[GitHub] incubator-geode pull request: Geode-54: missing javadocs

Github user davebarnes97 commented on the pull request: https://github.com/apache/incubator-geode/pull/115#issuecomment-197613902 Merged and Closed manually due to spurious Travis failure. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Review Request 44990: GEODE-947 Client log message misleading

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44990/#review124118 --- Ship it! Ship It! - Jianxia Chen On March 17, 2016, 10:50

[GitHub] incubator-geode pull request: Geode-54: missing javadocs

Github user sbawaska commented on the pull request: https://github.com/apache/incubator-geode/pull/115#issuecomment-197601802 +1 I will merge this in. CI failed because .travis.yml file does not exist on the asf-site branch. --- If your project is set up for it, you can reply

Review Request 44936: Changed references of off-heap compaction to defragmentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44936/ --- Review request for geode and Darrel Schneider. Bugs: GEODE-1017

Re: [DISCUSS] Remove setCustomEvictionAttributes that came in with HDFS changes from develop?

+1 Also would like to see the storage layer move to a pluggable model for stores other than disk (we would like to contribute this). Would be willing to take on the work of turing HDFS into a separate pluggable module as part of this effort. If responses are positive will open a Jira to

Review Request 45053: GEODE-936 test is seeing DistributedSystemDisconnectedException exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45053/ --- Review request for geode, Bruce Schuchardt and Dan Smith. Repository: geode

Re: [DISCUSS] M2 issues - what's included and how we're tracking them

It sounds like we have consensus on using the fix version to track what's in the release. I'll update the fix version on the tickets that don't have it and change the query for the wiki page. I think there is some consensus for pushing out the subtasks GEODE-818, so I'll update those to not be in

Re: [DISCUSS] Remove setCustomEvictionAttributes that came in with HDFS changes from develop?

Hi Bob, Pluggable persistence sounds like a great feature! Help cleaning up this HDFS feature to be more pluggable is also most welcome :) I'm interested to hear more about what your ideas are for pluggable persistence - such as whether you're thinking about swapping out the persistence at an

[DISCUSS] Remove setCustomEvictionAttributes that came in with HDFS changes from develop?

While looking to the HDFS related changes, I noticed that a new custom eviction feature was also added related to those changes. Unlike the already existing CustomExpiry which returns an expiration time for a single key, this takes an EvictionCriteria that is polled periodically and returns return

Re: source code build instruction improvements on the cwiki

Thank you Karen, looks good! On Fri, Mar 18, 2016 at 4:20 PM, Karen Miller wrote: > Check out improvements to the cwiki page on building Geode from source at > > https://cwiki.apache.org/confluence/display/GEODE/Building+and+Running+Geode+from+Source > > I've also refined

Re: source code build instruction improvements on the cwiki

build depends on installDist so I think "build installDist" is redundant. It should be just ./gradlew build or ./gradlew build -Dskip.tests=true There is a gradlew.bat script for windows if you actually clone the source. Should we tell people that only need to install gradle if they download the

source code build instruction improvements on the cwiki

Check out improvements to the cwiki page on building Geode from source at https://cwiki.apache.org/confluence/display/GEODE/Building+and+Running+Geode+from+Source I've also refined the Geode In 5 Minutes guide found at https://cwiki.apache.org/confluence/display/GEODE/Index Please consider and

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #254 was SUCCESSFUL (with 1342 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #254 was successful. --- Scheduled 1346 tests in total. https://build.spring.io/browse/SGF-NAG-254/ -- This

Re: Review Request 44936: Changed references of off-heap compaction to defragmentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44936/#review123952 --- Ship it! Ship It! - Darrel Schneider On March 16, 2016,

cache.tier.sockets dunit tests have setup with sleep

I'm seeing lots of cache.tier.sockets dunit tests that have a setup method which disconnectsAllFromDS() and then sleeps for 5 or 10 seconds before continuing. Is there a valid reason for these tests to sleep at that point? And if I were to change this to use Awaitility what condition would I need

Re: Review Request 45053: GEODE-936 test is seeing DistributedSystemDisconnectedException exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45053/#review124300 --- Ship it! Ship It! - Bruce Schuchardt On March 18, 2016,

Re: Review Request 44936: Changed references of off-heap compaction to defragmentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44936/ --- (Updated March 16, 2016, 11:30 p.m.) Review request for geode and Darrel

Re: GEODE-949

The Apache build from 18 March had these failures: com.gemstone.gemfire.distributed.internal.streaming.StreamingOperationManyDUnitTest.testStreamingManyProvidersNoExceptions 47 ms1 com.gemstone.gemfire.internal.cache.execute.DistributedRegionFunctionExecutionDUnitTest.testBug41367 11

Re: Review Request 44995: GEODE-1050: add JUnit 4 versions of DistributedTestCase and CacheTestCase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44995/#review124236 --- Ship it! Awesome clean up Kirk! - William Markito On March

Re: cache.tier.sockets dunit tests have setup with sleep

I think you should take out the waits. If disconnectAllFromDS() is returning before things have shut down it should be fixed. Le 3/18/2016 1:42 PM, Kirk Lund a écrit : I'm seeing lots of cache.tier.sockets dunit tests that have a setup method which disconnectsAllFromDS() and then sleeps for 5

Re: [DISCUSS] Remove setCustomEvictionAttributes that came in with HDFS changes from develop?

+1 to move it to "HDFS feature branch". I'd rather have a eviction class(es) specific to HDFS. On Fri, Mar 18, 2016 at 4:03 PM, Dan Smith wrote: > While looking to the HDFS related changes, I noticed that a new custom > eviction feature was also added related to those

Converting a DUnit test from JUnit 3 to JUnit 4

Converting a DUnit test from JUnit 3 to JUnit 4: 1) extend *JUnit4DistributedTestCase* or *JUnit4CacheTestCase* 2) remove constructor(String name) 3) *import static com.gemstone.gemfire.test.dunit.Assert.*;* 4) annotate test class directly with *@Category(DistributedTest.class)* 5) annotate all

Review Request 45058: GEODE-1107 CI failure: RestAPIsWithSSLDUnitTest.testSimpleSSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45058/ --- Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.