Re: Checkstyle and PMD

2007-07-26 Thread Bruce Snyder
On 7/26/07, Guillaume Nodet [EMAIL PROTECTED] wrote: Note that you can disable the checks by adding -Pnochecks on the command line iirc. Yeah I've seen that profile, but I just figured that it hadn't been fleshed out yet . Why is that profile empty? Bruce -- perl -e 'print

Re: Checkstyle and PMD

2007-07-26 Thread Guillaume Nodet
As the profile is empty it simply means that the checks wont be configured and activated :-) On 7/26/07, Bruce Snyder [EMAIL PROTECTED] wrote: On 7/26/07, Guillaume Nodet [EMAIL PROTECTED] wrote: Note that you can disable the checks by adding -Pnochecks on the command line iirc. Yeah I've

Re: Checkstyle and PMD

2007-07-26 Thread Bruce Snyder
, import order, etc For each project, it also sets up Checkstyle and PMD (assumes you have the checkstyle and PMD plugins installed). Thus eclipse does all the code format checks for me.Thus, I usually run with -Pnochecks. I've seen these goals in the CXF POMs before and just figured

Re: Checkstyle and PMD

2007-07-26 Thread Guillaume Nodet
that the checks wont be configured and activated :-) How does an empty profile prevent the invocation of Checkstyle and PMD? Sounds like Maven voodoo. Bruce -- perl -e 'print unpack(u30,D0G)[EMAIL PROTECTED]5R\F)R=6-E+G-N61ED\!G;6%I;\YC;VT* );' Apache Geronimo - http://geronimo.apache.org/ Apache ActiveMQ

Re: Checkstyle and PMD

2007-07-26 Thread Guillaume Nodet
Note that you can disable the checks by adding -Pnochecks on the command line iirc. On 7/26/07, Kit Plummer [EMAIL PROTECTED] wrote: On 7/25/07, Bruce Snyder [EMAIL PROTECTED] wrote: On 7/25/07, Kit Plummer [EMAIL PROTECTED] wrote: As long as I can comment out the feature at one place I

Re: Checkstyle and PMD

2007-07-26 Thread Daniel Kulp
eclipse:eclipse) It injects the CXF checkstyle rules into the workspace, sets the workspace warning levels appropriately, injects the code format template, import order, etc For each project, it also sets up Checkstyle and PMD (assumes you have the checkstyle and PMD plugins installed

Re: Checkstyle and PMD

2007-07-25 Thread Guillaume Nodet
there should be all components refactored and the checkstyle will be enabled in only one POM. 2) It is a *major* pain to have a build fail simply because the code is not formatted according to the Checkstyle and PMD conventions being used in ServiceMix. So I've taken a stab at creating a code

Re: Checkstyle and PMD

2007-07-25 Thread Kit Plummer
On 7/25/07, Bruce Snyder [EMAIL PROTECTED] wrote: On 7/25/07, Guillaume Nodet [EMAIL PROTECTED] wrote: If people find this configuration too painful, we can easily disable the checks by default but i thought it was a good way to enforce a coherent code format. And yes, all the configuration

Re: Checkstyle and PMD

2007-07-25 Thread Bruce Snyder
On 7/25/07, Kit Plummer [EMAIL PROTECTED] wrote: As long as I can comment out the feature at one place I don't mind the styleguide stuff. But, you are right...seems like it would be more of a pre-commit hook thing. Well the problem is that Subversion commits don't go through the Maven build;

Checkstyle and PMD

2007-07-25 Thread Bruce Snyder
in build module POM. 2) It is a *major* pain to have a build fail simply because the code is not formatted according to the Checkstyle and PMD conventions being used in ServiceMix. So I've taken a stab at creating a code formatter profile for Eclipse and some quick docs located here: http

Re: Checkstyle and PMD

2007-07-25 Thread Thomas Termin
to have a build fail simply because the code is not formatted according to the Checkstyle and PMD conventions being used in ServiceMix. So I've taken a stab at creating a code formatter profile for Eclipse and some quick docs located here: This prevents a user to checkin stuff which

Re: Checkstyle and PMD

2007-07-25 Thread Bruce Snyder
components refactored and the checkstyle will be enabled in only one POM. 2) It is a *major* pain to have a build fail simply because the code is not formatted according to the Checkstyle and PMD conventions being used in ServiceMix. So I've taken a stab at creating a code formatter profile for Eclipse

Re: Checkstyle and PMD

2007-07-25 Thread Kit Plummer
On 7/25/07, Bruce Snyder [EMAIL PROTECTED] wrote: On 7/25/07, Kit Plummer [EMAIL PROTECTED] wrote: As long as I can comment out the feature at one place I don't mind the styleguide stuff. But, you are right...seems like it would be more of a pre-commit hook thing. Well the problem is that

[jira] Updated: (SM-976) servicemix-sca is out of touch with the CheckStyle and PMD guides.

2007-06-23 Thread Kit Plummer (JIRA)
[ https://issues.apache.org/activemq/browse/SM-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kit Plummer updated SM-976: --- Attachment: checkstyle_fixes_servicemix-sca.diff This diff covers all of the CheckStyle and PMD errors

[jira] Created: (SM-976) servicemix-sca is out of touch with the CheckStyle and PMD guides.

2007-06-23 Thread Kit Plummer (JIRA)
servicemix-sca is out of touch with the CheckStyle and PMD guides. --- Key: SM-976 URL: https://issues.apache.org/activemq/browse/SM-976 Project: ServiceMix Issue Type: Bug

[jira] Resolved: (SM-976) servicemix-sca is out of touch with the CheckStyle and PMD guides.

2007-06-23 Thread Gert Vanthienen (JIRA)
/CheckStyle enabled... servicemix-sca is out of touch with the CheckStyle and PMD guides. --- Key: SM-976 URL: https://issues.apache.org/activemq/browse/SM-976 Project: ServiceMix