Re: xbean-reflect changes and potential xbean 5?

Thanks David. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: xbean-reflect changes and potential xbean 5?

I think what threw me off was seeing XBEAN-309 updated from 4.10 to 4.11. I suspect you moved it only because I hadn't bother to close it, which I should. I've updated it to 4.10 and marked it closed. -David > On Oct 2, 2018, at 12:27 AM, Romain Manni-Bucau wrote: > > No worries, let's

Re: xbean-reflect changes and potential xbean 5?

No worries, let's tackle this asm7 thing and we can even add other features ;) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: xbean-reflect changes and potential xbean 5?

Apparently I have to worry about becoming senile. I did an svn log and swore I didn't see the commit in there. It's definitely there. I think my mind has been warped by working with Git too long. Sorry for the noise and thank for the release, sir! -- David Blevins

Re: xbean-reflect changes and potential xbean 5?

Seems the code is still here - see https://github.com/apache/geronimo-xbean/blob/trunk/xbean-reflect/src/main/java/org/apache/xbean/propertyeditor/PropertyEditorRegistry.java Le lun. 1 oct. 2018 22:04, Romain Manni-Bucau a écrit : > Hmm, thought i just did what was mentionned in this thread

Re: xbean-reflect changes and potential xbean 5?

Hmm, thought i just did what was mentionned in this thread which was not about dropping any code but ensuring static usage was kept only for compatibility and moving to a not leaking impl. Do you have a failling test of the missing feature? - feel free to push it with @Ignore ;). I can check

Re: xbean-reflect changes and potential xbean 5?

> On Aug 8, 2018, at 6:53 PM, David Blevins wrote: > > I'd love to do a 4.x release of this code. Hey Romain, is there any reason you pulled this code out of the XBean 4.10 release? Ideally we discuss these things as a community before tacking action. Would you mind if I did a 4.11 with it

Re: xbean-reflect changes and potential xbean 5?

That sounds like good improvements. Thanks for the visibility. And also 5.x sounds better considering the changes and the removal of some converters. Le jeu. 9 août 2018 à 09:37, Romain Manni-Bucau a écrit : > pushed > > > Romain Manni-Bucau > @rmannibucau |

Re: xbean-reflect changes and potential xbean 5?

pushed Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: xbean-reflect changes and potential xbean 5?

If we go 5 we should probably drop the static PropertiesEditors class which leads to trivial leakages in all servers and do a registry apps instantiate at need with closeable support for editors. I can push that today if there is no objection. It would also ensure we can cache the reflection

xbean-reflect changes and potential xbean 5?

All, I updated the converter code in xbean-reflect to add support for JAX-RS style string constructors and static factory methods. We weren't so clever to think of this in 2006, but it definitely fits. Moreover, I don't think we need half of the built-in Converter/PropertyEditor