[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628813#comment-13628813
]
Claudio Martella commented on GIRAPH-613:
-
Finally I understand it, I totally get
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629117#comment-13629117
]
Maja Kabiljo commented on GIRAPH-613:
-
Awesome, thanks! One question: where are the
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629120#comment-13629120
]
Claudio Martella commented on GIRAPH-613:
-
Ooops, I must have uploaded the wrong
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629535#comment-13629535
]
Hudson commented on GIRAPH-613:
---
Integrated in Giraph-trunk-Commit #911 (See
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627744#comment-13627744
]
Claudio Martella commented on GIRAPH-613:
-
Actually, I would have like to test it
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627831#comment-13627831
]
Maja Kabiljo commented on GIRAPH-613:
-
Refactor was really just a refactor, so it's
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627844#comment-13627844
]
Claudio Martella commented on GIRAPH-613:
-
Makes sense. Tested also with
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627904#comment-13627904
]
Maja Kabiljo commented on GIRAPH-613:
-
Looks good overall, apart from one concern -
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627908#comment-13627908
]
Claudio Martella commented on GIRAPH-613:
-
I'm not sure where we reuse objects in
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627965#comment-13627965
]
Maja Kabiljo commented on GIRAPH-613:
-
It's not exactly that you broke it, but earlier
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627972#comment-13627972
]
Claudio Martella commented on GIRAPH-613:
-
Ok, I see. Nonetheless, it would be
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627988#comment-13627988
]
Avery Ching commented on GIRAPH-613:
[~majakabiljo], you have a great memory. As you
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627990#comment-13627990
]
Claudio Martella commented on GIRAPH-613:
-
So, it's not this patch that broke it,
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628053#comment-13628053
]
Maja Kabiljo commented on GIRAPH-613:
-
The patch makes it impossible to reuse objects
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628055#comment-13628055
]
Maja Kabiljo commented on GIRAPH-613:
-
I thought our distributed tests are broken? :-)
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628277#comment-13628277
]
Claudio Martella commented on GIRAPH-613:
-
Honestly, I do not understand your
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628346#comment-13628346
]
Maja Kabiljo commented on GIRAPH-613:
-
I am not sure which patch you are referring to,
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628387#comment-13628387
]
Claudio Martella commented on GIRAPH-613:
-
Then I must have misunderstood what you
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628455#comment-13628455
]
Maja Kabiljo commented on GIRAPH-613:
-
I'm sorry for the confusion. There was
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626926#comment-13626926
]
Maja Kabiljo commented on GIRAPH-613:
-
Probably I'm missing something here - why is
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626969#comment-13626969
]
Maja Kabiljo commented on GIRAPH-613:
-
That way it makes much more sense. And for now
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626976#comment-13626976
]
Claudio Martella commented on GIRAPH-613:
-
I'm doing one thing at a time, but that
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626981#comment-13626981
]
Maja Kabiljo commented on GIRAPH-613:
-
Ok then, unless somebody else has arguments
23 matches
Mail list logo
