[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-19 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315113927 ## File path: pom.xml ## @@ -826,10 +827,21 @@ 2.2.22 0.2

[GitHub] [gora] kamaci commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-19 Thread GitBox
kamaci commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315118863 ## File path: pom.xml ## @@ -826,10 +827,21 @@ 2.2.22 0.2.0 -

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-19 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315121656 ## File path: pom.xml ## @@ -826,10 +827,21 @@ 2.2.22 0.2

[GitHub] [gora] djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora

2019-08-19 Thread GitBox
djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#discussion_r315124701 ## File path: gora-hive/pom.xml ## @@ -0,0 +1,249 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http

[GitHub] [gora] kamaci commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-19 Thread GitBox
kamaci commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315127381 ## File path: pom.xml ## @@ -826,10 +827,21 @@ 2.2.22 0.2.0 -

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-19 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315136504 ## File path: pom.xml ## @@ -826,10 +827,21 @@ 2.2.22 0.2

[GitHub] [gora] djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora

2019-08-19 Thread GitBox
djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#discussion_r315141276 ## File path: pom.xml ## @@ -773,6 +773,7 @@ gora-ignite gora-tutorial sources-dist +gora-hive

[GitHub] [gora] djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora

2019-08-19 Thread GitBox
djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#discussion_r315146282 ## File path: gora-hive/pom.xml ## @@ -0,0 +1,249 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-19 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315147828 ## File path: pom.xml ## @@ -826,10 +827,21 @@ 2.2.22 0.2

[GitHub] [gora] djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora

2019-08-19 Thread GitBox
djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#discussion_r315152530 ## File path: gora-hive/src/test/java/org/apache/gora/hive/GoraHiveTestDriver.java ## @@ -0,0 +1,39 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora

2019-08-19 Thread GitBox
djkevincr commented on a change in pull request #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#discussion_r315152530 ## File path: gora-hive/src/test/java/org/apache/gora/hive/GoraHiveTestDriver.java ## @@ -0,0 +1,39 @@ +/* + * Lic

[GitHub] [gora] lewismc merged pull request #171: GORA-538 No content stored for an object field with name "value"

2019-08-19 Thread GitBox
lewismc merged pull request #171: GORA-538 No content stored for an object field with name "value" URL: https://github.com/apache/gora/pull/171 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [gora] chanakadkb commented on a change in pull request #187: GORA-320 Hive backend support in Gora

2019-08-19 Thread GitBox
chanakadkb commented on a change in pull request #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#discussion_r315467966 ## File path: gora-hive/src/test/java/org/apache/gora/hive/GoraHiveTestDriver.java ## @@ -0,0 +1,39 @@ +/* + * Li

[GitHub] [gora] jhnmora000 commented on issue #178: GORA-485 Apache Kudu datastore for Gora

2019-08-19 Thread GitBox
jhnmora000 commented on issue #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#issuecomment-522861072 Hi @carlosrmng and @kamaci Thanks for feedback. I have updated my PR. Please let me know if you have more suggestions. -

[GitHub] [gora] jhnmora000 edited a comment on issue #178: GORA-485 Apache Kudu datastore for Gora

2019-08-19 Thread GitBox
jhnmora000 edited a comment on issue #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#issuecomment-522861072 Hi @carlosrmng and @kamaci Thanks for your feedback. I have updated my PR. Please let me know if you have more suggestions.

[GitHub] [gora] djkevincr commented on issue #187: GORA-320 Hive backend support in Gora

2019-08-20 Thread GitBox
djkevincr commented on issue #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#issuecomment-522908117 Tests Passes - ( mvn clean install ) [INFO] Tests run: 43, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 757.768 s - in org.apache.gora.hive.st

[GitHub] [gora] djkevincr commented on issue #187: GORA-320 Hive backend support in Gora

2019-08-20 Thread GitBox
djkevincr commented on issue #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#issuecomment-522909305 Javadoc aggregate ( mvn javadoc:aggregate ) [INFO] [INFO] Building Apac

[GitHub] [gora] kamaci commented on issue #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
kamaci commented on issue #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#issuecomment-522913140 Thanks for the effort you made! Could you check indentation throughout the PR files? ---

[GitHub] [gora] djkevincr commented on issue #187: GORA-320 Hive backend support in Gora

2019-08-20 Thread GitBox
djkevincr commented on issue #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#issuecomment-522917373 @chanakadkb Thank you for addressing my review comments. I ll let others to have a look as well. I do have a very minor concern on test running time w

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315578059 ## File path: gora-benchmark/src/test/java/org/apache/gora/benchmark/GoraClientTest.

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315578059 ## File path: gora-benchmark/src/test/java/org/apache/gora/benchmark/GoraClientTest.

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315592665 ## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmarkCl

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315592665 ## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmarkCl

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315592665 ## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmarkCl

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315603638 ## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmarkUt

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315604148 ## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmarkCl

[GitHub] [gora] djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315624050 ## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmarkCl

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315628275 ## File path: gora-redis/pom.xml ## @@ -0,0 +1,193 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] [gora] chanakadkb commented on issue #187: GORA-320 Hive backend support in Gora

2019-08-20 Thread GitBox
chanakadkb commented on issue #187: GORA-320 Hive backend support in Gora URL: https://github.com/apache/gora/pull/187#issuecomment-522973871 @djkevincr Thanks for the review. I think queries like INSERT are bit slower in hive compared to other data stores like Hbase. The main reason is hiv

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315736122 ## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmark

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315750627 ## File path: gora-benchmark/src/test/java/org/apache/gora/benchmark/GoraClientTes

[GitHub] [gora] sneceesay77 closed pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
sneceesay77 closed pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179 This is an automated message from the Apache Git Service. To res

[GitHub] [gora] sneceesay77 commented on issue #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
sneceesay77 commented on issue #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#issuecomment-523064409 > Thanks for the effort you made! Could you check indentation throughout the PR files?

[GitHub] [gora] sneceesay77 opened a new pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
sneceesay77 opened a new pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179 Initial pull request. This is an automated message from th

[GitHub] [gora] sneceesay77 removed a comment on issue #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
sneceesay77 removed a comment on issue #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#issuecomment-523064409 > Thanks for the effort you made! Could you check indentation throughout the PR files?

[GitHub] [gora] sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments

2019-08-20 Thread GitBox
sneceesay77 commented on a change in pull request #179: GORA-532: Apache Gora Benchmark initial pull request for review and comments URL: https://github.com/apache/gora/pull/179#discussion_r315756318 ## File path: gora-benchmark/src/main/java/org/apache/gora/benchmark/GoraBenchmark

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315773894 ## File path: gora-redis/pom.xml ## @@ -0,0 +1,193 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315774753 ## File path: gora-redis/src/examples/java/.gitignore ## @@ -0,0 +1,15 @@ +# Licensed to the Apache Software

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315774945 ## File path: gora-redis/src/main/java/org/apache/gora/redis/package-info.java ## @@ -0,0 +1,20 @@ +/** + *

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315777508 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/package-info.java ## @@ -0,0 +1,21 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315777381 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315776975 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315777130 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315776698 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315777963 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisMapping.java ## @@ -0,0 +1,63 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315779056 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315793558 ## File path: gora-redis/pom.xml ## @@ -0,0 +1,193 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315794515 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisQuery.java ## @@ -0,0 +1,45 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315795166 ## File path: gora-redis/pom.xml ## @@ -0,0 +1,193 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="h

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315777381 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315806605 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315798484 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315802210 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315798982 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315813532 ## File path: pom.xml ## @@ -845,7 +848,7 @@ 2.8.1 1.4 0.8 -3.1.1 +2.5.4 Review co

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315815707 ## File path: gora-redis/src/test/java/org/apache/gora/redis/GoraRedisTestDriver.java ## @@ -0,0 +1,105 @@

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315814307 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisType.java ## @@ -0,0 +1,24 @@ +/** +

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315988175 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/ServerMode.java ## @@ -0,0 +1,21 @@ +/** +

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315988384 ## File path: gora-redis/src/test/java/org/apache/gora/redis/GoraRedisTestDriver.java ## @@ -0,0 +1,105 @@

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315988060 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/DatumHandler.java ## @@ -0,0 +1,327 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315988210 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/ServerMode.java ## @@ -0,0 +1,21 @@ +/** +

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315988240 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/StorageMode.java ## @@ -0,0 +1,21 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315988304 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/StorageMode.java ## @@ -0,0 +1,21 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315987970 ## File path: gora-redis/src/main/java/org/apache/gora/redis/util/DatumHandler.java ## @@ -0,0 +1,327 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315990817 ## File path: pom.xml ## @@ -382,7 +382,7 @@ -posix +

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315991250 ## File path: gora-redis/src/test/java/org/apache/gora/redis/util/RedisStartupLogWaitStrategy.java ## @@ -0

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315993213 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,531 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315992799 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,531 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315993343 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,531 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315993566 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,531 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315993624 ## File path: gora-redis/src/main/java/org/apache/gora/redis/store/RedisStore.java ## @@ -0,0 +1,531 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315996655 ## File path: pom.xml ## @@ -1061,7 +1064,37 @@ ${flink.version} compile - +

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-20 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r315996655 ## File path: pom.xml ## @@ -1061,7 +1064,37 @@ ${flink.version} compile - +

[GitHub] [gora] djkevincr commented on issue #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
djkevincr commented on issue #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#issuecomment-523379426 mvn clean install ``` [WARNING] Tests run: 43, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 30.902 s - in org.apache.gora.redis.store

[GitHub] [gora] djkevincr commented on issue #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
djkevincr commented on issue #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#issuecomment-523380046 mvn javadoc:aggregate - Its better if you can fix these warnings. ``` [WARNING] Javadoc Warnings [WARNING] /home/djkevincr/apache_membe

[GitHub] [gora] djkevincr commented on issue #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
djkevincr commented on issue #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#issuecomment-523383201 @cuent This is excellent work and thank you for all the hard work/research you put into it. This PR is in great shape and there are several case

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316101724 ## File path: pom.xml ## @@ -1642,16 +1676,16 @@ - org.apache.pig - pig -

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316100408 ## File path: gora-kudu/pom.xml ## @@ -0,0 +1,189 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http:/

[GitHub] [gora] cuent commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
cuent commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r316484889 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisQuery.java ## @@ -0,0 +1,45 @@ +/** + *

[GitHub] [gora] cuent commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
cuent commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r316485046 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/** +

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r316492084 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisQuery.java ## @@ -0,0 +1,45 @@ +/**

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r316496181 ## File path: gora-redis/src/main/java/org/apache/gora/redis/query/RedisResult.java ## @@ -0,0 +1,111 @@ +/

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r316498705 ## File path: pom.xml ## @@ -382,7 +382,7 @@ -posix +

[GitHub] [gora] djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #186: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/186#discussion_r316498705 ## File path: pom.xml ## @@ -382,7 +382,7 @@ -posix +

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316512967 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/mapping/Column.java ## @@ -0,0 +1,161 @@ +/* + * Lice

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316516924 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/mapping/KuduMappingBuilder.java ## @@ -0,0 +1,170 @@

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316517481 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/query/KuduResult.java ## @@ -0,0 +1,86 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316513181 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/mapping/Column.java ## @@ -0,0 +1,161 @@ +/* + * Lice

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316517848 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/query/KuduResult.java ## @@ -0,0 +1,86 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316512221 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/mapping/Column.java ## @@ -0,0 +1,161 @@ +/* + * Lice

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316517431 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/query/KuduQuery.java ## @@ -0,0 +1,36 @@ +/* + * Lice

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316513054 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/mapping/Column.java ## @@ -0,0 +1,161 @@ +/* + * Lice

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316519047 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/mapping/KuduMappingBuilder.java ## @@ -0,0 +1,170 @@

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-21 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316521129 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java ## @@ -0,0 +1,654 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-22 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316540555 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java ## @@ -0,0 +1,654 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-22 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316540236 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java ## @@ -0,0 +1,654 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-22 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316540236 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java ## @@ -0,0 +1,654 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-22 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316540236 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java ## @@ -0,0 +1,654 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-22 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316540236 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStore.java ## @@ -0,0 +1,654 @@ +/* + * Lic

[GitHub] [gora] djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora

2019-08-22 Thread GitBox
djkevincr commented on a change in pull request #178: GORA-485 Apache Kudu datastore for Gora URL: https://github.com/apache/gora/pull/178#discussion_r316580734 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/utils/KuduParameters.java ## @@ -0,0 +1,217 @@ +/* +

<    1   2   3   4   5   6   7   8   9   10   >