[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r226905150 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[jira] [Commented] (GRIFFIN-207) LDAP auth is not supporting group filters and non-CN login names

[ https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658594#comment-16658594 ] ASF GitHub Bot commented on GRIFFIN-207: Github user toyboxman commented on a diff in the pull

[jira] [Commented] (GRIFFIN-207) LDAP auth is not supporting group filters and non-CN login names

[ https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658593#comment-16658593 ] ASF GitHub Bot commented on GRIFFIN-207: Github user toyboxman commented on a diff in the pull

[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...

Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/441#discussion_r226904188 --- Diff: service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java --- @@ -0,0 +1,68 @@ +package

[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...

Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/441#discussion_r226904191 --- Diff: service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java --- @@ -0,0 +1,68 @@ +package

[jira] [Commented] (GRIFFIN-207) LDAP auth is not supporting group filters and non-CN login names

[ https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658591#comment-16658591 ] ASF GitHub Bot commented on GRIFFIN-207: Github user toyboxman commented on a diff in the pull

[jira] [Commented] (GRIFFIN-207) LDAP auth is not supporting group filters and non-CN login names

[ https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658590#comment-16658590 ] ASF GitHub Bot commented on GRIFFIN-207: Github user toyboxman commented on a diff in the pull

[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...

Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/441#discussion_r226903885 --- Diff: service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java --- @@ -0,0 +1,68 @@ +package

[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...

Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/441#discussion_r226903865 --- Diff: service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java --- @@ -0,0 +1,68 @@ +package

Re: Hooks support in JobService

Sounds good to me. You can implement your preferred hive-style, I can implement spring integration based on your interface. William On Mon, Oct 22, 2018 at 2:10 AM Nick Sokolov wrote: > Hi William, > > Totally agree on keeping interface as abstract as possible. Interfaces feel > like natural

Re: Hooks support in JobService

Hi William, Totally agree on keeping interface as abstract as possible. Interfaces feel like natural solution here. It should be relatively easy to provide spring integration implementation of hook interface. Probably we can even have default spring integration hook provided as an example. On

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r226871843 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r226866876 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[jira] [Commented] (GRIFFIN-207) LDAP auth is not supporting group filters and non-CN login names

[ https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658262#comment-16658262 ] ASF GitHub Bot commented on GRIFFIN-207: Github user guoyuepeng commented on a diff in the pull

[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...

Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/441#discussion_r226866713 --- Diff: service/src/main/java/org/apache/griffin/core/login/LoginServiceLdapImpl.java --- @@ -48,68 +53,137 @@ Licensed to the Apache

[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...

Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/441#discussion_r226866655 --- Diff: service/src/main/java/org/apache/griffin/core/login/LoginServiceLdapImpl.java --- @@ -48,68 +53,137 @@ Licensed to the Apache

Re: Hooks support in JobService

hi Nick, I agree with you we need to have some lifecycle hooks for jobs. No matter which extension mechanism we choose at runtime, but we can always abstract common lifecycle interfaces, and implements different solutions for different environments. Say, at runtime someone can configure griffin