Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/456#discussion_r235226675
--- Diff: griffin-doc/measure/measure-configuration-guide.md ---
@@ -188,7 +188,7 @@ Above lists DQ job configure parameters.
- **sinks
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/459
LGTM.
@boltzjf Thanks for make it clear.
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/455
I don't know what is wrong between apache repo and github repo, I had
merged/closed this PR, but it still exists here as OPEN.
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin-site/pull/15
Yes, we make deploy.sh 644 on purpose, make sure think twice before deploy.
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin-site/pull/14
'Current Events' footer looks good.
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin-site/pull/14
Thanks, Roy.
LGTM.
---
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/453
Fixservicetests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin fixservicetests
Alternatively you
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
>> > Can we provide several individually implements in configuration like
GriffinHook1, GriffionHook2, and autowired all individual hooks instances into
List?
>>
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
I am ok for registration through declaration in properties.
my problem is can we write triggered on called test case for in
EventServiceTests.
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
Based on previous design discuss and code review.
LGTM now.
Any comments from you? @chemikadze
---
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r231369447
--- Diff:
service/src/test/java/org/apache/griffin/core/job/EventServiceTest.java ---
@@ -0,0 +1,69 @@
+package
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r231173157
--- Diff:
service/src/main/java/org/apache/griffin/core/event/GriffinEventListeners.java
---
@@ -0,0 +1,51 @@
+package
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
@chemikadze right, we cannot tie events to jobs related. @toyboxman
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
cool!
how about rename GriffinHookChain as GriffinJobEventManager so similar?
---
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229714976
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/JobEvent.java ---
@@ -0,0 +1,21 @@
+package
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229715591
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/JobEventHook.java ---
@@ -0,0 +1,11 @@
+package
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229720415
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229713768
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229713456
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEventListeners.java
---
@@ -0,0 +1,61 @@
+package
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229708121
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEvent.java ---
@@ -0,0 +1,44 @@
+/*
+Licensed to the Apache
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/450
LGTM
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/447
@chemikadze LGTM.
Just rushed out for my meeting. sorry for confusing.
---
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/447#discussion_r228420528
--- Diff: ui/angular/src/app/measure/create-measure/ac/ac.component.ts ---
@@ -644,48 +644,37 @@ export class AcComponent implements OnInit
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/447#discussion_r228419404
--- Diff:
service/src/main/java/org/apache/griffin/core/metastore/hive/HiveMetaStoreServiceImpl.java
---
@@ -99,8 +100,17 @@ public
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/442#discussion_r228217972
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -81,6 +81,9 @@ Licensed to the Apache Software
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/446
Awesome!
---
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/445#discussion_r228021021
--- Diff: griffin-doc/deploy/deploy-guide.md ---
@@ -50,7 +50,7 @@ createdb -O quartz
```
Init quartz tables in PostgreSQL using
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/442#discussion_r227272894
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -81,6 +81,9 @@ Licensed to the Apache Software
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/442#discussion_r226866876
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -81,6 +81,9 @@ Licensed to the Apache Software
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r226866713
--- Diff:
service/src/main/java/org/apache/griffin/core/login/LoginServiceLdapImpl.java
---
@@ -48,68 +53,137 @@ Licensed to the Apache
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r226866655
--- Diff:
service/src/main/java/org/apache/griffin/core/login/LoginServiceLdapImpl.java
---
@@ -48,68 +53,137 @@ Licensed to the Apache
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/439
LGTM
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/435
data partition timezone is come from data connector.
https://github.com/apache/incubator-griffin/blob/master/service/src/main/java/org/apache/griffin/core/measure/entity
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/435
let me check
---
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/434#discussion_r224956565
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala
---
@@ -125,14 +126,20
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/434#discussion_r224956533
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala
---
@@ -125,14 +126,20
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/432#discussion_r224948471
--- Diff: griffin-doc/measure/measure-batch-sample.md ---
@@ -18,7 +18,7 @@ under the License.
-->
# Measure Batch Sam
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/432#discussion_r224948476
--- Diff: griffin-doc/measure/measure-streaming-sample.md ---
@@ -18,7 +18,7 @@ under the License.
-->
# Measure Stream
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224956283
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224955984
--- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java
---
@@ -148,4 +149,11 @@ private static String refreshEscapeHashTag
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224948342
--- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts ---
@@ -134,8 +134,8 @@ export class BatchComponent implements OnInit
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/435#discussion_r224947629
--- Diff: service/src/main/java/org/apache/griffin/core/util/TimeUtil.java
---
@@ -148,4 +149,11 @@ private static String refreshEscapeHashTag
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/434#discussion_r224486025
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala
---
@@ -74,9 +74,9 @@ case class
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/436
always use apache griffin together as our mark
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin-site/pull/10
update Nikolay as committer from contributor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/430
remove duplicated cache settings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/429
ok, I will keep both 30m wait time and git quiet option.
will verify and then might reopen it later.
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/429
so that means we don't need to wait 30 minutes?
@toyboxman @chemikadze
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/426
ok
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/420
I don't know either.
---
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/425
Fix case clauses
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin fix_case_clauses
Alternatively you
Github user guoyuepeng closed the pull request at:
https://github.com/apache/incubator-griffin/pull/424
---
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/424
Fiximport
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin fiximport
Alternatively you can review
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/421#discussion_r219672109
--- Diff:
service/src/main/java/org/apache/griffin/core/util/YarnNetUtil.java ---
@@ -56,6 +62,14 @@ public static boolean update(String url
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/422#discussion_r219671878
--- Diff: ui/angular/src/app/sidebar/sidebar.component.html ---
@@ -38,15 +38,15
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/405
update gpg keys
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin update_gpg_keys
Alternatively you
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/404
fix license header
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
fix_service_header
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/398
make ui style consistent
make ui module code style consistent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/396#discussion_r210855056
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/expr/TreeNode.scala
---
@@ -18,28 +18,42 @@ under the License
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/396#discussion_r210854573
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/expr/TreeNode.scala
---
@@ -18,28 +18,42 @@ under the License
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/388
@toyboxman
hi Jin,
There are some conflicts, could you try to sync it and submit the PR again?
Thanks,
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/394
hi Grant,
Could you rebase your code before submit PR?
Thanks,
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/392
@SparshSinghalHM
We are updating for our documents.
Thanks,
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/392
Hi @SparshSinghalHM
Thanks for your PR, but we cannot use mysql in our primary pom.xml directly
since its license not compatible with apache community.
so if you
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/384
@toyboxman
---
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/376
update dq job spec
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
update_griffin_job_spec
Github user guoyuepeng closed the pull request at:
https://github.com/apache/incubator-griffin/pull/373
---
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/373
Update batch measure config
redesign batch config interfce
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/363
This closes #330, This closes #286
This closes #330, This closes #286
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng
Github user guoyuepeng closed the pull request at:
https://github.com/apache/incubator-griffin/pull/362
---
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/362
2018 07 19 doc update 2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
2018_07_19_doc_update_2
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/361
2018 07 19 doc update 2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
2018_07_19_doc_update_2
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/360
2018 07 19 doc update 1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
2018_07_19_doc_update_1
Github user guoyuepeng closed the pull request at:
https://github.com/apache/incubator-griffin/pull/357
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/343
ok.
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
hi @toyboxman
Yes, we might need to new patch for all '\n'
Thanks,
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/334
I agree 's' Interpolator is unnecessary for these two cases.
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/333
LGTM
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/331
hi Jin,
Could you check why build failed?
Tests in error:
JobInstanceBeanRepoTest.testFindByActiveState » IllegalState Failed to
load Ap
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/328
2018 06 28 fix job controller
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/321
hi Jason,
Thanks, that makes sense.
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/320
OK, we will review your patch.
Thanks Kevin.
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/320
hi Yao,
there are some conflicting files, could you fix them then we will review
this patch.
Thanks,
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/321
LGTM.
---
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/318
This closes #125
at the same time, we will close some obsolete PRs.
This closes #125
This closes #241
THis closes #242
This closes #279
You can merge this pull
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/316
hi
for compatible, we need scala-maven-plugin as 3.3.1
Thanks,
William
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/309
hi YAO,
We want to use h2 in dev profile(application-dev.properties),
but for prod profile, we need to application-prod.properties untouched.
Could you change
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/304
2018 06 14 refactor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
2018_06_14_refactor
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/302
refactor persist to sink
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/298
add config reader test spec
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
2018_06_13_testcases
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/296
2018 06 11 refactor measure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/295
rename field name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
2018_06_11_refactor_measure
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/293
2018 06 11 remove reduntant finals
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/292
remove redundant keywords
remote final keywords from case class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/276
to download the sample file, where is the specification for the sample?
say we only download the head 20 records?
---
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/159
20171101 update parent artifact
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/155
20171030 remove generated readme
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/131
20171011 upgrdate angular2 build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
Github user guoyuepeng commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/121#discussion_r135491329
--- Diff: service/src/test/resources/quartz-test.sql ---
@@ -1,3 +1,22 @@
+/*
--- End diff --
comments with sql.
---
If your
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/incubator-griffin/pull/113
20170720 remove test properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin
1 - 100 of 132 matches
Mail list logo
