GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/456
[GRIFFIN-213] Custom connector support
Provide ability to extend batch and streaming data integrations
with custom user-provided connectors. Introduces new data connector
type
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
@toyboxman leaving minor comments aside, looks really nice!
---
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230578657
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/JobEventHook.java ---
@@ -0,0 +1,11 @@
+package
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230578522
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -158,17 +162,22 @@ public JobServiceImpl
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230578497
--- Diff:
service/src/test/java/org/apache/griffin/core/job/EventServiceTest.java ---
@@ -0,0 +1,69 @@
+package
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r230578447
--- Diff: service/src/main/resources/application.properties ---
@@ -62,3 +62,5 @@ elasticsearch.scheme=http
livy.uri=http://localhost:8998
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/444
Regardig naming -- do you think we should really tie it to Jobs? Handling
Measure events could be useful as well.
---
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229565301
--- Diff:
service/src/test/java/org/apache/griffin/core/job/EventServiceTest.java ---
@@ -0,0 +1,69 @@
+package
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229564055
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/JobEvent.java ---
@@ -0,0 +1,21 @@
+package
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229565395
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEvent.java ---
@@ -0,0 +1,44 @@
+/*
+Licensed to the Apache
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r229565134
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -168,7 +175,14 @@ public AbstractJob addJob(AbstractJob
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/447
@guoyuepeng can you please clarify your comments, please? Not very clear
what changes are required, if any.
---
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/450
Document compression, SSL and LDAP conf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chemikadze/incubator-griffin patch-2
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/448#discussion_r228385053
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/Application.scala ---
@@ -104,12 +106,18 @@ object Application extends Loggable
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/446
Looks like there are still some rendering issues:
https://user-images.githubusercontent.com/867294/47530131-9ac61b80-d85e-11e8-8bf1-aa825105ff52.png;>
---
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/448
[GRIFFIN-208] log exception details when it makes sense
Sometimes error messages are not descriptive enough and do not allow
to pinpoint exact issue. Exception stack traces should
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/447
[GRIFFIN-194] single call to fetch all tables of all dbs
Significantly improves opening speed for measure dialogs.
Previously taking 10+ seconds on huge schemas, with this call
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/446
LGTM
---
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/446#discussion_r228037817
--- Diff: ui/angular/src/app/measure/create-measure/raw/raw.component.ts ---
@@ -0,0 +1,146 @@
+/*
+Licensed to the Apache Software
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/446#discussion_r228036689
--- Diff: ui/angular/src/app/measure/create-measure/raw/raw.component.html
---
@@ -0,0 +1,100 @@
+
+
+
+Create Measure
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/446#discussion_r228035101
--- Diff: ui/angular/src/app/measure/create-measure/raw/raw.component.ts ---
@@ -0,0 +1,180 @@
+/*
+Licensed to the Apache Software
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/446#discussion_r228035823
--- Diff: ui/angular/src/app/measure/create-measure/raw/raw.component.html
---
@@ -0,0 +1,100 @@
+
+
+
+Create Measure
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/446#discussion_r228035192
--- Diff: ui/angular/src/app/measure/create-measure/raw/raw.component.ts ---
@@ -0,0 +1,180 @@
+/*
+Licensed to the Apache Software
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r227897445
--- Diff:
service/src/main/java/org/apache/griffin/core/integration/GriffinEvent.java ---
@@ -0,0 +1,44 @@
+/*
+Licensed to the Apache
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/444#discussion_r227900111
--- Diff:
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
@@ -128,10 +129,22 @@ Licensed to the Apache Software
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/441
@whhe @toyboxman @guoyuepeng are you good with fixes after review?
---
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/443
Fix conventions in batch-sample
Bring conventions for enums in measure-batch-sample in sync with service
module.
While measure accepts any case, service requires them capitalized
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/442#discussion_r227217198
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -81,6 +81,9 @@ Licensed to the Apache Software
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r227214831
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,100 @@
+/*
+Licensed
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/441
@toyboxman i've updated the code according to your comments, thanks!
---
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/442#discussion_r226871843
--- Diff:
service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java ---
@@ -81,6 +81,9 @@ Licensed to the Apache Software
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/442
Support "cache" field on rules in service module
Measure module exposes "cache" flag on rules, but it's not possible to
store and schedule such a job in service mo
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/441
[GRIFFIN-207] LDAP login service improvements
- allow non-CN usernames
- allow disabling certificate checks
- allow limiting set of login users
- improve logging
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/440
Update recommended ES index schema
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chemikadze/incubator-griffin patch-1
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/435
@guoyuepeng @ahutsunshine is there anything left preventing the merge?
---
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/435
@ahutsunshine I've found only usage of cron.time.zone is only during
schedule creation:
https://github.com/apache/incubator-griffin/blob/master/service/src/main/java/org/apache/griffin
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/437
Show raw rules on UI
Creates section on Measure Detail page, showing formatted JSON of the rule.
Wed Oct 10 2018 11:30:48 GMT-0700 (Pacific Daylight Time)
> ne
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/434#discussion_r224151599
--- Diff:
measure/src/test/scala/org/apache/griffin/measure/transformations/AccuracyTransformationsIntegrationTest.scala
---
@@ -0,0 +1,169
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/434#discussion_r224152545
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala
---
@@ -148,12 +148,12 @@ case class
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/434#discussion_r224152055
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala
---
@@ -74,9 +74,9 @@ case class
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/434#discussion_r224150071
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala
---
@@ -125,14 +126,26
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/431
@bhlx3lyx7 pushed the same for accuracy
---
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/423
Closes GRIFFIN-199
---
Github user chemikadze closed the pull request at:
https://github.com/apache/incubator-griffin/pull/427
---
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/429
Just removing -q can produce a lot of output. I did few experiments
yesterday:
- without -q:
https://travis-ci.org/apache/incubator-griffin/builds/435410581
- without -q
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/428
I've accidentally noticed, that builds are freezing specifically on
attempts to access sonatype-apache repository, and no artifacts is successfully
downloaded from that repository
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/428
@guoyuepeng as far as I understand, Travis is not preserving state between
builds, and maven artifact caches are anyway not cleaned up at clean phase.
From other hand, looks like
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/428
Increase build silence timeout
According to experiment, resolving dependencies takes longer
than default build timeout of 20 minutes. Increasing to 30.
[Experiment](https
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/427
[DONOTMERGE] debug failing builds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chemikadze/incubator-griffin
debug-failing
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/421#discussion_r219724832
--- Diff:
service/src/main/java/org/apache/griffin/core/util/YarnNetUtil.java ---
@@ -56,6 +62,14 @@ public static boolean update(String url
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/422
Minor UI fixes
"Back" button text alignment
https://user-images.githubusercontent.com/867294/45912572-79de5680-bdd8-11e8-9acb-19670b7ca3d7.png;>
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/421
GRIFFIN-197 Treat non-existing YARN app as FAILED
This avoids jobs becoming stuck in UNKNOWN state on Service side.
Also, improves logging for YARN client errors.
You can merge
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/416
However, looks like GriffinInfoController still should be updated.
---
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/419
Rethrow hive metastore exceptions
Avoid polluting cache with empty values by rethowing exceptions.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/418
Make Rule table MySQL-compatible
OUT is reserved word in MySQL, so it should be quoted in queries.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/417
Deployment and compose doc improvements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chemikadze/incubator-griffin
deployment
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/416
Oh, sorry, looks like my local copy is out of date already.
---
Github user chemikadze commented on the issue:
https://github.com/apache/incubator-griffin/pull/416
@toyboxman I remember there was similar issue in banner.txt, maybe it makes
sense to fix it there as well?
---
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/415
Bring persist/sink documentation up to date
Another followup after 7b749ad72a78eb4244bcf47a80a52f2a6e3f222f
You can merge this pull request into a Git repository by running
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin-site/pull/4
Fix mailing archives links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chemikadze/incubator-griffin-site patch-1
GitHub user chemikadze opened a pull request:
https://github.com/apache/incubator-griffin/pull/414
Updated documentation for outputs
Documentation is out of sync with code after
7b749ad72a78eb4244bcf47a80a52f2a6e3f222f.
Updating measuring examples and format description
70 matches
Mail list logo
