[RESULT][VOTE] Release Apache Groovy 2.5.0

The vote has passed with 3 binding +1 votes and 3 additional +1 votes. I'll proceed with next steps. On Sun, May 27, 2018 at 1:29 PM, Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0 release! > > This release includes 12 bug

Re: [VOTE] Release Apache Groovy 2.5.0

+1 Looks good from what I've tried. On Mon, May 28, 2018 at 5:51 AM, John Wagenleitner < john.wagenleit...@gmail.com> wrote: > +1 (binding) > > > On Sat, May 26, 2018 at 8:29 PM Paul King wrote: > >> >> Dear development community, >> >> I am happy to start the VOTE thread for a Groovy 2.5.0

Re: [VOTE] Release Apache Groovy 2.5.0

+1 (binding) On Sat, May 26, 2018 at 8:29 PM Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0 release! > > This release includes 12 bug fixes/improvements as outlined in the > changelog: > >

Re: [VOTE] Release Apache Groovy 2.5.0

Hi Paul, +1 from me. I downloaded the source distribution and ran tests, all tests pass on my machine. Here is the my machine info: Gradle 4.7 Build time:

Re: [VOTE] Release Apache Groovy 2.5.0

+1 -- Russel. == Dr Russel Winder t: +44 20 7585 2200 41 Buckmaster Roadm: +44 7770 465 077 London SW11 1EN, UK w: www.russel.org.uk signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Groovy 2.5.0

+1 Super happy to see 2.5 going out! Le dim. 27 mai 2018 à 05:29, Paul King a écrit : > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0 release! > > This release includes 12 bug fixes/improvements as outlined in the > changelog: > >

[RESULT][VOTE] Release Apache Groovy 2.5.0-rc-3

The vote has passed with 4 binding +1 votes and 4 additional +1 votes. I'll proceed with next steps. Cheers, Paul. On Sun, May 20, 2018 at 1:40 AM, Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release! > >

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

a...@asert.com.au> > Date: Tue, May 22, 2018 at 12:22 PM > Subject: Re: [VOTE] Release Apache Groovy 2.5.0-rc-3 > To: Remko Popma <remko.po...@gmail.com> > > > The warnings are by design. The java.time classes are only in JDK8, so our > extensions wouldn't make sense

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

:22 PM > Subject: Re: [VOTE] Release Apache Groovy 2.5.0-rc-3 > To: Remko Popma <remko.po...@gmail.com> > > > The warnings are by design. The java.time classes are only in JDK8, so our > extensions wouldn't make sense to load in JDK7. > > The windows warning is I

Fwd: [VOTE] Release Apache Groovy 2.5.0-rc-3

Sorry, I accidentally went off-list. -- Forwarded message -- From: Paul King <pa...@asert.com.au> Date: Tue, May 22, 2018 at 12:22 PM Subject: Re: [VOTE] Release Apache Groovy 2.5.0-rc-3 To: Remko Popma <remko.po...@gmail.com> The warnings are by design. The java.

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

Potential Java 7 issue: When I run the grape, groovyDoc, groovyConsole or groovysh command line tools with environment variable JAVA_HOME set to my JDK-7 installation, I see two warnings that the extensions and the static extensions for Date could not be installed. $ groovyDoc May 22, 2018

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

If you run: ./gradlew rat It should exclude all the necessary files using the excludes in gradle/quality.gradle (the excludes list actually has some extra entries so you can run it on the full repo - which includes a few things we don't put in the src zip) As for the other tools still using

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

No bug in your example. X is picked up correctly normally but not for the forward reference in Daniel's example. So in Daniel's example the forward reference issue is one bug (now fixed). As to whether there is another bug I haven't checked. I'd say quite possibly. On Mon, May 21, 2018 at 8:32

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

It's a requirement to keep the vote open to account for subsequent -1 votes (except in circumstances like an emergency security fix). On Mon, May 21, 2018 at 2:59 PM, Remko Popma wrote: > > > > On May 21, 2018, at 13:35, Daniel.Sun wrote: > > > > My

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

> On May 21, 2018, at 13:35, Daniel.Sun wrote: > > My pleasure :-) > > P.S. You've collected more than three +1 from PMC members. Still probably good to keep the vote open for the announced 72 hours in case someone finds a showstopper. Remko > > Cheers, > Daniel.Sun >

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

My pleasure :-) P.S. You've collected more than three +1 from PMC members. Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

I suspect there is some stray "X" class on the test classpath which keeps the early checks happy until later resolution. Thanks for the fix. Cheers, Paul. On Mon, May 21, 2018 at 1:29 AM, Daniel.Sun wrote: > +1 > > All tests pass on my machine. Here is my machine info: > ```

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

+1 On 19.05.2018 17:40, Paul King wrote: Dear development community, I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release! This release includes 27 bug fixes/improvements as outlined in the changelog:

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

+1 Le dim. 20 mai 2018 à 18:30, Daniel.Sun a écrit : > "GROOVY-6167" should be finally fixed by > 1) fix resolving [1] (pushed just now, will be included in 2.5.0 GA) > 2) fix type inference [2] > > But it's really weird, I still don't know the reason why the test[3] always >

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

"GROOVY-6167" should be finally fixed by 1) fix resolving [1] (pushed just now, will be included in 2.5.0 GA) 2) fix type inference [2] But it's really weird, I still don't know the reason why the test[3] always passes... P.S. The issue number should be 6167(not 6171), it is fixed by too

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

+1 All tests pass on my machine. Here is my machine info: ``` Gradle 4.7 Build time: 2018-04-18 09:09:12 UTC Revision: b9a962bf70638332300e7f810689cb2febbd4a6c Groovy:

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

+1 Sent from my primitive Tricorder > On 20 May 2018, at 18:45, Russel Winder wrote: > > >> [ ] +1 Release Apache Groovy 2.5.0-rc-3 >> [ ] 0 I don't have a strong opinion about this, but I assume it's ok >> [ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because... >>

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

> [ ] +1 Release Apache Groovy 2.5.0-rc-3 > [ ] 0 I don't have a strong opinion about this, but I assume it's ok > [ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because... > > +1 -- Russel. == Dr Russel Winder t: +44 20 7585 2200 41 Buckmaster

Re: [VOTE] Release Apache Groovy 2.5.0-rc-3

+1 (binding) On Sat, May 19, 2018 at 8:40 AM Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release! > > This release includes 27 bug fixes/improvements as outlined in the > changelog: > >

[VOTE] Release Apache Groovy 2.5.0-rc-3

Dear development community, I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release! This release includes 27 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12343166 Tag:

[RESULT][VOTE] Release Apache Groovy 2.5.0-rc-2

The vote has passed with 4 +1 PMC votes and 3 additional +1 votes. I'll proceed with next steps. Cheers, Paul. On Thu, May 3, 2018 at 6:49 PM, Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release! > > This

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

+1 On Thu, May 3, 2018 at 6:52 PM, John Wagenleitner < john.wagenleit...@gmail.com> wrote: > +1 (binding) > > On Thu, May 3, 2018 at 1:49 AM, Paul King wrote: > >> >> Dear development community, >> >> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release! >> >>

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

+1 (binding) On Thu, May 3, 2018 at 1:49 AM, Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release! > > This release includes 16 bug fixes/improvements as outlined in the > changelog: >

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

Hi Cédric, `org.codehaus.groovy.runtime.memoize.MemoizeTest#testMemoizeConcurrently` should be fixed now. Here is the relevant commit: https://github.com/apache/groovy/commit/639264e7fe9ed44f0b81266a24748e09c6d0b921 Cheers, Daniel.Sun -- Sent from:

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

+1, even though some tests are not passing, see below, I think we should take a look at them gradle -b wrapper.gradle wrapper : ok ./gradlew clean dist: ok (https://scans.gradle.com/s/c7jwthugis7b2, we seriously need to do something for the performance of Groovydoc...) ./gradlew testAll: ko

Re: [VOTE] Release Apache Groovy 2.5.0-rc-2

+1 All tests pass, and I built groovy from source code and tested groovy console via the following code, which runs well. ``` class A { enum E { E1, E2 } } class B extends A { E e1() { E.E1 } E e2() { E.E2 } } def b = new B() assert A.E.E1 == b.e1() assert A.E.E2 == b.e2() ``` Here

[VOTE] Release Apache Groovy 2.5.0-rc-2

Dear development community, I am happy to start the VOTE thread for a Groovy 2.5.0-rc-2 release! This release includes 16 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12343030 Tag:

[RESULT][VOTE] Release Apache Groovy 2.5.0-rc-1

Thanks everyone. The vote has passed with 3 binding +1 votes and two additional +1 votes. I'll proceed with next steps. Cheers, Paul. On Sun, Apr 8, 2018 at 1:31 AM, John Wagenleitner < john.wagenleit...@gmail.com> wrote: > +1 (binding) > > > On Thu, Apr 5, 2018, 9:14 AM Paul King

Re: [VOTE] Release Apache Groovy 2.5.0-rc-1

+1 (binding) On Thu, Apr 5, 2018, 9:14 AM Paul King wrote: > > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-rc-1 release! > > This release includes 18 bug fixes/improvements as outlined in the > changelog: > >

Re: [VOTE] Release Apache Groovy 2.5.0-rc-1

+1 On 2018/04/05 16:13:57, Paul King wrote: > Dear development community,> > > I am happy to start the VOTE thread for a Groovy 2.5.0-rc-1 release!> > > This release includes 18 bug fixes/improvements as outlined in the> > changelog:> >

Re: [VOTE] Release Apache Groovy 2.5.0-rc-1

Hi Paul, I've just tried locally with the lasted snapshot (2.5.0-20180405.201629-991) and I'm getting the same error as in the CI server. Anyhow I assume you have the situation under control, therefore I retire my -1 Thanks, Paolo On Thu, Apr 5, 2018 at 6:28 PM, Paul King

Re: [VOTE] Release Apache Groovy 2.5.0-rc-1

+1 My usual build + console smoke test went fine. On Thu, Apr 5, 2018 at 6:36 PM, Daniel.Sun wrote: > +1 > > Cheers, > Daniel.Sun > > > > > -- > Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html > -- Guillaume Laforge Apache Groovy committer & PMC

Re: [VOTE] Release Apache Groovy 2.5.0-rc-1

+1 Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: [VOTE] Release Apache Groovy 2.5.0-rc-1

Hi Paolo, for some reason your build isn't getting the latest snapshots. If you run locally, it will still fail but with a known issue related to final variable analysis which is on my list for rc-2. Cheers, Paul. On Fri, Apr 6, 2018 at 2:23 AM, Paolo Di Tommaso

Re: [VOTE] Release Apache Groovy 2.5.0-rc-1

The nextflow joint build is still failing badly. http://ci.groovy-lang.org/viewType.html?buildTypeId=JointBuilds_Nextflow_Groovy25xJointBuild it's a -1 (tho not binding) p On Thu, Apr 5, 2018 at 6:13 PM, Paul King wrote: > > Dear development community, > > I am happy to

[VOTE] Release Apache Groovy 2.5.0-rc-1

Dear development community, I am happy to start the VOTE thread for a Groovy 2.5.0-rc-1 release! This release includes 18 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12342817 Tag:

Re: [VOTE] Release Apache Groovy 2.5.0-beta-2

+1 (binding) On Sun, Oct 1, 2017 at 8:16 PM, Paul King wrote: > > Dear community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-beta-2 release! > > This release includes 22 bug fixes/improvements as outlined in the > changelog: >

Re: [VOTE] Release Apache Groovy 2.5.0-beta-2

+1 (binding) As I'm travelling, I haven't had time to play much with it. I only installed it, tried a few scripts with groovy and groovyConsole. And everything went fine. Guillaume On Mon, Oct 2, 2017 at 9:46 PM, Daniel Sun wrote: > +1（binding） > > Cheers, >

Re: [VOTE] Release Apache Groovy 2.5.0-beta-2

+1（binding） Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

[VOTE] Release Apache Groovy 2.5.0-beta-2

Dear community, I am happy to start the VOTE thread for a Groovy 2.5.0-beta-2 release! This release includes 22 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12340842 Tag:

[RESULT][VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 3)

The vote has passed with 3 binding votes: Paul King Guillaume Laforge John Wagenleitner There was also 3 non-binding votes and additional votes cast during earlier candidates. I'll proceed with deploying the release. Cheers, Paul. On Thu, Mar 30, 2017 at 3:49 PM, Paul King

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 3)

+1 Was using it during my macro methods workshop (thanks to https://jitpack.io/ ), all went well :) On Sat, Apr 1, 2017 at 12:37 AM John Wagenleitner < john.wagenleit...@gmail.com> wrote: > +1 > > On Wed, Mar 29, 2017 at 10:49 PM, Paul King wrote: > > Dear community, > > I am

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 3)

+1 On Wed, Mar 29, 2017 at 10:49 PM, Paul King wrote: > Dear community, > > I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release! > > This release includes 165 bug fixes/improvements as outlined in the > changelog: >

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 3)

+1 ! On Thu, Mar 30, 2017 at 9:10 AM, Russel Winder wrote: > > > [ ] +1 Release Apache Groovy 2.5.0-alpha-1 > > [ ] 0 I don't have a strong opinion about this, but I assume it's ok > > [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because... > > Vote early, vote

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 3)

> [ ] +1 Release Apache Groovy 2.5.0-alpha-1 > [ ]  0 I don't have a strong opinion about this, but I assume it's ok > [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because... Vote early, vote often: +1 -- Russel.

[CANCELLED][VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

One failed test is something we could potentially release note but it seems just as easy to re-cut. I'll try one more time. Paul. On Thu, Mar 30, 2017 at 1:06 AM, Sergei Egorov wrote: > -1 > We have 1 failing test ( "MacroTest > testNotAMacroCall" ) > > Was caused by my

[VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 3)

Dear community, I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release! This release includes 165 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12338913 Tag:

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

I said +1 before, so +1 from me this time. -- Russel. = Dr Russel Winder t: +44 20 7585 2200 voip: sip:russel.win...@ekiga.net 41 Buckmaster Roadm: +44 7770 465 077 xmpp: rus...@winder.org.uk London SW11

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

True. But it's about "macro" method, aka "MacroGroovy". Its API also wasn't affected, basically, I just reimplemented it as a macro method :) FYI build is green now: http://ci.groovy-lang.org/viewLog.html?buildId=38463=buildResultsDiv=Groovy_Jdk8Build_2 On Wed, Mar 29, 2017 at 5:26 PM Guillaume

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

Guillaume, Yes, I fixed this test already, builds are running, locally is green as well. I had two long flights from 6am, please excuse me for today :) On Wed, Mar 29, 2017 at 5:22 PM Sergei Egorov wrote: > Jochen, > > This is a good question :) > > I'm going to present

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

Jochen, This is a good question :) I'm going to present them tomorrow on my workshop at Greach, will collect some feedback and then will start writing the docs. The only explanation you can find now is here https://github.com/bsideup/groovy-macro-methods-proposal There are open questions tho.

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

I thought I had run the tests, but I had actually run installGroovy the second time instead of running the tests too. I also get the failing test: :groovy-macro:test org.codehaus.groovy.macro.MacroTest > testNotAMacroCall FAILED java.lang.AssertionError: Closure

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

Indeed we need documentation. There's some, but that's not covering the current refactored version. Sergei, will you update it? On Wed, Mar 29, 2017 at 5:16 PM, Jochen Theodorou wrote: > > > On 29.03.2017 17:06, Sergei Egorov wrote: > >> -1 >> We have 1 failing test (

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

On 29.03.2017 17:06, Sergei Egorov wrote: -1 We have 1 failing test ( "MacroTest > testNotAMacroCall" ) Was caused by my recent change when I renamed extension module, sorry. I pushed a test fix. Assumption was incorrect, see the commit for an explanation. on a side note... where can I

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

-1 We have 1 failing test ( "MacroTest > testNotAMacroCall" ) Was caused by my recent change when I renamed extension module, sorry. I pushed a test fix. Assumption was incorrect, see the commit for an explanation. On Wed, Mar 29, 2017 at 4:18 PM Paul King wrote: > Dear

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

+1 (binding) Still builds / tests successfully, and now I don't see the error message anymore when launching groovy or groovyConsole. Guillaume On Wed, Mar 29, 2017 at 4:17 PM, Paul King wrote: > Dear community, > > I am happy to start the VOTE thread for a Groovy

[VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)

Dear community, I am happy to start the VOTE thread for a Groovy 2.5.0-alpha-1 release! This release includes 165 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12338913 Tag:

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1

The shadow gradle plugin can take care of merging resource files. Sent from my primitive Tricorder > On 29 Mar 2017, at 12:17, Sergei Egorov wrote: > > Okay, it's a leftover in build.gradle of groovy-macro. > > "org.codehaus.groovy.macro.runtime.MacroGroovyMethods" but

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1

Okay, it's a leftover in build.gradle of groovy-macro. "org.codehaus.groovy.macro.*runtime*.MacroGroovyMethods" but should be "org.codehaus.groovy.macro.*methods*.MacroGroovyMethods" Also, we don't merge "org.codehaus.groovy.transform.ASTTransformation" files when doing a jarjar-ing of

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1

Okie dokie. I haven't tried running a @Macro example though, so I can't confirm it impacts the new macro stuff from within a groovy console session or not. But that is worth a try to further debug / track this. On Wed, Mar 29, 2017 at 10:49 AM, Paul King wrote: > Yes, Sergei

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1

Yes, Sergei just spotted something similar. We're still tracking it down. It may be that groovy-macro functionality might not work (fully) in some scenarios. If we can confirm what's wrong I can cancel the VOTE and re-start the release process, otherwise we can just release note the limitation(s).

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1

+1 Would be nice to test macro stuff :) On Wed, 29 Mar 2017 at 07:18, Russel Winder wrote: > > > [ ] +1 Release Apache Groovy 2.5.0-alpha-1 > > [ ] 0 I don't have a strong opinion about this, but I assume it's ok > > [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1

Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1

> [ ] +1 Release Apache Groovy 2.5.0-alpha-1 > [ ]  0 I don't have a strong opinion about this, but I assume it's ok > [ ] -1 Do not release Apache Groovy 2.5.0-alpha-1 because... Now that Git master/HEAD is 3.0.0, I think there must be a 2.5.0 release. Given this is marked alpha, I see no