[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232502934 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232502752 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-11-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r232503178 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229823288 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229821057 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229824188 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229822193 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229823156 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-31 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r229825489 --- Diff: src/terminal/terminal/ansi_escape_codes.h --- @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228670354 --- Diff: src/terminal/terminal_handlers.c --- @@ -1422,7 +1431,7 @@ int guac_terminal_ctrl_func(guac_terminal* term, unsigned char c) {

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228667920 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228667853 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228672433 --- Diff: src/terminal/terminal_handlers.c --- @@ -469,7 +470,7 @@ static int guac_terminal_parse_xterm256_rgb(int argc, const int* argv,

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228668050 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228669193 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228668762 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/197#discussion_r228669520 --- Diff: src/terminal/ansi_escape_codes.h --- @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #197: GUACAMOLE-287: Added Constants in place ...

2018-10-26 Thread m-khan-glyptodon
GitHub user m-khan-glyptodon opened a pull request: https://github.com/apache/guacamole-server/pull/197 GUACAMOLE-287: Added Constants in place of magic numbers The constants are defined in the "ansi_escape_codes.h" file You can merge this pull request into a Git repository by