[GitHub] daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

2019-01-21 Thread GitBox
daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#discussion_r249559627 ## File path:

[GitHub] daniquir commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

2019-01-21 Thread GitBox
daniquir commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456172559 Like you have been able to verify it's a very laborious and extensive work. I take into account

[GitHub] daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

2019-01-21 Thread GitBox
daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#discussion_r249556549 ## File path: .gitignore ## @@ -1,2 +1,3 @@ *~ target/

[GitHub] daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

2019-01-21 Thread GitBox
daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#discussion_r249556760 ## File path:

[GitHub] daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

2019-01-21 Thread GitBox
daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#discussion_r24955 ## File path:

[GitHub] necouchman commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

2019-01-21 Thread GitBox
necouchman commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#discussion_r249591757 ## File path:

[GitHub] necouchman commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

2019-01-21 Thread GitBox
necouchman commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#discussion_r249591965 ## File path:

Re: [DISCUSS] Beyond 1.0.0

2019-01-21 Thread Mike Jumper
On Sun, Jan 20, 2019 at 2:24 PM Mike Jumper wrote: > On Fri, Jan 18, 2019 at 12:52 PM Nick Couchman wrote: > >> On Fri, Jan 18, 2019 at 2:37 PM Mike Jumper wrote: >> ... >> > >> > A compat layer would be pretty tricky. >> > >> > If we can somehow modify the API changes such that things are

[GitHub] necouchman commented on a change in pull request #353: GUACAMOLE-577: Support for configuring the Guacamole Proxy in LDAP Connections

2019-01-21 Thread GitBox
necouchman commented on a change in pull request #353: GUACAMOLE-577: Support for configuring the Guacamole Proxy in LDAP Connections URL: https://github.com/apache/guacamole-client/pull/353#discussion_r249611660 ## File path:

[GitHub] necouchman commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

2019-01-21 Thread GitBox
necouchman commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456212242 > Before finishing the development of those things I wanted them to be reviewed by you in case I

Re: [DISCUSS] Beyond 1.0.0

2019-01-21 Thread Mike Jumper
On Mon, Jan 21, 2019 at 5:29 PM Mike Jumper wrote: > On Sun, Jan 20, 2019 at 2:24 PM Mike Jumper wrote: > >> On Fri, Jan 18, 2019 at 12:52 PM Nick Couchman wrote: >> >>> On Fri, Jan 18, 2019 at 2:37 PM Mike Jumper wrote: >>> ... >>> > >>> > A compat layer would be pretty tricky. >>> > >>> >

[GitHub] mike-jumper opened a new pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

2019-01-21 Thread GitBox
mike-jumper opened a new pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360 [As discussed on