[GitHub] necouchman commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

necouchman commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360#discussion_r249743845 ## File path:

[GitHub] necouchman commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

necouchman commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360#discussion_r249741779 ## File path:

[GitHub] daniquir commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

daniquir commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456356442 Ok, I'll make the changes as soon as possible. I will investigate what you say about NetBeans

[GitHub] jjamorozo opened a new pull request #363: Merge pull request #1 from apache/master

jjamorozo opened a new pull request #363: Merge pull request #1 from apache/master URL: https://github.com/apache/guacamole-client/pull/363 Merge This is an automated message from the Apache Git Service. To respond to the

[GitHub] necouchman commented on issue #363: Merge pull request #1 from apache/master

necouchman commented on issue #363: Merge pull request #1 from apache/master URL: https://github.com/apache/guacamole-client/pull/363#issuecomment-456542244 @jjamorozo Not sure what you're doing, but I think you're doing it against the wrong repo. I'm going to close your pull request.

[GitHub] JoelB opened a new pull request #364: GUACAMOLE-704: LDAP Follow Referrals for Docker ContainerLDAP Follow Referrals for Docker Container

JoelB opened a new pull request #364: GUACAMOLE-704: LDAP Follow Referrals for Docker ContainerLDAP Follow Referrals for Docker Container URL: https://github.com/apache/guacamole-client/pull/364 This will add the ldap-follow-referrals config setting to the start.sh file for Docker. I've

[GitHub] mike-jumper commented on issue #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

mike-jumper commented on issue #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360#issuecomment-456596709 Reading through things again, I think we might need to also update

[GitHub] necouchman closed pull request #363: Merge pull request #1 from apache/master

necouchman closed pull request #363: Merge pull request #1 from apache/master URL: https://github.com/apache/guacamole-client/pull/363 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] jjamorozo commented on issue #363: Merge pull request #1 from apache/master

jjamorozo commented on issue #363: Merge pull request #1 from apache/master URL: https://github.com/apache/guacamole-client/pull/363#issuecomment-456541969 Merge This is an automated message from the Apache Git Service. To

[GitHub] JoelB closed pull request #364: GUACAMOLE-704: LDAP Follow Referrals setting for Docker containers

JoelB closed pull request #364: GUACAMOLE-704: LDAP Follow Referrals setting for Docker containers URL: https://github.com/apache/guacamole-client/pull/364 This is an automated message from the Apache Git Service. To

[GitHub] mike-jumper commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

mike-jumper commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360#discussion_r249982985 ## File path:

[GitHub] mike-jumper commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

mike-jumper commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360#discussion_r249984635 ## File path:

[GitHub] JoelB opened a new pull request #365: GUACAMOLE-704: Add ldap-follow-referrals setting for Docker containers

JoelB opened a new pull request #365: GUACAMOLE-704: Add ldap-follow-referrals setting for Docker containers URL: https://github.com/apache/guacamole-client/pull/365 JIRA Issue: https://issues.apache.org/jira/browse/GUACAMOLE-704 This will add the ldap-follow-referrals config

[GitHub] mike-jumper commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

mike-jumper commented on a change in pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360#discussion_r249990557 ## File path:

Re: [DISCUSS] Beyond 1.0.0

On Tue, Jan 22, 2019 at 19:45 Mike Jumper : > > > > > > Very nice. So shall we try for a 1.1.0 release, next (soon)? Maybe > squash > > a few more bugs that have surfaced from 1.0.0? > > > > Sounds good to me. > > > > And do we want to continue this versioning scheme, or continue to toss > >

[GitHub] necouchman merged pull request #365: GUACAMOLE-704: Add ldap-follow-referrals setting for Docker containers

necouchman merged pull request #365: GUACAMOLE-704: Add ldap-follow-referrals setting for Docker containers URL: https://github.com/apache/guacamole-client/pull/365 This is an automated message from the Apache Git Service.

Re: Build failed in Jenkins: guacamole-client-docker #28

On Tue, Jan 22, 2019 at 5:57 PM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/guacamole-client-docker/28/display/redirect?page=changes > > > > Changes: > > [jbest] GUACAMOLE-704: Add ldap-follow-referrals setting for Docker > containers > >

[GitHub] mike-jumper edited a comment on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

mike-jumper edited a comment on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456664784 > The reason why there are interfaces and empty classes is being able to share the code

[GitHub] mike-jumper commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

mike-jumper commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456664784 > The reason why there are interfaces and empty classes is being able to share the code in a

[GitHub] necouchman merged pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

necouchman merged pull request #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360 This is an automated message from the Apache

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250055304 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250055343 ## File path: src/libguac/tests/string/strlcat.c ## @@

Re: [DISCUSS] Beyond 1.0.0

On Tue, Jan 22, 2019 at 19:10 Mike Jumper wrote: > On Tue, Jan 22, 2019 at 6:50 AM Nick Couchman wrote: > > > Very cool. Was 524 the only change that would push us to a major version > > (2.0.0)? I can't remember off the top of my head if anything else > > introduced API-relevant changes. > >

Re: [DISCUSS] Beyond 1.0.0

On Tue, Jan 22, 2019 at 4:19 PM Nick Couchman wrote: > On Tue, Jan 22, 2019 at 19:10 Mike Jumper wrote: > > > On Tue, Jan 22, 2019 at 6:50 AM Nick Couchman wrote: > > > > > Very cool. Was 524 the only change that would push us to a major > version > > > (2.0.0)? I can't remember off the top

[GitHub] jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250054899 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250054761 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] mike-jumper commented on issue #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0.

mike-jumper commented on issue #360: GUACAMOLE-524: Update connect() API changes for backward compatibility with 1.0.0. URL: https://github.com/apache/guacamole-client/pull/360#issuecomment-456613503 OK - I've gone through and made sure that any guacamole-ext class which provides a

Re: [DISCUSS] Beyond 1.0.0

On Tue, Jan 22, 2019 at 6:50 AM Nick Couchman wrote: > Very cool. Was 524 the only change that would push us to a major version > (2.0.0)? I can't remember off the top of my head if anything else > introduced API-relevant changes. > Yep. Other than the changes to Connectable, no other changes

Re: [DISCUSS] Beyond 1.0.0

On Mon, Jan 21, 2019 at 8:55 PM Mike Jumper wrote: > > > > I think we can allow the old connect() to be overridden and still work as > > intended by leveraging thread-local storage. We could use a thread-local > > variable to effectively pass the tokens received by the new connect() > such > >

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250056865 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250058281 ## File path: src/protocols/rdp/rdp_fs.c ## @@ -607,11

[GitHub] jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250056305 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250057913 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250057929 ## File path: src/protocols/rdp/rdp_fs.c ## @@ -607,11

Jenkins build is back to normal : guacamole-client-docker #30

See

[GitHub] jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250056434 ## File path: src/libguac/tests/string/strlcpy.c ## @@

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250057217 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] necouchman commented on issue #362: GUACAMOLE-712: Add Danish to RDP

necouchman commented on issue #362: GUACAMOLE-712: Add Danish to RDP URL: https://github.com/apache/guacamole-client/pull/362#issuecomment-456637235 @netromnetrom Thanks for the contribution! If you could create a single pull request with all of the changes, that would be great.

Build failed in Jenkins: guacamole-client-docker #28

See Changes: [jbest] GUACAMOLE-704: Add ldap-follow-referrals setting for Docker containers [jbest] GUACAMOLE-704: Add ldap-follow-referrals setting for Docker containers

Build failed in Jenkins: guacamole-client-docker #29

See Changes: [mjumper] GUACAMOLE-524: Provide bridge implementations of both old and new [mjumper] GUACAMOLE-524: Provide distinct, documented, internal access to raw [mjumper] GUACAMOLE-524: Leverage

[GitHub] daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#discussion_r249926894 ## File path:

[GitHub] daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

daniquir commented on a change in pull request #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#discussion_r249925043 ## File path:

[GitHub] netromnetrom opened a new pull request #362: GUACAMOLE-712

netromnetrom opened a new pull request #362: GUACAMOLE-712 URL: https://github.com/apache/guacamole-client/pull/362 Add Danish This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] netromnetrom opened a new pull request #361: GUACAMOLE-712

netromnetrom opened a new pull request #361: GUACAMOLE-712 URL: https://github.com/apache/guacamole-client/pull/361 Add Danish This is an automated message from the Apache Git Service. To respond to the message, please log