On Mon, Jan 21, 2019 at 8:55 PM Mike Jumper <[email protected]> wrote:
> > > > I think we can allow the old connect() to be overridden and still work as > > intended by leveraging thread-local storage. We could use a thread-local > > variable to effectively pass the tokens received by the new connect() > such > > that they are available internally by SimpleConnection's implementation > of > > the old connect(). With the new version internally leveraging the old, > > users which override either will see the behavior they expect. > > > > The GuacamoleConfiguration returned by getConfiguration() would still no > > longer have tokens applied, unlike past releases where tokens were baked > in > > before each instance of SimpleConnection was created, but perhaps that's > a > > reasonable enough sacrifice? > > > > For example: > > > https://github.com/mike-jumper/guacamole-client/commit/7e67dde75155ab88af4570bcfeb3a94175093fc9 Very cool. Was 524 the only change that would push us to a major version (2.0.0)? I can't remember off the top of my head if anything else introduced API-relevant changes. -Nick
