[GitHub] incubator-hawq pull request: HAWQ-363. Add guc variables for contr...

[jiny2]

GitHub user jiny2 opened a pull request:

https://github.com/apache/incubator-hawq/pull/294

HAWQ-363. Add guc variables for controlling FTS heartbeat interval an…

hawq_rm_segment_heartbeat_interval, control interval of sending heart-beat 
in a HAWQ segment. default 30s
hawq_rm_segment_timeout, HAWQ RM sets one segment down if its heart-beat is 
not received for more than hawq_rm_segment_timeout seconds. default 300s
hawq_rm_segment_config_refresh_interval, the interval for periodically 
checking local host configuration. default 30s
hawq_rm_segment_tmpdir_detect_interval, the interval for periodically 
checking temporary directories. default 300s

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jiny2/incubator-hawq HAWQ-363

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #294


commit caf4a797f3f8fe59a77e707ecb166aef8bafd81a
Author: YI JIN 
Date:   2016-01-26T03:55:48Z

HAWQ-363. Add guc variables for controlling FTS heartbeat interval and 
timeout




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] HAWQ 2.0.0-beta-incubating RC4

[陶征霖]

+1
Downloaded, deployed and tested

2016-01-26 13:35 GMT+08:00 Yi Jin :

> +1
>
> What I have done:
> 1) Downloaded, deployed and tested the project.
> 2) Reviewed LICENSE, COPYRIGHT, DISCLAIMER and NOTICE files.
>
> Best,
> Yi Jin
>
> On Tue, Jan 26, 2016 at 4:14 PM, Ruilong Huo  wrote:
>
> > Downloaded, deployed, tested and reviewed it. +1
> >
> > Best regards,
> > Ruilong Huo
> >
> > On Tue, Jan 26, 2016 at 12:41 PM, Lei Chang 
> wrote:
> >
> > > +1 (binding)
> > >
> > > Cheers
> > > Lei
> > >
> > >
> > > On Tue, Jan 26, 2016 at 6:33 AM, Roman Shaposhnik <
> ro...@shaposhnik.org>
> > > wrote:
> > >
> > > > Lei, can you please explicitly cast +1/-1 vote?
> > > >
> > > > Thanks,
> > > > Roman.
> > > >
> > > > On Sun, Jan 24, 2016 at 7:50 PM, Lei Chang 
> > wrote:
> > > > > Look good!
> > > > >
> > > > > Run mvn verify, get:
> > > > >
> > > > > *
> > > > >
> > > > > Summary
> > > > >
> > > > > ---
> > > > >
> > > > > Generated at: 2016-01-24T19:50:43-08:00
> > > > >
> > > > > Notes: 5
> > > > >
> > > > > Binaries: 0
> > > > >
> > > > > Archives: 0
> > > > >
> > > > > Standards: 2627
> > > > >
> > > > > Apache Licensed: 1796
> > > > >
> > > > > Generated Documents: 0
> > > > >
> > > > > JavaDocs are generated and so license header is optional
> > > > >
> > > > > Generated files do not required license headers
> > > > >
> > > > > 0 Unknown Licenses
> > > > >
> > > > > ***
> > > > >
> > > > > Unapproved licenses:
> > > > >
> > > > > ***
> > > > >
> > > > > Cheers
> > > > >
> > > > > Lei Chang
> > > > >
> > > > > On Sat, Jan 23, 2016 at 9:14 AM, Roman Shaposhnik <
> > > ro...@shaposhnik.org>
> > > > > wrote:
> > > > >
> > > > >> On Fri, Jan 22, 2016 at 11:20 AM, Caleb Welton <
> cwel...@pivotal.io>
> > > > wrote:
> > > > >> > First question for me is:
> > > > >> > - We have a couple existing jiras on IP clearance, including
> > > > >> >   - https://issues.apache.org/jira/browse/HAWQ-184
> > > > >> >   - https://issues.apache.org/jira/browse/HAWQ-207
> > > > >> >
> > > > >> > In particular if HAWQ-184 has *not* been resolved then how are
> we
> > > > clear
> > > > >> of
> > > > >> > our IP issues?  I see that there was a commit associated with
> the
> > > > issue,
> > > > >> so
> > > > >> > perhaps this is just a lack of jira hygiene?
> > > > >>
> > > > >> I wasn't too eager to resolve 184 until the vote passes,
> > > > >> as for 207 -- that ended up being fixed in a different way
> > > > >> and I resolve it as not applicable anymore.
> > > > >>
> > > > >> Thanks,
> > > > >> Roman.
> > > > >>
> > > >
> > >
> >
>



-- 
陶征霖
Pivotal

Re: [VOTE] HAWQ 2.0.0-beta-incubating RC4

[Lei Chang]

+1 (binding)

Cheers
Lei


On Tue, Jan 26, 2016 at 6:33 AM, Roman Shaposhnik 
wrote:

> Lei, can you please explicitly cast +1/-1 vote?
>
> Thanks,
> Roman.
>
> On Sun, Jan 24, 2016 at 7:50 PM, Lei Chang  wrote:
> > Look good!
> >
> > Run mvn verify, get:
> >
> > *
> >
> > Summary
> >
> > ---
> >
> > Generated at: 2016-01-24T19:50:43-08:00
> >
> > Notes: 5
> >
> > Binaries: 0
> >
> > Archives: 0
> >
> > Standards: 2627
> >
> > Apache Licensed: 1796
> >
> > Generated Documents: 0
> >
> > JavaDocs are generated and so license header is optional
> >
> > Generated files do not required license headers
> >
> > 0 Unknown Licenses
> >
> > ***
> >
> > Unapproved licenses:
> >
> > ***
> >
> > Cheers
> >
> > Lei Chang
> >
> > On Sat, Jan 23, 2016 at 9:14 AM, Roman Shaposhnik 
> > wrote:
> >
> >> On Fri, Jan 22, 2016 at 11:20 AM, Caleb Welton 
> wrote:
> >> > First question for me is:
> >> > - We have a couple existing jiras on IP clearance, including
> >> >   - https://issues.apache.org/jira/browse/HAWQ-184
> >> >   - https://issues.apache.org/jira/browse/HAWQ-207
> >> >
> >> > In particular if HAWQ-184 has *not* been resolved then how are we
> clear
> >> of
> >> > our IP issues?  I see that there was a commit associated with the
> issue,
> >> so
> >> > perhaps this is just a lack of jira hygiene?
> >>
> >> I wasn't too eager to resolve 184 until the vote passes,
> >> as for 207 -- that ended up being fixed in a different way
> >> and I resolve it as not applicable anymore.
> >>
> >> Thanks,
> >> Roman.
> >>
>

Re: [VOTE] HAWQ 2.0.0-beta-incubating RC4

[Yi Jin]

+1

What I have done:
1) Downloaded, deployed and tested the project.
2) Reviewed LICENSE, COPYRIGHT, DISCLAIMER and NOTICE files.

Best,
Yi Jin

On Tue, Jan 26, 2016 at 4:14 PM, Ruilong Huo  wrote:

> Downloaded, deployed, tested and reviewed it. +1
>
> Best regards,
> Ruilong Huo
>
> On Tue, Jan 26, 2016 at 12:41 PM, Lei Chang  wrote:
>
> > +1 (binding)
> >
> > Cheers
> > Lei
> >
> >
> > On Tue, Jan 26, 2016 at 6:33 AM, Roman Shaposhnik 
> > wrote:
> >
> > > Lei, can you please explicitly cast +1/-1 vote?
> > >
> > > Thanks,
> > > Roman.
> > >
> > > On Sun, Jan 24, 2016 at 7:50 PM, Lei Chang 
> wrote:
> > > > Look good!
> > > >
> > > > Run mvn verify, get:
> > > >
> > > > *
> > > >
> > > > Summary
> > > >
> > > > ---
> > > >
> > > > Generated at: 2016-01-24T19:50:43-08:00
> > > >
> > > > Notes: 5
> > > >
> > > > Binaries: 0
> > > >
> > > > Archives: 0
> > > >
> > > > Standards: 2627
> > > >
> > > > Apache Licensed: 1796
> > > >
> > > > Generated Documents: 0
> > > >
> > > > JavaDocs are generated and so license header is optional
> > > >
> > > > Generated files do not required license headers
> > > >
> > > > 0 Unknown Licenses
> > > >
> > > > ***
> > > >
> > > > Unapproved licenses:
> > > >
> > > > ***
> > > >
> > > > Cheers
> > > >
> > > > Lei Chang
> > > >
> > > > On Sat, Jan 23, 2016 at 9:14 AM, Roman Shaposhnik <
> > ro...@shaposhnik.org>
> > > > wrote:
> > > >
> > > >> On Fri, Jan 22, 2016 at 11:20 AM, Caleb Welton 
> > > wrote:
> > > >> > First question for me is:
> > > >> > - We have a couple existing jiras on IP clearance, including
> > > >> >   - https://issues.apache.org/jira/browse/HAWQ-184
> > > >> >   - https://issues.apache.org/jira/browse/HAWQ-207
> > > >> >
> > > >> > In particular if HAWQ-184 has *not* been resolved then how are we
> > > clear
> > > >> of
> > > >> > our IP issues?  I see that there was a commit associated with the
> > > issue,
> > > >> so
> > > >> > perhaps this is just a lack of jira hygiene?
> > > >>
> > > >> I wasn't too eager to resolve 184 until the vote passes,
> > > >> as for 207 -- that ended up being fixed in a different way
> > > >> and I resolve it as not applicable anymore.
> > > >>
> > > >> Thanks,
> > > >> Roman.
> > > >>
> > >
> >
>

Re: [VOTE] HAWQ 2.0.0-beta-incubating RC4

[Hubert Zhang]

Downloaded and reviewed
+1

On Tue, Jan 26, 2016 at 2:20 PM, 陶征霖  wrote:

> +1
> Downloaded, deployed and tested
>
> 2016-01-26 13:35 GMT+08:00 Yi Jin :
>
> > +1
> >
> > What I have done:
> > 1) Downloaded, deployed and tested the project.
> > 2) Reviewed LICENSE, COPYRIGHT, DISCLAIMER and NOTICE files.
> >
> > Best,
> > Yi Jin
> >
> > On Tue, Jan 26, 2016 at 4:14 PM, Ruilong Huo  wrote:
> >
> > > Downloaded, deployed, tested and reviewed it. +1
> > >
> > > Best regards,
> > > Ruilong Huo
> > >
> > > On Tue, Jan 26, 2016 at 12:41 PM, Lei Chang 
> > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > Cheers
> > > > Lei
> > > >
> > > >
> > > > On Tue, Jan 26, 2016 at 6:33 AM, Roman Shaposhnik <
> > ro...@shaposhnik.org>
> > > > wrote:
> > > >
> > > > > Lei, can you please explicitly cast +1/-1 vote?
> > > > >
> > > > > Thanks,
> > > > > Roman.
> > > > >
> > > > > On Sun, Jan 24, 2016 at 7:50 PM, Lei Chang 
> > > wrote:
> > > > > > Look good!
> > > > > >
> > > > > > Run mvn verify, get:
> > > > > >
> > > > > > *
> > > > > >
> > > > > > Summary
> > > > > >
> > > > > > ---
> > > > > >
> > > > > > Generated at: 2016-01-24T19:50:43-08:00
> > > > > >
> > > > > > Notes: 5
> > > > > >
> > > > > > Binaries: 0
> > > > > >
> > > > > > Archives: 0
> > > > > >
> > > > > > Standards: 2627
> > > > > >
> > > > > > Apache Licensed: 1796
> > > > > >
> > > > > > Generated Documents: 0
> > > > > >
> > > > > > JavaDocs are generated and so license header is optional
> > > > > >
> > > > > > Generated files do not required license headers
> > > > > >
> > > > > > 0 Unknown Licenses
> > > > > >
> > > > > > ***
> > > > > >
> > > > > > Unapproved licenses:
> > > > > >
> > > > > > ***
> > > > > >
> > > > > > Cheers
> > > > > >
> > > > > > Lei Chang
> > > > > >
> > > > > > On Sat, Jan 23, 2016 at 9:14 AM, Roman Shaposhnik <
> > > > ro...@shaposhnik.org>
> > > > > > wrote:
> > > > > >
> > > > > >> On Fri, Jan 22, 2016 at 11:20 AM, Caleb Welton <
> > cwel...@pivotal.io>
> > > > > wrote:
> > > > > >> > First question for me is:
> > > > > >> > - We have a couple existing jiras on IP clearance, including
> > > > > >> >   - https://issues.apache.org/jira/browse/HAWQ-184
> > > > > >> >   - https://issues.apache.org/jira/browse/HAWQ-207
> > > > > >> >
> > > > > >> > In particular if HAWQ-184 has *not* been resolved then how are
> > we
> > > > > clear
> > > > > >> of
> > > > > >> > our IP issues?  I see that there was a commit associated with
> > the
> > > > > issue,
> > > > > >> so
> > > > > >> > perhaps this is just a lack of jira hygiene?
> > > > > >>
> > > > > >> I wasn't too eager to resolve 184 until the vote passes,
> > > > > >> as for 207 -- that ended up being fixed in a different way
> > > > > >> and I resolve it as not applicable anymore.
> > > > > >>
> > > > > >> Thanks,
> > > > > >> Roman.
> > > > > >>
> > > > >
> > > >
> > >
> >
>
>
>
> --
> 陶征霖
> Pivotal
>

Re: [VOTE] HAWQ 2.0.0-beta-incubating RC4

[Roman Shaposhnik]

On Wed, Jan 20, 2016 at 3:34 PM, Ting(Goden) Yao  wrote:
> This is the 1st release for Apache HAWQ (incubating), version:
> 2.0.0-beta-incubating
>
> *It fixes the following issues:*
> Clear all IP related issues for HAWQ and this is a source code tarball only
> release.
> Full list of JIRAs fixed/related to the release: link
> 
>
> *** Please download, review and vote by *Friday 6pm Jan 22, 2016 PST* ***
>
> *We're voting upon the source (tag):*
> 2.0.0-beta-incubating-RC4
>
> *Source Files:*
> https://dist.apache.org/repos/dist/dev/incubator/hawq/2.0.0-beta-incubating.RC4
>
> *Tag to be voted upon:*
> https://git-wip-us.apache.org/repos/asf?p=incubator-hawq.git;a=commit;h=1b11926fef3a7ca445238c157571494c03276a82
>
>
> *KEYS file containing PGP Keys we use to sign the release:*
> https://dist.apache.org/repos/dist/dev/incubator/hawq/KEYS

+1 (binding)

* imported KEYS
* checked MD5, SHA and GPG sig
* verified LICENSE NOTICE and DISCLAIMER files
* compared the content of the tarball to the TAG
* ran RAT check and verified license headers and exclusion list (top
of the RAT report bellow)
* ran a build

Thanks,
Roman.


*
Summary
---
Generated at: 2016-01-25T23:27:45-08:00
Notes: 5
Binaries: 0
Archives: 0
Standards: 2627

Apache Licensed: 1796
Generated Documents: 0

JavaDocs are generated and so license header is optional
Generated files do not required license headers

0 Unknown Licenses

***

Unapproved licenses:


***

Archives:

*

[GitHub] incubator-hawq pull request: HAWQ-274. Fix a bug of using failed t...

[linwen]

Github user linwen closed the pull request at:

https://github.com/apache/incubator-hawq/pull/289


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: Hawq-274 Remove shared memory for tmp...

[linwen]

Github user linwen closed the pull request at:

https://github.com/apache/incubator-hawq/pull/284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-274. Fix coverity error

[linwen]

Github user linwen closed the pull request at:

https://github.com/apache/incubator-hawq/pull/288


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...

[hornn]

Github user hornn commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/290#discussion_r50758859
  
--- Diff: pxf/build.gradle ---
@@ -122,6 +124,42 @@ subprojects { subProject ->
 }
 
 project('pxf-service') {
+
+
+task generateSources {
--- End diff --

can you please add a comment in the code explaining the basic idea here? If 
I understand correctly, we replace any mention of @pxfProtocolVersion@ with the 
value from gradle.properties?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...

[hornn]

Github user hornn commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/290#discussion_r50758941
  
--- Diff: 
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/VersionResource.java
 ---
@@ -33,7 +34,7 @@
  * version e.g. {@code ...pxf/v14/Bridge}
  */
 class Version {
-final static String PXF_PROTOCOL_VERSION = "v14";
+final static String PXF_PROTOCOL_VERSION = "@pxfProtocolVersion@";
--- End diff --

also here please explain where this value is derived from


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...

[hornn]

Github user hornn commented on the pull request:

https://github.com/apache/incubator-hawq/pull/290#issuecomment-174671513
  
Really nice implementation, especially using gradle! I didn't know about 
this replacing mechanism.
+10 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...

[sansanichfb]

Github user sansanichfb commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/290#discussion_r50761090
  
--- Diff: pxf/build.gradle ---
@@ -122,6 +124,42 @@ subprojects { subProject ->
 }
 
 project('pxf-service') {
+
+
+task generateSources {
--- End diff --

Sure, let me add comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...

[sansanichfb]

Github user sansanichfb commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/290#discussion_r50761112
  
--- Diff: 
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/VersionResource.java
 ---
@@ -33,7 +34,7 @@
  * version e.g. {@code ...pxf/v14/Bridge}
  */
 class Version {
-final static String PXF_PROTOCOL_VERSION = "v14";
+final static String PXF_PROTOCOL_VERSION = "@pxfProtocolVersion@";
--- End diff --

Will add explanation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] HAWQ 2.0.0-beta-incubating RC4

[Roman Shaposhnik]

Lei, can you please explicitly cast +1/-1 vote?

Thanks,
Roman.

On Sun, Jan 24, 2016 at 7:50 PM, Lei Chang  wrote:
> Look good!
>
> Run mvn verify, get:
>
> *
>
> Summary
>
> ---
>
> Generated at: 2016-01-24T19:50:43-08:00
>
> Notes: 5
>
> Binaries: 0
>
> Archives: 0
>
> Standards: 2627
>
> Apache Licensed: 1796
>
> Generated Documents: 0
>
> JavaDocs are generated and so license header is optional
>
> Generated files do not required license headers
>
> 0 Unknown Licenses
>
> ***
>
> Unapproved licenses:
>
> ***
>
> Cheers
>
> Lei Chang
>
> On Sat, Jan 23, 2016 at 9:14 AM, Roman Shaposhnik 
> wrote:
>
>> On Fri, Jan 22, 2016 at 11:20 AM, Caleb Welton  wrote:
>> > First question for me is:
>> > - We have a couple existing jiras on IP clearance, including
>> >   - https://issues.apache.org/jira/browse/HAWQ-184
>> >   - https://issues.apache.org/jira/browse/HAWQ-207
>> >
>> > In particular if HAWQ-184 has *not* been resolved then how are we clear
>> of
>> > our IP issues?  I see that there was a commit associated with the issue,
>> so
>> > perhaps this is just a lack of jira hygiene?
>>
>> I wasn't too eager to resolve 184 until the vote passes,
>> as for 207 -- that ended up being fixed in a different way
>> and I resolve it as not applicable anymore.
>>
>> Thanks,
>> Roman.
>>

[GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...

[shivzone]

Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/290#discussion_r50771928
  
--- Diff: 
pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/rest/VersionResourceTest.java
 ---
@@ -22,21 +22,26 @@
 
 import static org.junit.Assert.assertEquals;
 
+import javax.ws.rs.core.HttpHeaders;
+import javax.ws.rs.core.MediaType;
 import javax.ws.rs.core.Response;
 
 import org.junit.Test;
 
 public class VersionResourceTest {
 
-@Test
-public void getProtocolVersion() throws Exception {
+   @Test
+   public void getProtocolVersion() throws Exception {
 
-VersionResource resource = new VersionResource();
-Response result = resource.getProtocolVersion();
+   VersionResource resource = new VersionResource();
--- End diff --

Fix your indentation to 4 space instead of 8 space


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...

[shivzone]

Github user shivzone commented on the pull request:

https://github.com/apache/incubator-hawq/pull/290#issuecomment-174725634
  
+1 Nice fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request: HAWQ-340. Make getVersion API return ...

[sansanichfb]

Github user sansanichfb commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/290#discussion_r50788596
  
--- Diff: 
pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/rest/VersionResourceTest.java
 ---
@@ -22,21 +22,26 @@
 
 import static org.junit.Assert.assertEquals;
 
+import javax.ws.rs.core.HttpHeaders;
+import javax.ws.rs.core.MediaType;
 import javax.ws.rs.core.Response;
 
 import org.junit.Test;
 
 public class VersionResourceTest {
 
-@Test
-public void getProtocolVersion() throws Exception {
+   @Test
+   public void getProtocolVersion() throws Exception {
 
-VersionResource resource = new VersionResource();
-Response result = resource.getProtocolVersion();
+   VersionResource resource = new VersionResource();
--- End diff --

@shivzone thanks, fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---