Re: Review Request: HBASE-3160: Use more intelligent priorities for PriorityCompactionQueue

2010-10-29 Thread stack
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1103/#review1709 --- Please do as separate JIRA. I committed last version of N's patch.

Build failed in Hudson: HBase-TRUNK #1596

2010-10-29 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/HBase-TRUNK/1596/changes Changes: [stack] HBASE-3169 NPE when master joins running cluster if a RIT references a RS no longer present -- [...truncated 999 lines...] Tests run: 2, Failures: 0, Errors: 0, Skipped:

Re: Review Request: Refactor Corrupt Data Tests in TestHLogSplit

2010-10-29 Thread Alex Newman
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1115/ --- (Updated 2010-10-29 13:24:54.726844) Review request for hbase and Nicolas.

Re: Review Request: Refactor Corrupt Data Tests in TestHLogSplit

2010-10-29 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1115/#review1712 --- src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java

Review Request: HBASE-3163 If we timeout PENDING_CLOSE and send another closeRegion RPC, need to handle NSRE from RS (comes as a RemoteException)

2010-10-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1130/ --- Review request for hbase and stack. Summary --- Unwraps RemoteExceptions

Re: Review Request: Refactor Corrupt Data Tests in TestHLogSplit

2010-10-29 Thread Alex Newman
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1115/ --- (Updated 2010-10-29 15:03:31.790831) Review request for hbase and Nicolas.

Re: Review Request: Refactor Corrupt Data Tests in TestHLogSplit

2010-10-29 Thread Alex Newman
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1115/#review1714 ---

Review Request: HBASE-2253: Show Block cache hit ratio for requests where cacheBlocks=true

2010-10-29 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1131/ --- Review request for hbase, stack and Jean-Daniel Cryans. Summary ---

Build failed in Hudson: HBase-TRUNK #1598

2010-10-29 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/HBase-TRUNK/1598/changes Changes: [stack] HBASE-2406 Define semantics of cell timestamps/versions -- [...truncated 998 lines...] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec Running

Re: Review Request: Add TimeRange support into Increment to optimize for counters that are partitioned on time

2010-10-29 Thread stack
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1132/#review1716 --- Ship it! Looks good to me.

Re: Review Request: Add TimeRange support into Increment to optimize for counters that are partitioned on time

2010-10-29 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1132/#review1720 --- Ship it! COMMIT THAT SHIT!

Re: Review Request: HBASE-2253: Show Block cache hit ratio for requests where cacheBlocks=true

2010-10-29 Thread stack
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1131/#review1721 --- Ship it! This is fine to commit but only after these new params have

Re: Review Request: Add TimeRange support into Increment to optimize for counters that are partitioned on time

2010-10-29 Thread Jonathan Gray
On 2010-10-29 21:19:11, Ryan Rawson wrote: trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java, line 274 http://review.cloudera.org/r/1132/diff/1/?file=16260#file16260line274 technically Increment.java has never shipped in a published version of HBase so we wont