Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-27 Thread Li Pi
+1 to 0.92 as well. On Tue, Jul 26, 2011 at 9:59 PM, Dhruba Borthakur dhr...@gmail.com wrote: This increases the efficiency of a hbase cluster tremendously. +1 for committing it earlier rather than later. -dhruba On Tue, Jul 26, 2011 at 7:29 PM, Andrew Purtell apurt...@apache.org wrote:

Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-27 Thread Nicolas Spiegelberg
+1 for 0.92. This has received a lot of testing and code review internally. We have already found/fixed a number of advanced bugs before even submitting the initial patch. Very high quality. On Jul 26, 2011, at 7:18 PM, Stack st...@duboce.net wrote: Shall we commit the patch at

Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-27 Thread Todd Lipcon
+1 to the idea of putting it in. I'm going to try to do a code review tonight. If we could hold off a day or so to commit I'd appreciate it... but if other stuff is blocked on it, go ahead whenever IMO. On Tue, Jul 26, 2011 at 11:25 PM, Nicolas Spiegelberg nspiegelb...@fb.comwrote: +1 for 0.92.

RE: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-27 Thread Jonathan Gray
+1 for 0.92 -Original Message- From: Todd Lipcon [mailto:t...@cloudera.com] Sent: Tuesday, July 26, 2011 11:27 PM To: dev@hbase.apache.org Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94? +1 to the idea of putting it in. I'm going to try to do a code review

Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-27 Thread Stack
) From: Jean-Daniel Cryans jdcry...@apache.org To: dev@hbase.apache.org Sent: Wednesday, July 27, 2011 11:36 AM Subject: Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94? +1 On Tue, Jul 26, 2011 at 7:17 PM, Stack st...@duboce.net wrote: Shall we commit the patch at https

Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-27 Thread Todd Lipcon
: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94? +1 On Tue, Jul 26, 2011 at 7:17 PM, Stack st...@duboce.net wrote: Shall we commit the patch at https://issues.apache.org/jira/browse/HBASE-3857 for 0.92? I reviewed it and its high-quality, with lots of new tests, and an attention

Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-26 Thread Ted Yu
I think this should go to 0.92 On Jul 26, 2011, at 7:17 PM, Stack st...@duboce.net wrote: Shall we commit the patch at https://issues.apache.org/jira/browse/HBASE-3857 for 0.92? I reviewed it and its high-quality, with lots of new tests, and an attention to self-migration (which it does)

Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-26 Thread Andrew Purtell
+1 It's a big patch but has seen much more testing than the typical and is of high quality as you mention. Earlier rather than later I'd say. But then let's let 0.92 bake with it sufficiently.   Best regards,    - Andy Problems worthy of attack prove their worth by hitting back. - Piet Hein

Re: [DISCUSSION] Move hfile to v2 for 0.92 rather than 0.94?

2011-07-26 Thread Dhruba Borthakur
This increases the efficiency of a hbase cluster tremendously. +1 for committing it earlier rather than later. -dhruba On Tue, Jul 26, 2011 at 7:29 PM, Andrew Purtell apurt...@apache.org wrote: +1 It's a big patch but has seen much more testing than the typical and is of high quality as you