Re: [PR] Add TUNNEL_PROXY support to AsyncConnectExec for proxy chain tunneling [httpcomponents-client]

2025-08-25 Thread via GitHub
arturobernalg closed pull request #685: Add TUNNEL_PROXY support to AsyncConnectExec for proxy chain tunneling URL: https://github.com/apache/httpcomponents-client/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HTTPCLIENT-2390: introduce RedirectMethodPolicy to control 301/302 method rewriting. [httpcomponents-client]

2025-08-25 Thread via GitHub
arturobernalg closed pull request #713: HTTPCLIENT-2390: introduce RedirectMethodPolicy to control 301/302 method rewriting. URL: https://github.com/apache/httpcomponents-client/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (HTTPCLIENT-2388) Idle connection management features

2025-08-25 Thread Sanghwa Min (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016197#comment-18016197 ] Sanghwa Min commented on HTTPCLIENT-2388: - Hi [Oleg|https://issues.apache.or

Re: HttpCore 5.3.5 release notes

2025-08-25 Thread Gary Gregory
LGTM (I made some minor edits). TY Oleg. Gary On Mon, Aug 25, 2025 at 9:48 AM Oleg Kalnichevski wrote: > > Folks > > Please review HttpCore 5.3.5 release notes and amend them as you deem > necessary. > > This would also be the right moment to test the latest 5.3.x snapshot > in your local envir

Re: [PR] Add TestConnectionClosureRace [httpcomponents-client]

2025-08-25 Thread via GitHub
rschmitt commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3221522295 FYI, I can also reproduce the h2 hang against httpcore 5.3.4, in addition to https://github.com/apache/httpcomponents-core/commit/be71c3aab1d82a1948fac22684b9b388f9e855d5. I

Re: [PR] Add TestConnectionClosureRace [httpcomponents-client]

2025-08-25 Thread via GitHub
rschmitt commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3221492859 I've amended the PR to rebase atop the latest `origin/master` and to move this test to a separate profile through the power of JUnit 5 tags. I figured that this is more like

Re: [PR] Add TestConnectionClosureRace [httpcomponents-client]

2025-08-25 Thread via GitHub
ok2c commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3221470760 > > The problem appears to be OS / JRE specific > > Testing against [apache/httpcomponents-core@be71c3a](https://github.com/apache/httpcomponents-core/commit/be71c3aab1d82

Re: [PR] Add TestConnectionClosureRace [httpcomponents-client]

2025-08-25 Thread via GitHub
ok2c commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3221451400 > > The HTTP/1.1 protocol handler by default aggressively pipelines request messages. > > That's an important detail. How does this work? Does pipelining only kick in whe

Re: [PR] Enable five-second TCP keep-alive by default [httpcomponents-core]

2025-08-25 Thread via GitHub
ok2c commented on PR #550: URL: https://github.com/apache/httpcomponents-core/pull/550#issuecomment-3221428456 > OK, I suppose I can move these defaults into the client builder. The only other default being set in these classes is the socket timeout. @rschmitt Finite socket timeout i

[jira] [Commented] (HTTPCLIENT-2390) Allow to control HTTP redirect 301/302 to not change POST to GET

2025-08-25 Thread Claus Ibsen (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016056#comment-18016056 ] Claus Ibsen commented on HTTPCLIENT-2390: - Okay thanks for the feedback. >

Re: [PR] Add TestConnectionClosureRace [httpcomponents-client]

2025-08-25 Thread via GitHub
rschmitt commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3221259325 > The problem appears to be OS / JRE specific Testing against https://github.com/apache/httpcomponents-core/commit/be71c3aab1d82a1948fac22684b9b388f9e855d5, I can rep

[jira] [Commented] (HTTPCLIENT-2390) Allow to control HTTP redirect 301/302 to not change POST to GET

2025-08-25 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016048#comment-18016048 ] Oleg Kalnichevski commented on HTTPCLIENT-2390: --- [~michael-o] "...Для

[jira] [Resolved] (HTTPCLIENT-2390) Allow to control HTTP redirect 301/302 to not change POST to GET

2025-08-25 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2390. --- Resolution: Information Provided > Allow to control HTTP redirect 301/30

Re: [PR] Enable five-second TCP keep-alive by default [httpcomponents-core]

2025-08-25 Thread via GitHub
rschmitt commented on PR #550: URL: https://github.com/apache/httpcomponents-core/pull/550#issuecomment-3221125952 OK, I suppose I can move these defaults into the client builder. The only other default being set in these classes is the socket timeout. -- This is an automated message fro

Re: [PR] Add TestConnectionClosureRace [httpcomponents-client]

2025-08-25 Thread via GitHub
rschmitt commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3221120219 > The HTTP/1.1 protocol handler by default aggressively pipelines request messages. That's an important detail. How does this work? Does pipelining only kick in when

[jira] [Commented] (HTTPCLIENT-2388) Idle connection management features

2025-08-25 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016008#comment-18016008 ] Oleg Kalnichevski commented on HTTPCLIENT-2388: --- > The validateAfterIn

HttpCore 5.3.5 release notes

2025-08-25 Thread Oleg Kalnichevski
Folks Please review HttpCore 5.3.5 release notes and amend them as you deem necessary.  This would also be the right moment to test the latest 5.3.x snapshot in your local environments and report any problems found. https://github.com/apache/httpcomponents-core/blob/5.3.x/RELEASE_NOTES.txt Oleg

Re: [PR] Clarify Javadoc for responseTimeout and socketTimeout interaction [httpcomponents-client]

2025-08-25 Thread via GitHub
ok2c commented on code in PR #712: URL: https://github.com/apache/httpcomponents-client/pull/712#discussion_r2297708092 ## httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java: ## @@ -549,6 +549,13 @@ public Builder setConnectTimeout(final long connec

Re: [PR] Add TestConnectionClosureRace [httpcomponents-client]

2025-08-25 Thread via GitHub
ok2c commented on PR #709: URL: https://github.com/apache/httpcomponents-client/pull/709#issuecomment-3219881134 @rschmitt I believe I have found the underlying cause of the problem (or misunderstanding if you agree to see it that way) Here is the thing. The HTTP/1.1 by default aggre

Re: [PR] Clarify Javadoc for responseTimeout and socketTimeout interaction [httpcomponents-client]

2025-08-25 Thread via GitHub
ok2c commented on code in PR #712: URL: https://github.com/apache/httpcomponents-client/pull/712#discussion_r2297708092 ## httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java: ## @@ -549,6 +549,13 @@ public Builder setConnectTimeout(final long connec

Re: [PR] Clarify Javadoc for responseTimeout and socketTimeout interaction [httpcomponents-client]

2025-08-25 Thread via GitHub
ok2c commented on code in PR #712: URL: https://github.com/apache/httpcomponents-client/pull/712#discussion_r2297700938 ## httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java: ## @@ -149,7 +149,15 @@ public Builder setSocketTimeout(final int soTime

Re: [PR] Clarify Javadoc for responseTimeout and socketTimeout interaction [httpcomponents-client]

2025-08-25 Thread via GitHub
ok2c commented on code in PR #712: URL: https://github.com/apache/httpcomponents-client/pull/712#discussion_r2297700938 ## httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java: ## @@ -149,7 +149,15 @@ public Builder setSocketTimeout(final int soTime

[jira] [Commented] (HTTPCLIENT-2389) Connection is not released after receiving "execution cancelled"

2025-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015902#comment-18015902 ] Grzegorz Jasiński commented on HTTPCLIENT-2389: --- Thank you [~olegk] ,