## Description:
- The Apache HttpComponents project is responsible for creating and
maintaining a toolset of low-level Java components focused on HTTP and
associated protocols
## Issues:
- There are no issues requiring board attention at this time.
- There are several casual
ok2c commented on issue #105: [HTTPCORE-572] Move examples to the src/test
folders for each module.
URL:
https://github.com/apache/httpcomponents-core/pull/105#issuecomment-463533637
@garydgregory Looks good. Could you please squash the commit though?
cstamas commented on issue #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463586677
Not a complete solution: IF relative redirects happens (and are allowed),
`java.net.URI#resolve(java.net.URI)` is being used that WILL normalize, despite
cstamas commented on issue #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463594991
@ok2c Sure, but that would mean that we need to reimplement
`java.net.URI#resolve(java.net.URI)` in body of
ok2c commented on issue #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463588140
@cstamas One can get actual `RequestConfig` settings from the execution
`HttpContext` at any point of request execution.
cstamas commented on a change in pull request #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#discussion_r256782190
##
File path: httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java
##
@@ -129,7 +129,8 @@ public static
[
https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768172#comment-16768172
]
ASF subversion and git services commented on HTTPCORE-572:
--
Commit
[
https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768170#comment-16768170
]
ASF subversion and git services commented on HTTPCORE-572:
--
Commit
[
https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768296#comment-16768296
]
ASF subversion and git services commented on HTTPCORE-572:
--
Commit
[
https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768298#comment-16768298
]
ASF subversion and git services commented on HTTPCORE-572:
--
Commit
cstamas commented on issue #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463614970
@ok2c Done
This is an automated message from the Apache Git Service.
To respond to the
garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move
examples to the src/test folders for each module.
URL:
https://github.com/apache/httpcomponents-core/pull/105#discussion_r256826050
##
File path: pom.xml
##
@@ -185,7 +185,15 @@
[
https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768284#comment-16768284
]
ASF subversion and git services commented on HTTPCORE-572:
--
Commit
ok2c commented on issue #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463603475
@cstamas Could you please squash all commits into a single one? I will go
over the changes one more time and will merge the PR.
garydgregory merged pull request #105: [HTTPCORE-572] Move examples to the
src/test folders for each module.
URL: https://github.com/apache/httpcomponents-core/pull/105
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768171#comment-16768171
]
ASF subversion and git services commented on HTTPCORE-572:
--
Commit
ok2c commented on issue #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463641012
@cstamas One of `TestFutureRequestExecutionService` tests appears to fail
intermittently due to a race condition. It is certainly unrelated to your
changes.
That sounds nice.
Can we agree to add trivial changes to master directly, for example, if I
want to Javadoc a previously undocumented method?
Gary
On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski wrote:
> Folks
>
> Since HttpComponents migration to GitBox I have been committing all my
>
[
https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768297#comment-16768297
]
ASF subversion and git services commented on HTTPCORE-572:
--
Commit
On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> That sounds nice.
>
> Can we agree to add trivial changes to master directly, for example,
> if I
> want to Javadoc a previously undocumented method?
>
I disagree rather strongly, especially if we want to keep master branch
protected.
Absolutely!
> Gesendet: Donnerstag, 14. Februar 2019 um 15:14 Uhr
> Von: "Gary Gregory"
> An: "HttpComponents Project"
> Betreff: Re: Formal code reviews and PRs
>
> That sounds nice.
>
> Can we agree to add trivial changes to master directly, for example, if I
> want to Javadoc a previously
On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote:
> > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> > > That sounds nice.
> > >
> > > Can we agree to add trivial changes to master directly, for
> > > example,
> > > if I
> > > want to Javadoc a previously undocumented method?
> >
> Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr
> Von: "Oleg Kalnichevski"
> An: "HttpComponents Project"
> Betreff: Re: Re: Formal code reviews and PRs
>
> On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote:
> > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> > > > That
ok2c commented on a change in pull request #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#discussion_r256864710
##
File path:
httpclient/src/main/java/org/apache/http/impl/client/DefaultRedirectStrategy.java
##
@@ -183,10 +190,23 @@
ok2c commented on a change in pull request #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#discussion_r256863307
##
File path: httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java
##
@@ -45,6 +46,51 @@
*/
public class
On Thu, 2019-02-14 at 16:27 +0100, Michael Osipov wrote:
> > Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr
> > Von: "Oleg Kalnichevski"
> > An: "HttpComponents Project"
> > Betreff: Re: Re: Formal code reviews and PRs
> >
> > On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote:
> > >
> On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote:
> > That sounds nice.
> >
> > Can we agree to add trivial changes to master directly, for example,
> > if I
> > want to Javadoc a previously undocumented method?
> >
>
> I disagree rather strongly, especially if we want to keep master
cstamas edited a comment on issue #136: HTTPCLIENT-1968
URL:
https://github.com/apache/httpcomponents-client/pull/136#issuecomment-463617176
@ok2c Seems Travis build failed but it is still OK for me (and Travis was OK
before squash), is there some concurrency problem in UTs?
```
rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256972993
##
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
##
@@
rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256969017
##
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/InputStreamEntity.java
##
@@
rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256966826
##
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/ByteBufferEntity.java
##
@@
rschmitt commented on a change in pull request #106: Immutable HttpEntity
classes
URL:
https://github.com/apache/httpcomponents-core/pull/106#discussion_r256973407
##
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/io/entity/SerializableEntity.java
##
@@
32 matches
Mail list logo
