Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
1. How come? That basically means that a read or write event can get
triggered by an I/O reactor thread concurrently with a timeout event triggered
by the time-wheel thread making it necessa
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
1. yes,all the time out task is executed by a separate thread. but I dont
think IOEventHandler need to synchronization because every channel has
difference IOEventHandler instance.
Github user garydgregory commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
It would be great to show a small program that demonstrates the performance
difference. Maybe something that can be run before and after the patch is
applied.
---
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
@xiaohu-zhang I have spent more time looking at the proposed change-set.
1. Do I understand it correctly that with this patch all
`IOEventHandler#timeout` events will be executed by a se
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
1. testTimeoutInSSecond method in class TestHashedWheelTimer should rename
to testTimeoutInSecond ,I dont have permission to push to your branch.
2.why delete
if (isWindows()
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
@xiaohu-zhang This is a much bigger change that I have initially
anticipated. It will take me a while to absorb it. First off, I do not think
HttpCore should expose any of those classes in i
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
that is ok.Look forward to your reply.If anything wrong,let me know.If
license is not ok,I can write it
by my self.
---
---
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
@xiaohu-zhang This is a large chunk of code that comes directly from
another project. The code is ASLv2 licensed and based on published academic
research. I personally do not see a problem t
