[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r307947633 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -115,14 +155,58 @@

[GitHub] [helix] kaisun2000 opened a new issue #364: Fix bugs in RoutingTableProvider metrics and enhance logs to record time spent

kaisun2000 opened a new issue #364: Fix bugs in RoutingTableProvider metrics and enhance logs to record time spent URL: https://github.com/apache/helix/issues/364 **Issues:** CurrentStateCache updating snapshot would miss all the existing partitions that having state change.

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307943700 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307940906 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307940435 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307940965 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307943962 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307935935 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307938009 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307939730 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307937930 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307936299 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307936299 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307935935 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.java

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307933787 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang opened a new pull request #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang opened a new pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363 ### Issues #331 ### Description The design is ensuring one read only to avoid locking during the change notification. However,

[GitHub] [helix] pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#issuecomment-515564146 @i3wangyi I've created a thread pool executor in the class as private. To avoid creating the thread pool each time at once when new a

[GitHub] [helix] dasahcc merged pull request #360: Remove TODO NPE log for computeResourceBestPossibleState

dasahcc merged pull request #360: Remove TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] jiajunwang merged pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang merged pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307863842 ## File path: helix-core/src/main/java/org/apache/helix/model/ResourceConfig.java ## @@

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307853283 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307850803 ## File path: helix-core/src/main/java/org/apache/helix/model/ResourceConfig.java ## @@ -775,17

[GitHub] [helix] jiajunwang commented on issue #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on issue #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#issuecomment-515333872 I tried to use more java 8 stream as @i3wangyi suggested. it is convenient. But I will not change all of the loops to stream.

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307472405 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -657,6

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307468949 ## File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307469162 ## File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307465191 ## File path: helix-core/src/test/java/org/apache/helix/model/TestInstanceConfig.java ## @@

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307458476 ## File path: helix-core/src/test/java/org/apache/helix/model/TestInstanceConfig.java ## @@

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307457877 ## File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ## @@ -505,6

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307456889 ## File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ## @@ -505,6

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307454764 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -657,6

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307454536 ## File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307453812 ## File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307448344 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -657,6

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307448106 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -657,6

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307448344 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -657,6

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307447376 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -80,7

[GitHub] [helix] jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

jiajunwang commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307446648 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -657,6

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307440208 ## File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ## @@ -505,6

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307437007 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -80,7

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307437507 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -657,6

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307439040 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ## @@ -657,6

[GitHub] [helix] i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer.

i3wangyi commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r307439825 ## File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java ## @@ -505,6

[GitHub] [helix] i3wangyi closed pull request #340: Log the enqueue time of clusterEvent, used to measure the blocking qu…

i3wangyi closed pull request #340: Log the enqueue time of clusterEvent, used to measure the blocking qu… URL: https://github.com/apache/helix/pull/340 This is an automated message from the Apache Git Service. To respond to

[GitHub] [helix] pkuwm opened a new issue #361: Improve WorkflowConfig.fromHelixProperty()

pkuwm opened a new issue #361: Improve WorkflowConfig.fromHelixProperty() URL: https://github.com/apache/helix/issues/361 **Problem**: fromHelixProperty() throws IllegalArgumentException if the HelixProperty is not a WorkflowConfig.

[GitHub] [helix] pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#issuecomment-514844901 > Please click the Resolve Converation if the concern has been addressed. Otherwise, it will be hard to review the code. Will do.

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r307070494 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java ## @@ -322,6 +322,22

[GitHub] [helix] i3wangyi commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

i3wangyi commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306578828 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java ## @@ -322,6

[GitHub] [helix] i3wangyi commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

i3wangyi commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306580266 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56

[GitHub] [helix] dasahcc merged pull request #356: Read Failure while reading non-existent znode.

dasahcc merged pull request #356: Read Failure while reading non-existent znode. URL: https://github.com/apache/helix/pull/356 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [helix] alirezazamani commented on a change in pull request #360: Remove TODO NPE log for computeResourceBestPossibleState

alirezazamani commented on a change in pull request #360: Remove TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360#discussion_r307054632 ## File path:

[GitHub] [helix] i3wangyi commented on issue #359: Dynamically change the processor thread name when consuming event

i3wangyi commented on issue #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#issuecomment-514812014 > Please verify this in your local deployment to make sure it works as expected It's working as expected while

[GitHub] [helix] dasahcc commented on a change in pull request #360: Remove TODO NPE log for computeResourceBestPossibleState

dasahcc commented on a change in pull request #360: Remove TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360#discussion_r307024152 ## File path:

[GitHub] [helix] alirezazamani commented on issue #360: Remove TODO NPE log for computeResourceBestPossibleState

alirezazamani commented on issue #360: Remove TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360#issuecomment-514796218 @narendly Sure. Thanks :) This is an automated message from

[GitHub] [helix] alirezazamani commented on a change in pull request #360: Remove TODO NPE log for computeResourceBestPossibleState

alirezazamani commented on a change in pull request #360: Remove TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360#discussion_r307011719 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r307010167 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java ## @@ -322,6 +322,22

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r307009266 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56 @@

[GitHub] [helix] i3wangyi commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

i3wangyi commented on a change in pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#discussion_r306977670 ## File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java

[GitHub] [helix] narendly commented on issue #360: Romve TODO NPE log for computeResourceBestPossibleState

narendly commented on issue #360: Romve TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360#issuecomment-514748462 Fix typo in title? :) On Jul 24, 2019, 20:31, at 20:31, Junkai Xue wrote: >dasahcc commented on this pull request. >

[GitHub] [helix] kaisun2000 closed issue #338: Implementation of StateModelDef access in rest 2.0

kaisun2000 closed issue #338: Implementation of StateModelDef access in rest 2.0 URL: https://github.com/apache/helix/issues/338 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [helix] kaisun2000 commented on issue #338: Implementation of StateModelDef access in rest 2.0

kaisun2000 commented on issue #338: Implementation of StateModelDef access in rest 2.0 URL: https://github.com/apache/helix/issues/338#issuecomment-514748274 Code merged into #339. This is an automated message from the

[GitHub] [helix] dasahcc commented on a change in pull request #360: Romve TODO NPE log for computeResourceBestPossibleState

dasahcc commented on a change in pull request #360: Romve TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360#discussion_r306959456 ## File path: helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java

[GitHub] [helix] dasahcc merged pull request #339: Implementation of stateModelDef modification in REST 2.0

dasahcc merged pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] narendly commented on issue #359: Dynamically change the processor thread name when consuming event

narendly commented on issue #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#issuecomment-514497403 Could we format the PR per the guidelines? :) On Jul 24, 2019, 07:17, at 07:17, jiajunwang wrote: >jiajunwang

[GitHub] [helix] jiajunwang commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

jiajunwang commented on a change in pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#discussion_r306629255 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

jiajunwang commented on a change in pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#discussion_r306630267 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

jiajunwang commented on a change in pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#discussion_r306629393 ## File path:

[GitHub] [helix] kaisun2000 opened a new pull request #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 opened a new pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339 **Issues** My PR addresses the following Helix issues and references them in the PR title: #338 **Description** Current

[GitHub] [helix] kaisun2000 commented on issue #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 commented on issue #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#issuecomment-514426296 Resolved all the issues. Ready to be merged to the apache repo.

[GitHub] [helix] kaisun2000 closed pull request #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 closed pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] alirezazamani commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

alirezazamani commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337#discussion_r306579233 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306579086 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java

[GitHub] [helix] alirezazamani commented on a change in pull request #344: Changing IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.

alirezazamani commented on a change in pull request #344: Changing IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/344#discussion_r306579065 ## File path:

[GitHub] [helix] alirezazamani opened a new pull request #360: Romve TODO NPE log for computeResourceBestPossibleState

alirezazamani opened a new pull request #360: Romve TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360 **Issues** The logs related to NPE in computeResourceBestPossibleState is not needed anymore and can be removed. (#351)

[GitHub] [helix] i3wangyi opened a new pull request #359: Dynamically change the processor thread name when consuming event

i3wangyi opened a new pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359 **Why is it necessary?** It helps the manual process of grepping the server logs of a continuous cluster event processing

[GitHub] [helix] jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306562024 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java ## @@ -322,6

[GitHub] [helix] jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306561344 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56

[GitHub] [helix] narendly commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

narendly commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#issuecomment-514407387 1. You could leave getWorkflows() as is,  and make getWorkflows(long timeout) a wrapper that calls getWorkflows() in a ExecutorService

[GitHub] [helix] jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306560312 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306557870 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56 @@

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306555356 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56 @@

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306553571 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56 @@

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306552726 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56 @@

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306552651 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java ## @@ -322,6 +322,22

[GitHub] [helix] alirezazamani commented on issue #356: Read Failure while reading non-existent znode.

alirezazamani commented on issue #356: Read Failure while reading non-existent znode. URL: https://github.com/apache/helix/pull/356#issuecomment-514395409 @narendly done :) This is an automated message from the Apache Git

[GitHub] [helix] dasahcc merged pull request #355: Change IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.

dasahcc merged pull request #355: Change IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/355 This is an automated message from the Apache Git

[GitHub] [helix] alirezazamani commented on issue #355: Change IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.

alirezazamani commented on issue #355: Change IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/355#issuecomment-514390821 @narendly I just reformatted the PR. @dasahcc Yes. You can merge it. Thanks.

[GitHub] [helix] kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306529981 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306527406 ## File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306526974 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306525969 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java

[GitHub] [helix] dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306523843 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java

[GitHub] [helix] dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306526246 ## File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java ##

[GitHub] [helix] dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

dasahcc commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306525483 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java

[GitHub] [helix] kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306521277 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r306521493 ## File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java

[GitHub] [helix] jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306517713 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56

[GitHub] [helix] jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306518919 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -850,6 +858,56

[GitHub] [helix] jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r306519517 ## File path: helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java ## @@ -322,6

[GitHub] [helix] dasahcc commented on issue #355: Change IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.

dasahcc commented on issue #355: Change IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/355#issuecomment-514373271 @alirezazamani Is it good to merge? I would like to have the final confirm before merge in.

<    1   2   3   4   5   6   7   >