Re: Review Request 51755: Support Intersect Distinct

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/ --- (Updated Oct. 15, 2016, 4:10 a.m.) Review request for hive and Ashutosh

[jira] [Created] (HIVE-14972) add a Hive command specific to q files to output HDFS file list without masking

Sergey Shelukhin created HIVE-14972: --- Summary: add a Hive command specific to q files to output HDFS file list without masking Key: HIVE-14972 URL: https://issues.apache.org/jira/browse/HIVE-14972

[jira] [Created] (HIVE-14971) Hive returns incorrect result when NOT used with <=> (null safe equals) operator

Sahil Takiar created HIVE-14971: --- Summary: Hive returns incorrect result when NOT used with <=> (null safe equals) operator Key: HIVE-14971 URL: https://issues.apache.org/jira/browse/HIVE-14971

Re: [DISCUSS] Pre-commit tests before commits

As far connecting in findbugs, etc. should we consider integrating with Apache Yetus for all this? Alan. > On Oct 14, 2016, at 12:27, Siddharth Seth wrote: > > Once we agree upon what the flow should be, I'm also in favor of reverting > patches which break things. Such

[jira] [Created] (HIVE-14970) repeated insert into is broken for buckets (incorrect results)

Sergey Shelukhin created HIVE-14970: --- Summary: repeated insert into is broken for buckets (incorrect results) Key: HIVE-14970 URL: https://issues.apache.org/jira/browse/HIVE-14970 Project: Hive

[jira] [Created] (HIVE-14969) add test cases for ACID

Sergey Shelukhin created HIVE-14969: --- Summary: add test cases for ACID Key: HIVE-14969 URL: https://issues.apache.org/jira/browse/HIVE-14969 Project: Hive Issue Type: Bug

Review Request 52900: HIVE-14959: Support distinct with windowing when CBO is disabled (Jesus Camacho Rodriguez)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52900/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-14959

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review152739 --- Ship it! Ship It! - Mohit Sabharwal On Oct. 14, 2016, 6:32

[jira] [Created] (HIVE-14968) Fix compilation failure on branch-1

Daniel Dai created HIVE-14968: - Summary: Fix compilation failure on branch-1 Key: HIVE-14968 URL: https://issues.apache.org/jira/browse/HIVE-14968 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-14967) bucketing with union is broken on Tez in certain cases

Sergey Shelukhin created HIVE-14967: --- Summary: bucketing with union is broken on Tez in certain cases Key: HIVE-14967 URL: https://issues.apache.org/jira/browse/HIVE-14967 Project: Hive

[jira] [Created] (HIVE-14966) JDBC: Make cookie-auth to be function in HTTP mode

Gopal V created HIVE-14966: -- Summary: JDBC: Make cookie-auth to be function in HTTP mode Key: HIVE-14966 URL: https://issues.apache.org/jira/browse/HIVE-14966 Project: Hive Issue Type: Bug

Re: Review Request 52708: HIVE-14913 Moved system tests to unit tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52708/#review152425 --- ql/src/test/queries/clientpositive/acid_globallimit.q (line 15)

Re: [DISCUSS] Pre-commit tests before commits

About formatting changes we could do it with at least 2 different approach: Hadoop way - the precommit script which only analyzes the code, and raises a red flag if there is more error in the patched file than before the patch - no extra effort needed for it other than creating the

Re: [DISCUSS] Pre-commit tests before commits

+1. We have a build/test environment for branch-1.2 and found the following two reasons for some of the flakiness in tests: 1. Derby leaves its database files hanging around the target directory, so the next test framework (e.g. TestMinimrCliDriver, TestMiniTezCliDriver) that runs picks up the

Re: [DISCUSS] Pre-commit tests before commits

Making global formatting changes will create a patch that changes almost every line and make git annotate useless which makes figuring out history of changes difficult. Perhaps disabling tests should require a separate +1 (ideally from initial author). On 10/14/16, 12:27 PM, "Siddharth Seth"

Re: [DISCUSS] Pre-commit tests before commits

Once we agree upon what the flow should be, I'm also in favor of reverting patches which break things. Such commits cause problems for all subsequent patches - where multiple people end up debugging the test. In terms of disabling tests - we may want to consider how often the test fails, before

[jira] [Created] (HIVE-14965) Hive on Tez automatically restarts killed query

Zsolt Tóth created HIVE-14965: - Summary: Hive on Tez automatically restarts killed query Key: HIVE-14965 URL: https://issues.apache.org/jira/browse/HIVE-14965 Project: Hive Issue Type: Bug

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

> On Oct. 13, 2016, 4:20 p.m., Mohit Sabharwal wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java, > > line 495 > > > > > > static ? The method uses non-static field conf so

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ --- (Updated Oct. 14, 2016, 6:32 p.m.) Review request for hive, Mohit Sabharwal

[jira] [Created] (HIVE-14964) Fix TestBeelineArgParsing tests

Jason Dere created HIVE-14964: - Summary: Fix TestBeelineArgParsing tests Key: HIVE-14964 URL: https://issues.apache.org/jira/browse/HIVE-14964 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-14963) Fix TestJdbc*Auth test failures

Jason Dere created HIVE-14963: - Summary: Fix TestJdbc*Auth test failures Key: HIVE-14963 URL: https://issues.apache.org/jira/browse/HIVE-14963 Project: Hive Issue Type: Sub-task

Re: Review Request 52862: HIVE-13316: Upgrade to Calcite 1.10

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52862/#review152689 ---

[jira] [Created] (HIVE-14962) Add integrations tests to test credential provider support using S3 test framework

Vihang Karajgaonkar created HIVE-14962: -- Summary: Add integrations tests to test credential provider support using S3 test framework Key: HIVE-14962 URL: https://issues.apache.org/jira/browse/HIVE-14962

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

> On Oct. 14, 2016, 3:38 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 123 > > > > > > I verified against derby and it works fine. > > > > Let me verify other

[jira] [Created] (HIVE-14961) HDFS dir permission check in SessionState. createRootHDFSDir

Ethan Aubin created HIVE-14961: -- Summary: HDFS dir permission check in SessionState. createRootHDFSDir Key: HIVE-14961 URL: https://issues.apache.org/jira/browse/HIVE-14961 Project: Hive Issue

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152688 --- beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152686 --- beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

> On Oct. 14, 2016, 2:18 p.m., Yongzhi Chen wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java, line 231 > > > > > > Is that possible a command has more than one lines? Yes. It's possible.

[jira] [Created] (HIVE-14960) Improve the stability of TestNotificationListener

Marta Kuczora created HIVE-14960: Summary: Improve the stability of TestNotificationListener Key: HIVE-14960 URL: https://issues.apache.org/jira/browse/HIVE-14960 Project: Hive Issue Type:

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152674 --- beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java

Re: Review Request 52684: HIVE-14754: Track the queries execution lifecycle times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52684/#review152673 --- Ship it! Ship It! - Peter Vary On Oct. 10, 2016, 5:54 p.m.,

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

> On Oct. 13, 2016, 8:42 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 289 > > > > > > Yeah. I thought about changing the error. But we are committing one > > script

Re: Review Request 52559: HIVE-14799: Query operation are not thread safe during its cancellation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52559/#review152659 --- The 8th version looks good to me. +1 - Yongzhi Chen On Oct.

Re: Review Request 52079: HIVE-14753: Track the number of open/closed/abandoned sessions in HS2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/ --- (Updated Oct. 14, 2016, 10:35 a.m.) Review request for hive, Gabor Szadovszky,

Review Request 52862: HIVE-13316: Upgrade to Calcite 1.10

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52862/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-13316

Re: [DISCUSS] Pre-commit tests before commits

+1 from me too. I think it lowers the barrier for the contributors, if there are clean and easy to follow rules for adding a patch. I had very good experience with the Hadoop commit flow where only “all green” results are accepted. If we are thinking about changes in the commit flow, it would

Re: Review Request 52684: HIVE-14754: Track the queries execution lifecycle times

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52684/#review152642 --- Thanks a lot for the patch, it very nice and clean! It looks

Re: [DISCUSS] Pre-commit tests before commits

+1 from my side as well. I also like the suggestion to revert a patch causing new test failures instead of expecting the owner to fix the issues in follow up jiras. And I would also have a borderline "radical" suggestion.. if a flaky test is failing and the committer isn't sure at a glance that

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

> On Oct. 13, 2016, 8:42 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 289 > > > > > > Yeah. I thought about changing the error. But we are committing one > > script

Re: Review Request 52684: HIVE-14754: Track the queries execution lifecycle times

> On Oct. 10, 2016, 1:37 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 581 > > > > > > Why this MetricsQueryLifeTimeHook is not another one of the > >

Re: [DISCUSS] Pre-commit tests before commits

+1 on the proposal. Adding more to it. A lot of time has been spent on improving the test runtime and bringing down the flaky tests. Following jiras should give an overview of the effort involved https://issues.apache.org/jira/browse/HIVE-14547 https://issues.apache.org/jira/browse/HIVE-13503

[jira] [Created] (HIVE-14959) Support distinct with windowing when CBO is disabled

Jesus Camacho Rodriguez created HIVE-14959: -- Summary: Support distinct with windowing when CBO is disabled Key: HIVE-14959 URL: https://issues.apache.org/jira/browse/HIVE-14959 Project: Hive

[jira] [Created] (HIVE-14958) Improve the 'TestClass' did not produce a TEST-*.xml file message to include list of all qfiles in a batch, batch id

Siddharth Seth created HIVE-14958: - Summary: Improve the 'TestClass' did not produce a TEST-*.xml file message to include list of all qfiles in a batch, batch id Key: HIVE-14958 URL:

[DISCUSS] Pre-commit tests before commits

There's been a lot of work to make the test runs faster, as well as more reliable via HIVE-14547, HIVE-13503, and several other jiras. Test runtimes are around the 1 hour mark, and going down. There were a few green pre-commit runs (after years?). At the same time, there's still some flaky tests.