Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-04-14 Thread Adam Szita via Review Board
> On April 9, 2020, 9:09 a.m., Adam Szita wrote: > > Ship It! Committed. This can be closed. - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#rev

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-04-09 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#review220266 --- Ship it! Ship It! - Adam Szita On April 6, 2020, 10:04 a.m

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-03-30 Thread Adam Szita via Review Board
ager.java Lines 453 (patched) <https://reviews.apache.org/r/72276/#comment308414> this is a no-op here - Adam Szita On March 27, 2020, 10:08 a.m., Peter Varga wrote: > > --- > This is an automatically generated e-mail. To

Ptest issues in recent days

2019-12-18 Thread Adam Szita
Hi, It seems like ptest was pretty much down in the last couple of days. I looked into it, and I think it should be fixed now, but I'll keep monitoring it for now. Details here: https://issues.apache.org/jira/browse/HIVE-22659 Adam

Re: Review Request 71575: HIVE-22284: Improve LLAP CacheContentsTracker to collect and display correct statistics

2019-10-08 Thread Adam Szita via Review Board
--- Thanks, Adam Szita

Re: Review Request 71575: HIVE-22284: Improve LLAP CacheContentsTracker to collect and display correct statistics

2019-10-07 Thread Adam Szita via Review Board
/ Changes: https://reviews.apache.org/r/71575/diff/2-3/ Testing --- Thanks, Adam Szita

Re: Review Request 71575: HIVE-22284: Improve LLAP CacheContentsTracker to collect and display correct statistics

2019-10-03 Thread Adam Szita via Review Board
/ Changes: https://reviews.apache.org/r/71575/diff/1-2/ Testing --- Thanks, Adam Szita

Review Request 71575: HIVE-22284: Improve LLAP CacheContentsTracker to collect and display correct statistics

2019-10-02 Thread Adam Szita via Review Board
d7de3619380d24a1aeea2bac9a66485d7d468517 Diff: https://reviews.apache.org/r/71575/diff/1/ Testing --- Thanks, Adam Szita

[jira] [Created] (HIVE-22175) TestBudyAllocator#testMTT test is flaky

2019-09-06 Thread Adam Szita (Jira)
Adam Szita created HIVE-22175: - Summary: TestBudyAllocator#testMTT test is flaky Key: HIVE-22175 URL: https://issues.apache.org/jira/browse/HIVE-22175 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-22099) GenericUDFDateFormat can't handle Julian dates properly

2019-08-12 Thread Adam Szita (JIRA)
Adam Szita created HIVE-22099: - Summary: GenericUDFDateFormat can't handle Julian dates properly Key: HIVE-22099 URL: https://issues.apache.org/jira/browse/HIVE-22099 Project: Hive Issue Type

[jira] [Created] (HIVE-22043) Make LLAP's Yarn package dir on HDFS configurable

2019-07-24 Thread Adam Szita (JIRA)
Adam Szita created HIVE-22043: - Summary: Make LLAP's Yarn package dir on HDFS configurable Key: HIVE-22043 URL: https://issues.apache.org/jira/browse/HIVE-22043 Project: Hive Issue Type: New

[jira] [Created] (HIVE-21922) Allow keytabs to be reused in LLAP yarn applications through Yarn localization

2019-06-25 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21922: - Summary: Allow keytabs to be reused in LLAP yarn applications through Yarn localization Key: HIVE-21922 URL: https://issues.apache.org/jira/browse/HIVE-21922 Project: Hive

[jira] [Created] (HIVE-21866) LLAP status service driver may get stuck with wrong Yarn app ID

2019-06-12 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21866: - Summary: LLAP status service driver may get stuck with wrong Yarn app ID Key: HIVE-21866 URL: https://issues.apache.org/jira/browse/HIVE-21866 Project: Hive

[jira] [Created] (HIVE-21681) Describe formatted shows incorrect information for multiple primary keys

2019-05-02 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21681: - Summary: Describe formatted shows incorrect information for multiple primary keys Key: HIVE-21681 URL: https://issues.apache.org/jira/browse/HIVE-21681 Project: Hive

Re: Review Request 70453: HIVE-21584 Java 11 preparation: system class loader is not URLClassLoader

2019-04-12 Thread Adam Szita via Review Board
or even inside ql (within a utility class or something) as it is repeated 3 times. - Adam Szita On April 12, 2019, 9:50 a.m., Zoltan Matyus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

[jira] [Created] (HIVE-21509) LLAP may cache corrupted column vectors and return wrong query result

2019-03-26 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21509: - Summary: LLAP may cache corrupted column vectors and return wrong query result Key: HIVE-21509 URL: https://issues.apache.org/jira/browse/HIVE-21509 Project: Hive

[jira] [Created] (HIVE-21217) Optimize range calculation for PTF

2019-02-05 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21217: - Summary: Optimize range calculation for PTF Key: HIVE-21217 URL: https://issues.apache.org/jira/browse/HIVE-21217 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-21176) SetSparkReducerParallelism should check spark.executor.instances before opening SparkSession during compilation

2019-01-29 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21176: - Summary: SetSparkReducerParallelism should check spark.executor.instances before opening SparkSession during compilation Key: HIVE-21176 URL: https://issues.apache.org/jira/browse/HIVE

[jira] [Created] (HIVE-21097) Replace SparkConf dependency from HS2 with Hadoop Conf

2019-01-07 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21097: - Summary: Replace SparkConf dependency from HS2 with Hadoop Conf Key: HIVE-21097 URL: https://issues.apache.org/jira/browse/HIVE-21097 Project: Hive Issue Type

[jira] [Created] (HIVE-21096) Remove unnecessary Spark dependency from HS2 process

2019-01-07 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21096: - Summary: Remove unnecessary Spark dependency from HS2 process Key: HIVE-21096 URL: https://issues.apache.org/jira/browse/HIVE-21096 Project: Hive Issue Type

Re: Review Request 69560: HIVE-21035: Race condition in SparkUtilities#getSparkSession

2018-12-13 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69560/#review211278 --- Ship it! Ship It! - Adam Szita On Dec. 12, 2018, 3:13 p.m

[jira] [Created] (HIVE-21015) HCatLoader can't provide statistics for tables no in default DB

2018-12-06 Thread Adam Szita (JIRA)
Adam Szita created HIVE-21015: - Summary: HCatLoader can't provide statistics for tables no in default DB Key: HIVE-21015 URL: https://issues.apache.org/jira/browse/HIVE-21015 Project: Hive

Re: Review Request 69410: HIVE-20330: HCatLoader cannot handle multiple InputJobInfo objects for a job with multiple inputs

2018-11-23 Thread Adam Szita via Review Board
HCAT_KEY_JOB_INFO. - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69410/#review210792 --- On Nov. 20, 2018, 1

Review Request 69410: HIVE-20330: HCatLoader cannot handle multiple InputJobInfo objects for a job with multiple inputs

2018-11-20 Thread Adam Szita via Review Board
--- Added (true) unit tests to verify my method of adding/retrieving InputJobInfo instances to/from config instances. Added (integration-like) unit tests to mock Pig calling HCatLoader for multiple input tables, and checking the reported input sizes. Thanks, Adam Szita

Re: Review Request 68656: HIVE-20505: upgrade org.openjdk.jmh:jmh-core to 1.21

2018-09-07 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68656/#review208448 --- Ship it! Ship It! - Adam Szita On Sept. 6, 2018, 10:07 a.m

[jira] [Created] (HIVE-20487) Update committer's list at hive.apache.org/people.html

2018-08-30 Thread Adam Szita (JIRA)
Adam Szita created HIVE-20487: - Summary: Update committer's list at hive.apache.org/people.html Key: HIVE-20487 URL: https://issues.apache.org/jira/browse/HIVE-20487 Project: Hive Issue Type

[jira] [Created] (HIVE-20384) Fix flakiness of erasure_commands.q

2018-08-14 Thread Adam Szita (JIRA)
Adam Szita created HIVE-20384: - Summary: Fix flakiness of erasure_commands.q Key: HIVE-20384 URL: https://issues.apache.org/jira/browse/HIVE-20384 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-20330) HCatLoader cannot handle multiple InputJobInfo objects for a job with multiple inputs

2018-08-07 Thread Adam Szita (JIRA)
Adam Szita created HIVE-20330: - Summary: HCatLoader cannot handle multiple InputJobInfo objects for a job with multiple inputs Key: HIVE-20330 URL: https://issues.apache.org/jira/browse/HIVE-20330

Re: Review Request 67895: Improve HiveMetaStoreClient.dropDatabase

2018-07-13 Thread Adam Szita via Review Board
/ Testing --- Drop database is an existing feature - existing tests should be fine, but since I'm poking around client side hooks I've added an HBase drop db qtest so that code path is covered Thanks, Adam Szita

Review Request 67895: Improve HiveMetaStoreClient.dropDatabase

2018-07-12 Thread Adam Szita via Review Board
/TestTableIterable.java PRE-CREATION Diff: https://reviews.apache.org/r/67895/diff/1/ Testing --- Drop database is an existing feature - existing tests should be fine, but since I'm poking around client side hooks I've added an HBase drop db qtest so that code path is covered Thanks, Adam Szita

Re: [ANNOUNCE] New committer: Adam Szita

2018-06-22 Thread Adam Szita
e Adam! > > > Congratulations! > > > > > > > On Jun 20, 2018, at 21:02, Ashutosh Chauhan > > > wrote: > > > > > > > > Apache Hive's Project Management Committee (PMC) has invited Adam > Szita > > > > to become a committer

[jira] [Created] (HIVE-19969) Dependency order (dirlist) assessment fails in yetus run

2018-06-22 Thread Adam Szita (JIRA)
Adam Szita created HIVE-19969: - Summary: Dependency order (dirlist) assessment fails in yetus run Key: HIVE-19969 URL: https://issues.apache.org/jira/browse/HIVE-19969 Project: Hive Issue Type

[jira] [Created] (HIVE-19944) Investigate and fix version mismatch of GCP

2018-06-19 Thread Adam Szita (JIRA)
Adam Szita created HIVE-19944: - Summary: Investigate and fix version mismatch of GCP Key: HIVE-19944 URL: https://issues.apache.org/jira/browse/HIVE-19944 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-19583) Some yetus working dirs are left on hivepest-server-upstream disk after test

2018-05-17 Thread Adam Szita (JIRA)
Adam Szita created HIVE-19583: - Summary: Some yetus working dirs are left on hivepest-server-upstream disk after test Key: HIVE-19583 URL: https://issues.apache.org/jira/browse/HIVE-19583 Project: Hive

Re: ptest queue

2018-05-14 Thread Adam Szita
This is now committed and has been deployed some hours ago - don't worry if you see your job failed I resubmitted everything from the queue. I will be keeping an eye on how ptest works after this change. Thanks, Adam On 2 May 2018 at 17:34, Adam Szita <sz...@cloudera.com> wrote: &g

Re: ptest queue

2018-05-02 Thread Adam Szita
I have a patch available for the voted version at https://issues.apache.org/jira/browse/HIVE-19077. Let me know what you think. On 27 April 2018 at 15:55, Adam Szita <sz...@cloudera.com> wrote: > Thanks to all for the responses. > As I see it, option 3 is the winning one. Next we

Requesting write permission on Hive wiki page

2018-04-27 Thread Adam Szita
Hi, I'd like to request an edit permission for the Hive Confluence page please. My user ID is: szita Thanks, Adam

Re: ptest queue

2018-04-27 Thread Adam Szita
. > > > > Thanks, > > Peter > > > >> On Apr 25, 2018, at 11:01 AM, Adam Szita <sz...@cloudera.com> > wrote: > >> > >> Hi all, > >> > >> I had a patch (HIVE-19077) committed with the

Re: ptest queue

2018-04-25 Thread Adam Szita
Hi all, I had a patch (HIVE-19077) committed with the original aim being the prevention of wasting resources when running ptest on the same patch multiple times: It is supposed to manage scenarios where a developer uploads HIVE-XYZ.1.patch, that gets queued in jenkins, then before execution

Re: Reload of aux jars on HiveServer2 failing

2018-04-05 Thread Adam Szita
Hi Shashank, First of all make sure your jar is not on a path configured for the non-reloadable jars as well i.e. hive.aux.jars.path; it should only be on the reloadable one. As far as I know RELOAD statement creates new classloader over the old one to make sure new jar content is loaded,

[jira] [Created] (HIVE-19077) Handle duplicate ptests requests standing in queue at the same time

2018-03-29 Thread Adam Szita (JIRA)
Adam Szita created HIVE-19077: - Summary: Handle duplicate ptests requests standing in queue at the same time Key: HIVE-19077 URL: https://issues.apache.org/jira/browse/HIVE-19077 Project: Hive

Re: PTest stuck

2018-03-23 Thread Adam Szita
This is caused by a whitespace error in itests/src/test/resources/testconfiguration.properties, fixing by HIVE-19036 On 22 March 2018 at 21:55, Jesus Camacho Rodriguez < jcamachorodrig...@hortonworks.com> wrote: > There seems to be something wrong still, there are +330 failures, it seems > like

[jira] [Created] (HIVE-19036) Fix whitespace error in testconfiguration.properties after HIVE-14032

2018-03-23 Thread Adam Szita (JIRA)
Adam Szita created HIVE-19036: - Summary: Fix whitespace error in testconfiguration.properties after HIVE-14032 Key: HIVE-19036 URL: https://issues.apache.org/jira/browse/HIVE-19036 Project: Hive

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-02-22 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review198106 --- Ship it! Ship It! - Adam Szita On Feb. 21, 2018, 11:37 a.m

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-02-22 Thread Adam Szita via Review Board
> (Updated Feb. 21, 2018, 11:37 a.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18699 > https://issues.apache.org/jira/browse/HIVE-18699 > > > Repository: hive-git > > > Description > --- > > Ext

[jira] [Created] (HIVE-18706) Ensure each Yetus execution has its own separate working dir

2018-02-13 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18706: - Summary: Ensure each Yetus execution has its own separate working dir Key: HIVE-18706 URL: https://issues.apache.org/jira/browse/HIVE-18706 Project: Hive Issue

[jira] [Created] (HIVE-18705) Improve HiveMetaStoreClient.dropDatabase

2018-02-13 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18705: - Summary: Improve HiveMetaStoreClient.dropDatabase Key: HIVE-18705 URL: https://issues.apache.org/jira/browse/HIVE-18705 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-18704) Add test.groups parameter setting to ptest

2018-02-13 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18704: - Summary: Add test.groups parameter setting to ptest Key: HIVE-18704 URL: https://issues.apache.org/jira/browse/HIVE-18704 Project: Hive Issue Type: Improvement

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

2018-02-07 Thread Adam Szita via Review Board
, this is incredibly thourough! standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java Lines 1480-1501 (patched) <https://reviews.apache.org/r/65507/#comment277012> I'd mark these helper methods as static - Adam Szita On Feb. 5, 2018, 6:01 p.m.,

Re: Yetus JDK version

2018-02-06 Thread Adam Szita
This should be fixed now, https://issues.apache.org/jira/browse/HIVE-18612 is committed and new war is deployed on our ptest server. Alan, can you please go ahead and give it another go to see if it all works fine? Thanks, Adam On 2 February 2018 at 15:42, Adam Szita <sz...@cloudera.com>

Re: Yetus JDK version

2018-02-02 Thread Adam Szita
Hi, I've taken a look on this, and I think the problem is that although setting JAVA_HOME to 1.8 JDK makes maven use 1.8 java and javac, any subprocess forked only use "java" executable which is on PATH (and not checking JAVA_HOME value.) And on the server that is a 1.7 JRE so I'm proposing a fix

[jira] [Created] (HIVE-18612) Build subprocesses under Yetus in Ptest use 1.7 jre instead of 1.8

2018-02-02 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18612: - Summary: Build subprocesses under Yetus in Ptest use 1.7 jre instead of 1.8 Key: HIVE-18612 URL: https://issues.apache.org/jira/browse/HIVE-18612 Project: Hive

[jira] [Created] (HIVE-18604) DropDatabase cascade fails when there is an index in the DB

2018-02-01 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18604: - Summary: DropDatabase cascade fails when there is an index in the DB Key: HIVE-18604 URL: https://issues.apache.org/jira/browse/HIVE-18604 Project: Hive Issue

IMetaStoreClient.getPartitionsByNames is not case insensitive on names

2018-02-01 Thread Adam Szita
Hi all, While testing the HMS API, we've found that the col name part of partition names provided to IMetaStoreClient.getPartitionsByNames method are not handled in a case insensitive matter. See related test here:

Re: Build bot comments in Jira

2018-02-01 Thread Adam Szita
Hi, I can recommend using this Chrome extension: https://github.com/gezapeti/jira-comment-collapser. It was developed by a colleague of ours who's working on Oozie. It can also be found in the store:

Re: Review Request 65353: Create tests to cover getTableMeta method

2018-01-30 Thread Adam Szita via Review Board
/hive/metastore/client/TestGetTableMeta.java PRE-CREATION Diff: https://reviews.apache.org/r/65353/diff/2/ Changes: https://reviews.apache.org/r/65353/diff/1-2/ Testing --- Have run the tests themselves Thanks, Adam Szita

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

2018-01-30 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196517 --- Ship it! Ship It! - Adam Szita On Jan. 30, 2018, 8:15 a.m

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

2018-01-29 Thread Adam Szita via Review Board
380/#comment276059> 123456 may be a contant to be considered for extraction - Adam Szita On Jan. 29, 2018, 12:27 p.m., Marta Kuczora wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

2018-01-29 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196428 --- Ship it! Ship It! - Adam Szita On Jan. 29, 2018, 12:49 p.m

[jira] [Created] (HIVE-18567) ObjectStore.getPartitionNamesNoTxn doesn't handle max param properly

2018-01-29 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18567: - Summary: ObjectStore.getPartitionNamesNoTxn doesn't handle max param properly Key: HIVE-18567 URL: https://issues.apache.org/jira/browse/HIVE-18567 Project: Hive

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

2018-01-29 Thread Adam Szita via Review Board
(input.split("/")).map(v->v.split("=")[1]).collect(toList()) - Adam Szita On Jan. 26, 2018, 1:03 p.m., Marta Kuczora wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 65353: Create tests to cover getTableMeta method

2018-01-26 Thread Adam Szita via Review Board
/r/65353/diff/1/ Testing --- Have run the tests themselves Thanks, Adam Szita

[jira] [Created] (HIVE-18554) Fix false positive test ql.io.parquet.TestHiveSchemaConverter.testMap

2018-01-26 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18554: - Summary: Fix false positive test ql.io.parquet.TestHiveSchemaConverter.testMap Key: HIVE-18554 URL: https://issues.apache.org/jira/browse/HIVE-18554 Project: Hive

[jira] [Created] (HIVE-18542) Create tests to cover getTableMeta method

2018-01-25 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18542: - Summary: Create tests to cover getTableMeta method Key: HIVE-18542 URL: https://issues.apache.org/jira/browse/HIVE-18542 Project: Hive Issue Type: Sub-task

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-25 Thread Adam Szita via Review Board
-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65217/diff/4/ Changes: https://reviews.apache.org/r/65217/diff/3-4/ Testing --- Thanks, Adam Szita

Re: Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-25 Thread Adam Szita via Review Board
/TestGetPartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65285/diff/3/ Changes: https://reviews.apache.org/r/65285/diff/2-3/ Testing --- Thanks, Adam Szita

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-25 Thread Adam Szita via Review Board
> > getNumPartitionsByFilter return 0 or an other value? Added missing assertion - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review196236 ---

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-25 Thread Adam Szita via Review Board
/hadoop/hive/metastore/client/TestListPartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65284/diff/3/ Changes: https://reviews.apache.org/r/65284/diff/2-3/ Testing --- Thanks, Adam Szita

Re: Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-24 Thread Adam Szita via Review Board
/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65285/diff/2/ Changes: https://reviews.apache.org/r/65285/diff/1-2/ Testing --- Thanks, Adam Szita

Re: Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-24 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/#review196018 --- On Jan. 24, 2018, 2:02 p.m., Adam Szita wrote: > > --- > This is

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-24 Thread Adam Szita via Review Board
/hadoop/hive/metastore/client/TestListPartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65284/diff/2/ Changes: https://reviews.apache.org/r/65284/diff/1-2/ Testing --- Thanks, Adam Szita

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196031 --- Ship it! Ship It! - Adam Szita On Jan. 23, 2018, 4:47 p.m

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-23 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review196029 --- Ship it! Ship It! - Adam Szita On Jan. 23, 2018, 11:18 a.m

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-23 Thread Adam Szita via Review Board
astore/client/TestTablesCreateDropAlterTruncate.java Lines 429 (patched) <https://reviews.apache.org/r/65265/#comment275528> Is this line of code necessary here? - Adam Szita On Jan. 23, 2018, 11:48 a.m., Pete

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-23 Thread Adam Szita via Review Board
tiple times here? - Adam Szita On Jan. 22, 2018, 2:33 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-23 Thread Adam Szita via Review Board
ttps://reviews.apache.org/r/65217/diff/2/?file=1942597#file1942597line771> > > > > Is it possible to change any other attribute of a partition besides the > > value with the rename method? Added test case for this - Adam -------

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-23 Thread Adam Szita via Review Board
(updated) - standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65217/diff/3/ Changes: https://reviews.apache.org/r/65217/diff/2-3/ Testing --- Thanks, Adam Szita

Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-23 Thread Adam Szita via Review Board
://reviews.apache.org/r/65285/diff/1/ Testing --- Thanks, Adam Szita

Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-23 Thread Adam Szita via Review Board
://reviews.apache.org/r/65284/diff/1/ Testing --- Thanks, Adam Szita

[jira] [Created] (HIVE-18510) Enable running checkstyle on test sources as well

2018-01-22 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18510: - Summary: Enable running checkstyle on test sources as well Key: HIVE-18510 URL: https://issues.apache.org/jira/browse/HIVE-18510 Project: Hive Issue Type

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-22 Thread Adam Szita via Review Board
am().collect( Collectors.toMap(col->col.getName(), col->col) ).get("id") - Adam Szita On Jan. 19, 2018, 3:17 p.m., Marta Kuczora wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

2018-01-22 Thread Adam Szita via Review Board
here and then call with that with different num values. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java Lines 463-481 (patched) <https://reviews.apache.org/r/65240/#comment275231> Same remark here relating code duplication - Adam Szita

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

2018-01-19 Thread Adam Szita via Review Board
g/r/65219/#comment275152> This is found multiple times in the code, should we create a method for it? - Adam Szita On Jan. 18, 2018, 4:58 p.m., Marta Kuczora wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-19 Thread Adam Szita via Review Board
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195795 --- On Jan. 19, 2018, 2:29 p.m., Adam Szita wrote: > > ---

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-19 Thread Adam Szita via Review Board
-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java PRE-CREATION Diff: https://reviews.apache.org/r/65217/diff/2/ Changes: https://reviews.apache.org/r/65217/diff/1-2/ Testing --- Thanks, Adam Szita

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

2018-01-19 Thread Adam Szita via Review Board
che.org/r/65213/#comment275116> Guava lib has a handy method for these use cases: ArrayList com.google.common.collect.Lists.newArrayList(E... elements) ...which is doing exactly the same + optimising on initial list size. - Adam Szita On Jan. 18, 2018, 1:11 p.m., M

Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-18 Thread Adam Szita via Review Board
PRE-CREATION Diff: https://reviews.apache.org/r/65217/diff/1/ Testing --- Thanks, Adam Szita

[jira] [Created] (HIVE-18468) Create tests to cover alterPartition and renamePartition methods

2018-01-17 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18468: - Summary: Create tests to cover alterPartition and renamePartition methods Key: HIVE-18468 URL: https://issues.apache.org/jira/browse/HIVE-18468 Project: Hive

[jira] [Created] (HIVE-18443) Ensure git gc finished in ptest prep phase before copying repo

2018-01-11 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18443: - Summary: Ensure git gc finished in ptest prep phase before copying repo Key: HIVE-18443 URL: https://issues.apache.org/jira/browse/HIVE-18443 Project: Hive Issue

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

2018-01-11 Thread Adam Szita via Review Board
--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65018/ > --- > > (Updated Jan. 11, 2018, 12:54 p.m.) > > > Review request fo

Re: apache hive builds

2017-12-15 Thread Adam Szita
This should be fixed now. Some conclusions can be seen in at: https://issues.apache.org/jira/browse/HIVE-18263?focusedCommentId=16292354=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16292354 On 11 December 2017 at 18:48, Adam Szita <sz...@cloudera.com> wrote: &g

[jira] [Created] (HIVE-18263) Ptest execution are multiple times slower sometimes due to dying executor slaves

2017-12-11 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18263: - Summary: Ptest execution are multiple times slower sometimes due to dying executor slaves Key: HIVE-18263 URL: https://issues.apache.org/jira/browse/HIVE-18263 Project

Re: apache hive builds

2017-12-11 Thread Adam Szita
Hi all, There are two things related to this: 1, We have recently applied a fix on the ptest component so we did a restart this morning. We also re-triggered all pending jobs at that time. More details: https://issues.apache.org/jira/browse/HIVE-18212 2, It seems like that for some time (even

[jira] [Created] (HIVE-18212) Make sure Yetus check always has a full log

2017-12-04 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18212: - Summary: Make sure Yetus check always has a full log Key: HIVE-18212 URL: https://issues.apache.org/jira/browse/HIVE-18212 Project: Hive Issue Type: Sub-task

Re: Integrating Yetus with Precommit job

2017-11-22 Thread Adam Szita
:) On 21 November 2017 at 17:39, Adam Szita <sz...@cloudera.com> wrote: > Hi, > > In the last days all prerequisites have been resolved for this: > -ASF headers are fixed > -checkstyle is upgraded to support Java8 > -proper checkstyle configuration has been introduced to poms

Re: Integrating Yetus with Precommit job

2017-11-21 Thread Adam Szita
od. I’ll > commit them once the tests run. > > I think you’ll need to do similar patches for storage-api, as it is also > not connected to the hive pom anymore. > > Alan. > > On Tue, Nov 7, 2017 at 6:17 AM, Adam Szita <sz...@cloudera.com> wrote: > > > Thank

[jira] [Created] (HIVE-18085) Run checkstyle on storage-api module with proper configuration

2017-11-16 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18085: - Summary: Run checkstyle on storage-api module with proper configuration Key: HIVE-18085 URL: https://issues.apache.org/jira/browse/HIVE-18085 Project: Hive Issue

[jira] [Created] (HIVE-18084) Upgrade checkstyle version to support lambdas

2017-11-16 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18084: - Summary: Upgrade checkstyle version to support lambdas Key: HIVE-18084 URL: https://issues.apache.org/jira/browse/HIVE-18084 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-18030) HCatalog can't be used with Pig on Spark

2017-11-09 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18030: - Summary: HCatalog can't be used with Pig on Spark Key: HIVE-18030 URL: https://issues.apache.org/jira/browse/HIVE-18030 Project: Hive Issue Type: Bug

Re: Integrating Yetus with Precommit job

2017-11-07 Thread Adam Szita
; > > +1 > > > Yes, I think this can help us catch many issues early on, it will be > very > > > useful! > > > > > > > > > On Mon, Nov 6, 2017 at 7:43 AM, Adam Szita <sz...@cloudera.com> wrote: > > > > > > &g

  1   2   >