> On Aug. 30, 2016, 10:35 p.m., Siddharth Seth wrote:
> > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java,
> > line 554
> > <https://reviews.apache.org/r/51312/diff/1/?file=1481607#file1481607line554>
> >
> >
> On Aug. 30, 2016, 10:36 p.m., Siddharth Seth wrote:
> > Unrelated to this patch - Any idea why 'uniq' is static/ (private static
> > final UUID uniq = UUID.randomUUID();)
>
> Sergey Shelukhin wrote:
> it's daemon identity, so it's global per
Siddharth Seth created HIVE-14685:
-
Summary: The daemon unique id in LlapZkRegistry should not be a
static var
Key: HIVE-14685
URL: https://issues.apache.org/jira/browse/HIVE-14685
Project: Hive
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51312/#review147548
---
Will look at the updated patch tomorrow.
- Siddharth Seth
On
> On Aug. 30, 2016, 10:35 p.m., Siddharth Seth wrote:
> > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java,
> > line 538
> > <https://reviews.apache.org/r/51312/diff/1/?file=1481607#file1481607line538>
> >
> &g
Siddharth Seth created HIVE-14683:
-
Summary: ptest uses invalid killall command
Key: HIVE-14683
URL: https://issues.apache.org/jira/browse/HIVE-14683
Project: Hive
Issue Type: Sub-task
Siddharth Seth created HIVE-14682:
-
Summary: Fix errors during cleanup when executing certain q files
Key: HIVE-14682
URL: https://issues.apache.org/jira/browse/HIVE-14682
Project: Hive
Siddharth Seth created HIVE-14681:
-
Summary: Remove AssertionError for non zero return codes in
QTestUtil cleanup
Key: HIVE-14681
URL: https://issues.apache.org/jira/browse/HIVE-14681
Project: Hive
Siddharth Seth created HIVE-14675:
-
Summary: Ensure directories are cleaned up on test cleanup in
QTestUtil
Key: HIVE-14675
URL: https://issues.apache.org/jira/browse/HIVE-14675
Project: Hive
/ (private static final
UUID uniq = UUID.randomUUID();)
- Siddharth Seth
On Aug. 23, 2016, 1:41 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestHostAffinitySplitLocationProvider.java
(line 94)
<https://reviews.apache.org/r/51312/#comment214490>
This isn't part of the patch uploaded to jira?
- Siddharth Seth
On Aug. 23, 2016, 1:41 a.m., Sergey Shelukhin wrote:
>
Siddharth Seth created HIVE-14669:
-
Summary: Have the actual error reported when a q test fails
instead of having to go through the logs
Key: HIVE-14669
URL: https://issues.apache.org/jira/browse/HIVE-14669
Siddharth Seth created HIVE-14668:
-
Summary: TestMiniLlapCliDriver. hybridgrace_hashjoin_1 - the first
attempt for a couple of tasks fails
Key: HIVE-14668
URL: https://issues.apache.org/jira/browse/HIVE-14668
Siddharth Seth created HIVE-14663:
-
Summary: Change ptest java language version to 1.7, other version
changes and fixes
Key: HIVE-14663
URL: https://issues.apache.org/jira/browse/HIVE-14663
Project
> On Aug. 26, 2016, 2:01 a.m., Siddharth Seth wrote:
> > Not a lot here related to the patch itself in this comment.
> > Looks like everyone has gotten interested in fixing Hive tests at about the
> > same time - and there's a good reason for that :)
> > I
have a smaller window for conflicts. There's several jiras open
to fix either testing infrastructure, or individual tests, or get things
working in the IDE. I know Zoltan was driving towards getting tests working via
the IDE - I don't know how this affects that effort.
- Siddharth Se
Siddharth Seth created HIVE-14651:
-
Summary: Add a local cluster for Tez and LLAP
Key: HIVE-14651
URL: https://issues.apache.org/jira/browse/HIVE-14651
Project: Hive
Issue Type: Task
Siddharth Seth created HIVE-14629:
-
Summary: Failing test - TestMiniLlapCliDriver.acid_bucket_pruning
Key: HIVE-14629
URL: https://issues.apache.org/jira/browse/HIVE-14629
Project: Hive
Siddharth Seth created HIVE-14628:
-
Summary: Flaky tests: MiniYarnClusterDir in /tmp -
TestPigHBaseStorageHandler
Key: HIVE-14628
URL: https://issues.apache.org/jira/browse/HIVE-14628
Project: Hive
Siddharth Seth created HIVE-14625:
-
Summary: Minor qtest fixes
Key: HIVE-14625
URL: https://issues.apache.org/jira/browse/HIVE-14625
Project: Hive
Issue Type: Sub-task
Reporter
Siddharth Seth created HIVE-14599:
-
Summary: Log hive query id to llap activity/history log
Key: HIVE-14599
URL: https://issues.apache.org/jira/browse/HIVE-14599
Project: Hive
Issue Type
Siddharth Seth created HIVE-14598:
-
Summary: Disallow newlines in query name
Key: HIVE-14598
URL: https://issues.apache.org/jira/browse/HIVE-14598
Project: Hive
Issue Type: Bug
Siddharth Seth created HIVE-14569:
-
Summary: Enable reuseForks for most modules
Key: HIVE-14569
URL: https://issues.apache.org/jira/browse/HIVE-14569
Project: Hive
Issue Type: Sub-task
Siddharth Seth created HIVE-14561:
-
Summary: Upgrade version of spring for ptest2 to work with Java8
Key: HIVE-14561
URL: https://issues.apache.org/jira/browse/HIVE-14561
Project: Hive
Issue
Siddharth Seth created HIVE-14548:
-
Summary: Add a copy of the build configuration file to the hive
repo
Key: HIVE-14548
URL: https://issues.apache.org/jira/browse/HIVE-14548
Project: Hive
Siddharth Seth created HIVE-14547:
-
Summary: [Umbrella] Test case fixes / improvements
Key: HIVE-14547
URL: https://issues.apache.org/jira/browse/HIVE-14547
Project: Hive
Issue Type: Task
Siddharth Seth created HIVE-14540:
-
Summary: Create batches for non qfile tests
Key: HIVE-14540
URL: https://issues.apache.org/jira/browse/HIVE-14540
Project: Hive
Issue Type: Sub-task
Siddharth Seth created HIVE-14539:
-
Summary: Run additional tests from the module directory
Key: HIVE-14539
URL: https://issues.apache.org/jira/browse/HIVE-14539
Project: Hive
Issue Type
Siddharth Seth created HIVE-14439:
-
Summary: LlapTaskScheduler should try scheduling tasks when a node
is disabled
Key: HIVE-14439
URL: https://issues.apache.org/jira/browse/HIVE-14439
Project: Hive
Siddharth Seth created HIVE-14430:
-
Summary: More instances of HiveConf and the associated
UDFClassLoader than expected
Key: HIVE-14430
URL: https://issues.apache.org/jira/browse/HIVE-14430
Project
Siddharth Seth created HIVE-14429:
-
Summary: HadoopMetrics2Reporter leaks memory if the metrics sink
is not configured correctly
Key: HIVE-14429
URL: https://issues.apache.org/jira/browse/HIVE-14429
Siddharth Seth created HIVE-14428:
-
Summary: HadoopMetrics2Reporter leaks memory if the metrics sink
is not configured correctly
Key: HIVE-14428
URL: https://issues.apache.org/jira/browse/HIVE-14428
Siddharth Seth created HIVE-14421:
-
Summary: FS.deleteOnExit holds references to _tmp_space.db files
Key: HIVE-14421
URL: https://issues.apache.org/jira/browse/HIVE-14421
Project: Hive
Issue
Siddharth Seth created HIVE-14405:
-
Summary: Have tests log to the console along with hive.log
Key: HIVE-14405
URL: https://issues.apache.org/jira/browse/HIVE-14405
Project: Hive
Issue Type
Siddharth Seth created HIVE-14403:
-
Summary: LLAP node specific preemption will only preempt once on a
node per AM
Key: HIVE-14403
URL: https://issues.apache.org/jira/browse/HIVE-14403
Project: Hive
Siddharth Seth created HIVE-14392:
-
Summary: llap daemons should try using YARN local dirs, if
available
Key: HIVE-14392
URL: https://issues.apache.org/jira/browse/HIVE-14392
Project: Hive
Siddharth Seth created HIVE-14364:
-
Summary: Update timeouts for llap comparator tests
Key: HIVE-14364
URL: https://issues.apache.org/jira/browse/HIVE-14364
Project: Hive
Issue Type: Task
Siddharth Seth created HIVE-14321:
-
Summary: Improvements to the log uri provided by llap to tez
Key: HIVE-14321
URL: https://issues.apache.org/jira/browse/HIVE-14321
Project: Hive
Issue
Siddharth Seth created HIVE-14316:
-
Summary: TestLlapTokenChecker.testCheckPermissions, testGetToken
fails
Key: HIVE-14316
URL: https://issues.apache.org/jira/browse/HIVE-14316
Project: Hive
Siddharth Seth created HIVE-14300:
-
Summary: LLAP: Renaming query specific files on completion should
wait for completion of threads in the daemon
Key: HIVE-14300
URL: https://issues.apache.org/jira/browse/HIVE
Siddharth Seth created HIVE-14225:
-
Summary: Llap slider package should support configuring YARN
rolling log aggregation
Key: HIVE-14225
URL: https://issues.apache.org/jira/browse/HIVE-14225
Project
Siddharth Seth created HIVE-14224:
-
Summary: LLAP rename query specific log files once a query is
complete
Key: HIVE-14224
URL: https://issues.apache.org/jira/browse/HIVE-14224
Project: Hive
Siddharth Seth created HIVE-14213:
-
Summary: Add timeouts for various components in llap status check
Key: HIVE-14213
URL: https://issues.apache.org/jira/browse/HIVE-14213
Project: Hive
Siddharth Seth created HIVE-14202:
-
Summary: Change tez version used to 0.8.4
Key: HIVE-14202
URL: https://issues.apache.org/jira/browse/HIVE-14202
Project: Hive
Issue Type: Task
Siddharth Seth created HIVE-14168:
-
Summary: Avoid serializing all parameters from HiveConf.java into
in-memory HiveConf instances
Key: HIVE-14168
URL: https://issues.apache.org/jira/browse/HIVE-14168
Siddharth Seth created HIVE-14167:
-
Summary: Use work directories provided by Tez instead of directly
using YARN local dirs
Key: HIVE-14167
URL: https://issues.apache.org/jira/browse/HIVE-14167
Siddharth Seth created HIVE-14150:
-
Summary: Hive does not compile against Hadoop-2.9.0-SNAPSHOT
Key: HIVE-14150
URL: https://issues.apache.org/jira/browse/HIVE-14150
Project: Hive
Issue
/r/48886/#comment205692>
Does it make sense to return a FragmentCompletionHandler rather than a
Closeable ?
ql/src/test/org/apache/hadoop/hive/llap/TestLlapOutputFormat.java (line 52)
<https://reviews.apache.org/r/48886/#comment205693>
Needs tests.
O
Siddharth Seth created HIVE-14102:
-
Summary: LLAP Improvements to per executor memory computation in
daemons
Key: HIVE-14102
URL: https://issues.apache.org/jira/browse/HIVE-14102
Project: Hive
Siddharth Seth created HIVE-14072:
-
Summary: SessionIds reused across different queries
Key: HIVE-14072
URL: https://issues.apache.org/jira/browse/HIVE-14072
Project: Hive
Issue Type: Bug
Siddharth Seth created HIVE-14057:
-
Summary: Add an option in llapstatus to generate output to a file
Key: HIVE-14057
URL: https://issues.apache.org/jira/browse/HIVE-14057
Project: Hive
/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java
bdf254b
Diff: https://reviews.apache.org/r/48818/diff/
Testing
---
Thanks,
Siddharth Seth
/hadoop/hive/llap/tezplugins/TestLlapTaskCommunicator.java
1901328
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java
bdf254b
Diff: https://reviews.apache.org/r/48818/diff/
Testing
---
Thanks,
Siddharth Seth
o do. It can be re-introduced if required ? (The Hook
interface still exists in TezProcessor).
- Siddharth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48818/#review138141
--
Siddharth Seth created HIVE-14042:
-
Summary: Potential improvements to abort task handling - tez/llap
Key: HIVE-14042
URL: https://issues.apache.org/jira/browse/HIVE-14042
Project: Hive
Siddharth Seth created HIVE-14041:
-
Summary: llap scripts add hadoop and other libraries from the
machine local install to the daemon classpath
Key: HIVE-14041
URL: https://issues.apache.org/jira/browse/HIVE
/
Testing
---
Thanks,
Siddharth Seth
/TestLlapTaskCommunicator.java
1901328
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java
bdf254b
Diff: https://reviews.apache.org/r/48818/diff/
Testing
---
Thanks,
Siddharth Seth
Siddharth Seth created HIVE-14023:
-
Summary: LLAP: Make the Hive query id available in ContainerRunner
Key: HIVE-14023
URL: https://issues.apache.org/jira/browse/HIVE-14023
Project: Hive
stop sending
this repeated information. Think there's a jira open to avoid sending the
VertexSpec per split - that can include sending the token only once.
- Siddharth Seth
On June 9, 2016, 7:07 p.m., Sergey Shelukhin wrote:
>
> ---
-
>
> (Updated June 2, 2016, 8:55 p.m.)
>
>
> Review request for hive and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> ---
>
> see jira
>
>
> Diffs
> -
>
> llap-client/src/java/org/apache/hadoop/hive/
unfortunately has a really large Hive configuration)
ql/src/java/org/apache/tez/dag/api/TaskSpecBuilder.java (line 66)
<https://reviews.apache.org/r/48186/#comment201101>
Please elaborate ? (This is not a public Tez API).
Should this function just be removed. Used only once -
gt; > >>
> > > > >> On Tue, Apr 19, 2016 at 10:43 AM, Mohit Sabharwal <
> > mo...@cloudera.com
> > > >
> > > > >> wrote:
> > > > >>
> > > > >> > Created HIVE-13547 to track switching 2x tests to JDK8.
> > &
Siddharth Seth created HIVE-13919:
-
Summary: TestHWISessionManager 'did not produce TEST-*.xml' is
reported incorrectly
Key: HIVE-13919
URL: https://issues.apache.org/jira/browse/HIVE-13919
Siddharth Seth created HIVE-13918:
-
Summary: Towards a green jenkins precommit build
Key: HIVE-13918
URL: https://issues.apache.org/jira/browse/HIVE-13918
Project: Hive
Issue Type: Task
Siddharth Seth created HIVE-13917:
-
Summary: Investigate and fix tests which are timing out in the
precommit build
Key: HIVE-13917
URL: https://issues.apache.org/jira/browse/HIVE-13917
Project: Hive
Siddharth Seth created HIVE-13916:
-
Summary: Reduce the max runtime of a test further
Key: HIVE-13916
URL: https://issues.apache.org/jira/browse/HIVE-13916
Project: Hive
Issue Type: Sub-task
Siddharth Seth created HIVE-13915:
-
Summary: Avoid sending the VertexSpec along with each fragment in
GenericUDTFGetSplits
Key: HIVE-13915
URL: https://issues.apache.org/jira/browse/HIVE-13915
e the unnecessary TaskSpec
creation, and potentially skipping the unnecessary VertexSpec being sent each
time as a response from GenericUDTFGetSplits.
- Siddharth Seth
On June 2, 2016, midnight, Sergey Shelukhin wrote:
>
> ---
&
s like it's being checked in createSignedVertexSpec. The
comment still seems incorrect though, since TaskSpec is never sent any longer.
Assuming the serialized spec without a signature works in LLAP (i.e. when
the daemon gets the VertexSpecBinary without a signature - it handles it
correc
> Review request for hive, Jason Dere and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> ---
>
> see JIRA. Please ignore the first iteration, RB doesn't allow base patches on
> submit
>
>
> Diffs
> -
>
> com
> On May 31, 2016, 11:09 p.m., Siddharth Seth wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java, line
> > 381
> > <https://reviews.apache.org/r/47563/diff/3/?file=1399784#file1399784line381>
> >
> > Not sure why the use
> On May 31, 2016, 11:09 p.m., Siddharth Seth wrote:
> > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java,
> > line 350
> > <https://reviews.apache.org/r/47563/diff/3/?file=1399778#file1399778line350>
> >
> > Is a signatu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46754/#review135722
---
Ship it!
Ship It!
- Siddharth Seth
On May 28, 2016, 2:04
NullPointerException.
Hopefully this will be caught by some tests.
Would be good to add a couple of tests here as well.
- Siddharth Seth
On May 27, 2016, 9:32 p.m., Sergey Shelukhin wrote:
>
>
on the test before
committing.
- Siddharth Seth
On May 27, 2016, 12:39 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
Siddharth Seth created HIVE-13858:
-
Summary: LLAP: A preempted task can end up waiting on
completeInitialization if some part of the executing code suppressed the
interrupt
Key: HIVE-13858
URL: https
wner" end up getting treated as false.
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
<https://reviews.apache.org/r/46956/#comment199458>
This parameter can be removed from HiveConf now that it's not used.
- Siddharth Seth
On M
> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote:
> > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java,
> > line 290
> > <https://reviews.apache.org/r/46956/diff/2/?file=1387298#file1387298line290>
> >
> > Wha
issue.
- Siddharth Seth
On May 20, 2016, 1:49 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
che.org/r/46956/#comment199239>
This should explicitly check for "false". Any other value should either
default to true or thrown an error. Err on the side of being secure.
- Siddharth Seth
On May 21, 2016, 12:07 a.m.,
> On May 20, 2016, 2:21 a.m., Siddharth Seth wrote:
> > llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java,
> > line 134
> > <https://reviews.apache.org/r/46956/diff/2/?file=1387295#file1387295line134>
> >
> > Can a second
Siddharth Seth created HIVE-13801:
-
Summary: LLAP UI does not seem to accept credentials
Key: HIVE-13801
URL: https://issues.apache.org/jira/browse/HIVE-13801
Project: Hive
Issue Type: Bug
Siddharth Seth created HIVE-13800:
-
Summary: Disable auth enabled by default on LLAP UI for secure
clusters
Key: HIVE-13800
URL: https://issues.apache.org/jira/browse/HIVE-13800
Project: Hive
The one created earlier to generate tokens should be passed in.
The KeySigner could be an interface instead, and SecretManager (extends
ZKDelegationTokenSecretManager) can implement this. ACL checks etc are already
setup there. There's no requirement to have two independent c
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47546/#review134040
---
Ship it!
Ship It!
- Siddharth Seth
On May 18, 2016, 7:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46579/#review133646
---
Ship it!
Ship It!
- Siddharth Seth
On May 17, 2016, 9:58
-
>
> (Updated May 17, 2016, 9:58 p.m.)
>
>
> Review request for hive, Gunther Hagleitner, Siddharth Seth, and Vikram Dixit
> Kumaraswamy.
>
>
> Repository: hive-git
>
>
> Description
> ---
>
> see JIRA
>
>
> Diffs
a performance
perspective, as well as to make sure the threads started by the SecretManager
are shutdown.
- Siddharth Seth
On May 17, 2016, 12:56 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail.
time.
Looks like not sharing the SecretManager could be expensive given the KDC
login each time ?
- Siddharth Seth
On May 5, 2016, 9:55 p.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generat
Siddharth Seth created HIVE-13678:
-
Summary: Add a utility method to construct various urls related to
a single llap instance
Key: HIVE-13678
URL: https://issues.apache.org/jira/browse/HIVE-13678
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46597/#review131512
---
Ship it!
Looks good.
- Siddharth Seth
On May 2, 2016, 10:01
/LlapSecurityHelper.java
(line 95)
<https://reviews.apache.org/r/46754/#comment195512>
Wondering if this ends up being a little too brittle. HADOOP-13081 itself
may break this code.
- Siddharth Seth
On May 2, 2016, 9:44 p.m., Sergey Shelukhin
Siddharth Seth created HIVE-13667:
-
Summary: Improve performance for ServiceInstanceSet.getByHost
Key: HIVE-13667
URL: https://issues.apache.org/jira/browse/HIVE-13667
Project: Hive
Issue
Siddharth Seth created HIVE-13666:
-
Summary: LLAP Provide the log url for a task attempt to display on
the UI
Key: HIVE-13666
URL: https://issues.apache.org/jira/browse/HIVE-13666
Project: Hive
oop/hive/llap/daemon/MiniLlapCluster.java
(line 196)
<https://reviews.apache.org/r/46597/#comment195150>
This can send in a real cluster name, instead of leaving it null ?
- Siddharth Seth
On April 26, 2016, 12:58 a.m., Sergey Shelukhin wrote:
>
> --
- create a pool of UGI
instances - 1 per executor, and share those.
The allowCache, static lock, compare principal seems unnecessary.
- Siddharth Seth
On April 27, 2016, 11:01 p.m., Sergey Shelukhin wrote:
>
> ---
> This
Siddharth Seth created HIVE-13643:
-
Summary: Various enhancements to llap cli tools
Key: HIVE-13643
URL: https://issues.apache.org/jira/browse/HIVE-13643
Project: Hive
Issue Type
Siddharth Seth created HIVE-13641:
-
Summary: LLAP fails to start if llap.io.enabled is set to true,
and cache size is set to 0
Key: HIVE-13641
URL: https://issues.apache.org/jira/browse/HIVE-13641
ports multiple instances, which will otherwise
end up with different UUIDs.
- Siddharth Seth
On April 23, 2016, 2:08 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail. To reply
101 - 200 of 447 matches
Mail list logo
