Re: Review Request 65422: HIVE-17626

2018-03-06 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/ --- (Updated March 6, 2018, 11:06 a.m.) Review request for hive and Ashutosh

Re: Review Request 65422: HIVE-17626

2018-03-05 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/ --- (Updated March 5, 2018, 10:12 p.m.) Review request for hive and Ashutosh

Re: Review Request 65422: HIVE-17626

2018-03-05 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/#review198652 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java Lines 653

Re: Review Request 65422: HIVE-17626

2018-03-05 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/ --- (Updated March 5, 2018, 8:08 a.m.) Review request for hive and Ashutosh

Re: Review Request 65422: HIVE-17626

2018-03-04 Thread Zoltan Haindrich
> On March 2, 2018, 11:19 p.m., Ashutosh Chauhan wrote: > > data/conf/hive-site.xml > > Lines 338 (patched) > > > > > > Is there a reason for this? AFAICT existing tests should not get > > affected by this, so this

Re: Review Request 65422: HIVE-17626

2018-03-02 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/#review198543 --- data/conf/hive-site.xml Lines 338 (patched)

Re: Review Request 65422: HIVE-17626

2018-03-01 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/ --- (Updated March 1, 2018, 3:35 p.m.) Review request for hive and Ashutosh

Re: Review Request 65422: HIVE-17626

2018-02-27 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/ --- (Updated Feb. 27, 2018, 6:36 p.m.) Review request for hive and Ashutosh

Re: Review Request 65422: HIVE-17626

2018-02-27 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/ --- (Updated Feb. 27, 2018, 11:17 a.m.) Review request for hive and Ashutosh

Re: Review Request 65422: HIVE-17626

2018-02-27 Thread Zoltan Haindrich
> On Feb. 16, 2018, 4:50 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > > Lines 139 (patched) > > > > > > Should also compare with

Re: Review Request 65422: HIVE-17626

2018-02-26 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/ --- (Updated Feb. 26, 2018, 6:19 p.m.) Review request for hive and Ashutosh

Re: Review Request 65422: HIVE-17626

2018-02-20 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/ --- (Updated Feb. 20, 2018, 6:41 p.m.) Review request for hive and Ashutosh

Re: Review Request 65422: HIVE-17626

2018-02-19 Thread Zoltan Haindrich
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3691 (patched) > > > > > > Instead of config this should be explain modifier. WE already

Re: Review Request 65422: HIVE-17626

2018-02-19 Thread Zoltan Haindrich
> On Feb. 16, 2018, 4:50 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java > > Lines 131 (patched) > > > > > > This is hackish.. as pointed above it needs to happen

Re: Review Request 65422: HIVE-17626

2018-02-15 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/#review197649 --- ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java

Re: Review Request 65422: HIVE-17626

2018-02-06 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65422/#review196950 --- First pass review.