---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
---
(Updated Aug. 26, 2014, 5:10 p.m.)
Review request for hive, Navis Ryu,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review51558
---
Code changes look good to me. Some nit below.
On Aug. 26, 2014, 6:17 p.m., Szehon Ho wrote:
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java,
line 5229
https://reviews.apache.org/r/23320/diff/5/?file=669421#file669421line5229
Can we remove these whitespace change from the patch? I guess its good
to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
---
(Updated Aug. 25, 2014, 7:15 p.m.)
Review request for hive, Navis Ryu,
On Aug. 7, 2014, 12:02 a.m., Szehon Ho wrote:
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java,
line 252
https://reviews.apache.org/r/23320/diff/2/?file=653814#file653814line252
It can still be final even if static.
Yup, can be made final now. In the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
---
(Updated Aug. 12, 2014, 11:33 a.m.)
Review request for hive, Navis Ryu,
On Aug. 6, 2014, 7:24 p.m., Lefty Leverenz wrote:
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1457
https://reviews.apache.org/r/23320/diff/2/?file=653813#file653813line1457
Please specify time units.
Also, what does #min mean here -- minimum? (If
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review50174
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
---
(Updated Aug. 6, 2014, 3:46 p.m.)
Review request for hive, Sushanth Sowmyan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
---
(Updated Aug. 6, 2014, 4:11 p.m.)
Review request for hive, Sushanth Sowmyan,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
---
(Updated Aug. 6, 2014, 4:11 p.m.)
Review request for hive, Navis Ryu, Sushanth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review49792
---
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review49832
---
Looks better technically, just some minor style and cleanup comment
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review47550
---
One general question I had is with this scheme is, could background
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/#review47551
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23320/
---
Review request for hive, Sushanth Sowmyan and Thejas Nair.
Bugs: HIVE-7353
16 matches
Mail list logo
