Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review133646 --- Ship it! Ship It! - Siddharth Seth On May 17, 2016, 9:58

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

> On May 17, 2016, 10:01 p.m., Siddharth Seth wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java, line > > 376 > > > > > > Required here as well ? remote one doesn't start threads;

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review133639 ---

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/ --- (Updated May 17, 2016, 9:58 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review133629 --- Ship it! Looks good. Think HIVE-13698 becomes a blocker - from

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

> On May 6, 2016, midnight, Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2694-2698 > > > > > > My usual comment: please spell out the abbreviations ZK and HS2 (at > >

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/ --- (Updated May 17, 2016, 12:56 a.m.) Review request for hive, Gunther

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

> On May 17, 2016, 12:01 a.m., Siddharth Seth wrote: > > llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java, line 24 > > > > > > Can appId be removed from the parameter list. Doesn't look like it's > >

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review133466 ---

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review131971 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/ --- (Updated May 5, 2016, 9:55 p.m.) Review request for hive, Gunther Hagleitner,

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review130365 --- Ship it! Looks good. One minor comment - in case you want to

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/ --- (Updated April 23, 2016, 1:57 a.m.) Review request for hive, Gunther

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

> On April 23, 2016, 12:38 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java, > > line 193 > > > > > > Can we restrict this configuration parameter to

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

> On April 23, 2016, 12:38 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java, > > line 193 > > > > > > Can we restrict this configuration parameter to

Re: Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review130230 --- Mostly looks good. Left some comments - mostly minor issues. The

Review Request 46579: HIVE-13449 LLAP: HS2 should get the token directly, rather than from LLAP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/ --- Review request for hive, Gunther Hagleitner, Siddharth Seth, and Vikram Dixit